enh(#2876): retire the dead and pass-through exports from bin/install.js (#3615)

* enh(#2876): retire the dead and pass-through exports from bin/install.js

The installer exported 197 names and had zero production consumers - every
non-test require of it repo-wide sits inside a comment. Its interface was
shaped by test access, not by callers.

Removes 9 dead exports and 61 pass-throughs, repointing their tests onto the
extracted modules' own interfaces. 197 down to 127.

Every count in the issue was wrong: 197 exports not 188, 9 dead not 12, 61
pass-throughs not 49, 44 test files not 42 - and the audit itself then missed
7 more consumer files. restoreUserArtifacts was on the dead list but ceased to
exist in phase 6, and two _GSD_EFFORT_MANIFEST_* names listed as dead are now
genuinely asserted, so acting on that list would have deleted live exports.

7 of the 9 dead names collide with an independent declaration that install.js
delegates TO. Each removal was justified by which declaration a reference
resolves to, never by whether the name appears somewhere.

Coverage parity was the gate rather than test greenness: per-file counts were
captured before any edit and diffed after. 44 of 45 files are byte-identical;
the single delta is one added assertion, not a loss.

The sweep for scattered require sites found two forms static grep misses -
require(VARIABLE) and multi-line require() - plus tests asserting that
install.js re-exports the SAME object, which now assert retirement instead.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

* fix(#2876): close review findings — restore the duplicate-body guard, sweep orphaned code

Both review engines found real defects in the first cut.

The DEFECT.GENERATIVE-FIX single-owner guard from #1511 had been repointed
from a reference-identity check to install.X === undefined. Those are not
equivalent: the guard exists to catch a duplicate function body reintroduced
into install.js, and the replacement passes cleanly if that duplicate is used
internally and never exported. It now walks bin/install.js's real top-level
bindings, so it catches a duplicate under either shape, exported or not -
strictly stronger than the check it replaced. Proved by injecting a duplicate
and watching it go red.

That weakening survived the coverage-parity gate because the assertion count
never moved. The gate compares counts, so an assertion that changes meaning
rather than number is invisible to it.

Removing the exports had orphaned their wrapper bodies: 14 dead wrappers, 9
consts and 9 destructure entries, several pre-existing and found by the same
sweep. Dead code left in the file this phase exists to shrink.

Three more comments claimed re-exports this phase removed, and tests were
reading Cursor and Windsurf hook constants from install.js's local copy while
calling functions from the hooks surface - equal today, with nothing holding
them equal. The local consts now reference the owning module.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

* chore(#2876): backfill changeset pr number

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

---------

Co-authored-by: sim <sim@local>
Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

tests/codex-config.test.cjs

@@ -69,10 +69,10 @@ const {
   GSD_CODEX_MARKER,
   CODEX_AGENT_SANDBOX,
   parseTomlToObject,
-  resolveNodeRunner,
   validateCodexConfigSchema,
 } = require('../bin/install.js');
 
+const { resolveNodeRunner } = require('../gsd-core/bin/lib/runtime-hooks-surface.cjs');
 const { resolveInstallPlan } = require('../gsd-core/bin/lib/runtime-config-adapter-registry.cjs');
 
 function runCodexInstall(codexHome, cwd = path.join(__dirname, '..')) {
@@ -5392,9 +5392,9 @@ const { test, describe } = require('node:test');
 const assert = require('node:assert/strict');
 const path = require('node:path');
 
-const INSTALL = require(path.join(__dirname, '..', 'bin', 'install.js'));
+const HOOKS_SURFACE = require(path.join(__dirname, '..', 'gsd-core', 'bin', 'lib', 'runtime-hooks-surface.cjs'));
 const projection = require(path.join(__dirname, '..', 'gsd-core', 'bin', 'lib', 'shell-command-projection.cjs'));
-const { buildCodexHookBlock, rewriteLegacyCodexHookBlock, resolveNodeRunner } = INSTALL;
+const { buildCodexHookBlock, rewriteLegacyCodexHookBlock, resolveNodeRunner } = HOOKS_SURFACE;
 const { projectCodexHookTomlCommand } = projection;
 
 /**
@@ -6959,15 +6959,19 @@ const fs = require('node:fs');
 const path = require('node:path');
 
 const INSTALL = require('../bin/install.js');
+const HOOKS_SURFACE = require('../gsd-core/bin/lib/runtime-hooks-surface.cjs');
 const PROJECTION = require('../gsd-core/bin/lib/shell-command-projection.cjs');
 const { createTempDir, cleanup } = require('./helpers.cjs');
 
+const {
+  uninstall,
+} = INSTALL;
+
 const {
   buildCodexHookWindowsShimIR,
   ensureCodexHooksJsonSessionStart,
   resolveNodeRunner,
-  uninstall,
-} = INSTALL;
+} = HOOKS_SURFACE;
 
 const { projectManagedHookCommand } = PROJECTION;
 
@@ -6991,12 +6995,12 @@ function hookHandlersForEvent(hooksJson, eventName) {
 describe('#3426 — export surface: buildCodexHookWindowsShimIR must be exported', () => {
   test('buildCodexHookWindowsShimIR is a function', () => {
     assert.equal(typeof buildCodexHookWindowsShimIR, 'function',
-      'buildCodexHookWindowsShimIR must be exported from bin/install.js');
+      'buildCodexHookWindowsShimIR must be exported from runtime-hooks-surface.cjs');
   });
 
   test('ensureCodexHooksJsonSessionStart is a function', () => {
     assert.equal(typeof ensureCodexHooksJsonSessionStart, 'function',
-      'ensureCodexHooksJsonSessionStart must be exported from bin/install.js');
+      'ensureCodexHooksJsonSessionStart must be exported from runtime-hooks-surface.cjs');
   });
 });
 
@@ -9382,13 +9386,12 @@ const assert = require('node:assert/strict');
 const fs = require('node:fs');
 const path = require('node:path');
 
-const INSTALL = require('../bin/install.js');
 const {
   ensureCodexHooksJsonSessionStart,
   ensureCodexHooksJsonEvent,
   removeCodexHooksJsonEvent,
   reconcileCodexHooksJsonEvent,
-} = INSTALL;
+} = require('../gsd-core/bin/lib/runtime-hooks-surface.cjs');
 const { createTempDir, cleanup } = require('./helpers.cjs');
 
 // ─── Helpers ─────────────────────────────────────────────────────────────────
@@ -9430,17 +9433,17 @@ function stubHookFile(targetDir, hookName) {
 describe('enh-772: export surface — new functions are exported', () => {
   test('ensureCodexHooksJsonEvent is a function', () => {
     assert.strictEqual(typeof ensureCodexHooksJsonEvent, 'function',
-      'ensureCodexHooksJsonEvent must be exported from bin/install.js');
+      'ensureCodexHooksJsonEvent must be exported from runtime-hooks-surface.cjs');
   });
 
   test('removeCodexHooksJsonEvent is a function', () => {
     assert.strictEqual(typeof removeCodexHooksJsonEvent, 'function',
-      'removeCodexHooksJsonEvent must be exported from bin/install.js');
+      'removeCodexHooksJsonEvent must be exported from runtime-hooks-surface.cjs');
   });
 
   test('reconcileCodexHooksJsonEvent is a function', () => {
     assert.strictEqual(typeof reconcileCodexHooksJsonEvent, 'function',
-      'reconcileCodexHooksJsonEvent must be exported from bin/install.js');
+      'reconcileCodexHooksJsonEvent must be exported from runtime-hooks-surface.cjs');
   });
 });