golem15/msd-core
4
0
Fork 0
Code Issues 1 Pull Requests Actions 3 Packages Projects Releases Wiki Activity

fix(#581): add Edit to six writer agents' tools so Edit-only discipline is enforceable (#582)

Browse Source 
* fix(#581): add Edit to six writer agents' tools so Edit-only discipline is enforceable

Six writer agents (gsd-eval-planner, gsd-ai-researcher, gsd-domain-researcher,
gsd-phase-researcher, gsd-ui-researcher, gsd-debug-session-manager) shipped with
Write but no Edit in their tools: frontmatter. Their spawn prompts instruct
surgical in-place section edits on existing/shared files (notably the AI-SPEC.md
trio writing disjoint sections of the same file), but with no Edit tool they
fall back to whole-file Write — silently clobbering sibling sections
(last-writer-wins) while still reporting success.

Same bug class as #571, fixed for gsd-doc-writer in #575. This adds Edit
alongside the existing Write for all six (Edit placed adjacent to Write, mirroring
the gsd-doc-writer fix). Write is retained; no prompt-body changes; no other agents
touched.

Adds a regression test (tests/agent-frontmatter.test.cjs) asserting each of the
six section-writer agents carries both Write and Edit.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* chore(#581): add changeset fragment for writer-agent Edit fix

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* chore(#581): regenerate changeset via npm run changeset

Replace hand-authored fragment with one generated by the official
scripts/changeset/new.cjs script (correct <adjective>-<noun>-<noun>
filename convention).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Tom Boucher
2026-06-01 14:25:12 -04:00
committed by GitHub
parent faf329ecb9
commit 692343f8cc
8 changed files with 46 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
tests/agent-frontmatter.test.cjs
View File

@@ -397,6 +397,41 @@ describe('DISCUSS: discussion log generation', () => {
});
});
// ─── Section-writer agents must carry both Write and Edit (#581) ────────────
describe('EDITWRITE: section-writer agents must have both Write and Edit in tools', () => {
// These agents perform in-place section edits on shared/existing files (e.g.
// AI-SPEC.md). Without Edit in tools:, the "Edit-only" discipline in their
// spawn-prompt is unenforceable — they fall back to whole-file Write and
// clobber sibling sections. Same bug class as #571/#575 (fixed gsd-doc-writer).
// Issue #581.
const SECTION_WRITER_AGENTS = [
'gsd-eval-planner',
'gsd-ai-researcher',
'gsd-domain-researcher',
'gsd-phase-researcher',
'gsd-ui-researcher',
'gsd-debug-session-manager',
];
for (const agent of SECTION_WRITER_AGENTS) {
test(`${agent} has both Write and Edit in tools: (#581)`, () => {
const content = fs.readFileSync(path.join(AGENTS_DIR, agent + '.md'), 'utf-8');
const toolsMatch = content.match(/^tools:\s*(.+)$/m);
assert.ok(toolsMatch, `${agent} missing tools: line in frontmatter`);
const tools = toolsMatch[1].split(',').map(t => t.trim());
assert.ok(
tools.includes('Write'),
`${agent} missing Write in tools: — required for file creation`
);
assert.ok(
tools.includes('Edit'),
`${agent} missing Edit in tools: — required to enforce Edit-only discipline on shared files (#581)`
);
});
}
});
// ─── Cross-runtime agent compatibility (#1522) ──────────────────────────────
describe('COMPAT: agents must not use runtime-specific frontmatter keys', () => {