test(#1977): consolidate 22 misc + repo-invariant regression tests
Final epic-#1969 batch. Fold 22 issue-named files: the 4 genuine repo-wide invariant scans (551-eslint-bin-lib-coverage, bug-3054 stale /gsd-next, bug-3810 no-gsd-sdk-runtime-refs, feat-3593 cli-negative-universal) into a NEW shared repo-invariants.test.cjs; the other 18 as singletons into their nearest module suite (model-resolver, codex-config, runtime-converters, security, state-transition, worktree-safety, roadmap-parser, etc.). Verbatim block-scoped describe wrappers; 334 subtests conserved 1:1. Host-env pre-check (B2+B6): the 6 CLI folds into GSD_TEST_MODE-setting hosts (model-resolver/ codex-config/runtime-converters) are benign — each origin independently sets GSD_TEST_MODE=1 itself (idempotent), unlike the B6 real-install case. Regenerates regression-name allowlist (222->213), ratchets file-count allowlist (state 17->16), makes 7 relocated allow-test-rule exemptions issue-ref-compliant (ADR-456; prunes stale ids). Repoints 2 tests/ refs in docs/TESTING-SUITES.md. lint:ci green. Part of epic #1969. Closes #1977. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
@@ -82,3 +82,128 @@ describe('READING: agents with reading blocks use <required_reading>', () => {
|
||||
});
|
||||
}
|
||||
});
|
||||
|
||||
|
||||
// ────────────────────────────────────────────────────────────────────────
|
||||
// Folded from tests/bug-patterns-reference.test.cjs — consolidation epic #1969 (B8 #1977)
|
||||
// ────────────────────────────────────────────────────────────────────────
|
||||
{
|
||||
const { describe: __foldDescribe } = require('node:test');
|
||||
__foldDescribe("folded:bug-patterns-reference (consolidation epic #1969 B8 #1977)", () => {
|
||||
// allow-test-rule: source-text-is-the-product
|
||||
// Workflow .md / agent .md / command .md / reference .md files — their text
|
||||
// IS what the runtime loads. Testing text content tests the deployed contract.
|
||||
// Per CONTRIBUTING.md exception matrix.
|
||||
|
||||
/**
|
||||
* Common Bug Patterns Reference Tests
|
||||
*
|
||||
* Structural tests for the common-bug-patterns.md reference file:
|
||||
* - File exists at expected path
|
||||
* - Contains expected bug pattern categories (at least 5 of 10)
|
||||
* - Debugger agent references the file in required_reading
|
||||
*/
|
||||
|
||||
const { describe, test } = require('node:test');
|
||||
const assert = require('node:assert/strict');
|
||||
const fs = require('fs');
|
||||
const path = require('path');
|
||||
|
||||
const REFERENCE_PATH = path.join(
|
||||
__dirname, '..', 'gsd-core', 'references', 'common-bug-patterns.md'
|
||||
);
|
||||
const DEBUGGER_AGENT_PATH = path.join(
|
||||
__dirname, '..', 'agents', 'gsd-debugger.md'
|
||||
);
|
||||
|
||||
const EXPECTED_CATEGORIES = [
|
||||
'Off-by-One',
|
||||
'Null',
|
||||
'Async',
|
||||
'State Management',
|
||||
'Import',
|
||||
'Environment',
|
||||
'Data Shape',
|
||||
'String Handling',
|
||||
'File System',
|
||||
'Error Handling',
|
||||
];
|
||||
|
||||
describe('common-bug-patterns.md reference', () => {
|
||||
test('reference file exists', () => {
|
||||
assert.ok(
|
||||
fs.existsSync(REFERENCE_PATH),
|
||||
`Expected reference file at ${REFERENCE_PATH}`
|
||||
);
|
||||
});
|
||||
|
||||
test('has title and intro', () => {
|
||||
const content = fs.readFileSync(REFERENCE_PATH, 'utf-8');
|
||||
assert.ok(
|
||||
content.startsWith('# Common Bug Patterns'),
|
||||
'File should start with "# Common Bug Patterns" title'
|
||||
);
|
||||
assert.ok(
|
||||
content.includes('---'),
|
||||
'File should contain --- separator after intro'
|
||||
);
|
||||
});
|
||||
|
||||
test('contains at least 5 of 10 expected categories', () => {
|
||||
const content = fs.readFileSync(REFERENCE_PATH, 'utf-8');
|
||||
const found = EXPECTED_CATEGORIES.filter(cat =>
|
||||
content.toLowerCase().includes(cat.toLowerCase())
|
||||
);
|
||||
assert.ok(
|
||||
found.length >= 5,
|
||||
`Expected at least 5 categories, found ${found.length}: ${found.join(', ')}`
|
||||
);
|
||||
});
|
||||
|
||||
test('each pattern category has at least one bold bullet item', () => {
|
||||
const content = fs.readFileSync(REFERENCE_PATH, 'utf-8');
|
||||
// Only check sections inside <patterns> block, not <usage>
|
||||
const patternsBlock = (content.split('<patterns>')[1] || '').split('</patterns>')[0];
|
||||
const sections = patternsBlock.split(/^## /m).slice(1);
|
||||
assert.ok(sections.length >= 5, `Expected at least 5 pattern sections, got ${sections.length}`);
|
||||
for (const section of sections) {
|
||||
const title = section.split('\n')[0].trim();
|
||||
const bullets = section.match(/^- \*\*/gm);
|
||||
assert.ok(
|
||||
bullets && bullets.length >= 1,
|
||||
`Pattern section "${title}" should have at least one "- **" bullet item`
|
||||
);
|
||||
}
|
||||
});
|
||||
});
|
||||
|
||||
describe('debugger agent references bug patterns', () => {
|
||||
test('gsd-debugger.md exists', () => {
|
||||
assert.ok(
|
||||
fs.existsSync(DEBUGGER_AGENT_PATH),
|
||||
`Expected debugger agent at ${DEBUGGER_AGENT_PATH}`
|
||||
);
|
||||
});
|
||||
|
||||
test('gsd-debugger.md references common-bug-patterns.md', () => {
|
||||
const content = fs.readFileSync(DEBUGGER_AGENT_PATH, 'utf-8');
|
||||
assert.ok(
|
||||
content.includes('common-bug-patterns.md'),
|
||||
'Debugger agent should reference common-bug-patterns.md'
|
||||
);
|
||||
});
|
||||
|
||||
test('reference is inside <required_reading> block', () => {
|
||||
const content = fs.readFileSync(DEBUGGER_AGENT_PATH, 'utf-8');
|
||||
const reqReadMatch = content.match(
|
||||
/<required_reading>([\s\S]*?)<\/required_reading>/
|
||||
);
|
||||
assert.ok(reqReadMatch, 'Debugger agent should have a <required_reading> block');
|
||||
assert.ok(
|
||||
reqReadMatch[1].includes('common-bug-patterns.md'),
|
||||
'common-bug-patterns.md should be inside <required_reading> block'
|
||||
);
|
||||
});
|
||||
});
|
||||
});
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user