test(#4518): migrate loop/hook-point e2e batch to named timeout constants
Batch 7 of 17 in the ad hoc timeout literal migration (epic #4445). Replaces every bare numeric timeout/timeoutMs object-literal property in tests/loop-render-hooks.test.cjs, tests/loop-walk.qa.test.cjs, tests/loop-hooks-empty-points-e2e.test.cjs, tests/loop-hooks-ship-pre-e2e.test.cjs, tests/loop-hooks-verify-post-e2e.test.cjs, tests/check-gap-analysis-plan-post-e2e.test.cjs, tests/check-tdd-review-checkpoint-e2e.test.cjs, tests/execute-wave-post-gate-pipeline-e2e.test.cjs, tests/plan-pre-hook-e2e.test.cjs, and tests/qa/tdd-walk.cjs with a named constant, per eslint-rules/no-adhoc-timeout-literal.cjs. Removes the 10 files from the rule's allowlist. Promotes a new shared class norm to tests/helpers/timeouts.cjs, LOOP_HOOK_POINT_CLI_TIMEOUT_MS: 7 files independently arrived at the same value for a single gsd-tools.cjs CLI subcommand invocation with no confirmed subprocess fan-out. Reuses the existing PROBE_TIMEOUT_MS for loop-render-hooks.test.cjs's 11 sites (same class, exact value match). Adds 4 file-local constants for values that share a class with the new norm or an existing one but diverge in pre-existing value, or that numerically coincide with an unrelated existing constant without matching its actual operation. Isolated Standards-axis review caught that the new shared constant's doc comment exhaustively enumerated 3 verb families while a 7th genuine site (an `init new-project` invocation) also correctly belonged to the class; fixed by rewording the comment to state the class definition (call shape) first and list all 4 representative verbs, explicitly illustrative rather than exhaustive. No value changed, no site's classification changed. No src/bin file touched, no numeric value changed anywhere. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
@@ -190,6 +190,19 @@ function parseResultSentinel(stdout) {
|
||||
return lineEndIdx === -1 ? stdout.slice(valueStart) : stdout.slice(valueStart, lineEndIdx);
|
||||
}
|
||||
|
||||
// Bounds `bash -c` execution (below) of a REAL fenced bash block extracted
|
||||
// from a workflow markdown file's resolution/dispatch step — a bash-hosted
|
||||
// script that may itself shell out further (e.g. via a `gsd_run` shim), not
|
||||
// a bare `gsd-tools.cjs` CLI subcommand invocation. Numerically coincides
|
||||
// with tests/helpers/timeouts.cjs's `BUILD_TIMEOUT_MS` (hooks-bundle build
|
||||
// via scripts/build-hooks.js, an unrelated operation) and with this batch's
|
||||
// other file-local `PLAN_PRE_HOOK_CLI_TIMEOUT_MS` (a different file, a
|
||||
// different command), but matches neither class — kept local, both
|
||||
// coincidences disclosed rather than silently reusing an unrelated existing
|
||||
// constant. No fresh bench data justifies a different number, so the
|
||||
// pre-existing 30000ms literal is preserved exactly under this name.
|
||||
const TDD_BACKEND_SCRIPT_TIMEOUT_MS = 30000;
|
||||
|
||||
/**
|
||||
* Execute a backend's extracted script for real, via `bash -c`, against
|
||||
* `cwd`. Never throws: a non-zero exit is captured and returned as a normal
|
||||
@@ -217,7 +230,7 @@ function executeBackendScript(script, cwd) {
|
||||
cwd,
|
||||
env: { ...process.env, ...TEST_ENV_BASE, RUNTIME_DIR: REPO_ROOT, GSD_TEST_MODE: '1' },
|
||||
encoding: 'utf8',
|
||||
timeout: 30000,
|
||||
timeout: TDD_BACKEND_SCRIPT_TIMEOUT_MS,
|
||||
});
|
||||
return { success: true, value: parseResultSentinel(stdout), stdout, stderr: '' };
|
||||
} catch (error) {
|
||||
|
||||
Reference in New Issue
Block a user