enhance(#3180): the sibling validators share one envelope and one owner — Phase 12 (#3407)

This commit is contained in:
Tom Boucher
2026-08-13 11:31:16 -04:00
committed by GitHub
parent bf05479928
commit 6dbc124018
27 changed files with 2212 additions and 354 deletions

View File

@@ -97,9 +97,15 @@ describe('validate consistency command', () => {
const output = JSON.parse(result.output);
assert.ok(output.warning_count > 0, 'should have warnings');
assert.ok(
output.warnings.some(w => w.includes('disk but not in ROADMAP')),
output.warnings.some(w => w.message.includes('disk but not in ROADMAP')),
'should warn about orphan directory'
);
// W007 is REUSED verbatim from `validate.health`'s rule table (design doc,
// "Which rules run where") — the code is proof of reuse, not a mistake.
assert.ok(
output.warnings.some(w => w.code === 'W007'),
`expected code W007 for the orphan-on-disk warning; got: ${JSON.stringify(output.warnings)}`
);
});
test('#3225: sentinel phase dirs (999/0) do not warn; real orphans still do', () => {
@@ -119,7 +125,7 @@ describe('validate consistency command', () => {
const output = JSON.parse(result.output);
const sentinelWarnings = output.warnings.filter(
w => w.includes('disk but not in ROADMAP') && /\b(0|999)\b/.test(w)
w => w.message.includes('disk but not in ROADMAP') && /\b(0|999)\b/.test(w.message)
);
assert.strictEqual(
sentinelWarnings.length, 0,
@@ -127,14 +133,14 @@ describe('validate consistency command', () => {
);
// Negative space: the real orphan must still warn.
assert.ok(
output.warnings.some(w => w.includes('disk but not in ROADMAP') && /02\b/.test(w)),
output.warnings.some(w => w.message.includes('disk but not in ROADMAP') && /02\b/.test(w.message)),
`expected a warning for the real orphan 02; got: ${JSON.stringify(output.warnings)}`
);
// #3225 (review finding): a sentinel dir must NOT produce a spurious
// "Gap in phase numbering: N → 999" either (the gap check builds its integer
// sequence from diskPhases and would otherwise include 999).
const sentinelGaps = output.warnings.filter(
w => w.includes('Gap in phase numbering') && /999\b/.test(w)
w => w.message.includes('Gap in phase numbering') && /999\b/.test(w.message)
);
assert.strictEqual(
sentinelGaps.length, 0,
@@ -155,9 +161,15 @@ describe('validate consistency command', () => {
const output = JSON.parse(result.output);
assert.ok(
output.warnings.some(w => w.includes('Gap in phase numbering')),
output.warnings.some(w => w.message.includes('Gap in phase numbering')),
'should warn about gap'
);
// C001 — new code namespace (design doc, "Code namespace"): not a W0NN,
// since this subject has no `validate.health` equivalent.
assert.ok(
output.warnings.some(w => w.code === 'C001'),
`expected code C001 for the phase-numbering gap; got: ${JSON.stringify(output.warnings)}`
);
});
});
@@ -3298,7 +3310,18 @@ describe('#2701: state validate rejects NUL-corrupted STATE.md', () => {
const out = parseResult(t, ['state', 'validate'], tmpDir);
assert.strictEqual(out.valid, false, `expected valid:false; got ${JSON.stringify(out)}`);
assert.ok(out.warnings.some((w) => /NUL/i.test(w)), `warning must name NUL: ${JSON.stringify(out.warnings)}`);
// `state validate` (Phase 12 migration) emits coded warning objects
// ({code, severity, message, remedy}), not bare strings — assert on the
// code as the primary check, with a message substring as a secondary,
// human-readable confirmation.
assert.ok(
out.warnings.some((w) => w.code === 'S001'),
`warning must carry code S001: ${JSON.stringify(out.warnings)}`,
);
assert.ok(
out.warnings.some((w) => /NUL/i.test(w.message)),
`warning must name NUL: ${JSON.stringify(out.warnings)}`,
);
});
});