From 6e757aaa77ead82bbe2ce840984dd429053558bf Mon Sep 17 00:00:00 2001 From: Lex Christopherson Date: Tue, 20 Jan 2026 11:47:43 -0600 Subject: [PATCH] fix(05): revise plan 05-02 based on checker feedback - Reframe must_haves truths to outcome-focused (scalability, UX) - Add instruction to fix outdated slug documentation (-- to -) - Add slug verification to task verify checklist Co-Authored-By: Claude Opus 4.5 --- .../05-02-PLAN.md | 23 +++++++++++++++---- 1 file changed, 18 insertions(+), 5 deletions(-) diff --git a/.planning/phases/05-subagent-codebase-analysis/05-02-PLAN.md b/.planning/phases/05-subagent-codebase-analysis/05-02-PLAN.md index cecfd2222..770c4a59d 100644 --- a/.planning/phases/05-subagent-codebase-analysis/05-02-PLAN.md +++ b/.planning/phases/05-subagent-codebase-analysis/05-02-PLAN.md @@ -10,10 +10,10 @@ autonomous: false must_haves: truths: - - "analyze-codebase Step 9 spawns gsd-entity-generator subagent" - - "Subagent receives file list (paths only, not contents)" - - "Orchestrator context is preserved (no file contents loaded)" - - "Entity generation completes and returns statistics" + - "Entity generation scales to 500+ files without context exhaustion" + - "Subagent receives only file paths, preserving orchestrator context" + - "Entity files appear in .planning/intel/entities/ after generation" + - "User can run /gsd:analyze-codebase on large codebases without degradation" artifacts: - path: "commands/gsd/analyze-codebase.md" provides: "Refactored command with subagent delegation" @@ -164,6 +164,17 @@ Next: Intel hooks will continue incremental updates as you code. - This preserves orchestrator context for large codebases (500+ files) ``` +**Fix outdated slug documentation** (around line 286): +The entity filename convention example is outdated. Change: +```markdown +- Example: src/utils/auth.js -> src--utils--auth-js.md +``` +To: +```markdown +- Example: src/utils/auth.js -> src-utils-auth-js.md +``` +(Single hyphen, not double hyphen. The hook `gsd-intel-index.js:generateSlug` already uses single hyphen format.) + **Important:** Do NOT pass file contents to subagent. Pass file PATHS only. Subagent reads files itself (fresh context). @@ -173,9 +184,10 @@ Read updated commands/gsd/analyze-codebase.md and confirm: - File paths passed, not file contents - Context section mentions subagent delegation - Steps 9.4-9.5 updated for new flow +- Slug example at line ~286 uses single hyphen (src-utils-auth-js.md) -analyze-codebase.md Step 9 refactored. Entity generation now delegates to gsd-entity-generator subagent instead of inline Task batching. +analyze-codebase.md Step 9 refactored. Entity generation now delegates to gsd-entity-generator subagent instead of inline Task batching. Outdated slug documentation corrected. @@ -204,6 +216,7 @@ analyze-codebase.md Step 9 refactored. Entity generation now delegates to gsd-en - [ ] File paths passed to subagent (not file contents) - [ ] No batch-of-10 pattern in command - [ ] Context section documents subagent model +- [ ] Slug example uses single hyphen format (matches hook) - [ ] Entity files created in test project - [ ] Entities follow template format - [ ] Graph database updated (via hook)