fix(#3423): standardize on <required_reading>, retire the files_to_read emit tag (#3432)

* fix(#3423): standardize on required_reading, retire files_to_read emit tag

* test(#3423): flip tag assertions, extend consistency guard to spawner surfaces

* fix(#3423): sweep capabilities fragments, regen registry+skills, anchor executor test

* chore(#3423): acknowledge tag-rename emitted ripples and workflow growth

* chore(#3423): broaden emitted-ripple acknowledgment to all embedders

* chore(#3423): settle emitted-drift acks post-rebase (merge 3004/1689-owned keys)

* chore(#3423): drop stale ripple acks, ack execute-phase growth

* chore(#3423): restore pristine 3004 fragment, keep only consumed appends

* chore(#3423): backfill changeset pr number

* chore(#3423): settle emitted-drift acks post-merge (move code-review-fix ripple into 3190, tag-rename ripples into 3191/3297)

* chore(#3423): re-arm 3324 ack for execute-phase.md tag-rename ripple

* fix(#3423): trim 8 bytes from execute-phase model note to hold ADR-857 margin, re-arm 3370 ack for net +4 growth

---------

Co-authored-by: sim <sim@local>
This commit is contained in:
Tom Boucher
2026-08-14 16:03:48 -04:00
committed by GitHub
parent 8a6d87538f
commit 71180983a0
53 changed files with 289 additions and 206 deletions

View File

@@ -2878,7 +2878,7 @@ describe('#2376 — init.* path fields resolve when process cwd differs from --c
// allow-test-rule: source-text-is-the-product (see #2376)
//
// Checks verbatim presence of the exact edited <files_to_read>/output blocks
// Checks verbatim presence of the exact edited <required_reading>/output blocks
// rather than scanning the whole file for absence of the old literals: several
// of those literals (e.g. .planning/PROJECT.md, .planning/config.json) remain
// legitimately elsewhere in this file in orchestrator-local bash/doc-table
@@ -2889,17 +2889,17 @@ describe('#2376 — init.* path fields resolve when process cwd differs from --c
const content = fs.readFileSync(wfPath, 'utf8');
assert.ok(content.includes(
'<files_to_read>\n- {research_dir}/STACK.md\n- {research_dir}/FEATURES.md\n- {research_dir}/ARCHITECTURE.md\n- {research_dir}/PITFALLS.md\n</files_to_read>'
'<required_reading>\n- {research_dir}/STACK.md\n- {research_dir}/FEATURES.md\n- {research_dir}/ARCHITECTURE.md\n- {research_dir}/PITFALLS.md\n</required_reading>'
), 'research-synthesizer spawn must read from {research_dir}, not bare .planning/research/*.md literals');
assert.ok(content.includes('Write to: {research_dir}/SUMMARY.md'),
'research-synthesizer spawn must write to {research_dir}/SUMMARY.md, not a bare literal');
assert.ok(content.includes(
'<files_to_read>\n- {project_path} (Project context)\n- {requirements_path} (v1 Requirements)\n- {research_dir}/SUMMARY.md (Research findings - if exists)\n- {config_path} (Granularity and mode settings)\n</files_to_read>'
'<required_reading>\n- {project_path} (Project context)\n- {requirements_path} (v1 Requirements)\n- {research_dir}/SUMMARY.md (Research findings - if exists)\n- {config_path} (Granularity and mode settings)\n</required_reading>'
), 'roadmapper spawn must read from {project_path}/{requirements_path}/{research_dir}/{config_path}, not bare .planning literals');
assert.ok(content.includes(
'<files_to_read>\n - {roadmap_path} (Current roadmap to revise)\n </files_to_read>'
'<required_reading>\n - {roadmap_path} (Current roadmap to revise)\n </required_reading>'
), 'roadmapper revision spawn must read {roadmap_path}, not a bare .planning/ROADMAP.md literal');
});
@@ -2909,13 +2909,13 @@ describe('#2376 — init.* path fields resolve when process cwd differs from --c
const content = fs.readFileSync(wfPath, 'utf8');
assert.ok(content.includes(
'<files_to_read>\n- {research_dir}/STACK.md\n- {research_dir}/FEATURES.md\n- {research_dir}/ARCHITECTURE.md\n- {research_dir}/PITFALLS.md\n</files_to_read>'
'<required_reading>\n- {research_dir}/STACK.md\n- {research_dir}/FEATURES.md\n- {research_dir}/ARCHITECTURE.md\n- {research_dir}/PITFALLS.md\n</required_reading>'
), 'research-synthesizer spawn must read from {research_dir}, not bare .planning/research/*.md literals');
assert.ok(content.includes('Write to: {research_dir}/SUMMARY.md'),
'research-synthesizer spawn must write to {research_dir}/SUMMARY.md, not a bare literal');
assert.ok(content.includes(
'<files_to_read>\n- {project_path}\n- {requirements_path}\n- {research_dir}/SUMMARY.md (if exists)\n- {config_path}\n- {milestones_path}\n</files_to_read>'
'<required_reading>\n- {project_path}\n- {requirements_path}\n- {research_dir}/SUMMARY.md (if exists)\n- {config_path}\n- {milestones_path}\n</required_reading>'
), 'roadmapper spawn must read from {project_path}/{requirements_path}/{research_dir}/{config_path}/{milestones_path}, not bare .planning literals');
});