fix(#3902): packaging guard resolves npm 12's pack --json shape — stays armed on Node 26 (#4064)

* test(#3902): packListToPathSet must resolve npm 12's object-keyed pack --json shape (failing first)

* fix(#3902): resolve both npm pack --json shapes — the packaging guard stays armed on Node 26

npm 12 (bundled with Node 26) emits an object keyed by package name
where npm <=11 emitted an array; parsed[0] was undefined, the before()
hook threw, and all 6 tests in the packaging guard — including the two
'does NOT ship' guards that stop repo-only CI tooling leaking into the
published package — went dark for contributors on Node 26. CONTRIBUTING
pins Node 24 as the floor but requires Node 26 compatibility for code
AND tests; this was the test's parse, not the code.

packListToPathSet now resolves either shape and fails loud on anything
else — a silently-empty set would be the exact dark-guard failure mode
this guard exists to prevent.

* fix(#3902): review fold-in — a multi-key object fails loud

Single-package assumption documented and enforced: npm 12 emits exactly
one key for this repo (no workspaces — verified); if workspaces were
ever adopted, first-key selection would silently validate one package's
file list and recreate the exact silent-disarm this fix kills.

* chore(#3902): changeset fragment (pr number backfilled after PR creation)

* chore(#3902): backfill changeset PR number (4064)

---------

Co-authored-by: sim <sim@local>
This commit is contained in:
Tom Boucher
2026-08-29 18:17:24 -04:00
committed by GitHub
parent 686c05a740
commit 73919526e9
2 changed files with 69 additions and 1 deletions

View File

@@ -0,0 +1,5 @@
---
type: Fixed
pr: 4064
---
**The packaging guard stays armed on npm 12 (Node 26)** — npm 12 emits pack --json as an object keyed by package name, so parsed[0] was undefined, the before() hook threw, and all 6 packaging-guard tests (including both does-NOT-ship gates) went dark for Node 26 contributors (#3902)