chore: sweep Kimi mentions from comments and notes
Some checks failed
Tests / PR mergeability (push) Successful in 19s
Tests / Base branch health (push) Successful in 10s
Tests / Detect test scope (push) Successful in 17s
Tests / lint-tests (push) Failing after 1m43s
Tests / plugin-validate (push) Successful in 1m7s
Tests / test (ubuntu-latest, 24, shard 1/3) (push) Failing after 18s
Tests / test (ubuntu-latest, 24, shard 2/3) (push) Failing after 19s
Tests / test (ubuntu-latest, 24, shard 3/3) (push) Failing after 19s
Tests / test (ubuntu-latest, 24) (push) Failing after 17s
Tests / test (inert CI) (push) Has been skipped
Tests / QA loop walk (smell ratchet) (push) Failing after 18s
Tests / Coverage gate (merged shards) (push) Has been skipped
Tests / Publish emitted-baseline artifact (push) Has been skipped
Dismiss Unauthorized PR Approvals / dismiss-unauthorized-approval (push) Successful in 8s
Tests / Required tests (push) Has been cancelled
Tests / conformance test (macos-latest, 24) (push) Has been cancelled
Tests / conformance test (windows-latest, 24, shard 1/3) (push) Has been cancelled
Tests / conformance test (windows-latest, 24, shard 2/3) (push) Has been cancelled
Tests / conformance test (windows-latest, 24, shard 3/3) (push) Has been cancelled
Some checks failed
Tests / PR mergeability (push) Successful in 19s
Tests / Base branch health (push) Successful in 10s
Tests / Detect test scope (push) Successful in 17s
Tests / lint-tests (push) Failing after 1m43s
Tests / plugin-validate (push) Successful in 1m7s
Tests / test (ubuntu-latest, 24, shard 1/3) (push) Failing after 18s
Tests / test (ubuntu-latest, 24, shard 2/3) (push) Failing after 19s
Tests / test (ubuntu-latest, 24, shard 3/3) (push) Failing after 19s
Tests / test (ubuntu-latest, 24) (push) Failing after 17s
Tests / test (inert CI) (push) Has been skipped
Tests / QA loop walk (smell ratchet) (push) Failing after 18s
Tests / Coverage gate (merged shards) (push) Has been skipped
Tests / Publish emitted-baseline artifact (push) Has been skipped
Dismiss Unauthorized PR Approvals / dismiss-unauthorized-approval (push) Successful in 8s
Tests / Required tests (push) Has been cancelled
Tests / conformance test (macos-latest, 24) (push) Has been cancelled
Tests / conformance test (windows-latest, 24, shard 1/3) (push) Has been cancelled
Tests / conformance test (windows-latest, 24, shard 2/3) (push) Has been cancelled
Tests / conformance test (windows-latest, 24, shard 3/3) (push) Has been cancelled
This commit is contained in:
@@ -1587,24 +1587,21 @@ describe('resolveOrchestratorExec — the 4 shipped orchestrator-worktree descri
|
||||
assert.equal(result.cwd, CWD);
|
||||
});
|
||||
|
||||
// #2627: `args` carries --print because kimi's working mode is otherwise the
|
||||
// #2627: `args` carries --print because some hosts' working mode is otherwise the
|
||||
// interactive TUI — an orchestrator spawning a TUI hangs forever rather than
|
||||
// returning a completed plan.
|
||||
test('kimi: --print --work-dir <cwd> (headless flag leads)', () => {
|
||||
const result = resolveOrchestratorExec({ command: 'kimi', args: ['--print'], cwdFlag: '--work-dir' }, CWD);
|
||||
test('--print --work-dir <cwd> (headless flag leads)', () => {
|
||||
const result = resolveOrchestratorExec({ command: 'hostcli', args: ['--print'], cwdFlag: '--work-dir' }, CWD);
|
||||
assert.equal(result.ok, true);
|
||||
assert.equal(result.command, 'kimi');
|
||||
assert.equal(result.command, 'hostcli');
|
||||
assert.deepEqual(result.args, ['--print', '--work-dir', CWD]);
|
||||
assert.equal(result.cwd, CWD);
|
||||
});
|
||||
|
||||
// #2627: the binary is `kimi`, NOT `kimi-code` — Moonshot's TypeScript Kimi
|
||||
// Code installs its binary as `kimi`; `kimi-code` is only the npm package and
|
||||
// config-home name, so spawning it is an immediate ENOENT.
|
||||
test('kimi-code: command is "kimi"; cwdFlag:null appends NO flag, cwd still returned (process-cwd case)', () => {
|
||||
const result = resolveOrchestratorExec({ command: 'kimi', args: [], cwdFlag: null }, CWD);
|
||||
test('cwdFlag:null appends NO flag, cwd still returned (process-cwd case)', () => {
|
||||
const result = resolveOrchestratorExec({ command: 'hostcli', args: [], cwdFlag: null }, CWD);
|
||||
assert.equal(result.ok, true);
|
||||
assert.equal(result.command, 'kimi');
|
||||
assert.equal(result.command, 'hostcli');
|
||||
assert.deepEqual(result.args, []);
|
||||
assert.equal(result.cwd, CWD);
|
||||
});
|
||||
@@ -1630,17 +1627,17 @@ describe('resolveOrchestratorExec — prompt passing (#2627, Phase 3)', () => {
|
||||
assert.deepEqual(result.args, ['run', '--dir', CWD, PROMPT]);
|
||||
});
|
||||
|
||||
test('promptFlag string → [flag, prompt] appended (kimi shape)', () => {
|
||||
test('promptFlag string → [flag, prompt] appended (flag-carried prompt shape)', () => {
|
||||
const result = resolveOrchestratorExec(
|
||||
{ command: 'kimi', args: ['--print'], cwdFlag: '--work-dir', promptFlag: '--prompt' }, CWD, PROMPT,
|
||||
{ command: 'hostcli', args: ['--print'], cwdFlag: '--work-dir', promptFlag: '--prompt' }, CWD, PROMPT,
|
||||
);
|
||||
assert.equal(result.ok, true);
|
||||
assert.deepEqual(result.args, ['--print', '--work-dir', CWD, '--prompt', PROMPT]);
|
||||
});
|
||||
|
||||
test('promptFlag string + cwdFlag null → prompt flag only, cwd via process cwd (kimi-code shape)', () => {
|
||||
test('promptFlag string + cwdFlag null → prompt flag only, cwd via process cwd (process-cwd shape)', () => {
|
||||
const result = resolveOrchestratorExec(
|
||||
{ command: 'kimi', args: [], cwdFlag: null, promptFlag: '--prompt' }, CWD, PROMPT,
|
||||
{ command: 'hostcli', args: [], cwdFlag: null, promptFlag: '--prompt' }, CWD, PROMPT,
|
||||
);
|
||||
assert.equal(result.ok, true);
|
||||
assert.deepEqual(result.args, ['--prompt', PROMPT]);
|
||||
@@ -2045,7 +2042,7 @@ describe('#2584 orchestratorExec — validator', () => {
|
||||
|
||||
test('cwdFlag: null is valid (no error)', () => {
|
||||
const cap = shippedCodexCapabilityWithoutOrchestratorExec();
|
||||
cap.runtime.orchestratorExec = { command: 'kimi-code', args: [], cwdFlag: null };
|
||||
cap.runtime.orchestratorExec = { command: 'hostcli', args: [], cwdFlag: null };
|
||||
const errors = validateCapability(cap, 'codex');
|
||||
const oeErrors = errors.filter((e) => e.includes('orchestratorExec'));
|
||||
assert.deepEqual(oeErrors, []);
|
||||
@@ -2227,10 +2224,10 @@ describe('#3714 resolveOrchestratorExec — modelFlag/model seam (mechanical, RE
|
||||
});
|
||||
|
||||
// MATRIX row 7 [CONTROL]: a host with no modelFlag is byte-identical to
|
||||
// today whether or not a model is passed — kimi-code/opencode never get a
|
||||
// today whether or not a model is passed — opencode never gets a
|
||||
// 5th positional token nor a flag pair injected.
|
||||
test('row 7 CONTROL: a host descriptor with NO modelFlag key resolves identically whether or not a model is passed', () => {
|
||||
const descriptor = { command: 'kimi', args: ['--print'], cwdFlag: '--work-dir', promptFlag: '--prompt' };
|
||||
const descriptor = { command: 'hostcli', args: ['--print'], cwdFlag: '--work-dir', promptFlag: '--prompt' };
|
||||
const withoutModelArg = resolveOrchestratorExec(descriptor, CWD, PROMPT);
|
||||
const withModelArg = resolveOrchestratorExec(descriptor, CWD, PROMPT, 'some-model');
|
||||
assert.deepEqual(withModelArg, withoutModelArg,
|
||||
|
||||
Reference in New Issue
Block a user