golem15/msd-core
4
0
Fork 0
Code Issues 1 Pull Requests Actions 1 Packages Projects Releases Wiki Activity

enhance(#2401): ground verify-command paths and inherit prior-phase commands (#3678)

Browse Source 
* feat(#2401): ground <automated> verify-command paths and inherit prior-phase commands

Adds a deterministic resolvability probe over each PLAN.md <automated> verify
command and surfaces the nearest prior phase's proven commands to the planner
at every context window.

- src/verify-command-grounding.cts: recognizer (not a shell interpreter) that
  grounds a leading cd <literal> chain and npm --prefix <literal>, and reports
  unresolvable rather than guessing. Never executes command text.
- gsd-tools check verify-command-paths <N>: per-phase probe, wired into
  plan-phase.md before the plan-check pass.
- init.plan-phase gains prior_verify_commands, ungated by context_window.
- gsd-plan-checker: new Verify Command Path Resolvability dimension that
  reports the failing target and never prescribes a replacement.

Also fixes first-match-wins prefix bucketing in scripts/lint-test-file-count.cjs
(readdir order is not stable across platforms, so a module whose name extends
another's with a hyphen bucketed differently on Linux than on macOS).

Closes #2401

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

* fix(#2401): ground the canonical --prefix form, quoted paths, and absolute cd resets

Independent review found three defects in the recognizer:

- npm --prefix DIR run SCRIPT never reached the script-existence check,
  because the pattern required npm and run to be adjacent. That is the
  form the docs tell planners to prefer, so script_missing never fired
  for it. The prefix flag and its value are now stripped before matching.
- --prefix captured with \S+, so a quoted path containing a space was
  truncated to a stray opening quote and reported as a missing directory
  - a false blocker, worse than the bug this feature fixes. The capture
  is now quote-aware.
- A chained cd whose later segment was absolute concatenated instead of
  resetting, producing a nonsense path and another false blocker. The
  fold now resets on an absolute segment.

Also replaces the bespoke phase-directory regex with the canonical
phase-id helpers. Real phase directories are NN-slug, not phase-N-slug,
so the prior-command harvest matched nothing outside its own fixtures
and the planner-inheritance half of this feature was dead code.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

* refactor(#2401): source task blocks from the canonical sectionizer

The module carried its own copy of the <task>-block grammar - a fourth
hand-rolled mirror of the one markdown-sectionizer owns. verify.cts keeps
its copy only because it needs the type= attribute the canonical helper
discards; this module never reads that attribute, so it can share the
owner outright instead of adding a test around a copy.

extractAutomatedCommands now takes task bodies from extractTaggedBlocks
and the out-of-task remainder from stripTaggedBlocks. A task-grammar
parity test pins the attributed task-name set against the canonical
helper across six awkward task shapes.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

* fix(#2401): extract agent-file overflow to references and repair the property arbitrary

The remote matrix run came back red with 19 failures, four root causes:

- agents/gsd-plan-checker.md and agents/gsd-planner.md both blew the
  49152 agent cap. Their bodies move to gsd-core/references/, leaving
  @-reference stubs, per the documented overflow pattern.
- The new checker dimension invoked gsd_run before the canonical
  preamble that defines it. The call is deleted outright: plan-phase.md
  already runs the probe and hands the result in as {VERIFY_PATHS}, so
  the dimension consumes that rather than re-running anything.
- fc.fullUnicodeString does not exist in fast-check 4.8.0. Replaced with
  fc.string({ unit: 'binary' }), which covers the same 0000-10FFFF range.
- Three runtime-loaded files grew; acknowledged in the existing ack
  fragments that already own those bare filenames, since two ack sources
  may never name the same path.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

* test(#2401): regenerate golden install-tree fixtures for the new references

Adding two files under gsd-core/references/ changes what the installer
emits into every runtime's tree, so all 19 golden install-parity
fixtures went stale. Regenerated with npm run gen:install-tree; the
delta is exactly the two new reference paths per runtime, no removals.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

* chore(#2401): backfill changeset pr number to 3678

* fix(#2401): treat ~ as a home expansion only at the start of a path

Windows CI caught this on both shards; the Linux-only remote matrix
cannot see it. The dynamic-path refusal rejected ~ anywhere, and a
GitHub Windows runner's tmpdir is an 8.3 short name -
C:\Users\RUNNER~1\AppData\Local\Temp - so a valid absolute Windows
path came back unresolvable/dynamic_path.

This was a production bug, not a test artifact: any Windows user whose
project path carries an 8.3 short name, or any literal ~, silently lost
the probe entirely - every command degrading to unresolvable with no
explanation.

~ is a home expansion only at the start of a path; elsewhere it is an
ordinary literal. The check is now split: $, backtick, *, ? and newline
stay refused anywhere (substitution and globs, and the glob characters
are illegal in Windows path components regardless), while ~ is refused
only leading, tolerating one leading quote since the check runs before
quote stripping.

The prior tests only caught this on Windows because only Windows puts a
~ in tmpdir. Four new tests pin it on every platform via a fixture
directory literally named RUNNER~1.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

---------

Co-authored-by: sim <sim@local>
Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
Tom Boucher
2026-08-19 15:21:15 -04:00
committed by GitHub
parent 4e60dba717
commit 79781e68eb
43 changed files with 2231 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tests/emitted-drift-acks/1954-plan-checker-undeclared-coupling.json
View File

@@ -1,6 +1,6 @@
{
"version": 1,
"paths": {
"gsd-plan-checker.md": "#1954: Dimension 3 gains sub-dimension 3b (undeclared / temporal coupling), plus one success-criteria line. Growth is the new sub-dimension only — no existing text was rewritten. The addition is deliberately dense rather than extracted: ADR-1610 Decision 4 names eager `@`-import relocation as proxy-gaming (it shrinks the measured file while leaving loaded context unchanged or larger), legitimate extraction is Read-at-step lazy, and this agent has no lazy-read seam; issue #1954's approved scope is also explicitly 'No new files'. After the change the file sits at 48810 bytes against the LARGE tier hard cap of 49152 (tests/agent-size-budget.test.cjs), i.e. 342 bytes of headroom. That is deliberate and disclosed: the cap is not crossed and is not raised, but the next contributor who needs room in this agent must do a lazy extraction rather than add prose. Content justification: Dimension 3 proves declared dependency edges resolve and are acyclic, and execute-phase's intra-wave guard proves same-wave plans do not overlap in files_modified — neither axis sees an undeclared edge, so two same-wave plans coupled through a shared config key, table, migration, env var, singleton or cache (or through one plan's produced state) pass plan-check and fail intermittently under parallel execution. 3b is advisory only (WARNING, never blocker, per the issue's rejected-alternatives list) and reuses the existing dependency_correctness finding key so no consumer sees a new dimension."
"gsd-plan-checker.md": "#1954: Dimension 3 gains sub-dimension 3b (undeclared / temporal coupling), plus one success-criteria line. Growth is the new sub-dimension only — no existing text was rewritten. The addition is deliberately dense rather than extracted: ADR-1610 Decision 4 names eager `@`-import relocation as proxy-gaming (it shrinks the measured file while leaving loaded context unchanged or larger), legitimate extraction is Read-at-step lazy, and this agent has no lazy-read seam; issue #1954's approved scope is also explicitly 'No new files'. After the change the file sits at 48810 bytes against the LARGE tier hard cap of 49152 (tests/agent-size-budget.test.cjs), i.e. 342 bytes of headroom. That is deliberate and disclosed: the cap is not crossed and is not raised, but the next contributor who needs room in this agent must do a lazy extraction rather than add prose. Content justification: Dimension 3 proves declared dependency edges resolve and are acyclic, and execute-phase's intra-wave guard proves same-wave plans do not overlap in files_modified — neither axis sees an undeclared edge, so two same-wave plans coupled through a shared config key, table, migration, env var, singleton or cache (or through one plan's produced state) pass plan-check and fail intermittently under parallel execution. 3b is advisory only (WARNING, never blocker, per the issue's rejected-alternatives list) and reuses the existing dependency_correctness finding key so no consumer sees a new dimension. — #2401 append (merged into this fragment because two ack sources may never name the same path): the Verify Command Path Resolvability dimension is now a short stub pointing at the extracted gsd-core/references/verify-command-path-resolvability.md (the full dimension body — including the {VERIFY_PATHS} probe-consumption rules and severity/reason table — moved out to stay under the LARGE cap). The file is now 49064 bytes, 88 bytes of headroom under the same 49152 LARGE cap."
}
}

2
tests/emitted-drift-acks/2775-planner-package-legitimacy-gate.json
View File

@@ -2,7 +2,7 @@
"version": 1,
"paths": {
"gsd-planner.md": {
"reason": "#2775: the STRIDE supply-chain row for npm/pip/cargo installs was rewritten from 'slopcheck + blocking human checkpoint for [ASSUMED]/[SUS]' to 'package-legitimacy gate + blocking human checkpoint for [ASSUMED]/[SUS]', matching ADR-0656 (registry-API verdicts are the gate; slopcheck is an optional escalate-only adapter no shipped configuration wires). The +14 bytes is the corrected mitigation description agents read at plan time, not incidental prose growth. #3565 appends the fenced `## Return Markers` section (~1.2 KB) enumerating the six exact stall-watch dispatch markers plan-phase.md matches on — the new registry lint requires every declared marker to be emitted in-fence by its producer, and the planner previously documented none of them anywhere."
"reason": "#2775: the STRIDE supply-chain row for npm/pip/cargo installs was rewritten from 'slopcheck + blocking human checkpoint for [ASSUMED]/[SUS]' to 'package-legitimacy gate + blocking human checkpoint for [ASSUMED]/[SUS]', matching ADR-0656 (registry-API verdicts are the gate; slopcheck is an optional escalate-only adapter no shipped configuration wires). The +14 bytes is the corrected mitigation description agents read at plan time, not incidental prose growth. #3565 appends the fenced `## Return Markers` section (~1.2 KB) enumerating the six exact stall-watch dispatch markers plan-phase.md matches on — the new registry lint requires every declared marker to be emitted in-fence by its producer, and the planner previously documented none of them anywhere. #2401 append (merged into this fragment because two ack sources may never name the same path): the 'Inherit the command that already worked' paragraph is now a short pointer to the extracted gsd-core/references/planner-verify-command-grounding.md (prior_verify_commands inheritance, npm --prefix grounding rules, and the guessing prohibition all moved to the reference). The file is now 49274 bytes, well under the XL tier's 57344-byte cap, and 49077 chars (LF-normalized) under the separate 49152-char cap asserted by tests/planner-decomposition.test.cjs, tests/precondition-element.test.cjs, tests/reversibility-tagging.test.cjs, and tests/security.test.cjs."
}
}
}

2
tests/emitted-drift-acks/3409-unreachable-guard-arms.json
View File

@@ -5,7 +5,7 @@
"gsd-verifier.md": "#3409: same nullglob-hang fix as gsd-phase-researcher.md, applied to `cat \"$PHASE_DIR\"/*-VERIFICATION.md` in Step 0 — an absent VERIFICATION.md previously left a zero-operand `cat` blocking on stdin instead of falling through to first-verification mode. Growth is the array-guard idiom (+49 bytes). — #3206 append (merged into this fragment because two ack sources may never name the same path): +52 bytes, 49098 -> 49150 (2 under the LARGE cap). The growth is the literal fix for the term 5b used undefined: the compressed explicit-evidence definition inlined at 5b (+34 net on the rewritten line — the trailing honest-verifier cite there is dropped as superseded by the inline definition; honest-verifier.md stays cited at 5c) plus gsd-core/ path-prefix repairs on the two 404ing bare references/ cites at 5c (honest-verifier.md) and the MVP-mode section (verify-mvp-mode.md) (+9 each). Lazy extraction remains untakeable in this change: the large extractable blocks are content-pinned by tests that read the agent file directly (tests/verifier-behavior-unverified.test.cjs, tests/verification-overrides.test.cjs), so extraction is its own coordinated change.",
"complete-milestone.md": "#3409: guarded `cat .planning/phases/*-*/*-SUMMARY.md` — with `shopt -s nullglob` active in this block's preamble (#2962), zero matching phase summaries collapses the glob to nothing and a bare `cat` blocks reading stdin rather than producing empty output, wedging the milestone-completion review. Growth is the array-existence-check idiom (+73 bytes, two glob segments makes this longer than the single-glob sites). — #2142 append (merged into this fragment because two ack sources may never name the same path): +1605 bytes, 40498 -> 42103. The `archive_milestone` step now documents the opt-in `--archive-quick` quick-task archival flag (default OFF, deliberately NOT symmetrical with phase archival's default-ON posture), folds the AskUserQuestion decision for it into the SAME `milestone.complete` invocation (avoiding a redundant second call), and states the known bucket-all provenance limit.",
"discuss-phase-assumptions.md": "#3409: replaced the unreachable `AUTO_MODE=$(gsd_run query check auto-mode --pick active 2>/dev/null || echo \"false\")` — `||` never fires because the query exits 0 with empty stdout when the field is absent, not a failure, so AUTO_MODE silently ended up empty rather than \"false\" — with a two-line capture-then-default (`AUTO_MODE=\"${AUTO_MODE:-false}\"`) that actually reaches the fallback. Growth is the extra default-assignment line (+19 bytes).",
"plan-phase.md": "#3409: three sites. `AUTO_CHAIN` and `PHASE_REQ_IDS` get the same unreachable-`||`-fallback fix as discuss-phase-assumptions.md (empty-but-successful `gsd_run query` output never triggered `|| echo`, now uses `${VAR:-default}`); `PRIOR_SUMMARIES` additionally swapped `gsd_run query phases.list --pick summaries_total` for `--type summaries --pick count` since the old pick key produced the same unreachable-fallback failure mode for the walking-skeleton check. Net growth across the three sites is +39 bytes. — #3576 append: bare `references/<name>.md` cites repaired to the canonical `gsd-core/references/<name>.md` form (+36 bytes, 4 cite(s) × 9). Dead-pointer fix; no content change. #3559: the generic gate-dispatch arm gained the in-context validation contract for manifest-supplied check values. gates[].check is not one of the four executable surfaces the install consent prompt discloses, so a capability consented to as declarative-only could still reach a shell through an unvalidated check.query interpolated into a command substitution. The reference (references/loop-hook-dispatch.md) stated this requirement for step -> ref.command and omitted it for gate; that omission is the root cause and is now closed at the reference plus all four dispatch sites. Growth is one validation paragraph per site. 90516 -> 90627 bytes (+111).",
"plan-phase.md": "#3409: three sites. `AUTO_CHAIN` and `PHASE_REQ_IDS` get the same unreachable-`||`-fallback fix as discuss-phase-assumptions.md (empty-but-successful `gsd_run query` output never triggered `|| echo`, now uses `${VAR:-default}`); `PRIOR_SUMMARIES` additionally swapped `gsd_run query phases.list --pick summaries_total` for `--type summaries --pick count` since the old pick key produced the same unreachable-fallback failure mode for the walking-skeleton check. Net growth across the three sites is +39 bytes. — #3576 append: bare `references/<name>.md` cites repaired to the canonical `gsd-core/references/<name>.md` form (+36 bytes, 4 cite(s) × 9). Dead-pointer fix; no content change. #3559: the generic gate-dispatch arm gained the in-context validation contract for manifest-supplied check values. gates[].check is not one of the four executable surfaces the install consent prompt discloses, so a capability consented to as declarative-only could still reach a shell through an unvalidated check.query interpolated into a command substitution. The reference (references/loop-hook-dispatch.md) stated this requirement for step -> ref.command and omitted it for gate; that omission is the root cause and is now closed at the reference plus all four dispatch sites. Growth is one validation paragraph per site. 90516 -> 90627 bytes (+111). — #2401 append (merged into this fragment because two ack sources may never name the same path): plan-phase.md now dispatches the deterministic `gsd_run check verify-command-paths` probe before spawning the plan-check pass and interpolates its result into the verification prompt as {VERIFY_PATHS} inside a new <verify_command_path_probe> block, plus a <proven_verify_commands> block carrying prior_verify_commands into planning context so the planner can reuse a proven path instead of re-deriving one. 90627 -> 92807 bytes (+2180). Deliberate runtime-loaded workflow text for the new feature, not converter drift.",
"session-report.md": "#3409: guarded `ls -la .planning/reports/SESSION_REPORT*.md 2>/dev/null || echo \"No previous reports\"` — with nullglob active, zero prior reports collapses the pattern to nothing and `ls -la` with no operands lists the current directory (a successful exit, wrong output) instead of failing into the `|| echo` fallback, so the report-existence check silently printed a directory listing. Replaced with an array-existence check that only lists when a real report file is present. Growth is the guard idiom (+58 bytes).",
"transition.md": "#3409: guarded `cat .planning/phases/XX-current/*-SUMMARY.md` — same nullglob-hang defect as complete-milestone.md's phase-summary read: zero summaries left a bare `cat` blocking on stdin instead of proceeding with no summary content during PROJECT.md evolution. Growth is the array-existence-check idiom (+73 bytes)."
}

2
tests/fixtures/install-tree/antigravity.json vendored
View File

@@ -125,6 +125,7 @@
"gsd-core/references/planner-reviews.md",
"gsd-core/references/planner-revision.md",
"gsd-core/references/planner-source-audit.md",
"gsd-core/references/planner-verify-command-grounding.md",
"gsd-core/references/planning-config.md",
"gsd-core/references/prohibition-probe-fixtures/01-streak-reminder/expected.json",
"gsd-core/references/prohibition-probe-fixtures/02-clean-utility/expected.json",
@@ -164,6 +165,7 @@
"gsd-core/references/verification-patterns.md",
"gsd-core/references/verifier-phase-gates.md",
"gsd-core/references/verifier-wiring-patterns.md",
"gsd-core/references/verify-command-path-resolvability.md",
"gsd-core/references/verify-mvp-mode.md",
"gsd-core/references/workstream-flag.md",
"gsd-core/references/worktree-branch-check.md",

2
tests/fixtures/install-tree/augment.json vendored
View File

@@ -196,6 +196,7 @@
"gsd-core/references/planner-reviews.md",
"gsd-core/references/planner-revision.md",
"gsd-core/references/planner-source-audit.md",
"gsd-core/references/planner-verify-command-grounding.md",
"gsd-core/references/planning-config.md",
"gsd-core/references/prohibition-probe-fixtures/01-streak-reminder/expected.json",
"gsd-core/references/prohibition-probe-fixtures/02-clean-utility/expected.json",
@@ -235,6 +236,7 @@
"gsd-core/references/verification-patterns.md",
"gsd-core/references/verifier-phase-gates.md",
"gsd-core/references/verifier-wiring-patterns.md",
"gsd-core/references/verify-command-path-resolvability.md",
"gsd-core/references/verify-mvp-mode.md",
"gsd-core/references/workstream-flag.md",
"gsd-core/references/worktree-branch-check.md",

2
tests/fixtures/install-tree/claude-local.json vendored
View File

@@ -196,6 +196,7 @@
"gsd-core/references/planner-reviews.md",
"gsd-core/references/planner-revision.md",
"gsd-core/references/planner-source-audit.md",
"gsd-core/references/planner-verify-command-grounding.md",
"gsd-core/references/planning-config.md",
"gsd-core/references/prohibition-probe-fixtures/01-streak-reminder/expected.json",
"gsd-core/references/prohibition-probe-fixtures/02-clean-utility/expected.json",
@@ -235,6 +236,7 @@
"gsd-core/references/verification-patterns.md",
"gsd-core/references/verifier-phase-gates.md",
"gsd-core/references/verifier-wiring-patterns.md",
"gsd-core/references/verify-command-path-resolvability.md",
"gsd-core/references/verify-mvp-mode.md",
"gsd-core/references/workstream-flag.md",
"gsd-core/references/worktree-branch-check.md",

2
tests/fixtures/install-tree/claude.json vendored
View File

@@ -125,6 +125,7 @@
"gsd-core/references/planner-reviews.md",
"gsd-core/references/planner-revision.md",
"gsd-core/references/planner-source-audit.md",
"gsd-core/references/planner-verify-command-grounding.md",
"gsd-core/references/planning-config.md",
"gsd-core/references/prohibition-probe-fixtures/01-streak-reminder/expected.json",
"gsd-core/references/prohibition-probe-fixtures/02-clean-utility/expected.json",
@@ -164,6 +165,7 @@
"gsd-core/references/verification-patterns.md",
"gsd-core/references/verifier-phase-gates.md",
"gsd-core/references/verifier-wiring-patterns.md",
"gsd-core/references/verify-command-path-resolvability.md",
"gsd-core/references/verify-mvp-mode.md",
"gsd-core/references/workstream-flag.md",
"gsd-core/references/worktree-branch-check.md",

2
tests/fixtures/install-tree/cline.json vendored
View File

@@ -127,6 +127,7 @@
"gsd-core/references/planner-reviews.md",
"gsd-core/references/planner-revision.md",
"gsd-core/references/planner-source-audit.md",
"gsd-core/references/planner-verify-command-grounding.md",
"gsd-core/references/planning-config.md",
"gsd-core/references/prohibition-probe-fixtures/01-streak-reminder/expected.json",
"gsd-core/references/prohibition-probe-fixtures/02-clean-utility/expected.json",
@@ -166,6 +167,7 @@
"gsd-core/references/verification-patterns.md",
"gsd-core/references/verifier-phase-gates.md",
"gsd-core/references/verifier-wiring-patterns.md",
"gsd-core/references/verify-command-path-resolvability.md",
"gsd-core/references/verify-mvp-mode.md",
"gsd-core/references/workstream-flag.md",
"gsd-core/references/worktree-branch-check.md",

2
tests/fixtures/install-tree/codebuddy.json vendored
View File

@@ -196,6 +196,7 @@
"gsd-core/references/planner-reviews.md",
"gsd-core/references/planner-revision.md",
"gsd-core/references/planner-source-audit.md",
"gsd-core/references/planner-verify-command-grounding.md",
"gsd-core/references/planning-config.md",
"gsd-core/references/prohibition-probe-fixtures/01-streak-reminder/expected.json",
"gsd-core/references/prohibition-probe-fixtures/02-clean-utility/expected.json",
@@ -235,6 +236,7 @@
"gsd-core/references/verification-patterns.md",
"gsd-core/references/verifier-phase-gates.md",
"gsd-core/references/verifier-wiring-patterns.md",
"gsd-core/references/verify-command-path-resolvability.md",
"gsd-core/references/verify-mvp-mode.md",
"gsd-core/references/workstream-flag.md",
"gsd-core/references/worktree-branch-check.md",

2
tests/fixtures/install-tree/codex.json vendored
View File

@@ -160,6 +160,7 @@
"gsd-core/references/planner-reviews.md",
"gsd-core/references/planner-revision.md",
"gsd-core/references/planner-source-audit.md",
"gsd-core/references/planner-verify-command-grounding.md",
"gsd-core/references/planning-config.md",
"gsd-core/references/prohibition-probe-fixtures/01-streak-reminder/expected.json",
"gsd-core/references/prohibition-probe-fixtures/02-clean-utility/expected.json",
@@ -199,6 +200,7 @@
"gsd-core/references/verification-patterns.md",
"gsd-core/references/verifier-phase-gates.md",
"gsd-core/references/verifier-wiring-patterns.md",
"gsd-core/references/verify-command-path-resolvability.md",
"gsd-core/references/verify-mvp-mode.md",
"gsd-core/references/workstream-flag.md",
"gsd-core/references/worktree-branch-check.md",

2
tests/fixtures/install-tree/copilot.json vendored
View File

@@ -126,6 +126,7 @@
"gsd-core/references/planner-reviews.md",
"gsd-core/references/planner-revision.md",
"gsd-core/references/planner-source-audit.md",
"gsd-core/references/planner-verify-command-grounding.md",
"gsd-core/references/planning-config.md",
"gsd-core/references/prohibition-probe-fixtures/01-streak-reminder/expected.json",
"gsd-core/references/prohibition-probe-fixtures/02-clean-utility/expected.json",
@@ -165,6 +166,7 @@
"gsd-core/references/verification-patterns.md",
"gsd-core/references/verifier-phase-gates.md",
"gsd-core/references/verifier-wiring-patterns.md",
"gsd-core/references/verify-command-path-resolvability.md",
"gsd-core/references/verify-mvp-mode.md",
"gsd-core/references/workstream-flag.md",
"gsd-core/references/worktree-branch-check.md",

2
tests/fixtures/install-tree/cursor.json vendored
View File

@@ -125,6 +125,7 @@
"gsd-core/references/planner-reviews.md",
"gsd-core/references/planner-revision.md",
"gsd-core/references/planner-source-audit.md",
"gsd-core/references/planner-verify-command-grounding.md",
"gsd-core/references/planning-config.md",
"gsd-core/references/prohibition-probe-fixtures/01-streak-reminder/expected.json",
"gsd-core/references/prohibition-probe-fixtures/02-clean-utility/expected.json",
@@ -164,6 +165,7 @@
"gsd-core/references/verification-patterns.md",
"gsd-core/references/verifier-phase-gates.md",
"gsd-core/references/verifier-wiring-patterns.md",
"gsd-core/references/verify-command-path-resolvability.md",
"gsd-core/references/verify-mvp-mode.md",
"gsd-core/references/workstream-flag.md",
"gsd-core/references/worktree-branch-check.md",

2
tests/fixtures/install-tree/hermes.json vendored
View File

@@ -125,6 +125,7 @@
"gsd-core/references/planner-reviews.md",
"gsd-core/references/planner-revision.md",
"gsd-core/references/planner-source-audit.md",
"gsd-core/references/planner-verify-command-grounding.md",
"gsd-core/references/planning-config.md",
"gsd-core/references/prohibition-probe-fixtures/01-streak-reminder/expected.json",
"gsd-core/references/prohibition-probe-fixtures/02-clean-utility/expected.json",
@@ -164,6 +165,7 @@
"gsd-core/references/verification-patterns.md",
"gsd-core/references/verifier-phase-gates.md",
"gsd-core/references/verifier-wiring-patterns.md",
"gsd-core/references/verify-command-path-resolvability.md",
"gsd-core/references/verify-mvp-mode.md",
"gsd-core/references/workstream-flag.md",
"gsd-core/references/worktree-branch-check.md",

2
tests/fixtures/install-tree/kilo.json vendored
View File

@@ -196,6 +196,7 @@
"gsd-core/references/planner-reviews.md",
"gsd-core/references/planner-revision.md",
"gsd-core/references/planner-source-audit.md",
"gsd-core/references/planner-verify-command-grounding.md",
"gsd-core/references/planning-config.md",
"gsd-core/references/prohibition-probe-fixtures/01-streak-reminder/expected.json",
"gsd-core/references/prohibition-probe-fixtures/02-clean-utility/expected.json",
@@ -235,6 +236,7 @@
"gsd-core/references/verification-patterns.md",
"gsd-core/references/verifier-phase-gates.md",
"gsd-core/references/verifier-wiring-patterns.md",
"gsd-core/references/verify-command-path-resolvability.md",
"gsd-core/references/verify-mvp-mode.md",
"gsd-core/references/workstream-flag.md",
"gsd-core/references/worktree-branch-check.md",

2
tests/fixtures/install-tree/kimi-code.json vendored
View File

@@ -126,6 +126,7 @@
"gsd-core/references/planner-reviews.md",
"gsd-core/references/planner-revision.md",
"gsd-core/references/planner-source-audit.md",
"gsd-core/references/planner-verify-command-grounding.md",
"gsd-core/references/planning-config.md",
"gsd-core/references/prohibition-probe-fixtures/01-streak-reminder/expected.json",
"gsd-core/references/prohibition-probe-fixtures/02-clean-utility/expected.json",
@@ -165,6 +166,7 @@
"gsd-core/references/verification-patterns.md",
"gsd-core/references/verifier-phase-gates.md",
"gsd-core/references/verifier-wiring-patterns.md",
"gsd-core/references/verify-command-path-resolvability.md",
"gsd-core/references/verify-mvp-mode.md",
"gsd-core/references/workstream-flag.md",
"gsd-core/references/worktree-branch-check.md",

2
tests/fixtures/install-tree/kimi.json vendored
View File

@@ -161,6 +161,7 @@
"gsd-core/references/planner-reviews.md",
"gsd-core/references/planner-revision.md",
"gsd-core/references/planner-source-audit.md",
"gsd-core/references/planner-verify-command-grounding.md",
"gsd-core/references/planning-config.md",
"gsd-core/references/prohibition-probe-fixtures/01-streak-reminder/expected.json",
"gsd-core/references/prohibition-probe-fixtures/02-clean-utility/expected.json",
@@ -200,6 +201,7 @@
"gsd-core/references/verification-patterns.md",
"gsd-core/references/verifier-phase-gates.md",
"gsd-core/references/verifier-wiring-patterns.md",
"gsd-core/references/verify-command-path-resolvability.md",
"gsd-core/references/verify-mvp-mode.md",
"gsd-core/references/workstream-flag.md",
"gsd-core/references/worktree-branch-check.md",

2
tests/fixtures/install-tree/opencode.json vendored
View File

@@ -196,6 +196,7 @@
"gsd-core/references/planner-reviews.md",
"gsd-core/references/planner-revision.md",
"gsd-core/references/planner-source-audit.md",
"gsd-core/references/planner-verify-command-grounding.md",
"gsd-core/references/planning-config.md",
"gsd-core/references/prohibition-probe-fixtures/01-streak-reminder/expected.json",
"gsd-core/references/prohibition-probe-fixtures/02-clean-utility/expected.json",
@@ -235,6 +236,7 @@
"gsd-core/references/verification-patterns.md",
"gsd-core/references/verifier-phase-gates.md",
"gsd-core/references/verifier-wiring-patterns.md",
"gsd-core/references/verify-command-path-resolvability.md",
"gsd-core/references/verify-mvp-mode.md",
"gsd-core/references/workstream-flag.md",
"gsd-core/references/worktree-branch-check.md",

2
tests/fixtures/install-tree/pi.json vendored
View File

@@ -93,6 +93,7 @@
"gsd-core/references/planner-reviews.md",
"gsd-core/references/planner-revision.md",
"gsd-core/references/planner-source-audit.md",
"gsd-core/references/planner-verify-command-grounding.md",
"gsd-core/references/planning-config.md",
"gsd-core/references/prohibition-probe-fixtures/01-streak-reminder/expected.json",
"gsd-core/references/prohibition-probe-fixtures/02-clean-utility/expected.json",
@@ -132,6 +133,7 @@
"gsd-core/references/verification-patterns.md",
"gsd-core/references/verifier-phase-gates.md",
"gsd-core/references/verifier-wiring-patterns.md",
"gsd-core/references/verify-command-path-resolvability.md",
"gsd-core/references/verify-mvp-mode.md",
"gsd-core/references/workstream-flag.md",
"gsd-core/references/worktree-branch-check.md",

2
tests/fixtures/install-tree/qwen.json vendored
View File

@@ -125,6 +125,7 @@
"gsd-core/references/planner-reviews.md",
"gsd-core/references/planner-revision.md",
"gsd-core/references/planner-source-audit.md",
"gsd-core/references/planner-verify-command-grounding.md",
"gsd-core/references/planning-config.md",
"gsd-core/references/prohibition-probe-fixtures/01-streak-reminder/expected.json",
"gsd-core/references/prohibition-probe-fixtures/02-clean-utility/expected.json",
@@ -164,6 +165,7 @@
"gsd-core/references/verification-patterns.md",
"gsd-core/references/verifier-phase-gates.md",
"gsd-core/references/verifier-wiring-patterns.md",
"gsd-core/references/verify-command-path-resolvability.md",
"gsd-core/references/verify-mvp-mode.md",
"gsd-core/references/workstream-flag.md",
"gsd-core/references/worktree-branch-check.md",

2
tests/fixtures/install-tree/trae.json vendored
View File

@@ -125,6 +125,7 @@
"gsd-core/references/planner-reviews.md",
"gsd-core/references/planner-revision.md",
"gsd-core/references/planner-source-audit.md",
"gsd-core/references/planner-verify-command-grounding.md",
"gsd-core/references/planning-config.md",
"gsd-core/references/prohibition-probe-fixtures/01-streak-reminder/expected.json",
"gsd-core/references/prohibition-probe-fixtures/02-clean-utility/expected.json",
@@ -164,6 +165,7 @@
"gsd-core/references/verification-patterns.md",
"gsd-core/references/verifier-phase-gates.md",
"gsd-core/references/verifier-wiring-patterns.md",
"gsd-core/references/verify-command-path-resolvability.md",
"gsd-core/references/verify-mvp-mode.md",
"gsd-core/references/workstream-flag.md",
"gsd-core/references/worktree-branch-check.md",

2
tests/fixtures/install-tree/windsurf.json vendored
View File

@@ -125,6 +125,7 @@
"gsd-core/references/planner-reviews.md",
"gsd-core/references/planner-revision.md",
"gsd-core/references/planner-source-audit.md",
"gsd-core/references/planner-verify-command-grounding.md",
"gsd-core/references/planning-config.md",
"gsd-core/references/prohibition-probe-fixtures/01-streak-reminder/expected.json",
"gsd-core/references/prohibition-probe-fixtures/02-clean-utility/expected.json",
@@ -164,6 +165,7 @@
"gsd-core/references/verification-patterns.md",
"gsd-core/references/verifier-phase-gates.md",
"gsd-core/references/verifier-wiring-patterns.md",
"gsd-core/references/verify-command-path-resolvability.md",
"gsd-core/references/verify-mvp-mode.md",
"gsd-core/references/workstream-flag.md",
"gsd-core/references/worktree-branch-check.md",

2
tests/fixtures/install-tree/zcode.json vendored
View File

@@ -196,6 +196,7 @@
"gsd-core/references/planner-reviews.md",
"gsd-core/references/planner-revision.md",
"gsd-core/references/planner-source-audit.md",
"gsd-core/references/planner-verify-command-grounding.md",
"gsd-core/references/planning-config.md",
"gsd-core/references/prohibition-probe-fixtures/01-streak-reminder/expected.json",
"gsd-core/references/prohibition-probe-fixtures/02-clean-utility/expected.json",
@@ -235,6 +236,7 @@
"gsd-core/references/verification-patterns.md",
"gsd-core/references/verifier-phase-gates.md",
"gsd-core/references/verifier-wiring-patterns.md",
"gsd-core/references/verify-command-path-resolvability.md",
"gsd-core/references/verify-mvp-mode.md",
"gsd-core/references/workstream-flag.md",
"gsd-core/references/worktree-branch-check.md",

37
tests/lint-test-file-count.test.cjs
View File

@@ -20,6 +20,7 @@ const {
Verdict,
evaluateLint,
testEffectivePrefix,
_buildTestMap,
} = require(LINT_SCRIPT);
// ---------------------------------------------------------------------------
@@ -262,6 +263,42 @@ describe('evaluateLint — allowlist behaviour (identity-based)', () => {
});
});
// ---------------------------------------------------------------------------
// _buildTestMap — longest-prefix bucketing (order-independence)
// ---------------------------------------------------------------------------
describe('_buildTestMap — longest-prefix bucketing', () => {
// Regression for readdirSync-order-dependent bucketing: `verify.cjs` and
// `verify-command-grounding.cjs` are production modules where one name is a
// hyphen-extension of the other. fs.readdirSync order is not stable across
// platforms (e.g. Linux ext4 hash order vs macOS HFS+/APFS), so
// `prodPrefixes` (a Map built from readdirSync) can iterate in either
// order. A test file matching the longer, more specific prefix must always
// bucket there — never fall through to the shorter prefix — regardless of
// which key the Map visits first.
const testFile = makeFiles('verify-command-grounding', ['verify-command-grounding.test.cjs'])[0];
test('buckets to the longer prefix when the short prefix is visited first', () => {
const prodPrefixes = new Map([
['verify', '/fake/src/verify.cjs'],
['verify-command-grounding', '/fake/src/verify-command-grounding.cjs'],
]);
const map = _buildTestMap(prodPrefixes, [testFile]);
assert.deepStrictEqual(map.get('verify-command-grounding'), [testFile]);
assert.deepStrictEqual(map.get('verify'), []);
});
test('buckets to the longer prefix when the long prefix is visited first', () => {
const prodPrefixes = new Map([
['verify-command-grounding', '/fake/src/verify-command-grounding.cjs'],
['verify', '/fake/src/verify.cjs'],
]);
const map = _buildTestMap(prodPrefixes, [testFile]);
assert.deepStrictEqual(map.get('verify-command-grounding'), [testFile]);
assert.deepStrictEqual(map.get('verify'), []);
});
});
// ---------------------------------------------------------------------------
// testEffectivePrefix — issue-stamp stripping
// ---------------------------------------------------------------------------

972
tests/verify-command-grounding.test.cjs Normal file
View File

@@ -0,0 +1,972 @@
'use strict';
/**
* Verify-command grounding (#2401).
*
* Module: gsd-core/bin/lib/verify-command-grounding.cjs
* Exported: extractAutomatedCommands, resolveVerifyCommandTarget,
* probePhaseVerifyCommands, harvestPriorVerifyCommands
*
* #2401: a planner authored `<automated>cd ../../frontend && npm run lint</automated>`
* whose target does not resolve from the executor's cwd, and the plan-checker —
* lacking a deterministic probe — hand-reasoned the filesystem and prescribed two
* successively-wrong replacement paths.
*
* This module answers "can this command's target directory be grounded?" WITHOUT
* executing the command. It is a RECOGNIZER, not a shell interpreter: exactly two
* forms are grounded (`cd <literal>` and `npm --prefix <literal>`), and anything
* carrying a variable, glob, substitution, or a LEADING `~` (home-expansion)
* returns `unresolvable` — a warning, never a blocker. A `~` anywhere else in
* the path (e.g. a Windows 8.3 short name like `RUNNER~1`) is an ordinary
* literal character and must resolve normally (#2401 CI regression). Refusing
* to guess is the whole point; guessing is the defect being fixed.
*
* Row numbers below map to `.gsd/phase/feat-2401-verify-command-grounding/50-test-matrix.md`.
*
* IO-failure rows monkeypatch the `fs` method and restore in `finally` — never
* `chmod 0o000`, which root bypasses in Docker/CI so the test would pass with
* zero coverage.
*
* The final `describe('property-based invariants', …)` block below carries the
* fast-check property tests for this module. Properties covered:
* (a) resolveVerifyCommandTarget never throws and always returns a known
* status/severity/base shape, for arbitrary string input.
* (b) a 'blocker' severity is only ever reported for a grounded form: form
* is non-null and target is a non-empty string.
* (c) extractAutomatedCommands recovers every generated <automated> command,
* in order, from synthesized plan text.
* (d) CRLF invariance: the same plan rendered with \r\n line joins produces
* an identical command list.
* (e) extractAutomatedCommands never throws on arbitrary input, including
* non-string values, and returns [] for non-strings.
*/
const { describe, test, before, after } = require('node:test');
const assert = require('node:assert/strict');
const fs = require('node:fs');
const os = require('node:os');
const path = require('node:path');
const fc = require('./helpers/fast-check-setup.cjs');
const { cleanup, runGsdTools } = require('./helpers.cjs');
const {
extractAutomatedCommands,
resolveVerifyCommandTarget,
probePhaseVerifyCommands,
harvestPriorVerifyCommands,
} = require('../gsd-core/bin/lib/verify-command-grounding.cjs');
const { extractTaggedBlocks } = require('../gsd-core/bin/lib/markdown-sectionizer.cjs');
const KNOWN_STATUSES = new Set([
'ok',
'broken',
'unresolvable',
'not_applicable',
'pending_creation',
]);
/** Root for every fixture built by this file; removed in `after`. */
let ROOT = '';
function fixtureRoot(name) {
const dir = path.join(ROOT, name);
fs.mkdirSync(dir, { recursive: true });
return dir;
}
function writePackageJson(dir, scripts) {
fs.mkdirSync(dir, { recursive: true });
fs.writeFileSync(path.join(dir, 'package.json'), JSON.stringify({ name: 'fx', scripts }), 'utf8');
}
/** Build a minimal PLAN.md body with one `<automated>` per supplied command. */
function planWith(commands, { taskFiles = [], artifacts = [], eol = '\n' } = {}) {
const tasks = commands
.map(
(cmd, i) =>
[
'<task type="auto">',
` <name>task-${i}</name>`,
` <files>${taskFiles[i] ?? ''}</files>`,
' <action>do the thing</action>',
` <verify><automated>${cmd}</automated></verify>`,
' <acceptance_criteria>it works</acceptance_criteria>',
' <done>committed</done>',
'</task>',
].join(eol),
)
.join(eol);
const artifactSection = artifacts.length
? [eol, '## Artifacts this phase produces', ...artifacts.map((a) => `- ${a}`)].join(eol)
: '';
return ['# Plan', '', tasks, artifactSection].join(eol);
}
function writePhase(root, phaseName, plans) {
const planningDir = path.join(root, '.planning');
const phaseDir = path.join(planningDir, phaseName);
fs.mkdirSync(phaseDir, { recursive: true });
for (const [file, body] of Object.entries(plans)) {
fs.writeFileSync(path.join(phaseDir, file), body, 'utf8');
}
return phaseDir;
}
before(() => {
ROOT = fs.mkdtempSync(path.join(os.tmpdir(), 'gsd-2401-'));
});
after(() => {
if (ROOT) cleanup(ROOT);
});
describe('extractAutomatedCommands', () => {
test('row 29 — non-string plan text yields empty list', () => {
for (const bad of [0, '', [], null, undefined, true, {}]) {
assert.deepEqual(extractAutomatedCommands(bad), [], `input ${JSON.stringify(bad)}`);
}
});
test('row 30 — empty automated block is skipped', () => {
const out = extractAutomatedCommands(planWith(['', ' ', 'npm test']));
assert.equal(out.length, 1);
assert.equal(out[0].command, 'npm test');
});
test('row 31 — attribute-bearing automated tag is extracted', () => {
const md = '<task type="auto"><name>t</name><verify><automated tier="fast">npm test</automated></verify></task>';
const out = extractAutomatedCommands(md);
assert.equal(out.length, 1);
assert.equal(out[0].command, 'npm test');
});
test('row 32 — unclosed automated openers terminate', () => {
const md = '<automated>'.repeat(200);
const out = extractAutomatedCommands(md);
assert.ok(Array.isArray(out));
});
test('row 27 — repeated command reports both occurrences', () => {
const out = extractAutomatedCommands(planWith(['npm test', 'npm test']));
assert.equal(out.length, 2);
});
test('carries the owning task name', () => {
const out = extractAutomatedCommands(planWith(['npm test']));
assert.equal(out[0].task, 'task-0');
});
test('row 25 — CRLF plan yields identical extraction to LF', () => {
const lf = extractAutomatedCommands(planWith(['cd web && npm test', 'npm run build']));
const crlf = extractAutomatedCommands(planWith(['cd web && npm test', 'npm run build'], { eol: '\r\n' }));
assert.deepEqual(
crlf.map((c) => c.command),
lf.map((c) => c.command),
);
});
});
describe('task-grammar parity', () => {
test('extractAutomatedCommands attributes the same task names as the canonical sectionizer', () => {
const longAttr = 'x'.repeat(400);
const fixture = [
'<task><name>bare</name><verify><automated>echo bare</automated></verify></task>',
'<task type="auto"><name>typed</name><verify><automated>echo typed</automated></verify></task>',
`<task type="auto" data-note="${longAttr}"><name>longattr</name><verify><automated>echo longattr</automated></verify></task>`,
'<task><name>adjacent-a</name><verify><automated>echo a</automated></verify></task>',
'<task><name>adjacent-b</name><verify><automated>echo b</automated></verify></task>',
'<task><name>lt</name><verify><automated>echo "a < b" && echo x < y</automated></verify></task>',
].join('\n');
const attributed = new Set(extractAutomatedCommands(fixture).map((c) => c.task));
const canonicalNames = new Set(
extractTaggedBlocks(fixture, 'task', true).map((body) => {
const m = /<name>([\s\S]*?)<\/name>/.exec(body);
return m ? m[1].trim() : '';
}),
);
assert.deepEqual(attributed, canonicalNames);
assert.deepEqual(
[...attributed].sort(),
['adjacent-a', 'adjacent-b', 'bare', 'longattr', 'lt', 'typed'],
);
});
});
describe('resolveVerifyCommandTarget — grounded forms', () => {
test('row 1 — no cd or prefix is not applicable', () => {
const root = fixtureRoot('row1');
const r = resolveVerifyCommandTarget('npm test -- --filter=x', { projectRoot: root });
assert.equal(r.status, 'not_applicable');
assert.equal(r.target, null);
assert.equal(r.severity, 'none');
});
test('row 2 — resolves a cd target that exists', () => {
const root = fixtureRoot('row2');
writePackageJson(path.join(root, 'frontend'), { lint: 'eslint .' });
const r = resolveVerifyCommandTarget('cd frontend && npm run lint', { projectRoot: root });
assert.equal(r.status, 'ok');
assert.equal(r.form, 'cd');
assert.equal(r.target, path.join(root, 'frontend'));
assert.equal(r.manifest, 'package.json');
assert.equal(r.severity, 'none');
});
test('row 3 — flags the reported unresolvable cd target', () => {
// Nested two levels deep so `cd ../../frontend` resolves to
// `<row3-root>/frontend` — inside the suite's own temp root, which it
// controls and does not create — rather than escaping into the shared OS
// temp directory where a stray `frontend/` could silently flip the
// assertion.
const root = fixtureRoot('row3/a/b');
const r = resolveVerifyCommandTarget('cd ../../frontend && npm run lint && npm run build', {
projectRoot: root,
});
assert.equal(r.status, 'broken');
assert.equal(r.reason, 'missing_dir');
assert.equal(r.severity, 'blocker');
// The probe reports what it resolved; it never prescribes a replacement.
assert.equal(r.rawTarget, '../../frontend');
assert.ok(!('suggestion' in r), 'probe must not prescribe a replacement path');
});
test('row 4 — dir without a manifest is broken for an npm command', () => {
const root = fixtureRoot('row4');
fs.mkdirSync(path.join(root, 'docs-only'), { recursive: true });
const r = resolveVerifyCommandTarget('cd docs-only && npm run lint', { projectRoot: root });
assert.equal(r.status, 'broken');
assert.equal(r.reason, 'no_manifest');
assert.equal(r.severity, 'blocker');
});
test('row 5 — non-npm command needs no manifest', () => {
const root = fixtureRoot('row5');
fs.mkdirSync(path.join(root, 'docs-only'), { recursive: true });
const r = resolveVerifyCommandTarget('cd docs-only && grep -q x README.md', { projectRoot: root });
assert.equal(r.status, 'ok');
assert.equal(r.severity, 'none');
});
test('row 6 — resolves npm --prefix', () => {
const root = fixtureRoot('row6');
writePackageJson(path.join(root, 'web'), { build: 'vite build' });
const r = resolveVerifyCommandTarget('npm --prefix ./web run build', { projectRoot: root });
assert.equal(r.status, 'ok');
assert.equal(r.form, 'prefix');
assert.equal(r.target, path.join(root, 'web'));
});
test('row 7 — resolves trailing --prefix', () => {
const root = fixtureRoot('row7');
writePackageJson(path.join(root, 'web'), { build: 'vite build' });
const r = resolveVerifyCommandTarget('npm run build --prefix ./web', { projectRoot: root });
assert.equal(r.status, 'ok');
assert.equal(r.target, path.join(root, 'web'));
});
test('row 8 — absolute prefix is not joined to root', () => {
const root = fixtureRoot('row8');
const abs = path.join(ROOT, 'row8-abs');
writePackageJson(abs, { lint: 'eslint .' });
const r = resolveVerifyCommandTarget(`npm --prefix ${abs} run lint`, { projectRoot: root });
assert.equal(r.status, 'ok');
assert.equal(r.target, abs);
});
test('row 9 — folds chained cd segments', () => {
const root = fixtureRoot('row9');
writePackageJson(path.join(root, 'a', 'b'), { test: 'node --version' });
const r = resolveVerifyCommandTarget('cd a && cd b && npm test', { projectRoot: root });
assert.equal(r.status, 'ok');
assert.equal(r.target, path.join(root, 'a', 'b'));
});
test('row 22 — cd dot resolves to project root', () => {
const root = fixtureRoot('row22');
writePackageJson(root, { test: 'node --version' });
const r = resolveVerifyCommandTarget('cd . && npm test', { projectRoot: root });
assert.equal(r.status, 'ok');
assert.equal(r.target, root);
});
test('row 20 — normalizes windows separators', () => {
const root = fixtureRoot('row20');
const back = resolveVerifyCommandTarget('cd ..\\..\\frontend && npm test', { projectRoot: root });
const fwd = resolveVerifyCommandTarget('cd ../../frontend && npm test', { projectRoot: root });
assert.equal(back.status, fwd.status);
assert.equal(back.target, fwd.target);
});
test('row 35 — file at target path is not a directory', () => {
const root = fixtureRoot('row35');
fs.writeFileSync(path.join(root, 'frontend'), 'not a dir', 'utf8');
const r = resolveVerifyCommandTarget('cd frontend && npm test', { projectRoot: root });
assert.equal(r.status, 'broken');
assert.equal(r.reason, 'missing_dir');
});
});
describe('#2401 review Finding 1 — script check runs for --prefix form regardless of flag order', () => {
test('npm --prefix ./web run <missing-script> is script_missing/warning', () => {
const root = fixtureRoot('finding1-prefix-first-missing');
writePackageJson(path.join(root, 'web'), { build: 'vite build' });
const r = resolveVerifyCommandTarget('npm --prefix ./web run nope', { projectRoot: root });
assert.equal(r.reason, 'script_missing');
assert.equal(r.severity, 'warning');
});
test('npm run <missing-script> --prefix ./web is script_missing/warning', () => {
const root = fixtureRoot('finding1-prefix-trailing-missing');
writePackageJson(path.join(root, 'web'), { build: 'vite build' });
const r = resolveVerifyCommandTarget('npm run nope --prefix ./web', { projectRoot: root });
assert.equal(r.reason, 'script_missing');
assert.equal(r.severity, 'warning');
});
test('npm --prefix ./web run <existing-script> is reason:null/severity:none', () => {
const root = fixtureRoot('finding1-prefix-first-present');
writePackageJson(path.join(root, 'web'), { build: 'vite build' });
const r = resolveVerifyCommandTarget('npm --prefix ./web run build', { projectRoot: root });
assert.equal(r.reason, null);
assert.equal(r.severity, 'none');
});
test('npm run <existing-script> --prefix ./web is reason:null/severity:none', () => {
const root = fixtureRoot('finding1-prefix-trailing-present');
writePackageJson(path.join(root, 'web'), { build: 'vite build' });
const r = resolveVerifyCommandTarget('npm run build --prefix ./web', { projectRoot: root });
assert.equal(r.reason, null);
assert.equal(r.severity, 'none');
});
});
describe('#2401 review Finding 2 — quoted --prefix paths containing spaces', () => {
for (const [label, quote] of [['double-quoted', '"'], ['single-quoted', "'"]]) {
test(`npm --prefix ${quote}my dir${quote} run test resolves the ${label} directory`, () => {
const root = fixtureRoot(`finding2-present-${label}`);
writePackageJson(path.join(root, 'my dir'), { test: 'node --version' });
const r = resolveVerifyCommandTarget(`npm --prefix ${quote}my dir${quote} run test`, { projectRoot: root });
assert.equal(r.status, 'ok');
assert.equal(r.severity, 'none');
assert.equal(r.target, path.join(root, 'my dir'));
});
test(`npm --prefix ${quote}my dir${quote} run test is broken/missing_dir when the ${label} dir does not exist`, () => {
const root = fixtureRoot(`finding2-absent-${label}`);
const r = resolveVerifyCommandTarget(`npm --prefix ${quote}my dir${quote} run test`, { projectRoot: root });
assert.equal(r.status, 'broken');
assert.equal(r.reason, 'missing_dir');
});
}
});
describe('#2401 review Finding 3 — an absolute segment in a chained cd resets, not concatenates', () => {
test('cd sub && cd <abs-existing-dir> && npm test resolves to the absolute dir', () => {
const root = fixtureRoot('finding3-abs-reset');
fs.mkdirSync(path.join(root, 'sub'), { recursive: true });
const abs = path.join(ROOT, 'finding3-abs-target');
writePackageJson(abs, { test: 'node --version' });
const r = resolveVerifyCommandTarget(`cd sub && cd ${abs} && npm test`, { projectRoot: root });
assert.equal(r.status, 'ok');
assert.equal(r.severity, 'none');
assert.equal(r.target, abs);
assert.equal(r.rawTarget, abs);
});
test('cd a && cd b && npm test (both relative) still resolves to <root>/a/b', () => {
const root = fixtureRoot('finding3-relative-chain');
writePackageJson(path.join(root, 'a', 'b'), { test: 'node --version' });
const r = resolveVerifyCommandTarget('cd a && cd b && npm test', { projectRoot: root });
assert.equal(r.status, 'ok');
assert.equal(r.target, path.join(root, 'a', 'b'));
});
});
describe('resolveVerifyCommandTarget — refusals and negative space', () => {
const hostile = [
['row 10 — refuses a variable path', 'cd "$FRONTEND" && npm test'],
['row 11 — refuses a glob path', 'cd frontend-* && npm test'],
['row 12 — refuses command substitution', 'cd $(git rev-parse --show-toplevel)/web && npm test'],
['row 13 — refuses backtick substitution', 'cd `pwd`/web && npm test'],
['row 14 — refuses tilde expansion', 'cd ~/web && npm test'],
];
for (const [name, command] of hostile) {
test(name, () => {
const root = fixtureRoot('hostile');
const r = resolveVerifyCommandTarget(command, { projectRoot: root });
assert.equal(r.status, 'unresolvable', command);
assert.equal(r.reason, 'dynamic_path');
assert.equal(r.severity, 'warning', 'an ungroundable path must never block');
});
}
test('row 15 — Nyquist MISSING sentinel is not applicable', () => {
const root = fixtureRoot('row15');
const r = resolveVerifyCommandTarget('MISSING — Wave 0 must create tests/x.py first', {
projectRoot: root,
});
assert.equal(r.status, 'not_applicable');
assert.equal(r.sentinel, true);
assert.equal(r.severity, 'none');
});
test('row 16 — pseudo-shell assertion is not applicable', () => {
const root = fixtureRoot('row16');
const r = resolveVerifyCommandTarget("grep -c '?from=' src/x.tsx == 0", { projectRoot: root });
assert.equal(r.status, 'not_applicable');
});
test('row 17 — dir created by an earlier task is pending, not broken', () => {
const root = fixtureRoot('row17');
const r = resolveVerifyCommandTarget('cd frontend && npm test', {
projectRoot: root,
declaredPaths: ['frontend/package.json'],
});
assert.equal(r.status, 'pending_creation');
assert.notEqual(r.severity, 'blocker');
});
test('row 21 — target above project root warns', () => {
const root = fixtureRoot('row21');
const r = resolveVerifyCommandTarget('cd ../.. && npm test', { projectRoot: root });
assert.equal(r.reason, 'outside_root');
assert.equal(r.severity, 'warning');
assert.equal(r.base, root, 'the resolved base must be reported');
});
test('row 19 — missing npm script warns, never blocks', () => {
const root = fixtureRoot('row19');
writePackageJson(path.join(root, 'frontend'), { lint: 'eslint .' });
const r = resolveVerifyCommandTarget('cd frontend && npm run nope', { projectRoot: root });
assert.equal(r.status, 'ok');
assert.equal(r.reason, 'script_missing');
assert.equal(r.severity, 'warning');
assert.equal(r.script, 'nope');
});
test('row 33 — invalid manifest json degrades to warning', () => {
const root = fixtureRoot('row33');
const dir = path.join(root, 'frontend');
fs.mkdirSync(dir, { recursive: true });
fs.writeFileSync(path.join(dir, 'package.json'), '{ not json', 'utf8');
const r = resolveVerifyCommandTarget('cd frontend && npm run lint', { projectRoot: root });
assert.equal(r.status, 'ok');
assert.equal(r.reason, 'manifest_unreadable');
assert.equal(r.severity, 'warning');
});
test('row 34 — non-object manifest json does not crash', () => {
for (const [i, body] of ['0', '"s"', '[]', 'null', 'true'].entries()) {
const root = fixtureRoot(`row34-${i}`);
const dir = path.join(root, 'frontend');
fs.mkdirSync(dir, { recursive: true });
fs.writeFileSync(path.join(dir, 'package.json'), body, 'utf8');
const r = resolveVerifyCommandTarget('cd frontend && npm run lint', { projectRoot: root });
assert.ok(KNOWN_STATUSES.has(r.status), `body ${body} → ${r.status}`);
assert.notEqual(r.severity, 'blocker', `body ${body} must not block`);
}
});
test('row 28 — bare call shape does not throw', () => {
const r = resolveVerifyCommandTarget('cd frontend && npm test');
assert.ok(KNOWN_STATUSES.has(r.status));
assert.equal(typeof r.base, 'string');
});
test('row 46 — probe never executes the command', () => {
const root = fixtureRoot('row46');
const canary = path.join(root, 'pwned');
resolveVerifyCommandTarget(`cd . && touch ${canary}`, { projectRoot: root });
resolveVerifyCommandTarget(`npm --prefix . run x; touch ${canary}`, { projectRoot: root });
assert.equal(fs.existsSync(canary), false, 'the probe must never execute command text');
});
});
describe('#2401 CI regression — mid-string ~ (Windows 8.3 short names) is a literal, not home-expansion', () => {
// Fixture dir literally named `RUNNER~1`, mirroring the 8.3 short-name shape
// GitHub's Windows runners put in os.tmpdir() (e.g. `C:\Users\RUNNER~1\...`).
// A `~` anywhere but the START of a path is an ordinary literal character;
// only a LEADING `~` is shell home-expansion.
function shortNameFixture(name) {
const root = fixtureRoot(name);
const app = path.join(root, 'RUNNER~1', 'app');
writePackageJson(app, { lint: 'eslint .', test: 'node --version' });
return { root, app };
}
test('mid-string ~ in an absolute --prefix path resolves', () => {
const { app } = shortNameFixture('tilde-abs-prefix');
const r = resolveVerifyCommandTarget(`npm --prefix ${app} run lint`, { projectRoot: app });
assert.equal(r.status, 'ok');
assert.equal(r.severity, 'none');
assert.equal(r.target, app);
});
test('mid-string ~ in a relative cd target resolves', () => {
const { root } = shortNameFixture('tilde-relative-cd');
const r = resolveVerifyCommandTarget('cd RUNNER~1/app && npm test', { projectRoot: root });
assert.equal(r.status, 'ok');
assert.equal(r.severity, 'none');
assert.equal(r.target, path.join(root, 'RUNNER~1', 'app'));
});
test('leading ~ is still refused (row 14 must not be weakened)', () => {
const root = fixtureRoot('tilde-leading-still-refused');
const r = resolveVerifyCommandTarget('cd ~/web && npm test', { projectRoot: root });
assert.equal(r.status, 'unresolvable');
assert.equal(r.reason, 'dynamic_path');
assert.equal(r.severity, 'warning');
});
test('quoted leading ~ is still refused', () => {
const root = fixtureRoot('tilde-leading-quoted-refused');
const r = resolveVerifyCommandTarget('cd "~/web" && npm test', { projectRoot: root });
assert.equal(r.status, 'unresolvable');
assert.equal(r.reason, 'dynamic_path');
assert.equal(r.severity, 'warning');
});
});
describe('probePhaseVerifyCommands', () => {
test('row 23 — plan with no automated blocks is ok', () => {
const root = fixtureRoot('row23');
const phaseDir = writePhase(root, 'phase-1', { '01-PLAN.md': '# Plan\n\nno tasks here\n' });
const r = probePhaseVerifyCommands({ phaseDir, projectRoot: root });
assert.deepEqual(r.commands, []);
assert.equal(r.status, 'ok');
});
test('row 26 — overall status is the worst present', () => {
const root = fixtureRoot('row26');
writePackageJson(path.join(root, 'good'), { test: 'node --version' });
const phaseDir = writePhase(root, 'phase-1', {
'01-PLAN.md': planWith(['cd good && npm test']),
'02-PLAN.md': planWith(['cd nowhere && npm test']),
});
const r = probePhaseVerifyCommands({ phaseDir, projectRoot: root });
assert.equal(r.commands.length, 2);
assert.equal(r.status, 'broken');
assert.equal(r.counts.blocker, 1);
});
test('row 18 — artifact-section path is pending, not broken', () => {
const root = fixtureRoot('row18');
const phaseDir = writePhase(root, 'phase-1', {
'01-PLAN.md': planWith(['cd frontend && npm test'], { artifacts: ['frontend/package.json'] }),
});
const r = probePhaseVerifyCommands({ phaseDir, projectRoot: root });
assert.equal(r.commands[0].status, 'pending_creation');
assert.equal(r.counts.blocker, 0);
});
test('row 17b — a path declared in an earlier task <files> is pending', () => {
const root = fixtureRoot('row17b');
const phaseDir = writePhase(root, 'phase-1', {
'01-PLAN.md': planWith(['cd frontend && npm test'], { taskFiles: ['frontend/package.json'] }),
});
const r = probePhaseVerifyCommands({ phaseDir, projectRoot: root });
assert.equal(r.commands[0].status, 'pending_creation');
});
test('row 25b — CRLF plan yields identical verdicts', () => {
const root = fixtureRoot('row25b');
writePackageJson(path.join(root, 'web'), { test: 'node --version' });
const lfDir = writePhase(root, 'phase-lf', {
'01-PLAN.md': planWith(['cd web && npm test', 'cd nowhere && npm test']),
});
const crlfDir = writePhase(root, 'phase-crlf', {
'01-PLAN.md': planWith(['cd web && npm test', 'cd nowhere && npm test'], { eol: '\r\n' }),
});
const lf = probePhaseVerifyCommands({ phaseDir: lfDir, projectRoot: root });
const crlf = probePhaseVerifyCommands({ phaseDir: crlfDir, projectRoot: root });
assert.deepEqual(
crlf.commands.map((c) => [c.command, c.status, c.reason]),
lf.commands.map((c) => [c.command, c.status, c.reason]),
);
});
test('row 24 — unreadable phase degrades, never throws', () => {
const root = fixtureRoot('row24');
const phaseDir = writePhase(root, 'phase-1', { '01-PLAN.md': planWith(['npm test']) });
const realReadFile = fs.readFileSync;
try {
fs.readFileSync = (p, ...rest) => {
if (String(p).endsWith('01-PLAN.md')) {
const err = new Error('EIO: simulated read failure');
err.code = 'EIO';
throw err;
}
return realReadFile.call(fs, p, ...rest);
};
const r = probePhaseVerifyCommands({ phaseDir, projectRoot: root });
assert.ok(r.readError, 'a read failure must surface as readError');
assert.deepEqual(r.commands, []);
} finally {
fs.readFileSync = realReadFile;
}
});
test('row 24b — absent phase dir degrades, never throws', () => {
const root = fixtureRoot('row24b');
const r = probePhaseVerifyCommands({
phaseDir: path.join(root, 'no-such-phase'),
projectRoot: root,
});
assert.ok(r.readError);
assert.deepEqual(r.commands, []);
});
});
describe('harvestPriorVerifyCommands', () => {
function planningWithPhases(name, phases) {
const root = fixtureRoot(name);
for (const [phaseName, plans] of Object.entries(phases)) writePhase(root, phaseName, plans);
return { root, planningDir: path.join(root, '.planning') };
}
test('row 36 — harvests prior phase commands', () => {
const { planningDir } = planningWithPhases('row36', {
'01-alpha': { '01-PLAN.md': planWith(['npm --prefix ./web run lint']) },
'02-beta': { '01-PLAN.md': planWith(['cd nowhere && npm test']) },
});
const r = harvestPriorVerifyCommands({ planningDir, beforePhase: 2 });
assert.equal(r.commands.length, 1);
assert.equal(r.commands[0].command, 'npm --prefix ./web run lint');
assert.equal(r.commands[0].phase, '01');
assert.ok(r.commands[0].plan.endsWith('01-PLAN.md'));
});
test('row 37 — no prior phase harvests empty', () => {
const { planningDir } = planningWithPhases('row37', {
'01-alpha': { '01-PLAN.md': planWith(['npm test']) },
});
assert.deepEqual(harvestPriorVerifyCommands({ planningDir, beforePhase: 1 }).commands, []);
});
test('row 38 — walks back to the nearest phase with commands', () => {
const { planningDir } = planningWithPhases('row38', {
'01-alpha': { '01-PLAN.md': planWith(['npm --prefix ./web run build']) },
'02-beta': { '01-PLAN.md': '# Plan\n\nno automated blocks\n' },
'03-gamma': { '01-PLAN.md': planWith(['cd x && npm test']) },
});
const r = harvestPriorVerifyCommands({ planningDir, beforePhase: 3 });
assert.equal(r.commands.length, 1);
assert.equal(r.commands[0].phase, '01');
});
test('row 39 — walkback stops at three phases', () => {
const { planningDir } = planningWithPhases('row39', {
'01-alpha': { '01-PLAN.md': planWith(['npm --prefix ./web run build']) },
'02-beta': { '01-PLAN.md': '# Plan\n' },
'03-gamma': { '01-PLAN.md': '# Plan\n' },
'04-delta': { '01-PLAN.md': '# Plan\n' },
'05-epsilon': { '01-PLAN.md': planWith(['cd x && npm test']) },
});
assert.deepEqual(harvestPriorVerifyCommands({ planningDir, beforePhase: 5 }).commands, []);
});
test('row 40 — harvest caps at twenty commands (19 / 20 / 21)', () => {
for (const [n, expected] of [
[19, 19],
[20, 20],
[21, 20],
]) {
const cmds = Array.from({ length: n }, (_, i) => `npm --prefix ./p${i} run build`);
const { planningDir } = planningWithPhases(`row40-${n}`, {
'01-alpha': { '01-PLAN.md': planWith(cmds) },
'02-beta': { '01-PLAN.md': '# Plan\n' },
});
const r = harvestPriorVerifyCommands({ planningDir, beforePhase: 2 });
assert.equal(r.commands.length, expected, `${n} distinct commands → ${expected}`);
}
});
test('row 40b — duplicate commands are deduped before the cap', () => {
const { planningDir } = planningWithPhases('row40b', {
'01-alpha': { '01-PLAN.md': planWith(['npm test', 'npm test', 'npm run lint']) },
'02-beta': { '01-PLAN.md': '# Plan\n' },
});
const r = harvestPriorVerifyCommands({ planningDir, beforePhase: 2 });
assert.deepEqual(
r.commands.map((c) => c.command),
['npm test', 'npm run lint'],
);
});
test('row 41 — harvest degrades on unreadable planning dir', () => {
const { planningDir } = planningWithPhases('row41', {
'01-alpha': { '01-PLAN.md': planWith(['npm test']) },
'02-beta': { '01-PLAN.md': '# Plan\n' },
});
const realReaddir = fs.readdirSync;
try {
fs.readdirSync = () => {
const err = new Error('EACCES: simulated');
err.code = 'EACCES';
throw err;
};
const r = harvestPriorVerifyCommands({ planningDir, beforePhase: 2 });
assert.deepEqual(r.commands, []);
assert.ok(r.readError);
} finally {
fs.readdirSync = realReaddir;
}
});
test('harvest never throws on a missing planning dir', () => {
const root = fixtureRoot('harvest-missing');
const r = harvestPriorVerifyCommands({
planningDir: path.join(root, 'nope'),
beforePhase: 3,
});
assert.deepEqual(r.commands, []);
});
// #2401 review fix: production phase directories are NOT named `phase-N-slug`
// — they are `01-foundation`, `3-thing`, `2.1-thing`, `12A-thing`, and
// optionally project-code-prefixed (`CK-01-name`). The bespoke
// `/^phase-(\d+(?:\.\d+)?)/` regex this module previously used matched none
// of these, so `harvestPriorVerifyCommands` always returned `[]` in
// production. These rows pin every real directory-naming form via the
// canonical `phase-id.cjs` grammar.
test('#2401 — zero-padded phase dir (01-foundation)', () => {
const { planningDir } = planningWithPhases('naming-zero-padded', {
'01-foundation': { '01-PLAN.md': planWith(['npm --prefix ./web run lint']) },
'02-next': { '01-PLAN.md': '# Plan\n' },
});
const r = harvestPriorVerifyCommands({ planningDir, beforePhase: 2 });
assert.equal(r.commands.length, 1);
assert.equal(r.commands[0].command, 'npm --prefix ./web run lint');
assert.equal(r.commands[0].phase, '01');
});
test('#2401 — unpadded phase dir (3-thing)', () => {
const { planningDir } = planningWithPhases('naming-unpadded', {
'3-thing': { '01-PLAN.md': planWith(['npm test']) },
'4-next': { '01-PLAN.md': '# Plan\n' },
});
const r = harvestPriorVerifyCommands({ planningDir, beforePhase: 4 });
assert.equal(r.commands.length, 1);
assert.equal(r.commands[0].command, 'npm test');
assert.equal(r.commands[0].phase, '3');
});
test('#2401 — decimal sub-phase (2.1-thing) orders between 2-thing and 3-thing', () => {
const { planningDir } = planningWithPhases('naming-decimal', {
'2-thing': { '01-PLAN.md': planWith(['npm run build:base']) },
'2.1-thing': { '01-PLAN.md': planWith(['npm run build:subphase']) },
'3-thing': { '01-PLAN.md': '# Plan\n' },
});
// beforePhase 3 walks back descending: 3-thing (empty) → 2.1-thing (has
// commands, stop) — 2.1 must sort BETWEEN 2 and 3, not after 3 or before 2.
const r = harvestPriorVerifyCommands({ planningDir, beforePhase: 3 });
assert.equal(r.commands.length, 1);
assert.equal(r.commands[0].command, 'npm run build:subphase');
assert.equal(r.commands[0].phase, '2.1');
});
test('#2401 — variant-suffixed phase dir (12A-thing)', () => {
const { planningDir } = planningWithPhases('naming-variant-suffix', {
'12A-thing': { '01-PLAN.md': planWith(['npm test']) },
'13-next': { '01-PLAN.md': '# Plan\n' },
});
const r = harvestPriorVerifyCommands({ planningDir, beforePhase: 13 });
assert.equal(r.commands.length, 1);
assert.equal(r.commands[0].command, 'npm test');
assert.equal(r.commands[0].phase, '12A');
});
test('#2401 — project-code-prefixed phase dir (CK-01-name)', () => {
const { planningDir } = planningWithPhases('naming-project-code', {
'CK-01-name': { '01-PLAN.md': planWith(['npm --prefix ./web run lint']) },
'CK-02-next': { '01-PLAN.md': '# Plan\n' },
});
const r = harvestPriorVerifyCommands({ planningDir, beforePhase: 2 });
assert.equal(r.commands.length, 1);
assert.equal(r.commands[0].command, 'npm --prefix ./web run lint');
});
test('#2401 — non-phase directories (notes, archive) are ignored, not thrown on', () => {
const { planningDir } = planningWithPhases('naming-non-phase-dirs', {
'01-alpha': { '01-PLAN.md': planWith(['npm test']) },
notes: { 'README.md': '# not a plan\n' },
archive: { 'old-PLAN.md': planWith(['npm run stale']) },
});
const r = harvestPriorVerifyCommands({ planningDir, beforePhase: 2 });
assert.equal(r.commands.length, 1);
assert.equal(r.commands[0].command, 'npm test');
});
});
describe('check verify-command-paths verb', () => {
/** Fixture matching the real `.planning/phases/<dir>/` layout findPhaseInternal resolves against. */
function writeCliPhase(root, dirName, planBody) {
const phaseDir = path.join(root, '.planning', 'phases', dirName);
fs.mkdirSync(phaseDir, { recursive: true });
fs.writeFileSync(path.join(phaseDir, '01-PLAN.md'), planBody, 'utf8');
return phaseDir;
}
test('row 44 — check verb emits documented json', () => {
const root = fixtureRoot('row44');
writeCliPhase(root, '01-test-phase', planWith(['npm test']));
const result = runGsdTools(['check', 'verify-command-paths', '1', '--raw'], root);
assert.ok(result.success, `check verify-command-paths should succeed. stderr: ${result.error}`);
const payload = JSON.parse(result.output);
assert.equal(typeof payload.status, 'string');
assert.ok(Array.isArray(payload.commands));
assert.equal(typeof payload.counts, 'object');
assert.equal(typeof payload.counts.blocker, 'number');
assert.equal(typeof payload.counts.warning, 'number');
assert.equal(typeof payload.counts.total, 'number');
assert.ok('readError' in payload);
});
test('row 45 — check verb degrades on unknown phase', () => {
const root = fixtureRoot('row45');
fs.mkdirSync(path.join(root, '.planning', 'phases'), { recursive: true });
// Capture the result rather than asserting on exit code: an unknown phase
// is a degraded-but-valid JSON payload, not necessarily a clean exit.
const result = runGsdTools(['check', 'verify-command-paths', '999', '--raw'], root);
const payload = JSON.parse(result.output);
assert.deepEqual(payload.commands, []);
assert.equal(typeof payload.readError, 'string');
assert.ok(payload.readError.length > 0);
});
});
describe('property-based invariants', () => {
const KNOWN_STATUSES_PROP = new Set([
'ok',
'broken',
'unresolvable',
'not_applicable',
'pending_creation',
]);
const KNOWN_SEVERITIES = new Set(['blocker', 'warning', 'none']);
// Safe alphabet for synthesized <automated> command bodies: excludes '<', '>'
// and '&' so the generated body cannot forge XML markup inside the rendered
// plan text, and is non-empty after trimming.
const commandArb = fc
.stringMatching(/^[A-Za-z0-9_./ :=-]+$/)
.filter(s => s.trim().length > 0);
describe('#2401 resolveVerifyCommandTarget — grounding properties', () => {
test('(a) never throws; always returns a known status/severity/base shape', () => {
fc.assert(fc.property(fc.string(), (s) => {
let result;
assert.doesNotThrow(() => {
result = resolveVerifyCommandTarget(s, { projectRoot: os.tmpdir() });
});
assert.ok(result && typeof result === 'object', 'must return an object');
assert.ok(KNOWN_STATUSES_PROP.has(result.status), `unknown status ${result.status}`);
assert.ok(KNOWN_SEVERITIES.has(result.severity), `unknown severity ${result.severity}`);
assert.strictEqual(typeof result.base, 'string');
}));
});
test('(a) never throws for full-unicode input; always returns a known status/severity/base shape', () => {
fc.assert(fc.property(fc.string({ unit: 'binary' }), (s) => {
let result;
assert.doesNotThrow(() => {
result = resolveVerifyCommandTarget(s, { projectRoot: os.tmpdir() });
});
assert.ok(result && typeof result === 'object', 'must return an object');
assert.ok(KNOWN_STATUSES_PROP.has(result.status), `unknown status ${result.status}`);
assert.ok(KNOWN_SEVERITIES.has(result.severity), `unknown severity ${result.severity}`);
assert.strictEqual(typeof result.base, 'string');
}));
});
test('(b) a blocker severity is only ever reported for a grounded form', () => {
fc.assert(fc.property(fc.string(), (s) => {
const result = resolveVerifyCommandTarget(s, { projectRoot: os.tmpdir() });
if (result.severity === 'blocker') {
assert.ok(result.form !== null && result.form !== undefined,
`blocker for ${JSON.stringify(s)} must have a non-null form`);
assert.strictEqual(typeof result.target, 'string',
`blocker for ${JSON.stringify(s)} must have a string target`);
assert.ok(result.target.length > 0,
`blocker for ${JSON.stringify(s)} must have a non-empty target`);
}
}));
});
test('(b) a blocker severity is only ever reported for a grounded form (full-unicode)', () => {
fc.assert(fc.property(fc.string({ unit: 'binary' }), (s) => {
const result = resolveVerifyCommandTarget(s, { projectRoot: os.tmpdir() });
if (result.severity === 'blocker') {
assert.ok(result.form !== null && result.form !== undefined,
`blocker for ${JSON.stringify(s)} must have a non-null form`);
assert.strictEqual(typeof result.target, 'string',
`blocker for ${JSON.stringify(s)} must have a string target`);
assert.ok(result.target.length > 0,
`blocker for ${JSON.stringify(s)} must have a non-empty target`);
}
}));
});
});
describe('#2401 extractAutomatedCommands — recovery properties', () => {
test('(c) recovers every generated command, in order, from synthesized plan text', () => {
fc.assert(fc.property(fc.array(commandArb, { minLength: 0, maxLength: 8 }), (commands) => {
const planText = commands
.map((cmd, i) => `<task type="auto"><name>t${i}</name><verify><automated>${cmd}</automated></verify></task>`)
.join('\n');
const extracted = extractAutomatedCommands(planText);
assert.deepStrictEqual(
extracted.map(c => c.command),
commands.map(c => c.trim()),
);
extracted.forEach((row, i) => {
assert.strictEqual(row.task, `t${i}`);
});
}));
});
test('(d) CRLF invariance: \\r\\n-joined plan text yields an identical command list', () => {
fc.assert(fc.property(fc.array(commandArb, { minLength: 0, maxLength: 8 }), (commands) => {
const lfPlanText = commands
.map((cmd, i) => `<task type="auto"><name>t${i}</name><verify><automated>${cmd}</automated></verify></task>`)
.join('\n');
const crlfPlanText = commands
.map((cmd, i) => `<task type="auto"><name>t${i}</name><verify><automated>${cmd}</automated></verify></task>`)
.join('\r\n');
const lfExtracted = extractAutomatedCommands(lfPlanText);
const crlfExtracted = extractAutomatedCommands(crlfPlanText);
assert.deepStrictEqual(crlfExtracted, lfExtracted);
}));
});
test('(e) never throws on arbitrary string input', () => {
fc.assert(fc.property(fc.string(), (s) => {
let result;
assert.doesNotThrow(() => {
result = extractAutomatedCommands(s);
});
assert.ok(Array.isArray(result), 'must return an array');
}));
});
test('(e) never throws on non-string input and returns [] for each', () => {
const nonStrings = [0, [], null, undefined, true, {}];
for (const v of nonStrings) {
let result;
assert.doesNotThrow(() => {
result = extractAutomatedCommands(v);
}, `must not throw for ${JSON.stringify(v)}`);
assert.deepStrictEqual(result, [], `must return [] for ${JSON.stringify(v)}`);
}
});
});
});