fix(#2163): review fixes — changeset format, explicit maxBuffer, hoisted require
- changeset reformatted to the bold-lead + (#2163) house convention - explicit 8 MiB maxBuffer on the git spawn (default 1 MiB could overflow on huge dirty repos; overflow still degrades to segment-absent) - child_process require hoisted to module level per file style Claude-Session: https://claude.ai/code/session_01Hme55Pvq6BhpgwBcyC5HAg
This commit is contained in:
@@ -6,6 +6,7 @@
|
||||
const fs = require('fs');
|
||||
const path = require('path');
|
||||
const os = require('os');
|
||||
const { execFileSync } = require('child_process');
|
||||
const { isSemverNewer } = require('../gsd-core/bin/lib/semver-compare.cjs');
|
||||
const { PACKAGE_NAME, updateCacheFileName } = require('../gsd-core/bin/lib/package-identity.cjs');
|
||||
|
||||
@@ -335,9 +336,11 @@ const GIT_STATUS_TIMEOUT_MS = 1500;
|
||||
*/
|
||||
function readGitStatus(dir) {
|
||||
try {
|
||||
const { execFileSync } = require('child_process');
|
||||
// 8 MiB maxBuffer (default 1 MiB) headroom for repos with very many changed
|
||||
// or untracked files; overflow still degrades safely to segment-absent via
|
||||
// the catch below.
|
||||
return execFileSync('git', ['-C', dir, 'status', '--porcelain=v2', '--branch'],
|
||||
{ encoding: 'utf8', timeout: GIT_STATUS_TIMEOUT_MS, stdio: ['ignore', 'pipe', 'ignore'] });
|
||||
{ encoding: 'utf8', timeout: GIT_STATUS_TIMEOUT_MS, maxBuffer: 8 * 1024 * 1024, stdio: ['ignore', 'pipe', 'ignore'] });
|
||||
} catch (e) {
|
||||
return null;
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user