golem15/msd-core
4
0
Fork 0
Code Issues 1 Pull Requests Actions 2 Packages Projects Releases Wiki Activity

fix(#1863): use named flags for state.* calls in executor + workflows (#1873)

Browse Source 
* fix(#1863): use named flags for state.* calls in executor + workflows

The named-only state-command router (parseNamedArgs) silently drops
positional args, so state.cjs threw its required-arg error and
metrics/decisions/blockers/session continuity were never recorded.

Convert record-metric / add-decision / add-blocker / record-session in
agents/gsd-executor.md to the named-flag form (mirroring execute-plan.md),
and fix the two remaining positional record-session calls in
gsd-core/workflows/milestone-summary.md and forensics.md. Recapture the
golden-install-parity fixtures and size baselines for the edited files.

Also fix a pre-existing detached-rebuild handle leak in
tests/graphify-auto-update.slow.test.cjs: three dispatch tests returned
after observing only the synchronous "running" status without awaiting the
detached rebuild's terminal state. That leak was latent until the new
#1863 regression block's added runtime shifted --test-force-exit timing
and surfaced it as a non-zero chunk exit. The three tests now await
terminal status via the file's existing waitForBuildStatus helper.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* chore(#1863): add changeset

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-authored-by: Tom Boucher <trekkie@nomorestars.com>
This commit is contained in:
Behruz Nassre Esfahani
2026-07-02 10:01:10 -07:00
committed by GitHub
parent 8751379cfc
commit 7bef6a6496
24 changed files with 154 additions and 68 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
tests/graphify-auto-update.slow.test.cjs
View File

@@ -415,7 +415,7 @@ describe('auto-update', () => {
describe('hook — dispatch path (all gates pass)',
{ skip: isWindows ? 'POSIX-only: harness spawns bash + kill -0 + sleep; the hook itself is a bash script under test' : false },
() => {
test('writes status file with status=running synchronously before returning', (t) => {
test('writes status file with status=running synchronously before returning', async (t) => {
const tmpDir = createTempGitRepo({
config: { graphify: { enabled: true, auto_update: true } },
});
@@ -435,6 +435,12 @@ describe('auto-update', () => {
const status = JSON.parse(fs.readFileSync(statusPath, 'utf8'));
assert.strictEqual(status.status, 'running', 'initial status must be "running"');
assert.ok(/^[0-9a-f]{7,40}$/.test(status.head_at_build), 'head_at_build must be a commit sha');
// Await the detached rebuild's terminal status so the subprocess has exited
// before the test returns. A dangling detached rebuild can outlive the chunk
// under `node --test --test-force-exit` and surface as a non-zero chunk exit.
const done = await waitForBuildStatus(statusPath, new Set(['ok', 'failed']));
assert.ok(done && (done.status === 'ok' || done.status === 'failed'),
'detached rebuild must reach a terminal status before the test returns');
});
test('completes to status=ok after detached graphify run succeeds', async (t) => {
@@ -509,7 +515,7 @@ describe('auto-update', () => {
);
});
test('stale lock file (dead PID) is treated as absent', (t) => {
test('stale lock file (dead PID) is treated as absent', async (t) => {
const tmpDir = createTempGitRepo({
config: { graphify: { enabled: true, auto_update: true } },
});
@@ -528,9 +534,13 @@ describe('auto-update', () => {
assert.strictEqual(r.status, 0);
const statusPath = path.join(tmpDir, '.planning/graphs/.last-build-status.json');
assert.ok(fs.existsSync(statusPath), 'stale lock must not block dispatch');
// Await terminal status so the detached rebuild is gone before returning (see above).
const done = await waitForBuildStatus(statusPath, new Set(['ok', 'failed']));
assert.ok(done && (done.status === 'ok' || done.status === 'failed'),
'detached rebuild must reach a terminal status before the test returns');
});
test('respects git.base_branch config override (default branch != main)', (t) => {
test('respects git.base_branch config override (default branch != main)', async (t) => {
const tmpDir = createTempGitRepo({
defaultBranch: 'trunk',
config: {
@@ -546,10 +556,15 @@ describe('auto-update', () => {
{ pathPrepend: mockBin },
);
assert.strictEqual(r.status, 0);
const statusPath = path.join(tmpDir, '.planning/graphs/.last-build-status.json');
assert.ok(
fs.existsSync(path.join(tmpDir, '.planning/graphs/.last-build-status.json')),
fs.existsSync(statusPath),
'hook must honor git.base_branch when default branch is not main',
);
// Await terminal status so the detached rebuild is gone before returning (see above).
const done = await waitForBuildStatus(statusPath, new Set(['ok', 'failed']));
assert.ok(done && (done.status === 'ok' || done.status === 'failed'),
'detached rebuild must reach a terminal status before the test returns');
});
});