fix(#1863): use named flags for state.* calls in executor + workflows (#1873)

* fix(#1863): use named flags for state.* calls in executor + workflows

The named-only state-command router (parseNamedArgs) silently drops
positional args, so state.cjs threw its required-arg error and
metrics/decisions/blockers/session continuity were never recorded.

Convert record-metric / add-decision / add-blocker / record-session in
agents/gsd-executor.md to the named-flag form (mirroring execute-plan.md),
and fix the two remaining positional record-session calls in
gsd-core/workflows/milestone-summary.md and forensics.md. Recapture the
golden-install-parity fixtures and size baselines for the edited files.

Also fix a pre-existing detached-rebuild handle leak in
tests/graphify-auto-update.slow.test.cjs: three dispatch tests returned
after observing only the synchronous "running" status without awaiting the
detached rebuild's terminal state. That leak was latent until the new
#1863 regression block's added runtime shifted --test-force-exit timing
and surfaced it as a non-zero chunk exit. The three tests now await
terminal status via the file's existing waitForBuildStatus helper.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* chore(#1863): add changeset

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-authored-by: Tom Boucher <trekkie@nomorestars.com>
This commit is contained in:
Behruz Nassre Esfahani
2026-07-02 10:01:10 -07:00
committed by GitHub
parent 8751379cfc
commit 7bef6a6496
24 changed files with 154 additions and 68 deletions

View File

@@ -29,7 +29,7 @@
"explore.md": 10497,
"extract-learnings.md": 12849,
"fast.md": 4149,
"forensics.md": 12463,
"forensics.md": 12487,
"graduation.md": 11578,
"health.md": 11824,
"help.md": 1722,
@@ -42,7 +42,7 @@
"list-workspaces.md": 5655,
"manager.md": 27258,
"map-codebase.md": 20789,
"milestone-summary.md": 11774,
"milestone-summary.md": 11798,
"mvp-phase.md": 13582,
"new-milestone.md": 32844,
"new-project.md": 66138,