test(#3090): stop exempting violations under categories that do not fit
An allow-test-rule annotation citing a category that does not apply is worse than no annotation, because it reads as reviewed. Eight were confirmed by reading the assertions each one covered, and auditing the rest found five more plus one refutation — a converter test whose wording described the wrong mechanism while the covered assertion genuinely was deployed-text. The instructive one used the CANONICAL string for the same mistake: STATE.md command output labelled as a deployed artifact. A canonical string is not evidence the category fits, which is why normalising strings alone would have laundered the problem rather than fixed it. Every mapping the audit had inferred rather than code-verified was spot-checked before rewriting, and the ones that turned out not to fit were re-annotated rather than relabelled. Fourteen STATE.md assertions had a typed extractor available all along and now use it; their annotations came out because nothing needs exempting. Eight assertions genuinely need a production change first — CLI stdout and stderr with no structured mode — and are tagged pending-migration-to-typed-ir citing #3090, which is what that category is for. It had zero real uses before this, while one file carried a real citation to migration issue #2974 under a non-canonical tag. Six annotations covered assertions that do no text matching at all. An exemption for a violation that does not exist is noise that makes the real ones harder to audit; those are removed. atomic-write-coverage gains the annotation it always warranted — its own docstring describes a structural-regression-guard while the file carried none. Fifty-nine non-canonical strings across roughly thirty files are normalised, and the allow-test-rule allowlist is regenerated to match. 472 annotations became 463: every one now uses a canonical category, and the two remaining non-canonical strings are ESLint RuleTester fixtures, not annotations. Refs #3057 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
@@ -1,5 +1,12 @@
|
||||
'use strict';
|
||||
// allow-test-rule: line 159 reads the STATE.md temp file written by readModifyWriteStateMd — this is a runtime output file assertion, not a source-grep; the API returns void so a file read-back is the only way to verify the transform was applied
|
||||
// allow-test-rule: pending-migration-to-typed-ir [#3090]
|
||||
// This file's assert.throws(fn, /regex/) sites (acquireStateLock /
|
||||
// readModifyWriteStateMd / withPlanningLock / acquireInstallMigrationLock
|
||||
// timeout and error-propagation checks) regex-match the human-readable
|
||||
// thrown Error#message — CONTRIBUTING's "Error / status / reason" BAD
|
||||
// pattern; the fix is a frozen-enum REASON code on the thrown error, which
|
||||
// requires a production change to those locking functions that is out of
|
||||
// scope for this test-only change. Tracked for correction under #3090.
|
||||
|
||||
/**
|
||||
* Deterministic clock-seam tests for acquireStateLock / withPlanningLock (issue #453).
|
||||
@@ -40,6 +47,7 @@ const stateMod = require('../gsd-core/bin/lib/state.cjs');
|
||||
const { acquireStateLock, releaseStateLock, readModifyWriteStateMd } = stateMod;
|
||||
const { withPlanningLock } = require('../gsd-core/bin/lib/planning-workspace.cjs');
|
||||
const { createTempProject, cleanup, runGsdTools } = require('./helpers.cjs');
|
||||
const { stateExtractField } = require('../gsd-core/bin/lib/state-document.cjs');
|
||||
|
||||
// ─────────────────────────────────────────────────────────────────────────────
|
||||
// 1. Fake-clock proof: acquireStateLock accepts and uses the clock seam
|
||||
@@ -822,7 +830,7 @@ describe('readModifyWriteStateMd lock cleanup on error', () => {
|
||||
const clock = makeFakeClock(0);
|
||||
readModifyWriteStateMd(statePath, (c) => c + '\n**Patched:** yes\n', tmpDir, undefined, clock);
|
||||
const content = fs.readFileSync(statePath, 'utf-8');
|
||||
assert.ok(content.includes('**Patched:** yes'), 'transform must be applied');
|
||||
assert.strictEqual(stateExtractField(content, 'Patched'), 'yes', 'transform must be applied');
|
||||
assert.strictEqual(clock.sleepCalls.length, 0, 'no sleep when lock is immediately available');
|
||||
});
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user