test(#3090): stop exempting violations under categories that do not fit
An allow-test-rule annotation citing a category that does not apply is worse than no annotation, because it reads as reviewed. Eight were confirmed by reading the assertions each one covered, and auditing the rest found five more plus one refutation — a converter test whose wording described the wrong mechanism while the covered assertion genuinely was deployed-text. The instructive one used the CANONICAL string for the same mistake: STATE.md command output labelled as a deployed artifact. A canonical string is not evidence the category fits, which is why normalising strings alone would have laundered the problem rather than fixed it. Every mapping the audit had inferred rather than code-verified was spot-checked before rewriting, and the ones that turned out not to fit were re-annotated rather than relabelled. Fourteen STATE.md assertions had a typed extractor available all along and now use it; their annotations came out because nothing needs exempting. Eight assertions genuinely need a production change first — CLI stdout and stderr with no structured mode — and are tagged pending-migration-to-typed-ir citing #3090, which is what that category is for. It had zero real uses before this, while one file carried a real citation to migration issue #2974 under a non-canonical tag. Six annotations covered assertions that do no text matching at all. An exemption for a violation that does not exist is noise that makes the real ones harder to audit; those are removed. atomic-write-coverage gains the annotation it always warranted — its own docstring describes a structural-regression-guard while the file carried none. Fifty-nine non-canonical strings across roughly thirty files are normalised, and the allow-test-rule allowlist is regenerated to match. 472 annotations became 463: every one now uses a canonical category, and the two remaining non-canonical strings are ESLint RuleTester fixtures, not annotations. Refs #3057 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
@@ -56,8 +56,10 @@ function listWorkflowFiles() {
|
||||
.map((e) => path.join(WORKFLOWS_DIR, e));
|
||||
|
||||
// Filter to files that have at least one Windows hosted-runner reference.
|
||||
// allow-test-rule: file-scope prefilter, not a test assertion — we need to
|
||||
// detect whether a workflow file targets Windows runners at all. The pwsh
|
||||
// allow-test-rule: source-text-is-the-product
|
||||
// Reads the shipped .github/workflows/*.yml — the deployed text GitHub
|
||||
// Actions executes — to detect whether a workflow targets Windows runners
|
||||
// at all. The pwsh
|
||||
// stderr-swallow class is windows-only, so files that never mention
|
||||
// windows-hosted labels are out of scope. Exposing a typed IR from production
|
||||
// code is not appropriate here because the source-of-truth is the YAML
|
||||
|
||||
Reference in New Issue
Block a user