fix(sdk): gate reasoning effort by runtime allowlist

This commit is contained in:
radioflyer28
2026-05-13 22:27:15 -04:00
parent c20f714d68
commit 810778e137
7 changed files with 80 additions and 6 deletions

View File

@@ -1132,6 +1132,42 @@ describe('resolve-model command', () => {
assert.strictEqual(output.reasoning_effort, 'xhigh');
});
test('does not include reasoning_effort for unsupported runtime overrides', () => {
fs.writeFileSync(path.join(tmpDir, '.planning', 'config.json'), JSON.stringify({
model_profile: 'balanced',
runtime: 'opencode',
models: { planning: 'opus' },
model_profile_overrides: {
opencode: {
opus: { model: 'openrouter/openai/gpt-5.5', reasoning_effort: 'high' },
},
},
}));
const result = runGsdTools('resolve-model gsd-planner', tmpDir);
assert.ok(result.success, `Command failed: ${result.error}`);
const output = JSON.parse(result.output);
assert.strictEqual(output.model, 'openrouter/openai/gpt-5.5');
assert.strictEqual(output.profile, 'balanced');
assert.ok(!Object.prototype.hasOwnProperty.call(output, 'reasoning_effort'));
});
test('does not include reasoning_effort for per-agent model_overrides', () => {
fs.writeFileSync(path.join(tmpDir, '.planning', 'config.json'), JSON.stringify({
model_profile: 'balanced',
runtime: 'codex',
models: { planning: 'opus' },
model_overrides: { 'gsd-planner': 'gpt-5.5' },
}));
const result = runGsdTools('resolve-model gsd-planner', tmpDir);
assert.ok(result.success, `Command failed: ${result.error}`);
const output = JSON.parse(result.output);
assert.strictEqual(output.model, 'gpt-5.5');
assert.strictEqual(output.profile, 'balanced');
assert.ok(!Object.prototype.hasOwnProperty.call(output, 'reasoning_effort'));
});
test('fails when no agent-type provided', () => {
const result = runGsdTools('resolve-model', tmpDir);
assert.ok(!result.success, 'should fail without agent-type');