From 811410be6182479d9cf72f6b730f6a1019ebaf63 Mon Sep 17 00:00:00 2001 From: Tom Boucher Date: Tue, 5 May 2026 11:22:37 -0400 Subject: [PATCH] fix: address all 13 CodeRabbit comments from second review pass MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Duplicate /gsd-help rows (caused by join-discord → help replacement landing in tables that already had /gsd-help): - Remove Discord-purpose duplicate row from README.md, README.ja-JP.md, README.zh-CN.md, README.ko-KR.md, docs/zh-CN/README.md, docs/zh-CN/USER-GUIDE.md, docs/ja-JP/USER-GUIDE.md, docs/ko-KR/USER-GUIDE.md - Remove orphaned Discord-only ### /gsd-help sections from docs/ja-JP/COMMANDS.md and docs/ko-KR/COMMANDS.md Gap-fix command precision (plan-milestone-gaps → audit-milestone --fix): - README.ja-JP.md, README.ko-KR.md, README.zh-CN.md gap-fix rows updated to /gsd-audit-milestone --fix docs/COMMANDS.md: document --path for --from-gsd2 in table and example block docs/FEATURES.md: - Add adaptive to /gsd-config --profile value set - Add blank line before spike Produces table (MD058) Suite: 6971/6971 pass --- README.ja-JP.md | 3 +-- README.ko-KR.md | 3 +-- README.md | 1 - README.zh-CN.md | 3 +-- docs/COMMANDS.md | 6 ++++-- docs/FEATURES.md | 3 ++- docs/ja-JP/COMMANDS.md | 7 ------- docs/ja-JP/USER-GUIDE.md | 1 - docs/ko-KR/COMMANDS.md | 7 ------- docs/ko-KR/USER-GUIDE.md | 1 - docs/zh-CN/README.md | 1 - docs/zh-CN/USER-GUIDE.md | 1 - 12 files changed, 9 insertions(+), 28 deletions(-) diff --git a/README.ja-JP.md b/README.ja-JP.md index afc520b0e..7f472cb87 100644 --- a/README.ja-JP.md +++ b/README.ja-JP.md @@ -584,7 +584,6 @@ lmn012o feat(08-02): create registration endpoint | `/gsd-progress --next` | 状態を自動検出し次のステップを実行 | | `/gsd-help` | 全コマンドと使い方ガイドを表示 | | `/gsd-update` | チェンジログプレビュー付きでGSDをアップデート | -| `/gsd-help` | GSD Discordコミュニティに参加 | | `/gsd-manager` | 複数フェーズ管理用のインタラクティブコマンドセンター | ### ブラウンフィールド @@ -602,7 +601,7 @@ lmn012o feat(08-02): create registration endpoint | `/gsd-phase --edit [N] [--force]` | 既存フェーズの任意フィールドをその場で編集 — 番号と位置は変更されない | | `/gsd-phase --remove [N]` | 将来のフェーズを削除し番号を振り直し | | `/gsd-discuss-phase --assumptions [N]` | 計画前にClaudeの意図するアプローチを確認 | -| `/gsd-audit-milestone` | 監査で見つかったギャップを埋めるフェーズを作成 | +| `/gsd-audit-milestone --fix` | 監査で見つかったギャップを埋めるフェーズを作成 | ### セッション diff --git a/README.ko-KR.md b/README.ko-KR.md index e97758d75..22274248d 100644 --- a/README.ko-KR.md +++ b/README.ko-KR.md @@ -581,7 +581,6 @@ lmn012o feat(08-02): create registration endpoint | `/gsd-progress --next` | 상태 자동 감지 및 다음 단계 실행 | | `/gsd-help` | 모든 명령어와 사용 가이드 표시 | | `/gsd-update` | 변경 로그 미리보기와 함께 GSD 업데이트 | -| `/gsd-help` | GSD Discord 커뮤니티 참여 | | `/gsd-manager` | 여러 단계 관리를 위한 대화형 커맨드 센터 | ### 브라운필드 @@ -599,7 +598,7 @@ lmn012o feat(08-02): create registration endpoint | `/gsd-phase --edit [N] [--force]` | 기존 단계의 임의 필드를 그 자리에서 수정 — 번호와 위치는 그대로 | | `/gsd-phase --remove [N]` | 미래 단계 제거, 번호 재정렬 | | `/gsd-discuss-phase --assumptions [N]` | 기획 전 Claude의 의도된 접근 방식 확인 | -| `/gsd-audit-milestone` | 감사에서 발견된 갭을 해소하기 위한 단계 생성 | +| `/gsd-audit-milestone --fix` | 감사에서 발견된 갭을 해소하기 위한 단계 생성 | ### 세션 diff --git a/README.md b/README.md index 161a0b5b7..e7b31a01c 100644 --- a/README.md +++ b/README.md @@ -679,7 +679,6 @@ You're never locked in. The system adapts. | `/gsd-progress --next` | Auto-detect state and run the next step | | `/gsd-help` | Show all commands and usage guide | | `/gsd-update` | Update GSD with changelog preview | -| `/gsd-help` | Join the GSD Discord community | | `/gsd-manager` | Interactive command center for managing multiple phases | ### Brownfield diff --git a/README.zh-CN.md b/README.zh-CN.md index 1915032c6..d0ea5d35b 100644 --- a/README.zh-CN.md +++ b/README.zh-CN.md @@ -577,7 +577,6 @@ lmn012o feat(08-02): create registration endpoint | `/gsd-progress --next` | 自动检测状态并执行下一步 | | `/gsd-help` | 显示全部命令和使用指南 | | `/gsd-update` | 更新 GSD，并预览变更日志 | -| `/gsd-help` | 加入 GSD Discord 社区 | ### Brownfield @@ -594,7 +593,7 @@ lmn012o feat(08-02): create registration endpoint | `/gsd-phase --edit [N] [--force]` | 就地修改已有 phase 的任意字段 — 编号与位置保持不变 | | `/gsd-phase --remove [N]` | 删除未来 phase，并重编号 | | `/gsd-discuss-phase --assumptions [N]` | 在规划前查看 Claude 打算采用的方案 | -| `/gsd-audit-milestone` | 为 audit 发现的缺口创建 phase | +| `/gsd-audit-milestone --fix` | 为 audit 发现的缺口创建 phase | ### 代码质量 diff --git a/docs/COMMANDS.md b/docs/COMMANDS.md index a6ea9a9fd..81918bafd 100644 --- a/docs/COMMANDS.md +++ b/docs/COMMANDS.md @@ -581,12 +581,14 @@ Ingest an external plan file into the GSD planning system with conflict detectio |------|----------|--------------| | `--from ` | Yes (or `--from-gsd2`) | Path to the external plan file to import | | `--from-gsd2` | Yes (or `--from`) | Reverse-migrate a GSD-2 (`.gsd/`) project back to GSD v1 (`.planning/`) format | +| `--path ` | No | With `--from-gsd2`: path to the GSD-2 project directory (defaults to current directory) | **Process:** Detects conflicts → prompts for resolution → writes as GSD PLAN.md → validates via `gsd-plan-checker` ```bash -/gsd-import --from /tmp/team-plan.md # Import and validate an external plan -/gsd-import --from-gsd2 # Migrate from GSD-2 back to v1 +/gsd-import --from /tmp/team-plan.md # Import and validate an external plan +/gsd-import --from-gsd2 # Migrate from GSD-2 back to v1 (current dir) +/gsd-import --from-gsd2 --path ~/old-project # Migrate from a different path ``` --- diff --git a/docs/FEATURES.md b/docs/FEATURES.md index 2947f399e..1bd961578 100644 --- a/docs/FEATURES.md +++ b/docs/FEATURES.md @@ -748,7 +748,7 @@ ### 26. Model Profiles -**Command:** `/gsd-config --profile ` +**Command:** `/gsd-config --profile ` **Purpose:** Control which AI model each agent uses, balancing quality vs cost. @@ -2542,6 +2542,7 @@ Users who run a memory / knowledge-base MCP server (for example, ExoCortex-style - REQ-SPIKE-06: `/gsd-spike --wrap-up` MUST package findings into `.claude/skills/spike-findings-[project]/` **Produces:** + | Artifact | Description | |----------|-------------| | `.planning/spikes/NNN-name/README.md` | Hypothesis, experiment code, verdict, and evidence | diff --git a/docs/ja-JP/COMMANDS.md b/docs/ja-JP/COMMANDS.md index 6b4bba568..1f86a5f11 100644 --- a/docs/ja-JP/COMMANDS.md +++ b/docs/ja-JP/COMMANDS.md @@ -948,10 +948,3 @@ GSDアップデート後にローカルの変更を復元します。 ## コミュニティコマンド -### `/gsd-help` - -Discordコミュニティの招待を開きます。 - -```bash -/gsd-help -``` diff --git a/docs/ja-JP/USER-GUIDE.md b/docs/ja-JP/USER-GUIDE.md index 88ecfd57a..c6ef424b5 100644 --- a/docs/ja-JP/USER-GUIDE.md +++ b/docs/ja-JP/USER-GUIDE.md @@ -407,7 +407,6 @@ GSD はマークダウンファイルを生成し、それが LLM のシステ | `/gsd-pause-work --report` | 作業内容と成果を含むセッションサマリーを生成 | セッション終了時、ステークホルダーへの共有時 | | `/gsd-help` | すべてのコマンドを表示 | クイックリファレンス | | `/gsd-update` | 変更履歴プレビュー付きで GSD を更新 | 新バージョンの確認時 | -| `/gsd-help` | Discord コミュニティの招待リンクを開く | 質問やコミュニティ参加時 | ### フェーズ管理 diff --git a/docs/ko-KR/COMMANDS.md b/docs/ko-KR/COMMANDS.md index 9a5cb94c6..4cc323176 100644 --- a/docs/ko-KR/COMMANDS.md +++ b/docs/ko-KR/COMMANDS.md @@ -948,10 +948,3 @@ GSD 업데이트 후 로컬 수정사항을 복원합니다. ## 커뮤니티 명령어 -### `/gsd-help` - -Discord 커뮤니티 초대 링크를 엽니다. - -```bash -/gsd-help -``` diff --git a/docs/ko-KR/USER-GUIDE.md b/docs/ko-KR/USER-GUIDE.md index 796fe6898..2c76bd4d9 100644 --- a/docs/ko-KR/USER-GUIDE.md +++ b/docs/ko-KR/USER-GUIDE.md @@ -407,7 +407,6 @@ GSD는 LLM 시스템 프롬프트가 되는 마크다운 파일을 생성합니 | `/gsd-pause-work --report` | 작업 및 결과가 포함된 세션 요약 생성 | 세션 종료 시, 이해관계자 공유 시 | | `/gsd-help` | 모든 명령어 표시 | 빠른 레퍼런스 | | `/gsd-update` | 변경 로그 미리보기와 함께 GSD 업데이트 | 새 버전 확인 시 | -| `/gsd-help` | Discord 커뮤니티 초대 링크 열기 | 질문이나 커뮤니티 참여 시 | ### 페이즈 관리 diff --git a/docs/zh-CN/README.md b/docs/zh-CN/README.md index d82ea1281..41e2a01cd 100644 --- a/docs/zh-CN/README.md +++ b/docs/zh-CN/README.md @@ -499,7 +499,6 @@ lmn012o feat(08-02): 创建注册端点 | `/gsd-progress` | 我在哪？接下来做什么？ | | `/gsd-help` | 显示所有命令和使用指南 | | `/gsd-update` | 更新 GSD 并预览变更日志 | -| `/gsd-help` | 加入 GSD Discord 社区 | ### 现有代码库 diff --git a/docs/zh-CN/USER-GUIDE.md b/docs/zh-CN/USER-GUIDE.md index 5c38792f1..e3bba7ca1 100644 --- a/docs/zh-CN/USER-GUIDE.md +++ b/docs/zh-CN/USER-GUIDE.md @@ -199,7 +199,6 @@ | `/gsd-pause-work` | 保存上下文交接 | 阶段中途停止 | | `/gsd-help` | 显示所有命令 | 快速参考 | | `/gsd-update` | 更新 GSD 并预览变更日志 | 检查新版本 | -| `/gsd-help` | 打开 Discord 社区邀请 | 问题或社区 | ### 阶段管理