golem15/msd-core
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(#2352): expand tilde paths in review scope before the deleted-file filter (#2419)

Browse Source 
* fix(#2352): tilde-expand SUMMARY.md key-files paths before deleted-file filter

compute_file_scope's "Filter deleted files" step tested the literal `~/...`
value from SUMMARY.md key-files entries with `[ -f "$file" ]`, which bash
never tilde-expands (only a literal `~` in source text expands, not one
arriving as an already-expanded variable value). Real files recorded with a
`~/...` path were silently misclassified as deleted and dropped from
REVIEW_FILES, and a phase whose every recorded file used a tilde path hit the
empty-scope skip as a false negative.

Adds a tilde-normalization loop as step 1 of post-processing (all tiers),
before the deleted-file filter, rewriting a leading `~/` to `${HOME}/...` so
downstream existence checks, the empty-scope short-circuit, and the
FILES_TO_READ/CONFIG_FILES construction all see a real, openable path.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* chore(#2352): regenerate fixtures + lint gate-prep

* chore(#2352): add Fixed changeset fragment (pr 2419)

---------

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
Tom Boucher
2026-07-18 21:29:58 -04:00
committed by GitHub
parent dd5a2211c9
commit 873bdf51e5
22 changed files with 223 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tests/fixtures/golden-install-parity/antigravity.json vendored
View File

@@ -217,7 +217,7 @@
"gsd-core/workflows/check-todos.md": "5a62092df800ad7c",
"gsd-core/workflows/cleanup.md": "12c8fd85d3010fe6",
"gsd-core/workflows/code-review-fix.md": "60640e633b0a124b",
"gsd-core/workflows/code-review.md": "5c40505c01871153",
"gsd-core/workflows/code-review.md": "2d9943e121908327",
"gsd-core/workflows/complete-milestone.md": "aaf272074acec69d",
"gsd-core/workflows/debug.md": "0b802b267d0ca2d1",
"gsd-core/workflows/diagnose-issues.md": "c8c41993c277363c",

2
tests/fixtures/golden-install-parity/augment.json vendored
View File

@@ -288,7 +288,7 @@
"gsd-core/workflows/check-todos.md": "bdeaf43f9c61e0cc",
"gsd-core/workflows/cleanup.md": "0daa2f2720c111f1",
"gsd-core/workflows/code-review-fix.md": "2e113d1f4350a075",
"gsd-core/workflows/code-review.md": "334c90c401f291f8",
"gsd-core/workflows/code-review.md": "2aa1957579f50a87",
"gsd-core/workflows/complete-milestone.md": "c1f91b77f4ace7f2",
"gsd-core/workflows/debug.md": "98c8ed5af882ef8f",
"gsd-core/workflows/diagnose-issues.md": "6cc3900891dfb927",

2
tests/fixtures/golden-install-parity/claude-local.json vendored
View File

@@ -287,7 +287,7 @@
"gsd-core/workflows/check-todos.md": "8f2c6b27f18cc5e2",
"gsd-core/workflows/cleanup.md": "bfbab4b981d39544",
"gsd-core/workflows/code-review-fix.md": "78c716068ccdf820",
"gsd-core/workflows/code-review.md": "2d21452eb0449fdd",
"gsd-core/workflows/code-review.md": "595f0d9c7f475809",
"gsd-core/workflows/complete-milestone.md": "9962377cddee50d7",
"gsd-core/workflows/debug.md": "80c413b3a9877433",
"gsd-core/workflows/diagnose-issues.md": "db6a599674efbc4d",

2
tests/fixtures/golden-install-parity/claude.json vendored
View File

@@ -216,7 +216,7 @@
"gsd-core/workflows/check-todos.md": "6c2a43d1d3e86589",
"gsd-core/workflows/cleanup.md": "0daa2f2720c111f1",
"gsd-core/workflows/code-review-fix.md": "722416b71b31c5fc",
"gsd-core/workflows/code-review.md": "506412604f767adc",
"gsd-core/workflows/code-review.md": "14682c0ba32d5dc6",
"gsd-core/workflows/complete-milestone.md": "dcf1182398efb1ca",
"gsd-core/workflows/debug.md": "b4c658c9608d08e2",
"gsd-core/workflows/diagnose-issues.md": "75ffc381ac3059ff",

2
tests/fixtures/golden-install-parity/cline.json vendored
View File

@@ -220,7 +220,7 @@
"gsd-core/workflows/check-todos.md": "32fdf33f5dc8bdde",
"gsd-core/workflows/cleanup.md": "b0ebfc48792b407b",
"gsd-core/workflows/code-review-fix.md": "e4549af672e74e6f",
"gsd-core/workflows/code-review.md": "a65e3e869508f89e",
"gsd-core/workflows/code-review.md": "2f9cacacbc862af3",
"gsd-core/workflows/complete-milestone.md": "c0808127038a8f86",
"gsd-core/workflows/debug.md": "870682af53182a6c",
"gsd-core/workflows/diagnose-issues.md": "e616d0d730328d68",

2
tests/fixtures/golden-install-parity/codebuddy.json vendored
View File

@@ -288,7 +288,7 @@
"gsd-core/workflows/check-todos.md": "bdeaf43f9c61e0cc",
"gsd-core/workflows/cleanup.md": "0daa2f2720c111f1",
"gsd-core/workflows/code-review-fix.md": "2e113d1f4350a075",
"gsd-core/workflows/code-review.md": "334c90c401f291f8",
"gsd-core/workflows/code-review.md": "2aa1957579f50a87",
"gsd-core/workflows/complete-milestone.md": "c1f91b77f4ace7f2",
"gsd-core/workflows/debug.md": "98c8ed5af882ef8f",
"gsd-core/workflows/diagnose-issues.md": "77d98ac07c4a26ff",

2
tests/fixtures/golden-install-parity/codex.json vendored
View File

@@ -323,7 +323,7 @@
"gsd-core/workflows/check-todos.md": "b2b103e8638e760a",
"gsd-core/workflows/cleanup.md": "5d48d64664222a3e",
"gsd-core/workflows/code-review-fix.md": "ae7f9c6b39a23c12",
"gsd-core/workflows/code-review.md": "eadada9e0a89adf2",
"gsd-core/workflows/code-review.md": "8ac44419de9d2ab5",
"gsd-core/workflows/complete-milestone.md": "017df7443bd08da5",
"gsd-core/workflows/debug.md": "63691293c0bc0294",
"gsd-core/workflows/diagnose-issues.md": "e38bb21d06dff077",

2
tests/fixtures/golden-install-parity/copilot.json vendored
View File

@@ -218,7 +218,7 @@
"gsd-core/workflows/check-todos.md": "be9b50b5f28d7504",
"gsd-core/workflows/cleanup.md": "8233b05ebf011bec",
"gsd-core/workflows/code-review-fix.md": "fda53892ae4b17fc",
"gsd-core/workflows/code-review.md": "f1c045ec4d33abc8",
"gsd-core/workflows/code-review.md": "d58b02fb3a6160a8",
"gsd-core/workflows/complete-milestone.md": "470cf39261400ee2",
"gsd-core/workflows/debug.md": "37c900b9f6c11663",
"gsd-core/workflows/diagnose-issues.md": "42acbe2a43fc886e",

2
tests/fixtures/golden-install-parity/cursor.json vendored
View File

@@ -288,7 +288,7 @@
"gsd-core/workflows/check-todos.md": "1a67337d1630848f",
"gsd-core/workflows/cleanup.md": "db47963f103c2748",
"gsd-core/workflows/code-review-fix.md": "c57af378033b1b58",
"gsd-core/workflows/code-review.md": "32c37bcbec8b8698",
"gsd-core/workflows/code-review.md": "8d7d2de8781fb3f9",
"gsd-core/workflows/complete-milestone.md": "1400a4856f592f3e",
"gsd-core/workflows/debug.md": "fb9e5ecb5027b98e",
"gsd-core/workflows/diagnose-issues.md": "cd582747131726e3",

2
tests/fixtures/golden-install-parity/hermes.json vendored
View File

@@ -217,7 +217,7 @@
"gsd-core/workflows/check-todos.md": "ea9a303c48a5d752",
"gsd-core/workflows/cleanup.md": "6c488059fc152a49",
"gsd-core/workflows/code-review-fix.md": "5e396494a79c3f19",
"gsd-core/workflows/code-review.md": "64a62562611f7f2b",
"gsd-core/workflows/code-review.md": "cf7735c3643d9190",
"gsd-core/workflows/complete-milestone.md": "f1866541148dc291",
"gsd-core/workflows/debug.md": "a8132ea4480a4730",
"gsd-core/workflows/diagnose-issues.md": "385096674965c043",

2
tests/fixtures/golden-install-parity/kilo.json vendored
View File

@@ -288,7 +288,7 @@
"gsd-core/workflows/check-todos.md": "ed4b4eb12be222d7",
"gsd-core/workflows/cleanup.md": "c5f1bf186395d67d",
"gsd-core/workflows/code-review-fix.md": "722416b71b31c5fc",
"gsd-core/workflows/code-review.md": "506412604f767adc",
"gsd-core/workflows/code-review.md": "14682c0ba32d5dc6",
"gsd-core/workflows/complete-milestone.md": "59753bf44d4300da",
"gsd-core/workflows/debug.md": "e88c2d430c3625b6",
"gsd-core/workflows/diagnose-issues.md": "210b5b313e8a559a",

2
tests/fixtures/golden-install-parity/kimi.json vendored
View File

@@ -281,7 +281,7 @@
"gsd-core/workflows/check-todos.md": "bdeaf43f9c61e0cc",
"gsd-core/workflows/cleanup.md": "0daa2f2720c111f1",
"gsd-core/workflows/code-review-fix.md": "2e113d1f4350a075",
"gsd-core/workflows/code-review.md": "334c90c401f291f8",
"gsd-core/workflows/code-review.md": "2aa1957579f50a87",
"gsd-core/workflows/complete-milestone.md": "c1f91b77f4ace7f2",
"gsd-core/workflows/debug.md": "98c8ed5af882ef8f",
"gsd-core/workflows/diagnose-issues.md": "67c058fc7ae6026b",

2
tests/fixtures/golden-install-parity/opencode.json vendored
View File

@@ -288,7 +288,7 @@
"gsd-core/workflows/check-todos.md": "6526b64ee88c7d2e",
"gsd-core/workflows/cleanup.md": "94d771d26f62dc86",
"gsd-core/workflows/code-review-fix.md": "adb9388bb157610c",
"gsd-core/workflows/code-review.md": "ae6bcbd1575aeec4",
"gsd-core/workflows/code-review.md": "8ff9884096ae8341",
"gsd-core/workflows/complete-milestone.md": "614299b2c08e66c3",
"gsd-core/workflows/debug.md": "161be2a77ffce47a",
"gsd-core/workflows/diagnose-issues.md": "2971c699d52f1b85",

2
tests/fixtures/golden-install-parity/pi.json vendored
View File

@@ -184,7 +184,7 @@
"gsd-core/workflows/check-todos.md": "bdeaf43f9c61e0cc",
"gsd-core/workflows/cleanup.md": "0daa2f2720c111f1",
"gsd-core/workflows/code-review-fix.md": "2e113d1f4350a075",
"gsd-core/workflows/code-review.md": "334c90c401f291f8",
"gsd-core/workflows/code-review.md": "2aa1957579f50a87",
"gsd-core/workflows/complete-milestone.md": "c1f91b77f4ace7f2",
"gsd-core/workflows/debug.md": "98c8ed5af882ef8f",
"gsd-core/workflows/diagnose-issues.md": "d6d978fddfd5da8d",

2
tests/fixtures/golden-install-parity/qwen.json vendored
View File

@@ -217,7 +217,7 @@
"gsd-core/workflows/check-todos.md": "ec8c22920f6b2df1",
"gsd-core/workflows/cleanup.md": "6a18b165752e3087",
"gsd-core/workflows/code-review-fix.md": "f3725ae9d685bed2",
"gsd-core/workflows/code-review.md": "29125604bed2c467",
"gsd-core/workflows/code-review.md": "6076e252b0d315f4",
"gsd-core/workflows/complete-milestone.md": "40085d32b15805c8",
"gsd-core/workflows/debug.md": "09b6bad63939bb82",
"gsd-core/workflows/diagnose-issues.md": "652ae26975f82242",

2
tests/fixtures/golden-install-parity/trae.json vendored
View File

@@ -217,7 +217,7 @@
"gsd-core/workflows/check-todos.md": "0dda8236355e8c9c",
"gsd-core/workflows/cleanup.md": "82f65f5214ecd748",
"gsd-core/workflows/code-review-fix.md": "f2761f7f8c4a5674",
"gsd-core/workflows/code-review.md": "47663a2922756c5e",
"gsd-core/workflows/code-review.md": "c5311718997f7681",
"gsd-core/workflows/complete-milestone.md": "6e918b72bd885426",
"gsd-core/workflows/debug.md": "04b29e0ba18603b6",
"gsd-core/workflows/diagnose-issues.md": "9274b11a3db98c65",

2
tests/fixtures/golden-install-parity/windsurf.json vendored
View File

@@ -217,7 +217,7 @@
"gsd-core/workflows/check-todos.md": "afc840fceb07bf99",
"gsd-core/workflows/cleanup.md": "93c14107979a4428",
"gsd-core/workflows/code-review-fix.md": "b99b1f20bb27c291",
"gsd-core/workflows/code-review.md": "faa87faf07ae765a",
"gsd-core/workflows/code-review.md": "ac70888b14a21aaf",
"gsd-core/workflows/complete-milestone.md": "f463bf4e86ac26f6",
"gsd-core/workflows/debug.md": "830c309b48c35c8c",
"gsd-core/workflows/diagnose-issues.md": "447072aa72385271",

2
tests/fixtures/golden-install-parity/zcode.json vendored
View File

@@ -288,7 +288,7 @@
"gsd-core/workflows/check-todos.md": "bdeaf43f9c61e0cc",
"gsd-core/workflows/cleanup.md": "0daa2f2720c111f1",
"gsd-core/workflows/code-review-fix.md": "2e113d1f4350a075",
"gsd-core/workflows/code-review.md": "334c90c401f291f8",
"gsd-core/workflows/code-review.md": "2aa1957579f50a87",
"gsd-core/workflows/complete-milestone.md": "c1f91b77f4ace7f2",
"gsd-core/workflows/debug.md": "98c8ed5af882ef8f",
"gsd-core/workflows/diagnose-issues.md": "aa8d787db8f3c46c",