From 891eae1025f57bed916bf7869b7a780f2cc922c0 Mon Sep 17 00:00:00 2001 From: Tom Boucher Date: Tue, 5 May 2026 11:05:17 -0400 Subject: [PATCH] fix: short-circuit --assumptions and --from-gsd2 dispatch; add changeset MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - discuss-phase --assumptions: add 'Stop here' + convert If→Otherwise chain so the flag is an exclusive route (CodeRabbit major) - import --from-gsd2: add 'Stop here' + convert final 'Execute...' to 'Otherwise...' to prevent fall-through to standard import (CodeRabbit major, inline comment) - .changeset/rewire-orphaned-workflows-3131.md: add missing changeset --- .changeset/rewire-orphaned-workflows-3131.md | 6 ++++++ commands/gsd/discuss-phase.md | 5 +++-- commands/gsd/import.md | 3 ++- 3 files changed, 11 insertions(+), 3 deletions(-) create mode 100644 .changeset/rewire-orphaned-workflows-3131.md diff --git a/.changeset/rewire-orphaned-workflows-3131.md b/.changeset/rewire-orphaned-workflows-3131.md new file mode 100644 index 000000000..f85832b3f --- /dev/null +++ b/.changeset/rewire-orphaned-workflows-3131.md @@ -0,0 +1,6 @@ +--- +type: Changed +pr: 3131 +--- + +**Re-wired 4 orphaned workflows as flags on parent commands** — six workflows were mis-categorised as "outright deleted dead skills" during the #2790 consolidation; two were caught by prior PRs (#3045, #3038) and four are fixed here. New flags: `/gsd-discuss-phase --assumptions` (surfaces Claude's implementation assumptions before planning), `/gsd-pause-work --report` (generates a post-session summary in `.planning/reports/`), `/gsd-manager --analyze-deps` (scans ROADMAP phases for dependency relationships before parallel execution), `/gsd-import --from-gsd2` (reverse-migrates a GSD-2 `.gsd/` project back to GSD v1 `.planning/` format). Also sweeps 29 stale `/gsd-*` command references across 27 user-facing files (English + 4 locales). Closes #3131. diff --git a/commands/gsd/discuss-phase.md b/commands/gsd/discuss-phase.md index 02a72b1ad..2a59027fc 100644 --- a/commands/gsd/discuss-phase.md +++ b/commands/gsd/discuss-phase.md @@ -51,11 +51,12 @@ DISCUSS_MODE=$(gsd-sdk query config-get workflow.discuss_mode 2>/dev/null || ech If `--assumptions` is in $ARGUMENTS: Read and execute `~/.claude/get-shit-done/workflows/list-phase-assumptions.md` end-to-end. +Stop here. -If `DISCUSS_MODE` is `"assumptions"`: +Otherwise, if `DISCUSS_MODE` is `"assumptions"`: Read and execute `~/.claude/get-shit-done/workflows/discuss-phase-assumptions.md` end-to-end. -If `DISCUSS_MODE` is `"discuss"` (or unset, or any other value): +Otherwise (`"discuss"` / unset / any other value): Read and execute `~/.claude/get-shit-done/workflows/discuss-phase.md` end-to-end. **MANDATORY:** Read the appropriate workflow file BEFORE taking any action. The objective and success_criteria sections in this command file are summaries — the workflow file contains the complete step-by-step process with all required behaviors, config checks, and interaction patterns. Do not improvise from the summary. diff --git a/commands/gsd/import.md b/commands/gsd/import.md index bbc56c7a5..ccb91a01b 100644 --- a/commands/gsd/import.md +++ b/commands/gsd/import.md @@ -35,6 +35,7 @@ $ARGUMENTS If `--from-gsd2` is in $ARGUMENTS: Run: `node "$HOME/.claude/get-shit-done/bin/gsd-tools.cjs" from-gsd2` Pass `--path ` if provided. Present the migration result to the user. +Stop here (do not run the standard import workflow). -Execute the import workflow end-to-end. +Otherwise, execute the import workflow end-to-end.