* fix(#2204): phase-completion writes 'All phases complete' per ADR-2207 completePhaseCore was writing the overloaded bare 'Milestone complete' on the last phase — the same string space the milestone-close verb owns for terminal state. Per ADR-2207, phase-completion now writes the existing intermediate value 'All phases complete' (already used in gsd2-import.cts). Milestone termination ('<version> milestone complete' / 'Awaiting next milestone') remains solely with milestoneCompleteCore. Status lifecycle: Ready to plan → All phases complete → <version> milestone complete → Awaiting next milestone. Changes: - src/state-transition.cts: completePhaseCore status value - src/phase.cts: #2028 guard comment - tests/state-transition.test.cjs: assertion + test name - tests/phase.test.cjs: 8 assertion updates (positive + negative) - tests/state.test.cjs: normalizeStateStatus test case + reset regex - tests/workstream.test.cjs: fixture status to terminal value - gsd-core/workflows/progress.md: Route D label - gsd-core/workflows/transition.md: Route B label - CONTEXT.md: Status lifecycle glossary entry (ADR-2207) - .changeset/brave-geese-jump.md * test(#2204): regenerate golden-install-parity fixtures + workflow-size baseline Workflow file edits (progress.md, transition.md) changed install payload hashes and pushed past the committed workflow-size baseline. Regenerated all 17 golden-install-parity fixtures + claude-local via the standalone gen script (which now also covers the local-scope claude layout). Updated workflow-size-baseline.json and agent-size-baseline.json via size:baseline. * fix(#2204): correct claude-local golden hashes + document gen-script limitation The gen-script's claude-local generation produces macOS-specific hashes incompatible with Linux CI (local-scope install embeds platform-varying node-runner paths). Reverted to manual update using Linux FAILURES.md +actual hashes for the 2 changed workflow files. Added explanatory comment in the gen script. * test(#2204): add isCompletedInventory coverage + clarify CONTEXT.md glossary Addresses orthogonal code-review findings (Medium #1 + #2): - Add isCompletedInventory test cases for ADR-2207 status lifecycle (terminal 'milestone complete' → true; intermediate 'All phases complete' → false; archived → true; active statuses → false) - Clarify CONTEXT.md glossary: note that isCompletedInventory intentionally excludes the intermediate value * docs: backfill changeset PR number (#2259) * docs(#2204): add Status lifecycle table to state-md reference (ADR-2207)
This commit is contained in:
@@ -498,6 +498,7 @@ stopped_at: Plan 2 of Phase 3
|
||||
{ input: 'Ready to plan', expected: 'planning' },
|
||||
{ input: 'Phase complete — ready for verification', expected: 'verifying' },
|
||||
{ input: 'Milestone complete', expected: 'completed' },
|
||||
{ input: 'All phases complete', expected: 'completed' },
|
||||
];
|
||||
|
||||
for (const { input, expected } of statusTests) {
|
||||
@@ -2053,7 +2054,7 @@ describe('progress counters correct after plan execution (#1589)', () => {
|
||||
);
|
||||
|
||||
// Trigger a STATE.md write (e.g. state update Status)
|
||||
const result = runGsdTools('state update Status "Milestone complete"', tmpDir);
|
||||
const result = runGsdTools('state update Status "All phases complete"', tmpDir);
|
||||
assert.ok(result.success, `Command failed: ${result.error}`);
|
||||
|
||||
// Read the frontmatter — percent must be derived from disk (4/4 = 100%), not from body "0%"
|
||||
@@ -2296,7 +2297,7 @@ describe('updatePerformanceMetricsSection', () => {
|
||||
const afterFirst = fs.readFileSync(statePath, 'utf-8');
|
||||
|
||||
// Reset state so we can complete again
|
||||
let resetContent = afterFirst.replace(/Milestone complete|Ready to plan/, 'Executing Phase 5');
|
||||
let resetContent = afterFirst.replace(/All phases complete|Ready to plan/, 'Executing Phase 5');
|
||||
resetContent = resetContent.replace(/Not started/, '1');
|
||||
fs.writeFileSync(statePath, resetContent);
|
||||
|
||||
|
||||
Reference in New Issue
Block a user