feat(#2008): generic command-exit-zero gate-predicate evaluator (#2011)

* feat(#2008): add generic command-exit-zero gate-predicate evaluator

Third-party capability gates declared via check.predicate were rendered for
display but never evaluated (only built-in check.query gates fired; the
security capability's gate worked solely via a hard-coded ship.md branch).

Add a generic, deps-injected gate-predicate evaluator (src/gate-predicate-evaluator.cts)
that dispatches by predicate.kind. Built-in kind: command-exit-zero — runs a
bounded sh -c command at the project root (via shell-command-projection.execTool),
inherits env, exit 0 => pass, non-zero => block, timeout => block, fail-closed.

Wire a 'check predicate' subcommand into check-command-router.cts and extend
the three generic workflow gate-dispatch sites (execute:wave:post, execute:post,
plan:post) to route check.predicate gates to the new evaluator. The two-step
gate contract (command-failure => onError; block => halt) is unchanged.

- src/gate-predicate-evaluator.cts: pure leaf, KIND_TABLE extensible
- src/check-command-router.cts: cmdCheckPredicate + buildPredicateDeps + parsePredicateFlags
- docs/adr/2008-*, docs/reference/gate-predicates.md, docs/how-to/command-exit-zero-gate.md
- tests: 38 unit + integration tests (exit mapping, timeout, interpolation,
  property-based bijection, malformed-predicate fail-closed, real subprocess e2e)

Closes #2008

* docs(#2008): backfill changeset pr number 2011
This commit is contained in:
Tom Boucher
2026-07-05 14:04:29 -04:00
committed by GitHub
parent 97730e59a1
commit 8de2ff9121
31 changed files with 1238 additions and 38 deletions

View File

@@ -228,7 +228,7 @@
"gsd-core/workflows/docs-update.md": "1c3a0d23ecc9605c",
"gsd-core/workflows/edit-phase.md": "f685fb7063616826",
"gsd-core/workflows/eval-review.md": "2da6215ce79b2f7c",
"gsd-core/workflows/execute-phase.md": "e7713d986ebf45e0",
"gsd-core/workflows/execute-phase.md": "660fb92b8ed43129",
"gsd-core/workflows/execute-phase/steps/codebase-drift-gate.md": "1da22ba32f524c6e",
"gsd-core/workflows/execute-phase/steps/per-plan-worktree-gate.md": "7ebb7d1af6082028",
"gsd-core/workflows/execute-phase/steps/post-merge-gate.md": "bb9113e7bf953797",
@@ -264,7 +264,7 @@
"gsd-core/workflows/note.md": "3ce09c0aa0a20599",
"gsd-core/workflows/pause-work.md": "3196d681d4dd8c71",
"gsd-core/workflows/plan-milestone-gaps.md": "94b193dfc9ca3681",
"gsd-core/workflows/plan-phase.md": "659b52bd338720fe",
"gsd-core/workflows/plan-phase.md": "1fecfb77b67d4833",
"gsd-core/workflows/plan-phase/steps/closed-phase-gate.md": "4099ef6d0868de60",
"gsd-core/workflows/plan-phase/steps/prd-express-path.md": "473d4d6e5b1f6340",
"gsd-core/workflows/plan-phase/steps/windows-troubleshooting.md": "e9de7a96bbfff261",

View File

@@ -298,7 +298,7 @@
"gsd-core/workflows/docs-update.md": "806ada831b961116",
"gsd-core/workflows/edit-phase.md": "e5624ac6e3f8bef5",
"gsd-core/workflows/eval-review.md": "dfcfb4f8ce031fae",
"gsd-core/workflows/execute-phase.md": "5daeb8fac7cab295",
"gsd-core/workflows/execute-phase.md": "5383dabd9fd40206",
"gsd-core/workflows/execute-phase/steps/codebase-drift-gate.md": "8898e0ea533cc643",
"gsd-core/workflows/execute-phase/steps/per-plan-worktree-gate.md": "7ebb7d1af6082028",
"gsd-core/workflows/execute-phase/steps/post-merge-gate.md": "abd2aca069c04a80",
@@ -334,7 +334,7 @@
"gsd-core/workflows/note.md": "5a99eb396c744619",
"gsd-core/workflows/pause-work.md": "7bcbdf27ba957c8b",
"gsd-core/workflows/plan-milestone-gaps.md": "02fee851c82e3b25",
"gsd-core/workflows/plan-phase.md": "dc0beefd1316a860",
"gsd-core/workflows/plan-phase.md": "f80ff87cec37c25c",
"gsd-core/workflows/plan-phase/steps/closed-phase-gate.md": "b36f77ac7344a072",
"gsd-core/workflows/plan-phase/steps/prd-express-path.md": "d64097345ffac40d",
"gsd-core/workflows/plan-phase/steps/windows-troubleshooting.md": "49f58c3f75be3eb5",

View File

@@ -227,7 +227,7 @@
"gsd-core/workflows/docs-update.md": "98c30bec9350542f",
"gsd-core/workflows/edit-phase.md": "a3ab51739c5c021c",
"gsd-core/workflows/eval-review.md": "f47fd1a7a1ca3308",
"gsd-core/workflows/execute-phase.md": "fe39dd64ff9db8f6",
"gsd-core/workflows/execute-phase.md": "d8ffe62c26c3f28e",
"gsd-core/workflows/execute-phase/steps/codebase-drift-gate.md": "c133828cf177a772",
"gsd-core/workflows/execute-phase/steps/per-plan-worktree-gate.md": "7ebb7d1af6082028",
"gsd-core/workflows/execute-phase/steps/post-merge-gate.md": "abd2aca069c04a80",
@@ -263,7 +263,7 @@
"gsd-core/workflows/note.md": "42b66686b2c102cb",
"gsd-core/workflows/pause-work.md": "0be71264eafd16dc",
"gsd-core/workflows/plan-milestone-gaps.md": "1976bf2001969719",
"gsd-core/workflows/plan-phase.md": "f0401a3221b74b58",
"gsd-core/workflows/plan-phase.md": "21a81a2c468c53c2",
"gsd-core/workflows/plan-phase/steps/closed-phase-gate.md": "4099ef6d0868de60",
"gsd-core/workflows/plan-phase/steps/prd-express-path.md": "d64097345ffac40d",
"gsd-core/workflows/plan-phase/steps/windows-troubleshooting.md": "e9de7a96bbfff261",

View File

@@ -231,7 +231,7 @@
"gsd-core/workflows/docs-update.md": "4aee7d852ab26710",
"gsd-core/workflows/edit-phase.md": "db501e21c762d2b2",
"gsd-core/workflows/eval-review.md": "e211cca4eea94930",
"gsd-core/workflows/execute-phase.md": "61b798388f3c28d7",
"gsd-core/workflows/execute-phase.md": "20299af3e665f539",
"gsd-core/workflows/execute-phase/steps/codebase-drift-gate.md": "84b49fd65d290399",
"gsd-core/workflows/execute-phase/steps/per-plan-worktree-gate.md": "7ebb7d1af6082028",
"gsd-core/workflows/execute-phase/steps/post-merge-gate.md": "bcb4ab75df626846",
@@ -267,7 +267,7 @@
"gsd-core/workflows/note.md": "5a99eb396c744619",
"gsd-core/workflows/pause-work.md": "9c1acf8c30a244fd",
"gsd-core/workflows/plan-milestone-gaps.md": "95ca791b0867fe2d",
"gsd-core/workflows/plan-phase.md": "e4256d987d376112",
"gsd-core/workflows/plan-phase.md": "b906c040d22d0424",
"gsd-core/workflows/plan-phase/steps/closed-phase-gate.md": "b36f77ac7344a072",
"gsd-core/workflows/plan-phase/steps/prd-express-path.md": "ae59c247ad4a57d2",
"gsd-core/workflows/plan-phase/steps/windows-troubleshooting.md": "090c31e22b1508fe",

View File

@@ -298,7 +298,7 @@
"gsd-core/workflows/docs-update.md": "806ada831b961116",
"gsd-core/workflows/edit-phase.md": "e5624ac6e3f8bef5",
"gsd-core/workflows/eval-review.md": "dfcfb4f8ce031fae",
"gsd-core/workflows/execute-phase.md": "d3c1583906de7408",
"gsd-core/workflows/execute-phase.md": "05280ea81a40a29f",
"gsd-core/workflows/execute-phase/steps/codebase-drift-gate.md": "8898e0ea533cc643",
"gsd-core/workflows/execute-phase/steps/per-plan-worktree-gate.md": "7ebb7d1af6082028",
"gsd-core/workflows/execute-phase/steps/post-merge-gate.md": "abd2aca069c04a80",
@@ -334,7 +334,7 @@
"gsd-core/workflows/note.md": "5a99eb396c744619",
"gsd-core/workflows/pause-work.md": "7bcbdf27ba957c8b",
"gsd-core/workflows/plan-milestone-gaps.md": "02fee851c82e3b25",
"gsd-core/workflows/plan-phase.md": "9fc35fa37928c14e",
"gsd-core/workflows/plan-phase.md": "9ad0d58d4abbfcb3",
"gsd-core/workflows/plan-phase/steps/closed-phase-gate.md": "b36f77ac7344a072",
"gsd-core/workflows/plan-phase/steps/prd-express-path.md": "d64097345ffac40d",
"gsd-core/workflows/plan-phase/steps/windows-troubleshooting.md": "49f58c3f75be3eb5",

View File

@@ -263,7 +263,7 @@
"gsd-core/workflows/docs-update.md": "c5e1ea372f4a9ee8",
"gsd-core/workflows/edit-phase.md": "c83ef0701c19c455",
"gsd-core/workflows/eval-review.md": "68d7d96bd415629b",
"gsd-core/workflows/execute-phase.md": "5db223634afa2b88",
"gsd-core/workflows/execute-phase.md": "5ac844394468bef0",
"gsd-core/workflows/execute-phase/steps/codebase-drift-gate.md": "7ae407e4435c9a2a",
"gsd-core/workflows/execute-phase/steps/per-plan-worktree-gate.md": "7ebb7d1af6082028",
"gsd-core/workflows/execute-phase/steps/post-merge-gate.md": "abd2aca069c04a80",
@@ -299,7 +299,7 @@
"gsd-core/workflows/note.md": "664da466ab989f9d",
"gsd-core/workflows/pause-work.md": "3c2ee96295959527",
"gsd-core/workflows/plan-milestone-gaps.md": "8ee841bcc7adc836",
"gsd-core/workflows/plan-phase.md": "5d3ed552933f81da",
"gsd-core/workflows/plan-phase.md": "58ee6f71fa269c46",
"gsd-core/workflows/plan-phase/steps/closed-phase-gate.md": "d838b87563feedf6",
"gsd-core/workflows/plan-phase/steps/prd-express-path.md": "44a12264f8b61d03",
"gsd-core/workflows/plan-phase/steps/windows-troubleshooting.md": "f5edc589cab52a7b",

View File

@@ -229,7 +229,7 @@
"gsd-core/workflows/docs-update.md": "15436f1f87ce9bd2",
"gsd-core/workflows/edit-phase.md": "a619911fd32d1f8e",
"gsd-core/workflows/eval-review.md": "b29095c5e7149975",
"gsd-core/workflows/execute-phase.md": "dcb483d5fceffac1",
"gsd-core/workflows/execute-phase.md": "63945642ac949204",
"gsd-core/workflows/execute-phase/steps/codebase-drift-gate.md": "8d835dbbc9bc72cf",
"gsd-core/workflows/execute-phase/steps/per-plan-worktree-gate.md": "7ebb7d1af6082028",
"gsd-core/workflows/execute-phase/steps/post-merge-gate.md": "a01e6aae9f3e416e",
@@ -265,7 +265,7 @@
"gsd-core/workflows/note.md": "4a5ee74cf2fc1f54",
"gsd-core/workflows/pause-work.md": "324e04e675dc7f7f",
"gsd-core/workflows/plan-milestone-gaps.md": "c0eb896eb42e22d4",
"gsd-core/workflows/plan-phase.md": "371be4167168d461",
"gsd-core/workflows/plan-phase.md": "cc53a19bfc3831e8",
"gsd-core/workflows/plan-phase/steps/closed-phase-gate.md": "4099ef6d0868de60",
"gsd-core/workflows/plan-phase/steps/prd-express-path.md": "d911a080dc1cece6",
"gsd-core/workflows/plan-phase/steps/windows-troubleshooting.md": "e9de7a96bbfff261",

View File

@@ -298,7 +298,7 @@
"gsd-core/workflows/docs-update.md": "b05a59f3079f6fa7",
"gsd-core/workflows/edit-phase.md": "a3ab51739c5c021c",
"gsd-core/workflows/eval-review.md": "8cc5788e32c15783",
"gsd-core/workflows/execute-phase.md": "c90b217abff9bbb3",
"gsd-core/workflows/execute-phase.md": "9ef2d83a416994dd",
"gsd-core/workflows/execute-phase/steps/codebase-drift-gate.md": "c133828cf177a772",
"gsd-core/workflows/execute-phase/steps/per-plan-worktree-gate.md": "7ebb7d1af6082028",
"gsd-core/workflows/execute-phase/steps/post-merge-gate.md": "abd2aca069c04a80",
@@ -334,7 +334,7 @@
"gsd-core/workflows/note.md": "1c1e466c764e3deb",
"gsd-core/workflows/pause-work.md": "0be71264eafd16dc",
"gsd-core/workflows/plan-milestone-gaps.md": "1976bf2001969719",
"gsd-core/workflows/plan-phase.md": "ba95020c3495b191",
"gsd-core/workflows/plan-phase.md": "f1f89fbd2bb723fb",
"gsd-core/workflows/plan-phase/steps/closed-phase-gate.md": "e06ccd4d4c0703fb",
"gsd-core/workflows/plan-phase/steps/prd-express-path.md": "d64097345ffac40d",
"gsd-core/workflows/plan-phase/steps/windows-troubleshooting.md": "3bed01c3c906ac52",

View File

@@ -228,7 +228,7 @@
"gsd-core/workflows/docs-update.md": "c9df0f7df1ebec79",
"gsd-core/workflows/edit-phase.md": "57d807e21fe70355",
"gsd-core/workflows/eval-review.md": "d16eebac88386c05",
"gsd-core/workflows/execute-phase.md": "0167a319ed9a5bc5",
"gsd-core/workflows/execute-phase.md": "f05a000ab97b5b25",
"gsd-core/workflows/execute-phase/steps/codebase-drift-gate.md": "b890bafa4a0c8bd3",
"gsd-core/workflows/execute-phase/steps/per-plan-worktree-gate.md": "7ebb7d1af6082028",
"gsd-core/workflows/execute-phase/steps/post-merge-gate.md": "e34415dec69b8432",
@@ -264,7 +264,7 @@
"gsd-core/workflows/note.md": "42b66686b2c102cb",
"gsd-core/workflows/pause-work.md": "2c3abcaa1fa6d2e2",
"gsd-core/workflows/plan-milestone-gaps.md": "419744c1191354af",
"gsd-core/workflows/plan-phase.md": "e1dcabd0499a03f9",
"gsd-core/workflows/plan-phase.md": "bdd3aade4649708a",
"gsd-core/workflows/plan-phase/steps/closed-phase-gate.md": "4099ef6d0868de60",
"gsd-core/workflows/plan-phase/steps/prd-express-path.md": "99949122a3bd455e",
"gsd-core/workflows/plan-phase/steps/windows-troubleshooting.md": "62f8e4f3b475fe5f",

View File

@@ -298,7 +298,7 @@
"gsd-core/workflows/docs-update.md": "87bf2a6b7b6ec9db",
"gsd-core/workflows/edit-phase.md": "a3ab51739c5c021c",
"gsd-core/workflows/eval-review.md": "f6183650f7fcabf9",
"gsd-core/workflows/execute-phase.md": "5c4b59ee5e04a022",
"gsd-core/workflows/execute-phase.md": "73e6a5c54af797bd",
"gsd-core/workflows/execute-phase/steps/codebase-drift-gate.md": "c133828cf177a772",
"gsd-core/workflows/execute-phase/steps/per-plan-worktree-gate.md": "7ebb7d1af6082028",
"gsd-core/workflows/execute-phase/steps/post-merge-gate.md": "abd2aca069c04a80",
@@ -334,7 +334,7 @@
"gsd-core/workflows/note.md": "f8c2842a2217f776",
"gsd-core/workflows/pause-work.md": "8b81699a46ca8e9b",
"gsd-core/workflows/plan-milestone-gaps.md": "1976bf2001969719",
"gsd-core/workflows/plan-phase.md": "a7642fb6484cf12e",
"gsd-core/workflows/plan-phase.md": "b58ec889ce1d1707",
"gsd-core/workflows/plan-phase/steps/closed-phase-gate.md": "4099ef6d0868de60",
"gsd-core/workflows/plan-phase/steps/prd-express-path.md": "44a12264f8b61d03",
"gsd-core/workflows/plan-phase/steps/windows-troubleshooting.md": "e9de7a96bbfff261",

View File

@@ -264,7 +264,7 @@
"gsd-core/workflows/docs-update.md": "806ada831b961116",
"gsd-core/workflows/edit-phase.md": "e5624ac6e3f8bef5",
"gsd-core/workflows/eval-review.md": "dfcfb4f8ce031fae",
"gsd-core/workflows/execute-phase.md": "444d5f17dfc1437a",
"gsd-core/workflows/execute-phase.md": "fea95b7022cad03f",
"gsd-core/workflows/execute-phase/steps/codebase-drift-gate.md": "8898e0ea533cc643",
"gsd-core/workflows/execute-phase/steps/per-plan-worktree-gate.md": "7ebb7d1af6082028",
"gsd-core/workflows/execute-phase/steps/post-merge-gate.md": "abd2aca069c04a80",
@@ -300,7 +300,7 @@
"gsd-core/workflows/note.md": "5a99eb396c744619",
"gsd-core/workflows/pause-work.md": "7bcbdf27ba957c8b",
"gsd-core/workflows/plan-milestone-gaps.md": "02fee851c82e3b25",
"gsd-core/workflows/plan-phase.md": "e69e435b47d77070",
"gsd-core/workflows/plan-phase.md": "5ab304e905e4e234",
"gsd-core/workflows/plan-phase/steps/closed-phase-gate.md": "b36f77ac7344a072",
"gsd-core/workflows/plan-phase/steps/prd-express-path.md": "d64097345ffac40d",
"gsd-core/workflows/plan-phase/steps/windows-troubleshooting.md": "49f58c3f75be3eb5",

View File

@@ -298,7 +298,7 @@
"gsd-core/workflows/docs-update.md": "93e969c3afb446a0",
"gsd-core/workflows/edit-phase.md": "ed948a400a0146c7",
"gsd-core/workflows/eval-review.md": "1ba1af74a43c07db",
"gsd-core/workflows/execute-phase.md": "f0ca3839e0d0cf8b",
"gsd-core/workflows/execute-phase.md": "24561c1fbc7b710e",
"gsd-core/workflows/execute-phase/steps/codebase-drift-gate.md": "a640b093a5a7b028",
"gsd-core/workflows/execute-phase/steps/per-plan-worktree-gate.md": "7ebb7d1af6082028",
"gsd-core/workflows/execute-phase/steps/post-merge-gate.md": "8b42f5df1a2c231f",
@@ -334,7 +334,7 @@
"gsd-core/workflows/note.md": "0d1374f2a2257858",
"gsd-core/workflows/pause-work.md": "c9f0b8826845dda7",
"gsd-core/workflows/plan-milestone-gaps.md": "5ec459734bf7570c",
"gsd-core/workflows/plan-phase.md": "03745f51d63d99b8",
"gsd-core/workflows/plan-phase.md": "f449b7d8f334ebb9",
"gsd-core/workflows/plan-phase/steps/closed-phase-gate.md": "4099ef6d0868de60",
"gsd-core/workflows/plan-phase/steps/prd-express-path.md": "fa7f29c323f4cb57",
"gsd-core/workflows/plan-phase/steps/windows-troubleshooting.md": "e9de7a96bbfff261",

View File

@@ -228,7 +228,7 @@
"gsd-core/workflows/docs-update.md": "12433c1e3cf9e40e",
"gsd-core/workflows/edit-phase.md": "4ba06a05cb29f3b7",
"gsd-core/workflows/eval-review.md": "0ab8368c8edf91fb",
"gsd-core/workflows/execute-phase.md": "c739c018da3d2c0d",
"gsd-core/workflows/execute-phase.md": "e79f8e56b5d9ccdb",
"gsd-core/workflows/execute-phase/steps/codebase-drift-gate.md": "9320986ccf0e8a60",
"gsd-core/workflows/execute-phase/steps/per-plan-worktree-gate.md": "7ebb7d1af6082028",
"gsd-core/workflows/execute-phase/steps/post-merge-gate.md": "4116471249699255",
@@ -264,7 +264,7 @@
"gsd-core/workflows/note.md": "42b66686b2c102cb",
"gsd-core/workflows/pause-work.md": "54f1c0a9e79e2c59",
"gsd-core/workflows/plan-milestone-gaps.md": "1b820f4e70acce86",
"gsd-core/workflows/plan-phase.md": "574fc8008416e6a7",
"gsd-core/workflows/plan-phase.md": "fa7053b515270b1d",
"gsd-core/workflows/plan-phase/steps/closed-phase-gate.md": "4099ef6d0868de60",
"gsd-core/workflows/plan-phase/steps/prd-express-path.md": "451a287826b36227",
"gsd-core/workflows/plan-phase/steps/windows-troubleshooting.md": "d050d8d551ed1756",

View File

@@ -228,7 +228,7 @@
"gsd-core/workflows/docs-update.md": "dd1050b32c2dc170",
"gsd-core/workflows/edit-phase.md": "38f9c9945073ac8c",
"gsd-core/workflows/eval-review.md": "48fdef1cf0e67525",
"gsd-core/workflows/execute-phase.md": "5e36e2287a165064",
"gsd-core/workflows/execute-phase.md": "706a2890f7556367",
"gsd-core/workflows/execute-phase/steps/codebase-drift-gate.md": "44d46d3e98942efc",
"gsd-core/workflows/execute-phase/steps/per-plan-worktree-gate.md": "7ebb7d1af6082028",
"gsd-core/workflows/execute-phase/steps/post-merge-gate.md": "a2fc97089560ec0a",
@@ -264,7 +264,7 @@
"gsd-core/workflows/note.md": "acc9130fb1e94f0b",
"gsd-core/workflows/pause-work.md": "09a6b8980f7b771a",
"gsd-core/workflows/plan-milestone-gaps.md": "022822b3b6971b75",
"gsd-core/workflows/plan-phase.md": "8eddecda8fcd8765",
"gsd-core/workflows/plan-phase.md": "857f539a33efa3a5",
"gsd-core/workflows/plan-phase/steps/closed-phase-gate.md": "e06ccd4d4c0703fb",
"gsd-core/workflows/plan-phase/steps/prd-express-path.md": "382dac17d70ebfac",
"gsd-core/workflows/plan-phase/steps/windows-troubleshooting.md": "619946c879f33b9d",

View File

@@ -228,7 +228,7 @@
"gsd-core/workflows/docs-update.md": "a3c2ec2c856aaabc",
"gsd-core/workflows/edit-phase.md": "1666ca537fbef030",
"gsd-core/workflows/eval-review.md": "bb01b3300db963bc",
"gsd-core/workflows/execute-phase.md": "20063847abe7ce75",
"gsd-core/workflows/execute-phase.md": "1bd9bf34f86de403",
"gsd-core/workflows/execute-phase/steps/codebase-drift-gate.md": "579a3dcf8d69de31",
"gsd-core/workflows/execute-phase/steps/per-plan-worktree-gate.md": "7ebb7d1af6082028",
"gsd-core/workflows/execute-phase/steps/post-merge-gate.md": "bbd704d6b6f0787b",
@@ -264,7 +264,7 @@
"gsd-core/workflows/note.md": "1c1e466c764e3deb",
"gsd-core/workflows/pause-work.md": "5ce6a137bd9fc0f8",
"gsd-core/workflows/plan-milestone-gaps.md": "19911e87fd4185f2",
"gsd-core/workflows/plan-phase.md": "f6e8c5e38d5c5a52",
"gsd-core/workflows/plan-phase.md": "20062e8d37f19e3d",
"gsd-core/workflows/plan-phase/steps/closed-phase-gate.md": "e06ccd4d4c0703fb",
"gsd-core/workflows/plan-phase/steps/prd-express-path.md": "7c2be59e3e19299a",
"gsd-core/workflows/plan-phase/steps/windows-troubleshooting.md": "3fed4740a91d0443",