From 90ebe4ea734dc6bd0e0545eef7f41922efacbfcc Mon Sep 17 00:00:00 2001 From: Jeremy McSpadden Date: Fri, 3 Jul 2026 19:02:56 -0500 Subject: [PATCH] no-mistakes(review): Include manager in onboard installs --- commands/gsd/onboard.md | 2 +- tests/runtime-artifact-layout-install-profiles.test.cjs | 8 ++++++++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/commands/gsd/onboard.md b/commands/gsd/onboard.md index 9211d3cff..e51fd9919 100644 --- a/commands/gsd/onboard.md +++ b/commands/gsd/onboard.md @@ -10,7 +10,7 @@ allowed-tools: - Grep - Agent - AskUserQuestion -requires: [config, new-project, map-codebase, ingest-docs] +requires: [config, new-project, map-codebase, ingest-docs, manager] --- **Copilot (VS Code):** Use `vscode_askquestions` wherever this workflow calls `AskUserQuestion`. They are equivalent — `vscode_askquestions` is the VS Code Copilot implementation of the same interactive question API. diff --git a/tests/runtime-artifact-layout-install-profiles.test.cjs b/tests/runtime-artifact-layout-install-profiles.test.cjs index ed94af736..6361ec939 100644 --- a/tests/runtime-artifact-layout-install-profiles.test.cjs +++ b/tests/runtime-artifact-layout-install-profiles.test.cjs @@ -380,6 +380,14 @@ describe('resolveProfile', () => { } }); + test('standard profile includes the onboard manager handoff dependency', () => { + const manifest = loadSkillsManifest(REAL_COMMANDS_DIR); + const result = resolveProfile({ modes: ['standard'], manifest }); + assert.ok(result.skills instanceof Set); + assert.ok(result.skills.has('onboard'), 'standard profile should include onboard'); + assert.ok(result.skills.has('manager'), 'onboard handoff must install gsd-manager'); + }); + test('resolves full profile — returns sentinel', () => { const manifest = loadSkillsManifest(REAL_COMMANDS_DIR); const result = resolveProfile({ modes: ['full'], manifest });