* docs(adr): add ADR-0003 model catalog module * fix(#3229): add shared model catalog as source of truth for agent profiles and runtime tier defaults Research / design (ADR-0003): - Existing drift came from 4 independent model truths: 1. CJS model-profiles.cjs 2. SDK config-query.ts stale copy (18 agents) 3. settings-advanced.md runtime tier table 4. session-runner Claude-only profile map - New design: one machine-readable Model Catalog Module in sdk/shared/ that both packages ship and consume. Implementation: - sdk/shared/model-catalog.json — canonical source of truth for: - full 33-agent registry - per-agent golden (quality) alias + balanced/budget aliases - adaptive derivation from routingTier - agent→phaseType map - agent→dynamic-routing default tier map - runtime tier defaults for all supported runtimes - get-shit-done/bin/lib/model-catalog.cjs — CJS adapter over the catalog - sdk/src/model-catalog.ts — SDK adapter over the same catalog - CJS model-profiles.cjs now re-exports derived data from model-catalog.cjs - SDK config-query.ts now re-exports MODEL_PROFILES/VALID_PROFILES from model-catalog.ts instead of maintaining its own list - sdk/src/query/helpers.ts runtime list now comes from the catalog (fixes hermes drift) - sdk/src/session-runner.ts Claude profile→model-id mapping now resolves via catalog - docs/CONFIGURATION.md + settings-advanced.md runtime tables updated to match catalog Behavior changes: - resolve-model now covers every shipped agent file on disk (33 agents) - unknown-agent fallback is profile-semantic, not hardcoded sonnet: quality→opus, budget→haiku, balanced/adaptive→sonnet, inherit→inherit - Group B runtimes remain known runtimes but do not get built-in tier defaults Tests (RED→GREEN): - root tests: shipped agent files must equal MODEL_PROFILES keys - sdk tests: shipped agent files must equal MODEL_PROFILES keys - direct fix assertion: gsd-code-reviewer resolves to opus under quality with no unknown_agent - runtime defaults parity test: settings-advanced.md + CONFIGURATION.md tables must match catalog - helper tests: hermes included in SUPPORTED_RUNTIMES and getRuntimeConfigDir() Closes #3229 * chore(changeset): update #3229 changeset pr field to 3230 * fix(ci): update inherit fallback expectations and inventory parity for model catalog
This commit is contained in:
@@ -1071,6 +1071,16 @@ describe('resolve-model command', () => {
|
||||
assert.strictEqual(output.unknown_agent, undefined, 'should not have unknown_agent for known agent');
|
||||
});
|
||||
|
||||
test('shipped-but-previously-missing agent resolves under quality profile (#3229)', () => {
|
||||
fs.writeFileSync(path.join(tmpDir, '.planning', 'config.json'), JSON.stringify({ model_profile: 'quality' }));
|
||||
const result = runGsdTools('resolve-model gsd-code-reviewer', tmpDir);
|
||||
assert.ok(result.success, `Command failed: ${result.error}`);
|
||||
const output = JSON.parse(result.output);
|
||||
assert.strictEqual(output.model, 'opus');
|
||||
assert.strictEqual(output.profile, 'quality');
|
||||
assert.strictEqual(output.unknown_agent, undefined);
|
||||
});
|
||||
|
||||
test('unknown agent returns unknown_agent=true', () => {
|
||||
const result = runGsdTools('resolve-model fake-nonexistent-agent', tmpDir);
|
||||
assert.ok(result.success, `Command failed: ${result.error}`);
|
||||
@@ -1079,6 +1089,24 @@ describe('resolve-model command', () => {
|
||||
assert.strictEqual(output.unknown_agent, true, 'should flag unknown agent');
|
||||
});
|
||||
|
||||
test('unknown agent uses quality-semantic fallback (opus)', () => {
|
||||
fs.writeFileSync(path.join(tmpDir, '.planning', 'config.json'), JSON.stringify({ model_profile: 'quality' }));
|
||||
const result = runGsdTools('resolve-model fake-nonexistent-agent', tmpDir);
|
||||
assert.ok(result.success, `Command failed: ${result.error}`);
|
||||
const output = JSON.parse(result.output);
|
||||
assert.strictEqual(output.model, 'opus');
|
||||
assert.strictEqual(output.unknown_agent, true);
|
||||
});
|
||||
|
||||
test('unknown agent uses budget-semantic fallback (haiku)', () => {
|
||||
fs.writeFileSync(path.join(tmpDir, '.planning', 'config.json'), JSON.stringify({ model_profile: 'budget' }));
|
||||
const result = runGsdTools('resolve-model fake-nonexistent-agent', tmpDir);
|
||||
assert.ok(result.success, `Command failed: ${result.error}`);
|
||||
const output = JSON.parse(result.output);
|
||||
assert.strictEqual(output.model, 'haiku');
|
||||
assert.strictEqual(output.unknown_agent, true);
|
||||
});
|
||||
|
||||
test('default profile fallback when no config exists', () => {
|
||||
// tmpDir has no config.json, so defaults to balanced profile
|
||||
const result = runGsdTools('resolve-model gsd-executor', tmpDir);
|
||||
|
||||
Reference in New Issue
Block a user