golem15/msd-core
4
0
Fork 0
Code Issues 1 Pull Requests Actions 2 Packages Projects Releases Wiki Activity

fix(#4759): hooks marker warning states the will-not-load claim conditionally, like the plugin path (#4875)

Browse Source 
* test(#4759): failing-first — preserved-foreign hooks warning must not claim may-not-load for a commonjs package.json

* fix(#4759): hooks marker warning states the will-not-load claim conditionally, like the plugin path

* test(#4759): review fold-ins — assert installer output on stdout+stderr (warn is stderr), register cleanup before the spawn, add the type-less foreign case

* chore(#4759): changeset fragment

* chore(#4759): backfill changeset PR number (4875)

---------

Co-authored-by: sim <sim@local>
This commit is contained in:
Tom Boucher
2026-09-19 10:55:01 -04:00
committed by GitHub
parent d36514b816
commit 969456c46d
3 changed files with 119 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
.changeset/sturdy-seals-click.md Normal file
View File

@@ -0,0 +1,5 @@
---
type: Fixed
pr: 4875
---
**Installer stops warning that hooks may not load when they already load as CommonJS** — installing over an existing hooks/package.json that declares "type": "commonjs" (any hand-written or formatter-touched file) printed "GSD hooks may not resolve as CommonJS"; the warning now states will-not-load only for the case that is true, a declared "type": "module", matching the plugin-path wording. (#4759)