diff --git a/.changeset/2098-eos-codebuddy.md b/.changeset/2098-eos-codebuddy.md new file mode 100644 index 000000000..66cf3cb78 --- /dev/null +++ b/.changeset/2098-eos-codebuddy.md @@ -0,0 +1,6 @@ +--- +type: Changed +pr: 2169 +--- + +**CodeBuddy now wires GSD's full extended lifecycle hook set and is driven by its capability descriptor** — installing GSD into CodeBuddy now registers `SubagentStart`, `SubagentStop`, `Stop`, and `PreCompact` hooks in its `settings.json` (it previously had none of these), matching the coverage Qwen/Kimi already ship, and CodeBuddy's install is fully descriptor-driven instead of via residual hardcoded runtime branches. (#2098) diff --git a/bin/install.js b/bin/install.js index 027c6c8c6..649bddb22 100755 --- a/bin/install.js +++ b/bin/install.js @@ -6850,7 +6850,8 @@ function uninstall(isGlobal, runtime = DEFAULT_RUNTIME) { // destructure). #2095: isKimi likewise dropped — kimi is now a hooks/ // consumer, so its former `&& !isKimi` uninstall guards were removed. // #2096: isAntigravity dropped — unused in this function. - const { isOpencode, isCodex, isCopilot, isCursor, isWindsurf, isAugment, isQwen, isHermes, isCodebuddy, isCline } = runtimeFlags(runtime); + // #2098: isCodebuddy dropped — unused in this function. + const { isOpencode, isCodex, isCopilot, isCursor, isWindsurf, isAugment, isQwen, isHermes, isCline } = runtimeFlags(runtime); const dirName = getDirName(runtime); // Get the target directory based on runtime and install type. Cline local @@ -8221,7 +8222,8 @@ function writeManifest(configDir, runtime = DEFAULT_RUNTIME, options = {}) { // #2095: isKimi dropped — kimi is now a hooks/ consumer like every other // settings-json-adjacent runtime, so the `&& !isKimi` term below was removed. // #2096: isAntigravity dropped — unused in this function. - const { isOpencode, isCodex, isCopilot, isCursor, isWindsurf, isAugment, isQwen, isHermes, isCodebuddy, isCline } = runtimeFlags(runtime); + // #2098: isCodebuddy dropped — unused in this function. + const { isOpencode, isCodex, isCopilot, isCursor, isWindsurf, isAugment, isQwen, isHermes, isCline } = runtimeFlags(runtime); const gsdDir = path.join(configDir, 'gsd-core'); // #1367: Claude local now writes flat gsd-*.md files at commands/ (not commands/gsd/). // Claude local uses flatCommandsDir instead for manifest recording. @@ -8732,7 +8734,11 @@ function install(isGlobal, runtime = DEFAULT_RUNTIME, options = {}) { // _DESCRIPTOR_AGENTS_RUNTIMES below, so its two legacy-agent-loop branches // (the path-rewrite skip and the converter dispatch) were unreachable dead // code; both were removed rather than re-gated on hostBehaviors. - const { isOpencode, isZcode, isCodex, isCopilot, isCursor, isWindsurf, isAugment, isTrae, isQwen, isHermes, isCodebuddy, isCline } = runtimeFlags(runtime); + // #2098: isCodebuddy dropped — codebuddy is also in + // _DESCRIPTOR_AGENTS_RUNTIMES below, so its legacy converter-dispatch branch + // (the `isCodebuddy` arm calling convertClaudeAgentToCodebuddyAgent) was + // unreachable dead code and was removed rather than re-gated. + const { isOpencode, isZcode, isCodex, isCopilot, isCursor, isWindsurf, isAugment, isTrae, isQwen, isHermes, isCline } = runtimeFlags(runtime); const plan = resolveInstallPlan(runtime); const dirName = getDirName(runtime); const src = path.join(__dirname, '..'); @@ -9351,22 +9357,6 @@ function install(isGlobal, runtime = DEFAULT_RUNTIME, options = {}) { failures.push('commands/gsd-*'); } } - - // CodeBuddy only: also report the commands/ output (#789 — slash commands) - if (isCodebuddy) { - const commandsDir = path.join(targetDir, 'commands'); - if (fs.existsSync(commandsDir)) { - const cmdCount = fs.readdirSync(commandsDir) - .filter(f => f.startsWith('gsd-') && f.endsWith('.md')).length; - if (cmdCount > 0) { - console.log(` ${green}✓${reset} Installed ${cmdCount} slash commands to commands/`); - } else { - failures.push('commands/gsd-*'); - } - } else { - failures.push('commands/gsd-*'); - } - } } } else if (_hostBehaviors(runtime).localCommandsViaRules) { // Cline local install: rules-based only — commands are embedded in .clinerules (generated below). @@ -9671,8 +9661,6 @@ function install(isGlobal, runtime = DEFAULT_RUNTIME, options = {}) { content = convertClaudeAgentToCopilotAgent(content, isGlobal); } else if (isWindsurf) { content = convertClaudeAgentToWindsurfAgent(content); - } else if (isCodebuddy) { - content = convertClaudeAgentToCodebuddyAgent(content); } else if (_hostBehaviors(runtime).frontmatterDialect === 'cline') { // Descriptor-driven (ADR-1239 / #2090): folded from `isCline` into // hostBehaviors.frontmatterDialect === 'cline'. @@ -10880,7 +10868,8 @@ function finishInstall(settingsPath, settings, statuslineCommand, shouldInstallS // #2095: isKimi dropped — the Kimi "Done!" banner below reads // _hostBehaviors(runtime).doneBannerStyle === 'kimi-agent-file' (descriptor-driven), not this flag. // #2096: isAntigravity dropped — unused in this function. - const { isOpencode, isCodex, isCopilot, isCursor, isWindsurf, isAugment, isQwen, isHermes, isCodebuddy, isCline } = runtimeFlags(runtime); + // #2098: isCodebuddy dropped — unused in this function. + const { isOpencode, isCodex, isCopilot, isCursor, isWindsurf, isAugment, isQwen, isHermes, isCline } = runtimeFlags(runtime); const plan = resolveInstallPlan(runtime); if (shouldInstallStatusline && plan.writesSharedSettings && !_hostBehaviors(runtime).skipSettingsUi) { diff --git a/capabilities/codebuddy/capability.json b/capabilities/codebuddy/capability.json index 15d0212a3..c8abf8601 100644 --- a/capabilities/codebuddy/capability.json +++ b/capabilities/codebuddy/capability.json @@ -81,7 +81,12 @@ "installSurface": "settings-json", "writesSharedSettings": true, "permissionWriter": null, - "extendedHookEvents": [], + "extendedHookEvents": [ + "SubagentStop", + "Stop", + "PreCompact", + "SubagentStart" + ], "hostIntegration": { "embeddingMode": "declarative", "commandSurface": "slash-file", @@ -98,6 +103,9 @@ "stateIO": "filesystem", "transport": "mcp", "runtime": "node" + }, + "hostBehaviors": { + "reportCommandsDir": true } } } diff --git a/docs/how-to/install-on-your-runtime.md b/docs/how-to/install-on-your-runtime.md index 70fc779f6..5db6c9f9a 100644 --- a/docs/how-to/install-on-your-runtime.md +++ b/docs/how-to/install-on-your-runtime.md @@ -353,6 +353,22 @@ npx @opengsd/gsd-core@latest --codebuddy --global GSD installs four surfaces. Slash command definitions land in `~/.codebuddy/commands/gsd-*.md` and appear as `/gsd-help`, `/gsd-phase`, `/gsd-ship`, etc. in the `/` menu. Subagents land in `~/.codebuddy/agents/gsd-*.md`. Skills land in `~/.codebuddy/skills/gsd-*/SKILL.md` — emitted with `user-invocable: false` so they stay out of the `/` menu (the commands surface is the sole `/` entry point) and remain available for model invocation. CodeBuddy hooks are written to `settings.json`. No `mcp.json` is written: GSD ships no MCP server. +**Hook coverage** + +GSD registers the following events automatically on install (Claude hook event dialect): + +| Event | Hook | Purpose | +|---|---|---| +| `SessionStart` | `gsd-check-update.js`, `gsd-session-state.sh` | Update check, session orientation | +| `PreToolUse` | `gsd-prompt-guard.js`, `gsd-read-guard.js`, `gsd-workflow-guard.js`, `gsd-worktree-path-guard.js`, `gsd-validate-commit.sh` | Prompt guard, read-before-edit, workflow + worktree safety, commit validation | +| `PostToolUse` | `gsd-context-monitor.js`, `gsd-read-injection-scanner.js`, `gsd-phase-boundary.sh`, `gsd-graphify-update.sh` | Context monitoring, read-time scan, phase boundary detection | +| `SubagentStop` | `gsd-context-monitor.js` | Context headroom tracking after subagent completion | +| `SubagentStart` | `gsd-context-monitor.js` | Context headroom tracking at subagent start | +| `Stop` | `gsd-context-monitor.js` | Context headroom tracking before model stop | +| `PreCompact` | `gsd-context-monitor.js` | Context awareness before conversation compaction | + +CodeBuddy's own [background sub-agent dispatch](https://www.codebuddy.ai/docs/cli/sub-agents) (`run_in_background: true`) is a caller-side invocation parameter, not something GSD's installed agent files control — there is no frontmatter field to set on GSD's agent artifacts to request it. + --- ### Qwen Code diff --git a/docs/reference/host-integration-capability-matrix.md b/docs/reference/host-integration-capability-matrix.md index 1898c9215..375c7e00f 100644 --- a/docs/reference/host-integration-capability-matrix.md +++ b/docs/reference/host-integration-capability-matrix.md @@ -427,6 +427,8 @@ Sources consulted: - https://www.codebuddy.ai/docs/cli/settings - /websites/codebuddy_cn (Context7) +**EoS migration status (#2098):** Migrated onto the declarative adapter (dogfooded in `tests/declarative-reference-codebuddy.test.cjs`). The two remaining `isCodebuddy` branches in `bin/install.js` — a duplicate `commands/` slash-command output report, and a dead legacy agent-converter dispatch arm (unreachable since codebuddy is in `_DESCRIPTOR_AGENTS_RUNTIMES`) — were folded onto the already-generic `runtime.hostBehaviors.reportCommandsDir` (shared with Cursor) and removed outright; `isCodebuddy` no longer appears as a live read anywhere in `bin/install.js`, `src/runtime-artifact-conversion.cts`, `src/shell-command-projection.cts`, or `src/runtime-name-policy.cts`. Two upgrades land: (1) **extended hook events** — codebuddy's `extendedHookEvents` was previously `[]` (none wired); this PR wires all four — `SubagentStop`/`Stop`/`PreCompact`/`SubagentStart` — into `extendedHookEvents` (mirrors qwen/kimi), so an install now registers all four as hooks in `settings.json` alongside the pre-existing base session/tool events (`SessionStart`/`PreToolUse`/`PostToolUse`); cite https://www.codebuddy.ai/docs/cli/hooks. (2) **`dispatch.background`** — the descriptor already declared `true`, exceeding the `declarative-cli` profile baseline of `false`; the negotiation contract (`negotiateHostCapabilities`) now surfaces that value with no downgrade warning, documenting the legitimate deviation. Note: the CodeBuddy CLI has no background-dispatch frontmatter field on sub-agents (`agentMode`/`enabledAutoRun` are IDE-only per https://www.codebuddy.ai/docs/cli/sub-agents) — background dispatch remains a caller-side invocation parameter (`run_in_background: true`), not a field GSD's agent artifacts emit. + --- ## copilot diff --git a/gsd-core/bin/lib/capability-registry.cjs b/gsd-core/bin/lib/capability-registry.cjs index e5c62b7a7..439e4e193 100644 --- a/gsd-core/bin/lib/capability-registry.cjs +++ b/gsd-core/bin/lib/capability-registry.cjs @@ -788,7 +788,12 @@ const capabilities = { "installSurface": "settings-json", "writesSharedSettings": true, "permissionWriter": null, - "extendedHookEvents": [], + "extendedHookEvents": [ + "SubagentStop", + "Stop", + "PreCompact", + "SubagentStart" + ], "hostIntegration": { "embeddingMode": "declarative", "commandSurface": "slash-file", @@ -805,6 +810,9 @@ const capabilities = { "stateIO": "filesystem", "transport": "mcp", "runtime": "node" + }, + "hostBehaviors": { + "reportCommandsDir": true } } }, @@ -4237,7 +4245,12 @@ const runtimes = { "installSurface": "settings-json", "writesSharedSettings": true, "permissionWriter": null, - "extendedHookEvents": [], + "extendedHookEvents": [ + "SubagentStop", + "Stop", + "PreCompact", + "SubagentStart" + ], "hostIntegration": { "embeddingMode": "declarative", "commandSurface": "slash-file", @@ -4254,6 +4267,9 @@ const runtimes = { "stateIO": "filesystem", "transport": "mcp", "runtime": "node" + }, + "hostBehaviors": { + "reportCommandsDir": true } } }, diff --git a/tests/codebuddy-upgrades.test.cjs b/tests/codebuddy-upgrades.test.cjs new file mode 100644 index 000000000..a727258a1 --- /dev/null +++ b/tests/codebuddy-upgrades.test.cjs @@ -0,0 +1,128 @@ +'use strict'; + +/** + * CodeBuddy capability UPGRADES — ADR-1239 / #2098 (EoS/codebuddy). + * + * Drives the user-reachable surface (spawned `bin/install.js` via + * `runMinimalInstall`) plus a direct negotiation-contract check to prove the + * two real upgrades CodeBuddy contributes as part of the EoS migration: + * + * UPGRADE 1 — extended hook events: CodeBuddy's `extendedHookEvents` was + * previously `[]` (none of the 4 extended events were wired). This PR + * wires all four — `SubagentStop`/`Stop`/`PreCompact`/`SubagentStart` — + * into `extendedHookEvents` (mirrors qwen #2092 / kimi exactly — same 4 + * events), so a live install registers all four as hooks in settings.json + * routed through gsd-context-monitor.js, giving CodeBuddy the + * subagent-lifecycle + stop/compact hooks it previously lacked. + * + * UPGRADE 2 — dispatch.background: CodeBuddy's capability.json already + * declares `dispatch.background: true`, which legitimately EXCEEDS the + * `declarative-cli` profile baseline (`false`, per + * `PROFILE_BASELINES['declarative-cli']` in src/host-integration.cts). + * NO agent-file/frontmatter change is involved — the CodeBuddy CLI has no + * background-dispatch frontmatter field (agentMode/enabledAutoRun are + * IDE-only; verified via codebuddy.ai/docs/cli/sub-agents). This is + * surfaced purely through the negotiated contract: a documented `true` + * value must survive negotiation without a downgrade warning. + */ + +const { test } = require('node:test'); +const assert = require('node:assert/strict'); +const fs = require('node:fs'); +const path = require('node:path'); + +const { runMinimalInstall } = require('./helpers/install-shared.cjs'); +const { cleanup } = require('./helpers.cjs'); +const { + profileOf, + negotiateHostCapabilities, + PROFILE_BASELINES, +} = require('../gsd-core/bin/lib/host-integration.cjs'); + +const CODEBUDDY_CAP = JSON.parse( + fs.readFileSync(path.join(__dirname, '..', 'capabilities', 'codebuddy', 'capability.json'), 'utf8'), +); +const CODEBUDDY_AXES = CODEBUDDY_CAP.runtime.hostIntegration; + +// --------------------------------------------------------------------------- +// UPGRADE 1: extended hook events — all 4 newly-wired events' live-install coverage +// --------------------------------------------------------------------------- + +test('capabilities/codebuddy/capability.json extendedHookEvents contains exactly the 4 documented events', () => { + const events = CODEBUDDY_CAP.runtime.extendedHookEvents; + assert.deepEqual(events, ['SubagentStop', 'Stop', 'PreCompact', 'SubagentStart']); + assert.equal(events.length, 4); +}); + +test('codebuddy --global: settings.json wires all 4 newly-added extended hook events to the GSD context-monitor hook (UPGRADE 1)', (t) => { + const { configDir, root } = runMinimalInstall({ runtime: 'codebuddy', scope: 'global' }); + t.after(() => cleanup(root)); + + const settingsPath = path.join(configDir, 'settings.json'); + assert.ok(fs.existsSync(settingsPath), `${settingsPath} must exist`); + const settings = JSON.parse(fs.readFileSync(settingsPath, 'utf8')); + + // All 4 events were newly wired by this PR — codebuddy's extendedHookEvents + // was previously [], so none of these existed before #2098. + const NEWLY_WIRED_EXTENDED_EVENTS = ['SubagentStop', 'Stop', 'PreCompact', 'SubagentStart']; + + const entries = NEWLY_WIRED_EXTENDED_EVENTS.map((eventName) => { + const eventHooks = settings.hooks && settings.hooks[eventName]; + assert.ok(Array.isArray(eventHooks) && eventHooks.length > 0, + `settings.hooks.${eventName} must exist and be non-empty`); + const entry = eventHooks[0].hooks[0]; + assert.ok(entry.command.includes('gsd-context-monitor'), + `${eventName} command must reference gsd-context-monitor.js, got: ${entry.command}`); + assert.equal(entry.timeout, 10, `${eventName} entry must have timeout 10`); + return entry; + }); + + const [stopEntry, ...restEntries] = entries; + for (const entry of restEntries) { + assert.equal(entry.command, stopEntry.command, + 'all 4 newly-wired extended events must wire the same gsd-context-monitor command'); + } +}); + +test('a runtime whose extendedHookEvents omits SubagentStart does NOT get one (descriptor-gated, not a global default)', (t) => { + const { configDir, root } = runMinimalInstall({ runtime: 'claude', scope: 'global' }); + t.after(() => cleanup(root)); + + const settingsPath = path.join(configDir, 'settings.json'); + const settings = JSON.parse(fs.readFileSync(settingsPath, 'utf8')); + + assert.ok( + settings.hooks && Array.isArray(settings.hooks.SubagentStop) && settings.hooks.SubagentStop.length > 0, + 'claude must have SubagentStop wired (sanity — proves hooks ARE configured)', + ); + assert.ok( + !settings.hooks || settings.hooks.SubagentStart === undefined, + "claude must NOT have SubagentStart wired — it is not in claude's extendedHookEvents", + ); +}); + +// --------------------------------------------------------------------------- +// UPGRADE 2: dispatch.background negotiation — documented true survives, +// exceeding the declarative-cli profile baseline. No agent-file/frontmatter +// change; caller-side invocation param only (no code path emits it). +// --------------------------------------------------------------------------- + +test("codebuddy classifies as the 'declarative-cli' profile, whose baseline dispatch.background is false", () => { + assert.equal(profileOf(CODEBUDDY_AXES), 'declarative-cli'); + assert.equal(PROFILE_BASELINES['declarative-cli'].dispatch.background, false, + 'sanity: the declarative-cli baseline is false — codebuddy legitimately exceeds it'); +}); + +test('negotiateHostCapabilities surfaces codebuddy\'s documented dispatch.background:true with no downgrade warning (UPGRADE 2)', () => { + assert.equal(CODEBUDDY_AXES.dispatch.background, true, + 'sanity: the descriptor declares dispatch.background: true (documented, not undocumented)'); + + const { effective, warnings } = negotiateHostCapabilities(CODEBUDDY_AXES); + + assert.equal(effective.dispatch.background, true, + 'a documented true value must survive negotiation, exceeding the declarative-cli baseline of false'); + assert.ok( + !warnings.some((w) => w.includes('dispatch.background')), + `no warning may be raised for the documented dispatch.background axis, got: ${JSON.stringify(warnings)}`, + ); +}); diff --git a/tests/declarative-reference-codebuddy.test.cjs b/tests/declarative-reference-codebuddy.test.cjs new file mode 100644 index 000000000..b27a59c38 --- /dev/null +++ b/tests/declarative-reference-codebuddy.test.cjs @@ -0,0 +1,155 @@ +// allow-test-rule: structural-regression-guard — AC2: assert no `runtime === 'codebuddy'` string-equality branch, no `isCodebuddy` conversion helper, no `canonical === 'codebuddy'` branch remains in bin/install.js, src/runtime-artifact-conversion.cts, src/shell-command-projection.cts, src/runtime-name-policy.cts — a source-text property, so source-grep is the faithful check (#2098) +'use strict'; + +/** + * Declarative reference host — CodeBuddy (#2098 / ADR-1239 EoS). + * + * CodeBuddy already installs through the descriptor-driven artifactLayout + * (commands/skills/agents, each with a named `converter`), and its + * capability.json already declares `hostIntegration` + `dispatch` axes. + * Unlike antigravity/qwen (#2096/#2092), CodeBuddy was NOT migrated off a + * legacy runtime-keyed branch chain wholesale — issue #2098 found it was + * already descriptor-driven except for two residual `isCodebuddy` branches + * in bin/install.js: + * 1. a duplicate `commands/` slash-command output report (byte-identical + * to the generic `hostBehaviors.reportCommandsDir` block already used + * by Cursor) — folded onto `hostBehaviors.reportCommandsDir` and deleted. + * 2. a dead legacy agent-converter dispatch arm in the inline agent-copy + * loop, unreachable because codebuddy is a member of + * `_DESCRIPTOR_AGENTS_RUNTIMES` (installRuntimeArtifacts already wrote + * the agents before that loop runs) — deleted outright. + * + * This test is the reference-host dogfood mirroring + * tests/declarative-reference-antigravity.test.cjs: it (1) classifies + * CodeBuddy's profile via profileOf, (2) confirms the public declarative + * adapter classifies it as declarative, (3) round-trips a real install + * proving a gsd command surface is emitted, (4) proves negotiation fails + * CLOSED on a corrupted descriptor, (5) proves the validator accepts the + * descriptor, and (6) source-greps the folded modules for the retired + * `isCodebuddy` branches (AC2). + * + * UPGRADE 1 (extended hook events) + UPGRADE 2 (dispatch.background + * negotiation) live-install coverage is in tests/codebuddy-upgrades.test.cjs + * — not duplicated here. + */ + +const { test, before } = require('node:test'); +const assert = require('node:assert/strict'); +const fs = require('node:fs'); +const path = require('node:path'); +const { execFileSync } = require('node:child_process'); + +const { + profileOf, + negotiateHostCapabilities, + PROFILE_BASELINES, + UNDOCUMENTED, +} = require('../gsd-core/bin/lib/host-integration.cjs'); +const { validateCapability } = require('../gsd-core/bin/lib/capability-validator.cjs'); +const { createDeclarativeAdapter } = require('../gsd-core/bin/lib/adapter-declarative.cjs'); +const { cleanup } = require('./helpers.cjs'); +const { walk, runMinimalInstall, BUILD_SCRIPT } = require('./helpers/install-shared.cjs'); + +const DESC = path.join(__dirname, '..', 'capabilities', 'codebuddy', 'capability.json'); +const CODEBUDDY_CAP = JSON.parse(fs.readFileSync(DESC, 'utf8')); +const CODEBUDDY_AXES = CODEBUDDY_CAP.runtime.hostIntegration; + +// hooks/dist is gitignored and built (mirrors golden-install-parity harness). +before(() => { + execFileSync(process.execPath, [BUILD_SCRIPT], { encoding: 'utf-8', stdio: 'pipe' }); +}); + +test('CodeBuddy classifies as the declarative-cli reference profile (profileOf)', () => { + const desc = JSON.parse(fs.readFileSync(DESC, 'utf8')); + const axes = desc.runtime.hostIntegration; + assert.ok(axes && axes.embeddingMode, 'codebuddy descriptor declares hostIntegration axes'); + assert.equal(profileOf(axes), 'declarative-cli', + 'CodeBuddy is a Declarative-CLI host'); +}); + +test('the public declarative adapter classifies CodeBuddy as a declarative host', () => { + const adapter = createDeclarativeAdapter({ runtime: 'codebuddy' }); + assert.equal(adapter.kind, 'declarative'); + assert.equal(adapter.runtime, 'codebuddy'); + assert.equal(typeof adapter.install, 'function'); + assert.equal(typeof adapter.uninstall, 'function'); +}); + +test('a real CodeBuddy install emits a gsd command/skill surface (invocable)', () => { + const { configDir, root } = runMinimalInstall({ runtime: 'codebuddy', scope: 'global' }); + try { + const files = walk(configDir); + assert.ok(files.length > 0, 'install must emit artifacts'); + // CodeBuddy uses a flat commands/gsd-*.md slash-command surface + // (CONTEXT.md installer module; capabilities/codebuddy/capability.json + // artifactLayout `kind: "commands"`). + const gsdSurface = files.filter((f) => /gsd/i.test(path.relative(configDir, f))); + assert.ok(gsdSurface.length > 0, + 'install must emit a gsd command/skill surface (declarative reference)'); + const commandsDir = path.join(configDir, 'commands'); + assert.ok(fs.existsSync(commandsDir), 'commands/ directory must exist'); + const cmdFiles = fs.readdirSync(commandsDir) + .filter((f) => f.startsWith('gsd-') && f.endsWith('.md')); + assert.ok(cmdFiles.length > 0, 'commands/ must contain gsd-*.md slash commands'); + } finally { + cleanup(root); + } +}); + +// --------------------------------------------------------------------------- +// #2098 EoS/codebuddy — fail-closed negotiation + validator acceptance + +// the folded descriptor (mirrors antigravity/qwen reference tests). +// --------------------------------------------------------------------------- + +test('negotiateHostCapabilities never throws for codebuddy, even fully corrupted', () => { + assert.doesNotThrow(() => negotiateHostCapabilities({})); + assert.doesNotThrow(() => negotiateHostCapabilities({ ...CODEBUDDY_AXES, embeddingMode: UNDOCUMENTED })); + assert.doesNotThrow(() => negotiateHostCapabilities({ ...CODEBUDDY_AXES, embeddingMode: 'future-unknown' })); + assert.doesNotThrow(() => negotiateHostCapabilities({ ...CODEBUDDY_AXES, dispatch: 'corrupted-not-an-object' })); + assert.doesNotThrow(() => negotiateHostCapabilities({ ...CODEBUDDY_AXES, dispatch: { ...CODEBUDDY_AXES.dispatch, maxDepth: 'not-a-number' } })); +}); + +test('a partial/empty codebuddy descriptor degrades to the safe floor, not the declarative-cli baseline', () => { + const result = negotiateHostCapabilities({}); + assert.equal(result.effective.embeddingMode, 'declarative', 'omitted embeddingMode degrades closed'); + assert.equal(result.effective.hookBus, 'none'); + assert.notDeepEqual(result.effective, PROFILE_BASELINES['declarative-cli']); + assert.ok(result.warnings.length > 0); +}); + +test('capabilities/codebuddy/capability.json validates — no errors', () => { + const errors = validateCapability(CODEBUDDY_CAP, 'codebuddy'); + assert.deepEqual(errors, [], `validateCapability must return no errors, got: ${JSON.stringify(errors)}`); +}); + +// -- AC2: the hardcoded branches are retired across all folded modules ------- + +test('no `runtime === "codebuddy"` string-equality branch (nor `isCodebuddy` conversion helper / `canonical === "codebuddy"`) remains in the descriptor-migrated modules (AC2)', () => { + const strip = (src) => src + .replace(/\/\*[\s\S]*?\*\//g, '') + .replace(/\/\/[^\r\n]*/g, '') + .replace(/`[^`]*`/g, ''); + const repoRoot = path.join(__dirname, '..'); + const files = [ + path.join(repoRoot, 'bin', 'install.js'), + path.join(repoRoot, 'src', 'runtime-artifact-conversion.cts'), + path.join(repoRoot, 'src', 'shell-command-projection.cts'), + path.join(repoRoot, 'src', 'runtime-name-policy.cts'), + ]; + for (const file of files) { + const src = fs.readFileSync(file, 'utf8'); + const stripped = strip(src); + + const eqOffenders = stripped.match(/runtime\s*[!=]==\s*'codebuddy'/g) || []; + assert.deepEqual(eqOffenders, [], + `AC2: no hardcoded runtime==='codebuddy' branch may remain in ${path.relative(repoRoot, file)}; found: ${eqOffenders.join(', ')}`); + + const isCodebuddyHits = stripped.match(/\bisCodebuddy\b/g) || []; + assert.deepEqual(isCodebuddyHits, [], + `AC2: no live isCodebuddy read may remain in ${path.relative(repoRoot, file)}; found ${isCodebuddyHits.length} occurrence(s)`); + + const canonicalOffenders = stripped.match(/canonical\s*===\s*'codebuddy'/g) || []; + assert.deepEqual(canonicalOffenders, [], + `AC2: no canonical==='codebuddy' branch may remain in ${path.relative(repoRoot, file)}; found: ${canonicalOffenders.join(', ')}`); + } +});