golem15/msd-core
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(#2103): drive VS Code through the Embeddable Orchestration System (ADR-1239)

Browse Source 
VS Code is a net-new EoS runtime that — unlike every prior migration — is NOT
CLI-installed (Marketplace/VSIX extension). It has zero runtime==='vscode'
branches in bin/install.js and stays that way (regression-guarded); it is driven
entirely through the negotiated imperative Host-Integration adapter.

Registry + validator (the hard part):
- capabilities/vscode/capability.json (role:runtime): full hostIntegration block
  (imperative / palette / active vscode.lm model / engine hook bus /
  sandboxed-storage / mcp transport / sandboxed-web runtime; dispatch nested,
  maxDepth 5 per VS Code's documented subagent depth).
- capability-validator.cjs extended so a role:runtime capability can legitimately
  declare "extension-distributed, no config directory": new configHome.kind:'none'
  + installSurface:'none' (+ GATE-A pairing + the parity maps), with localConfigDir
  and configHome.name made conditional on kind!=='none'. All 18 runtimes still
  validate; getDirName returns a distinct sentinel (not '.claude') for a no-config
  runtime.
- The add-a-registry-runtime tax: NON_INSTALLABLE_RUNTIMES exemption in the
  runtime-flags drift guard, vscode added to global-config-home SPECIAL_CASED,
  EXPECTED_PROFILES.vscode='ide', and the config-adapter/derivation/pin-count
  guards updated. No golden-install fixture, model-catalog, or CONFIGURATION rows
  (vscode never enters allRuntimes).

Dispatch + extension surface:
- Fixed vscode/extension.js's createHub()-no-args bug (every dispatch was
  UnknownCommand, masked by a vacuous reachability test) — now reuses the shared
  dispatchGsdCommand subprocess-shim (Node/desktop); the reachability test is
  tightened to assert real dispatch.
- Promoted the #1933 host binding to a shipped vscode/host-binding.js; activate()
  now composes the model/hookBus/stateIO seams through it. Corrected the model
  seam to VS Code's real API (vscode.lm.selectChatModels() -> model.sendRequest();
  vscode.lm.sendRequest does not exist) so the binding actually composes on real
  desktop VS Code instead of throwing.
- New vscode/browser.js Web Extension entry with ZERO Node APIs (the engine's
  config/capability loading is Node-bound, so the web entry registers the surface
  and directs full dispatch to the native MCP server — honestly documented).
- UPGRADE 1: GSD skills as native Language Model Tools (contributes.languageModelTools
  + vscode.lm.registerTool), invoke() dispatching through the hub.
- UPGRADE 2: native subagent dispatch wired onto #runSubagent /
  chat.subagents.allowInvocationsFromSubagents (fail-soft on API availability,
  maxDepth 5 enforced).
- vscode/package.json: browser entry, engines.vscode ^1.105, chatParticipants +
  languageModelTools contributions; fixed a stale activationPoints->activationEvents
  manifest key. Added "vscode" to the package files array.

Docs (## vscode matrix section) + changeset (Added).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
Tom Boucher
2026-07-11 22:35:18 -04:00
parent 97297d7e3f
commit a0fafedfa0
28 changed files with 1973 additions and 157 deletions
Download Patch File Download Diff File Expand all files Collapse all files

112
tests/vscode-ide-reference.test.cjs
View File

@@ -18,8 +18,9 @@
const { test } = require('node:test');
const assert = require('node:assert/strict');
const { profileOf } = require('../gsd-core/bin/lib/host-integration.cjs');
const { profileOf, negotiateHostCapabilities } = require('../gsd-core/bin/lib/host-integration.cjs');
const bindGsdToVscode = require('./fixtures/vscode-host-binding.cjs');
const registry = require('../gsd-core/bin/lib/capability-registry.cjs');
test('VS Code IDE axes classify as the ide profile', () => {
// ide baseline (host-integration.cts PROFILE_BASELINES): imperative + sandboxed-web.
@@ -27,10 +28,17 @@ test('VS Code IDE axes classify as the ide profile', () => {
assert.notEqual(profileOf({ embeddingMode: 'imperative', runtime: 'node' }), 'ide');
});
test('bindGsdToVscode composes the full IDE profile (active model + engine bus + sandboxed state + imperative adapter)', () => {
test('bindGsdToVscode composes the full IDE profile (active model + engine bus + sandboxed state + imperative adapter)', async () => {
// Real API: vscode.lm.selectChatModels() (async → LanguageModelChat[]); the
// SELECTED MODEL has .sendRequest, NOT vscode.lm itself (#2103 correction —
// there is no vscode.lm.sendRequest).
let lastLmReq = null;
const vscode = {
lm: { sendRequest: (req) => { lastLmReq = req; return 'lm-response'; } },
lm: {
selectChatModels: async () => [
{ sendRequest: (req) => { lastLmReq = req; return 'lm-response'; } },
],
},
};
const storageWrites = [];
const hostStorage = {
@@ -41,9 +49,10 @@ test('bindGsdToVscode composes the full IDE profile (active model + engine bus +
const host = bindGsdToVscode(vscode, hostStorage);
assert.equal(host.runtime, 'vscode');
// Active model routes through vscode.lm (no system messages — User role only).
// Active model routes through vscode.lm.selectChatModels() → model.sendRequest
// (no system messages — User role only).
assert.equal(host.model.mode, 'active');
assert.equal(host.model.sendRequest({ prompt: 'hi' }), 'lm-response');
assert.equal(await host.model.sendRequest({ prompt: 'hi' }), 'lm-response');
assert.deepEqual(lastLmReq, { prompt: 'hi' });
// Engine-owned hook bus: in-process pub/sub (VS Code has no host bus).
@@ -67,9 +76,30 @@ test('bindGsdToVscode composes the full IDE profile (active model + engine bus +
assert.ok(host.commands['gsd.invoke'], 'palette/chat command surface present');
});
// #2103: proves the binding actually COMPOSES (does not throw) against a
// realistic desktop VS Code `vscode.lm` shape — the whole point of the guard
// fix: a real host has `selectChatModels`, never `sendRequest` directly, and
// the binding must succeed, not silently fail-open at the extension.js layer.
test('#2103: bindGsdToVscode composes successfully against a REALISTIC vscode.lm (selectChatModels only, no vscode.lm.sendRequest)', async () => {
const vscode = {
lm: {
selectChatModels: async () => [{ sendRequest: (req) => Promise.resolve({ echoed: req }) }],
// Deliberately no top-level sendRequest — matches the real API surface.
},
};
const hostStorage = { read: () => '', write: () => {} };
let host;
assert.doesNotThrow(() => { host = bindGsdToVscode(vscode, hostStorage); },
'bindGsdToVscode must succeed on a realistic host (selectChatModels-only vscode.lm)');
assert.equal(host.model.mode, 'active');
const response = await host.model.sendRequest({ prompt: 'hello' });
assert.deepEqual(response, { echoed: { prompt: 'hello' } });
});
test('bindGsdToVscode is fail-closed without vscode.lm or hostStorage', () => {
const okStorage = { read() {}, write() {} };
const okVscode = { lm: { sendRequest() {} } };
const okVscode = { lm: { selectChatModels: async () => [] } };
// vscode.lm missing or incomplete → vscode.lm error
assert.throws(() => bindGsdToVscode({}, okStorage), /vscode\.lm/);
assert.throws(() => bindGsdToVscode({ lm: {} }, okStorage), /vscode\.lm/);
@@ -77,3 +107,73 @@ test('bindGsdToVscode is fail-closed without vscode.lm or hostStorage', () => {
assert.throws(() => bindGsdToVscode(okVscode, null), /hostStorage/);
assert.throws(() => bindGsdToVscode(okVscode, { read() {} }), /hostStorage/);
});
test('#2103: bindGsdToVscode still throws when vscode.lm.selectChatModels is ABSENT (a vscode.lm.sendRequest-only mock, matching the OLD incorrect API assumption, must be rejected)', () => {
const okStorage = { read() {}, write() {} };
// The pre-#2103 (wrong) shape: sendRequest directly on vscode.lm, no selectChatModels.
const staleShapeVscode = { lm: { sendRequest: () => 'stale' } };
assert.throws(() => bindGsdToVscode(staleShapeVscode, okStorage), /selectChatModels/);
});
// ── #2103: negotiate fail-closed for an UNDECLARED vscode axis ──────────────
// negotiateHostCapabilities must never throw and must degrade an undeclared
// (missing) axis to its most-restrictive documented default — the same
// fail-closed contract already proven for the "undocumented" sentinel
// (tests/host-integration-descriptors.test.cjs), but exercised here against a
// genuinely ABSENT key (not the string "undocumented") on vscode's real
// hostIntegration object, to prove the negotiation seam is defensive against
// both failure modes.
//
// #2103 FIX (adversarial review, MINOR): strengthened from a weak
// `!== undefined` check to a STRICT equality against the actual
// most-restrictive value negotiateHostCapabilities produces — the fail-closed
// floor pinned as `SAFE_DEFAULTS` in gsd-core/bin/lib/host-integration.cjs
// (not exported, so the values are pinned here verbatim, verified via node -e
// against the real negotiation output before writing this test — see the PR
// report). A `!== undefined` check would pass even if negotiation regressed
// to a WRONG-but-defined value (e.g. a less-restrictive default) — this
// assertion pins the exact known floor per the AC's own wording
// ("most-restrictive known value").
const HOST_INTEGRATION_SAFE_DEFAULTS = {
embeddingMode: 'declarative',
commandSurface: 'prose-only',
modelMode: 'passive',
hookBus: 'none',
stateIO: 'session-log-append',
transport: 'mcp',
runtime: 'node',
};
const HOST_INTEGRATION_DISPATCH_SAFE_DEFAULTS = {
namedDispatch: false,
nested: false,
maxDepth: 0,
background: false,
subagentToolkit: 'read-only',
backgroundDispatch: false,
};
test('#2103: negotiateHostCapabilities never throws for vscode with an UNDECLARED axis, and degrades to the EXACT most-restrictive SAFE_DEFAULTS value', () => {
const realHi = registry.runtimes.vscode.runtime.hostIntegration;
for (const axis of Object.keys(HOST_INTEGRATION_SAFE_DEFAULTS)) {
const undeclared = { ...realHi, dispatch: { ...realHi.dispatch } };
delete undeclared[axis];
let result;
assert.doesNotThrow(() => { result = negotiateHostCapabilities(undeclared); },
`negotiateHostCapabilities must not throw when vscode's "${axis}" axis is entirely absent`);
assert.strictEqual(result.effective[axis], HOST_INTEGRATION_SAFE_DEFAULTS[axis],
`effective.${axis} must resolve to the exact most-restrictive SAFE_DEFAULTS value "${HOST_INTEGRATION_SAFE_DEFAULTS[axis]}", got: ${JSON.stringify(result.effective[axis])}`);
}
});
test('#2103: negotiateHostCapabilities never throws for vscode with an UNDECLARED dispatch sub-axis, and degrades to the EXACT most-restrictive value', () => {
const realHi = registry.runtimes.vscode.runtime.hostIntegration;
for (const key of Object.keys(HOST_INTEGRATION_DISPATCH_SAFE_DEFAULTS)) {
const undeclared = { ...realHi, dispatch: { ...realHi.dispatch } };
delete undeclared.dispatch[key];
let result;
assert.doesNotThrow(() => { result = negotiateHostCapabilities(undeclared); },
`negotiateHostCapabilities must not throw when vscode's dispatch.${key} is entirely absent`);
assert.strictEqual(result.effective.dispatch[key], HOST_INTEGRATION_DISPATCH_SAFE_DEFAULTS[key],
`effective.dispatch.${key} must resolve to the exact most-restrictive value "${HOST_INTEGRATION_DISPATCH_SAFE_DEFAULTS[key]}", got: ${JSON.stringify(result.effective.dispatch[key])}`);
}
});