The windows-test-parity ratchet greps test source for fs.rmSync-without-
maxRetries (and six other Windows-portability anti-patterns), failing when an
integer offender COUNT exceeds a frozen baseline (rmSync: 95). A count ratchet
is a Goodhart metric: fixing one offender and adding another keeps the count
constant, so a new defect slips through green. Replace it — and every other
count ratchet in the repo — with a layered, masking-proof design.
Behavioral seam test
- tests/helpers-cleanup.test.cjs proves helpers.cleanup() carries the Windows
EBUSY retry budget. cleanup() delegates retries to Node's fs.rmSync via
maxRetries (it owns no loop), so the test asserts the option contract
(recursive/force/maxRetries>0/retryDelay>0) + real-FS removal + the cwd-guard,
rather than a loop that does not exist. The EBUSY risk is now tested ONCE at
the helper, not approximated textually at every call site.
Write-time ESLint rule (AST-accurate, replaces the grep)
- eslint-rules/no-raw-rmsync-in-tests.cjs (error in tests/**/*.test.cjs) bans
raw fs.rmSync, steering to cleanup(). Catches member, computed (fs['rmSync']),
destructured and aliased forms; escape hatch is inline
`// eslint-disable-next-line local/no-raw-rmsync-in-tests -- <reason>` only.
- Migrated 336 raw fs.rmSync teardown calls across ~116 test files to cleanup().
~18 genuinely load-bearing sites (mid-test SUT/fault-injection removals,
error-swallowing or name-colliding local teardown helpers) keep the raw call
with an inline eslint-disable + reason.
Shared anti-ratchet primitive
- scripts/lib/allowlist-ratchet.cjs:
- assertWithinAllowlist: fails on NOVEL ids (new offender introduced) AND on
STALE ids (a known offender was fixed but not pruned) — identity, not count,
and a ratchet DOWN toward zero.
- assertTightCeiling: a size/length budget whose ceiling must stay within a
grace band of the high-water mark, so budgets may only tighten, never creep.
Ratchets converted onto the primitive
- windows-test-parity-guard.test.cjs: rmSync rule deleted (now ESLint-enforced);
the remaining six patterns moved from integer baselines to named-set
allowlists with ratchet-down.
- scripts/lint-test-file-count.{cjs,allowlist.json}: per-module integer counts →
named filename sets (closes the swap-a-file-keep-the-count blind spot); a
module dropping under cap now FAILS to force pruning its allowlist entry.
- enh-2790 skill-count `<= 63` → named skill allowlist (ratchets toward ~58).
Size budgets hardened (tighten-only)
- agent-size / workflow-size / feat-3039 help-tiered: ceilings lowered to the
current high-water mark and an assertTightCeiling anti-creep check added per
tier. Fixed external-contract limits (description ≤100 chars, agent ≤100 KB)
are intentionally left as-is — they are not grandfathered creeping budgets.
No user-facing behavior change (tests + tooling only); no USER_FACING_PREFIXES
touched, so no changeset fragment is required.
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
@@ -3,10 +3,11 @@
|
||||
/**
|
||||
* eslint-rules.test.cjs
|
||||
*
|
||||
* RuleTester unit tests for the three local ESLint rules:
|
||||
* RuleTester unit tests for the local ESLint rules:
|
||||
* - local/no-source-grep
|
||||
* - local/no-magic-sleep-in-tests
|
||||
* - local/no-elapsed-assertion
|
||||
* - local/no-raw-rmsync-in-tests
|
||||
*/
|
||||
|
||||
const { test, describe } = require('node:test');
|
||||
@@ -16,6 +17,7 @@ const { RuleTester } = require('eslint');
|
||||
const noSourceGrep = require('../eslint-rules/no-source-grep.cjs');
|
||||
const noMagicSleepInTests = require('../eslint-rules/no-magic-sleep-in-tests.cjs');
|
||||
const noElapsedAssertion = require('../eslint-rules/no-elapsed-assertion.cjs');
|
||||
const noRawRmsyncInTests = require('../eslint-rules/no-raw-rmsync-in-tests.cjs');
|
||||
|
||||
const ruleTester = new RuleTester({
|
||||
languageOptions: {
|
||||
@@ -317,3 +319,173 @@ describe('no-elapsed-assertion rule', () => {
|
||||
assert.ok(true, 'no-elapsed-assertion flags assert.equal with timing comparison');
|
||||
});
|
||||
});
|
||||
|
||||
// ─── no-raw-rmsync-in-tests ──────────────────────────────────────────────────
|
||||
|
||||
describe('no-raw-rmsync-in-tests rule', () => {
|
||||
// ── INVALID cases (must error) ────────────────────────────────────────────
|
||||
|
||||
test('invalid: fs.rmSync() in a test file', () => {
|
||||
ruleTester.run('no-raw-rmsync-in-tests', noRawRmsyncInTests, {
|
||||
valid: [],
|
||||
invalid: [
|
||||
{
|
||||
code: `
|
||||
const fs = require('fs');
|
||||
fs.rmSync(tmpDir, { recursive: true, force: true });
|
||||
`,
|
||||
filename: 'tests/foo.test.cjs',
|
||||
errors: [{ messageId: 'noRawRmSync' }],
|
||||
},
|
||||
],
|
||||
});
|
||||
assert.ok(true, 'no-raw-rmsync-in-tests flags fs.rmSync() in test file');
|
||||
});
|
||||
|
||||
test('invalid: computed member fs["rmSync"]() in a test file', () => {
|
||||
ruleTester.run('no-raw-rmsync-in-tests', noRawRmsyncInTests, {
|
||||
valid: [],
|
||||
invalid: [
|
||||
{
|
||||
code: `
|
||||
const fs = require('fs');
|
||||
fs['rmSync'](d, { recursive: true, force: true });
|
||||
`,
|
||||
filename: 'tests/foo.test.cjs',
|
||||
errors: [{ messageId: 'noRawRmSync' }],
|
||||
},
|
||||
],
|
||||
});
|
||||
assert.ok(true, 'no-raw-rmsync-in-tests flags fs["rmSync"]() in test file');
|
||||
});
|
||||
|
||||
test('invalid: destructured rmSync from require("fs") in a test file', () => {
|
||||
ruleTester.run('no-raw-rmsync-in-tests', noRawRmsyncInTests, {
|
||||
valid: [],
|
||||
invalid: [
|
||||
{
|
||||
code: `
|
||||
const { rmSync } = require('fs');
|
||||
rmSync(d, { recursive: true, force: true });
|
||||
`,
|
||||
filename: 'tests/foo.test.cjs',
|
||||
errors: [{ messageId: 'noRawRmSync' }],
|
||||
},
|
||||
],
|
||||
});
|
||||
assert.ok(true, 'no-raw-rmsync-in-tests flags destructured rmSync from require("fs")');
|
||||
});
|
||||
|
||||
test('invalid: aliased const del = fs.rmSync; del() in a test file', () => {
|
||||
ruleTester.run('no-raw-rmsync-in-tests', noRawRmsyncInTests, {
|
||||
valid: [],
|
||||
invalid: [
|
||||
{
|
||||
code: `
|
||||
const fs = require('fs');
|
||||
const del = fs.rmSync;
|
||||
del(d, { recursive: true, force: true });
|
||||
`,
|
||||
filename: 'tests/foo.test.cjs',
|
||||
errors: [{ messageId: 'noRawRmSync' }],
|
||||
},
|
||||
],
|
||||
});
|
||||
assert.ok(true, 'no-raw-rmsync-in-tests flags aliased fs.rmSync');
|
||||
});
|
||||
|
||||
test('invalid: allow-test-rule annotation no longer suppresses this rule (Defect 1 fixed)', () => {
|
||||
// A file with // allow-test-rule: <source-grep reason> must still error
|
||||
// on raw rmSync calls. The file-level annotation is for no-source-grep only.
|
||||
ruleTester.run('no-raw-rmsync-in-tests', noRawRmsyncInTests, {
|
||||
valid: [],
|
||||
invalid: [
|
||||
{
|
||||
code: `
|
||||
// allow-test-rule: source-text-is-the-product
|
||||
const fs = require('fs');
|
||||
fs.rmSync(d, { recursive: true, force: true });
|
||||
`,
|
||||
filename: 'tests/foo.test.cjs',
|
||||
errors: [{ messageId: 'noRawRmSync' }],
|
||||
},
|
||||
],
|
||||
});
|
||||
assert.ok(true, 'no-raw-rmsync-in-tests is NOT suppressed by allow-test-rule annotation');
|
||||
});
|
||||
|
||||
// ── VALID cases (must NOT error) ──────────────────────────────────────────
|
||||
|
||||
test('valid: helpers.cleanup() in a test file (no error)', () => {
|
||||
ruleTester.run('no-raw-rmsync-in-tests', noRawRmsyncInTests, {
|
||||
valid: [
|
||||
{
|
||||
code: `
|
||||
const { cleanup } = require('../helpers.cjs');
|
||||
cleanup(tmpDir);
|
||||
`,
|
||||
filename: 'tests/foo.test.cjs',
|
||||
},
|
||||
],
|
||||
invalid: [],
|
||||
});
|
||||
assert.ok(true, 'no-raw-rmsync-in-tests allows helpers.cleanup()');
|
||||
});
|
||||
|
||||
test('valid: bare rmSync() that is NOT fs-derived (local function) is not flagged', () => {
|
||||
// A locally defined function named rmSync must not be flagged — the rule
|
||||
// only tracks names that were bound from require("fs").
|
||||
ruleTester.run('no-raw-rmsync-in-tests', noRawRmsyncInTests, {
|
||||
valid: [
|
||||
{
|
||||
code: `
|
||||
const rmSync = () => {};
|
||||
rmSync(d);
|
||||
`,
|
||||
filename: 'tests/foo.test.cjs',
|
||||
},
|
||||
],
|
||||
invalid: [],
|
||||
});
|
||||
assert.ok(true, 'no-raw-rmsync-in-tests does not flag a locally-defined rmSync()');
|
||||
});
|
||||
|
||||
// NOTE: The inline `// eslint-disable-next-line local/no-raw-rmsync-in-tests -- reason`
|
||||
// escape hatch is handled entirely by ESLint's own disable-comment mechanism and
|
||||
// cannot be unit-tested here via RuleTester (RuleTester runs the rule under a
|
||||
// different internal namespace so the comment's rule-id doesn't match). The escape
|
||||
// hatch works correctly when ESLint processes real files via `npx eslint`.
|
||||
|
||||
test('valid: fs.rmSync() in a non-test file (rule is inert outside *.test.cjs)', () => {
|
||||
ruleTester.run('no-raw-rmsync-in-tests', noRawRmsyncInTests, {
|
||||
valid: [
|
||||
{
|
||||
code: `
|
||||
const fs = require('fs');
|
||||
fs.rmSync(tmpDir, { recursive: true, force: true });
|
||||
`,
|
||||
filename: 'scripts/foo.cjs',
|
||||
},
|
||||
],
|
||||
invalid: [],
|
||||
});
|
||||
assert.ok(true, 'no-raw-rmsync-in-tests is inert in non-test files');
|
||||
});
|
||||
|
||||
test('valid: member access / assignment without calling (not a CallExpression)', () => {
|
||||
ruleTester.run('no-raw-rmsync-in-tests', noRawRmsyncInTests, {
|
||||
valid: [
|
||||
{
|
||||
code: `
|
||||
const fs = require('fs');
|
||||
const orig = fs.rmSync;
|
||||
fs.rmSync = orig;
|
||||
`,
|
||||
filename: 'tests/foo.test.cjs',
|
||||
},
|
||||
],
|
||||
invalid: [],
|
||||
});
|
||||
assert.ok(true, 'no-raw-rmsync-in-tests ignores member access / assignment without call');
|
||||
});
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user