fix(coderabbit): resolve all 12 findings on PR #3152
MAJOR (security/correctness): - commands/gsd/debug.md: add Write to allowed-tools (session file creation requires it — workflow explicitly says 'use Write tool, never heredoc') - workflows/debug.md: add SLUG sanitization guard to steps 1b+1c (status/ continue subcommands used raw user input in file paths — path traversal) - workflows/thread.md: sanitize $ARGUMENTS in RESUME mode before file path construction (was bypassing the sanitization guard in CLOSE/STATUS modes) MINOR (consistency/correctness): - docs/INVENTORY-MANIFEST.json: remove stale top-level 'workflows' array (duplicate of families.workflows introduced in earlier update) - commands/gsd/resume-work.md: normalize process to 'Execute end-to-end.' - commands/gsd/settings.md: normalize process to 'Execute end-to-end.' - commands/gsd/update.md: normalize otherwise branch to 'execute end-to-end.' - docs/adr/0002: add Status: Accepted + Date header (ADR convention) - workflows/extract-learnings.md: rename step extract_learnings → extract-learnings - tests/extract-learnings.test.cjs: tighten step-name assertion to exact name ARCHITECTURE: - scripts/command-contract-helpers.cjs: extract CANONICAL_TOOLS, parseFrontmatter, executionContextRefs as shared module — single source of truth consumed by both lint script and test suite (prevents silent lint/test disagreement) - scripts/lint-command-contract.cjs: require() helpers instead of duplicating - tests/command-contract.test.cjs: require() helpers; move readFileSync calls inside test() callbacks (registration-time throws surface as named failures)
This commit is contained in:
@@ -4,6 +4,7 @@ description: Systematic debugging with persistent state across context resets
|
||||
argument-hint: [list | status <slug> | continue <slug> | --diagnose] [issue description]
|
||||
allowed-tools:
|
||||
- Read
|
||||
- Write
|
||||
- Bash
|
||||
- Task
|
||||
- AskUserQuestion
|
||||
|
||||
@@ -26,15 +26,5 @@ Routes to the resume-project workflow which handles:
|
||||
</execution_context>
|
||||
|
||||
<process>
|
||||
**Follow the resume-project workflow**.
|
||||
|
||||
The workflow handles all resumption logic including:
|
||||
|
||||
1. Project existence verification
|
||||
2. STATE.md loading or reconstruction
|
||||
3. Checkpoint and incomplete work detection
|
||||
4. Visual status presentation
|
||||
5. Context-aware option offering (checks CONTEXT.md before suggesting plan vs discuss)
|
||||
6. Routing to appropriate next command
|
||||
7. Session continuity updates
|
||||
</process>
|
||||
Execute end-to-end.
|
||||
</process>
|
||||
|
||||
@@ -24,13 +24,5 @@ Routes to the settings workflow which handles:
|
||||
</execution_context>
|
||||
|
||||
<process>
|
||||
**Follow the settings workflow**.
|
||||
|
||||
The workflow handles all logic including:
|
||||
1. Config file creation with defaults if missing
|
||||
2. Current config reading
|
||||
3. Interactive settings presentation with pre-selection
|
||||
4. Answer parsing and config merging
|
||||
5. File writing
|
||||
6. Confirmation display
|
||||
Execute end-to-end.
|
||||
</process>
|
||||
|
||||
@@ -38,17 +38,8 @@ Routes to the update workflow which handles:
|
||||
Parse the first token of $ARGUMENTS:
|
||||
- If it is `--sync`: strip the flag, execute the sync-skills workflow (passing remaining args for --from/--to/--dry-run/--apply).
|
||||
- If it is `--reapply`: strip the flag, execute the reapply-patches workflow.
|
||||
- Otherwise: **Follow the update workflow**.
|
||||
- Otherwise: execute the update workflow end-to-end.
|
||||
|
||||
The update workflow handles all logic including:
|
||||
1. Installed version detection (local/global)
|
||||
2. Latest version checking via npm
|
||||
3. Version comparison
|
||||
4. Changelog fetching and extraction
|
||||
5. Clean install warning display
|
||||
6. User confirmation
|
||||
7. Update execution
|
||||
8. Cache clearing
|
||||
</process>
|
||||
|
||||
<execution_context_extended>
|
||||
|
||||
Reference in New Issue
Block a user