* test(#3335): fold the workflow-content & phase-lifecycle fix-* cluster — Wave 3 Folds 13 legacy fix-*.test.cjs regression files (131 test() blocks) into their module's main suite, per H3 (#3315) of the test-hygiene epic (#3053): - 6 files with no prior target coverage: renamed (git mv) into new suites (spike-manifest-scoping, ship-note, add-todo, workflow-jq-dependency, resolve-execution-dynamic-routing, clock) - 7 files merged into 5 pre-existing suites (worktree-base-ref x2, model-resolver, phase-locator x2, frontmatter, verification-status), deduplicated against existing coverage Zero net test-coverage loss: every source assertion preserved or verified as a genuine pre-existing duplicate. No production code changed. Last fix-* wave (Wave 1 #3341, Wave 2 #3342 already merged); 4 issue-* waves remain in #3315. * test(#3335): fix orthogonal-review findings — Wave 3 fold Standards-axis review + Memtrace graph pass found real defects in the just-folded suites, all fixed here: - phase-locator.test.cjs: pinned an unseeded fast-check property test (CONTRIBUTING.md determinism requirement), matching the sibling test's seed:7 convention. - phase-locator.test.cjs: added assert.ok() presence guards after 9 data.plans.find() calls that were dereferenced unguarded, inconsistent with 5 sibling tests in the same file that already guard correctly. Latent robustness gap — an omitted plan would throw an opaque TypeError instead of a clear assertion failure. - Standardized the fold-wrapper convention (block-scoped __foldDescribe) across worktree-base-ref.test.cjs, verification-status.test.cjs, and phase-locator.test.cjs to match the pattern already established in frontmatter.test.cjs and model-resolver.test.cjs from earlier folds. - worktree-base-ref.test.cjs: moved a mid-file require to the top-of-file require block. - Eliminated duplicated env-isolation helpers: model-resolver.test.cjs and phase-locator.test.cjs each reimplemented GSD_WORKSTREAM/GSD_PROJECT save-restore independently; factored a shared isolateWorkstreamEnv()/ restoreWorkstreamEnv() into tests/helpers.cjs and pointed both call sites at it. No test() count changed in any file. No production code touched. --------- Co-authored-by: sim <sim@local>
This commit is contained in:
@@ -2053,3 +2053,193 @@ test('extractFrontmatter handles large frontmatter blocks without body bleed', (
|
||||
});
|
||||
});
|
||||
}
|
||||
|
||||
|
||||
// ────────────────────────────────────────────────────────────────────────
|
||||
// Folded from tests/fix-2847-gap-closure-frontmatter.test.cjs — test-hygiene sweep #3335 (H3 Wave 3)
|
||||
// ────────────────────────────────────────────────────────────────────────
|
||||
{
|
||||
const { describe: __foldDescribe } = require('node:test');
|
||||
__foldDescribe("folded:fix-2847-gap-closure-frontmatter (test-hygiene sweep #3335 H3 Wave 3)", () => {
|
||||
'use strict';
|
||||
|
||||
// allow-test-rule: source-text-is-the-product (see #2847)
|
||||
// agents/gsd-planner.md is the deployed runtime prompt contract — testing its
|
||||
// text content tests the deployed contract (CONTRIBUTING.md exception matrix).
|
||||
//
|
||||
// Regression tests for #2847: "--gaps does not load planner-gap-closure.md,
|
||||
// so generated gap plans may miss gap_closure metadata". Root cause: the
|
||||
// planner's only machine-checked gate (`frontmatter.validate ... --schema
|
||||
// plan`) never required gap_closure — the requirement lived only in
|
||||
// conditionally-loaded prose. Fix: src/frontmatter.cts gained a
|
||||
// `plan-gap-closure` schema (covered behaviorally in frontmatter-cli.test.cjs
|
||||
// / frontmatter.unit.test.cjs); this block covers the prompt-level wiring in
|
||||
// agents/gsd-planner.md's <step name="validate_plan"> that selects it via a
|
||||
// real `--schema "$SCHEMA"` shell-variable reference instead of a hardcoded
|
||||
// literal. An earlier revision left the bash line unconditional
|
||||
// (`--schema plan)`) while only prose mentioned the conditional — caught by
|
||||
// review, not tests; the assertions below target executable content
|
||||
// specifically to catch that shape. See
|
||||
// .gsd/bug/fix-2847-gap-closure-frontmatter/10-diagnosis.md.
|
||||
//
|
||||
// Deliberately NOT touched: gsd-core/workflows/plan-phase.md sits under the
|
||||
// ADR-857 PRE_PHASE6 byte ceiling and cannot absorb a gap_closure mention;
|
||||
// the gsd-planner.md validate_plan step is the actual call site and is
|
||||
// sufficient on its own.
|
||||
|
||||
const { test, describe } = require('node:test');
|
||||
const assert = require('node:assert/strict');
|
||||
const fs = require('node:fs');
|
||||
const path = require('node:path');
|
||||
|
||||
const PLANNER_AGENT_PATH = path.join(__dirname, '..', 'agents', 'gsd-planner.md');
|
||||
|
||||
function readFile(p) {
|
||||
return fs.readFileSync(p, 'utf-8');
|
||||
}
|
||||
|
||||
function extractStep(content, stepName) {
|
||||
const marker = `<step name="${stepName}">`;
|
||||
const start = content.indexOf(marker);
|
||||
if (start === -1) return null;
|
||||
const end = content.indexOf('</step>', start);
|
||||
if (end === -1) return null;
|
||||
return content.slice(start, end + '</step>'.length);
|
||||
}
|
||||
|
||||
/**
|
||||
* Extract the FIRST ```bash ... ``` fenced block from a step's text. Returns null
|
||||
* if no fenced bash block is found.
|
||||
*/
|
||||
function extractFirstBashBlock(stepText) {
|
||||
const m = /```bash\r?\n([\s\S]*?)```/.exec(stepText);
|
||||
return m ? m[1] : null;
|
||||
}
|
||||
|
||||
/**
|
||||
* Find the literal line, within a bash block, that invokes `frontmatter.validate`.
|
||||
* Returns null if not found.
|
||||
*/
|
||||
function findValidateInvocationLine(bashBlock) {
|
||||
if (!bashBlock) return null;
|
||||
return bashBlock.split('\n').find((l) => l.includes('frontmatter.validate')) || null;
|
||||
}
|
||||
|
||||
// ─── agents/gsd-planner.md: validate_plan step BINDS schema to mode (#2847) ──
|
||||
//
|
||||
// This describe block asserts on the EXECUTABLE content of the step — the literal
|
||||
// argument passed to `--schema` in the fenced bash block the agent actually runs —
|
||||
// not on whether explanatory words appear anywhere in the step's prose. A prose
|
||||
// sentence like "use plan-gap-closure in gap_closure mode, else plan" sitting next
|
||||
// to an UNCONDITIONAL `--schema plan)` line satisfies every substring-presence
|
||||
// check imaginable while the agent still only ever executes `--schema plan`. That
|
||||
// exact shape shipped in an earlier revision of this fix and was caught by review,
|
||||
// not by tests — these tests are written specifically to catch it mechanically:
|
||||
// verified RED against that revision (`--schema plan)` hardcoded in the bash
|
||||
// block, `--schema plan-gap-closure` only in the prose sentence above it) before
|
||||
// the bash block was changed to `--schema "$SCHEMA"`.
|
||||
|
||||
describe('#2847: gsd-planner.md validate_plan step BINDS --schema to gap_closure mode (executable content, not prose)', () => {
|
||||
const plannerContent = readFile(PLANNER_AGENT_PATH);
|
||||
const validateStep = extractStep(plannerContent, 'validate_plan');
|
||||
const bashBlock = extractFirstBashBlock(validateStep || '');
|
||||
const invocationLine = findValidateInvocationLine(bashBlock);
|
||||
|
||||
test('validate_plan step exists and has a fenced bash block invoking frontmatter.validate', () => {
|
||||
assert.ok(validateStep, '<step name="validate_plan"> must exist in agents/gsd-planner.md');
|
||||
assert.ok(bashBlock, 'validate_plan step must have a ```bash fenced block');
|
||||
assert.ok(invocationLine, 'validate_plan step bash block must invoke frontmatter.validate');
|
||||
});
|
||||
|
||||
test('the --schema argument in the bash invocation is NOT a hardcoded literal', () => {
|
||||
// Precondition: both regex checks below use `.test(invocationLine)`, and
|
||||
// RegExp#test coerces a null/undefined argument to the STRING "null"/
|
||||
// "undefined" rather than throwing — neither hardcoded-literal pattern
|
||||
// matches that string, so both negative assertions would pass vacuously
|
||||
// (reporting "not hardcoded") even if the step or its bash block were
|
||||
// deleted entirely. Fail loudly on that precondition first so a deleted
|
||||
// step is reported as exactly that, not as a false "fix confirmed".
|
||||
assert.ok(invocationLine, 'precondition: invocationLine must be found (see the first test in this block)');
|
||||
|
||||
// This is the exact regression: a prior revision had this line read
|
||||
// `--schema plan)` verbatim — a plain, hardcoded, always-the-same-value
|
||||
// literal that an agent executes as-is regardless of mode. Reject BOTH
|
||||
// possible hardcoded literals explicitly, not just one, so a fix that
|
||||
// flips the hardcoded default to plan-gap-closure (breaking standard mode
|
||||
// instead of gap_closure mode) is caught too.
|
||||
assert.ok(
|
||||
!/--schema\s+plan\)/.test(invocationLine),
|
||||
`bash invocation must not hardcode --schema plan — found: ${invocationLine}`
|
||||
);
|
||||
assert.ok(
|
||||
!/--schema\s+plan-gap-closure\)/.test(invocationLine),
|
||||
`bash invocation must not hardcode --schema plan-gap-closure — found: ${invocationLine}`
|
||||
);
|
||||
});
|
||||
|
||||
test('the --schema argument in the bash invocation IS a shell variable reference', () => {
|
||||
// A variable reference means the value is resolved at execution time from
|
||||
// whatever the agent has bound it to, not printed once in the template and
|
||||
// copy-executed unchanged. Matches --schema "$SCHEMA", --schema $SCHEMA,
|
||||
// or --schema "${SCHEMA}".
|
||||
const varMatch = /--schema\s+"?\$\{?([A-Za-z_][A-Za-z0-9_]*)\}?"?\)/.exec(invocationLine);
|
||||
assert.ok(
|
||||
varMatch,
|
||||
`bash invocation's --schema argument must be a shell variable (e.g. --schema "$SCHEMA"), not a literal — found: ${invocationLine}`
|
||||
);
|
||||
});
|
||||
|
||||
test('the bound variable is actually conditioned on gap_closure mode in the step prose, and both target schema names are named', () => {
|
||||
const varMatch = /--schema\s+"?\$\{?([A-Za-z_][A-Za-z0-9_]*)\}?"?\)/.exec(invocationLine);
|
||||
assert.ok(varMatch, 'precondition: --schema must reference a variable (see previous test)');
|
||||
const varName = varMatch[1];
|
||||
|
||||
// The SAME variable name the bash block reads must appear in the step's prose
|
||||
// (outside the bash block) — otherwise the "binding" is a variable nothing
|
||||
// ever explains how to set, which is not meaningfully better than a literal.
|
||||
const proseOutsideBash = validateStep.replace(/```bash\r?\n[\s\S]*?```/, '');
|
||||
assert.ok(
|
||||
proseOutsideBash.includes(`$${varName}`) || proseOutsideBash.includes(`\`$${varName}\``),
|
||||
`step prose must explain how $${varName} is set — the bash block references it but nothing binds it`
|
||||
);
|
||||
|
||||
// Both concrete schema names this variable can resolve to must be named
|
||||
// somewhere in the step, and gap_closure mode must be the stated condition
|
||||
// for choosing between them. Match the plain `plan` schema as a standalone
|
||||
// backtick-quoted token (`` `plan` ``), not the bare substring "plan" —
|
||||
// a bare-substring check is satisfied incidentally by "verify.plan-structure"
|
||||
// a few lines below even if the plain-plan branch were deleted entirely from
|
||||
// the prose, which would make this assertion unable to ever fail.
|
||||
assert.ok(validateStep.includes('plan-gap-closure'), 'step must name the plan-gap-closure schema');
|
||||
assert.ok(
|
||||
/`plan`/.test(validateStep),
|
||||
'step must name the plain plan schema, as a standalone `plan` token, as the other branch'
|
||||
);
|
||||
assert.ok(/gap_closure mode/i.test(validateStep), 'step must condition the choice on gap_closure mode by name');
|
||||
});
|
||||
|
||||
test('the plan-structure validation call below (unrelated step) is unaffected', () => {
|
||||
// Regression guard for the fix itself: confirm the edit did not touch the
|
||||
// sibling verify.plan-structure invocation in the same step.
|
||||
assert.ok(
|
||||
validateStep.includes('verify.plan-structure "$PLAN_PATH"'),
|
||||
'validate_plan step must still invoke verify.plan-structure unchanged'
|
||||
);
|
||||
});
|
||||
});
|
||||
|
||||
// ─── Cross-file consistency: schema name used by both files matches (#2847) ──
|
||||
|
||||
describe('#2847: schema name consistency between gsd-planner.md and src/frontmatter.cts', () => {
|
||||
test('gsd-planner.md references the exact schema name "plan-gap-closure"', () => {
|
||||
const plannerContent = readFile(PLANNER_AGENT_PATH);
|
||||
assert.ok(
|
||||
plannerContent.includes('plan-gap-closure'),
|
||||
'agents/gsd-planner.md must reference the literal schema name "plan-gap-closure" ' +
|
||||
'(the exact key registered in FRONTMATTER_SCHEMAS in src/frontmatter.cts) — a ' +
|
||||
'mismatched name would fail at runtime with "Unknown schema"'
|
||||
);
|
||||
});
|
||||
});
|
||||
});
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user