refactor: hard-fork GSD -> MSD (Make Software Done)
Mechanical rename produced by scripts/msd-rename.cjs: gsd/Gsd/GSD -> msd/Msd/MSD across contents and paths, upstream package/repo coordinates -> @golem15/msd-core and golem15com/msd-core. Deep links into upstream history, sibling upstream packages, the GSD-2 import feature, CHANGELOG.md and .changeset/ are kept as-is. Hand edits on top: MSD block-letter banner and logos, LICENSE copyright line, package/plugin identity, regenerated lockfile, install-tree fixtures, derived registries and benchmark baseline; migration checksum baseline re-locked (MSD keeps its own install state, so no install had applied the old sums); sort-order and regex-escaped expectations in tests adjusted.
This commit is contained in:
@@ -8,12 +8,12 @@ This project's `tests/` directory uses **filename suffix markers** to group test
|
||||
|
||||
| Suite | Filename pattern | What goes here |
|
||||
|---|---|---|
|
||||
| `unit` | `*.test.cjs` (no other marker) | Default fast lane. Pure logic, no network, no external processes beyond `gsd-tools`. Most tests live here. |
|
||||
| `unit` | `*.test.cjs` (no other marker) | Default fast lane. Pure logic, no network, no external processes beyond `msd-tools`. Most tests live here. |
|
||||
| `integration` | `*.integration.test.cjs` | Cross-module flows: full installer end-to-end, multi-tool orchestration, anything that crosses two or more bin entry points. |
|
||||
| `install` | `*.install.test.cjs` | Tests that perform a real install/uninstall against a sandbox project. Slower; PR CI skips these on PRs and runs them on `main` push only. |
|
||||
| `security` | `*.security.test.cjs` | Adversarial input, prompt-injection guards, fixture-driven hostile-payload sweeps. |
|
||||
| `slow` | `*.slow.test.cjs` | Anything that routinely takes >5s wall-clock or holds significant memory. |
|
||||
| `qa` | `*.qa.test.cjs` | End-to-end walks that drive the real `gsd-tools` binary across multiple loop steps against one accumulating temp project, with invariant oracles after every step. Slower than `unit`; excluded from the fast lane. |
|
||||
| `qa` | `*.qa.test.cjs` | End-to-end walks that drive the real `msd-tools` binary across multiple loop steps against one accumulating temp project, with invariant oracles after every step. Slower than `unit`; excluded from the fast lane. |
|
||||
| `all` | (any) | Explicit alias for "no filter". Equivalent to running with no `--suite` flag. |
|
||||
|
||||
## How to place a new test
|
||||
@@ -65,11 +65,11 @@ suite is wrapped in a self-contained block carrying a marker:
|
||||
|
||||
```javascript
|
||||
// ────────────────────────────────────────────────────────────────────────
|
||||
// Folded from tests/bug-376-claude-js-hook-gsd-rewriter.test.cjs — …
|
||||
// Folded from tests/bug-376-claude-js-hook-msd-rewriter.test.cjs — …
|
||||
// ────────────────────────────────────────────────────────────────────────
|
||||
{
|
||||
const { describe: __foldDescribe } = require('node:test');
|
||||
__foldDescribe("folded:bug-376-claude-js-hook-gsd-rewriter (…)", () => { … });
|
||||
__foldDescribe("folded:bug-376-claude-js-hook-msd-rewriter (…)", () => { … });
|
||||
}
|
||||
```
|
||||
|
||||
@@ -109,7 +109,7 @@ pattern. If `issue-*`/`perf-*` one-offs start accumulating the same way
|
||||
> Bytes (not lines) per [#717](https://github.com/open-gsd/gsd-core/issues/717);
|
||||
> LF-normalized per [#683](https://github.com/open-gsd/gsd-core/issues/683).
|
||||
|
||||
Workflow files (`gsd-core/workflows/*.md`) and agent files (`agents/gsd-*.md`)
|
||||
Workflow files (`msd-core/workflows/*.md`) and agent files (`agents/msd-*.md`)
|
||||
both ship in the installed runtime and are loaded into context — workflows on
|
||||
every command, agents on every subagent dispatch — so their byte size is a real
|
||||
cost. Two sibling guards (`tests/workflow-size-budget.test.cjs` and
|
||||
@@ -119,7 +119,7 @@ layers:
|
||||
|
||||
| Layer | What it does | Where |
|
||||
|---|---|---|
|
||||
| **Differential attribution size ratchet** (primary, #2724 / ADR-2719 §4) | The same computed-attribution check that replaced the golden-install-parity fixtures also reports growth in any `gsd-core/workflows/*.md` or `agents/gsd-*.md` file, with the exact byte delta, comparing PR HEAD against `next`. Unacknowledged growth is a hard failure; shrinkage needs no acknowledgment. No committed snapshot — nothing to regenerate by hand. | `tests/emitted-attribution.test.cjs` (real-tree test) via `tests/helpers/emitted-diff.cjs` |
|
||||
| **Differential attribution size ratchet** (primary, #2724 / ADR-2719 §4) | The same computed-attribution check that replaced the golden-install-parity fixtures also reports growth in any `msd-core/workflows/*.md` or `agents/msd-*.md` file, with the exact byte delta, comparing PR HEAD against `next`. Unacknowledged growth is a hard failure; shrinkage needs no acknowledgment. No committed snapshot — nothing to regenerate by hand. | `tests/emitted-attribution.test.cjs` (real-tree test) via `tests/helpers/emitted-diff.cjs` |
|
||||
| **Loose tier hard caps** (backstop) | Absolute outer red lines per tier — workflows: `XL ≤ 98304`, `LARGE ≤ 61440`, `DEFAULT ≤ 40960` bytes; agents: `XL ≤ 57344`, `LARGE ≤ 49152`, `DEFAULT ≤ 24576` bytes. A cap is **never raised** when a file approaches it: crossing it means *extract*, not bump. Independent of the ratchet above — unaffected by #2724. | `XL/LARGE/DEFAULT_CAP` in each guard file |
|
||||
| **Headroom census + reserved margin** (visibility, [#4261](https://github.com/open-gsd/gsd-core/issues/4261)) | Every run prints each capped file's remaining bytes and percentage used — green runs included — sorted least-headroom-first, and appends a table of the files past a **95% reserved margin** to the GitHub job summary. The margin **reports, it does not fail**: a file at 96% is not broken, it is a file whose next contributor should extract before adding. Nothing here raises or relaxes a cap. | `buildHeadroomRows` / `marginFor` in `scripts/workflow-size.cjs` |
|
||||
|
||||
@@ -137,7 +137,7 @@ margin went unnoticed.
|
||||
(the discuss-phase progressive-disclosure split, #717). A net-new agent is
|
||||
DEFAULT-tier and already bounded by the DEFAULT cap — no separate new-agent cap
|
||||
is needed. (This tier-cap machinery is distinct from the separate 45 KB-*char*
|
||||
extraction-evidence threshold on `gsd-planner` enforced by
|
||||
extraction-evidence threshold on `msd-planner` enforced by
|
||||
`tests/planner-decomposition.test.cjs` — that one proves mode sections were
|
||||
extracted; this one bounds total agent bytes.)
|
||||
|
||||
@@ -156,7 +156,7 @@ The differential attribution check reports the file and the byte delta. To resol
|
||||
Emitted-Drift-Ack-Growth: explore.md — new dispatch section, reasoning ships with the block
|
||||
```
|
||||
|
||||
Growth keys on the **bare filename** as it appears under `gsd-core/workflows/`
|
||||
Growth keys on the **bare filename** as it appears under `msd-core/workflows/`
|
||||
or `agents/`; an unattributable **hash** ripple uses
|
||||
`Emitted-Drift-Ack-Hash:` and keys on the emitted path (which always contains
|
||||
a `/`). The two are separate namespaces — a growth trailer will not excuse a
|
||||
@@ -175,8 +175,8 @@ The differential attribution check reports the file and the byte delta. To resol
|
||||
4. **Or shrink it instead of acknowledging.** Prefer extraction when the growth
|
||||
is incidental: for a workflow, move per-mode bodies to
|
||||
`workflows/<name>/modes/`, templates to `workflows/<name>/templates/`, and
|
||||
shared prose to `gsd-core/references/`; for an agent, lift shared boilerplate
|
||||
into `gsd-core/references/` and `@`-reference it — then load it **LAZILY**. Do
|
||||
shared prose to `msd-core/references/`; for an agent, lift shared boilerplate
|
||||
into `msd-core/references/` and `@`-reference it — then load it **LAZILY**. Do
|
||||
*not* convert them to eager `@-required_reading` includes: that shrinks the
|
||||
file's bytes without shrinking loaded context, so it games the guard while
|
||||
making the real cost worse. See `workflows/discuss-phase/` for the
|
||||
@@ -213,7 +213,7 @@ absolute failure with no attribution reasoning involved. Regenerate it with
|
||||
|
||||
`tests/loop-walk.qa.test.cjs` (the `qa` suite) is the QA-walk harness's own
|
||||
self-test. Separately, `scripts/qa-smell-ratchet.cjs` drives that same harness
|
||||
end to end against the real `gsd-tools` binary and turns its findings into a
|
||||
end to end against the real `msd-tools` binary and turns its findings into a
|
||||
CI gate — run it with `npm run lint:qa-smells`.
|
||||
|
||||
The gate has three independent inputs. The harness's oracles
|
||||
@@ -323,16 +323,16 @@ Unknown suites exit non-zero with the list of valid suites. Empty suites (e.g. `
|
||||
|
||||
## The live-config hermeticity guard
|
||||
|
||||
Every `run-tests.cjs` invocation snapshots GSD's own install footprint in each
|
||||
Every `run-tests.cjs` invocation snapshots MSD's own install footprint in each
|
||||
live runtime config directory before the suite and re-checks it afterwards. It
|
||||
exists because the failure it catches is silent by construction: a test that
|
||||
resolves a config directory from the ambient environment instead of a sandbox
|
||||
writes into *your real* `~/.claude` (or `$GSD_HOME/.gsd`, or a Kimi
|
||||
writes into *your real* `~/.claude` (or `$MSD_HOME/.msd`, or a Kimi
|
||||
`config.toml`), and nothing reports it. CI cannot catch this class at all —
|
||||
CI never has `CLAUDE_CONFIG_DIR` and friends set.
|
||||
|
||||
The guard watches only what GSD unambiguously owns — its top-level install
|
||||
footprint plus `gsd-`-prefixed children of directories shared with the host
|
||||
The guard watches only what MSD unambiguously owns — its top-level install
|
||||
footprint plus `msd-`-prefixed children of directories shared with the host
|
||||
agent — never whole config roots, because a host agent legitimately writing
|
||||
`history.jsonl` mid-run would make the guard cry wolf, and a guard that cries
|
||||
wolf gets switched off.
|
||||
@@ -341,8 +341,8 @@ Two environment variables control it:
|
||||
|
||||
| Variable | Effect |
|
||||
|---|---|
|
||||
| `GSD_STRICT_LIVE_CONFIG_GUARD=1` | A detected write **fails the run**. Set on the Linux/macOS lanes of every CI job that runs the suite. |
|
||||
| `GSD_SKIP_LIVE_CONFIG_GUARD=1` | Skips the check entirely. |
|
||||
| `MSD_STRICT_LIVE_CONFIG_GUARD=1` | A detected write **fails the run**. Set on the Linux/macOS lanes of every CI job that runs the suite. |
|
||||
| `MSD_SKIP_LIVE_CONFIG_GUARD=1` | Skips the check entirely. |
|
||||
|
||||
Unset, the guard **reports and does not fail** — deliberately, not timidly. On
|
||||
its first CI run it surfaced pre-existing leaks on the Windows lane, where
|
||||
@@ -353,7 +353,7 @@ obeyed. Windows lanes therefore stay report-only until that sweep lands; this
|
||||
repo has the pattern already, in the `local/no-source-grep` ESLint rule that
|
||||
shipped at `warn` and was promoted to `error` after its cleanup (ADR 452).
|
||||
|
||||
`GSD_SKIP_LIVE_CONFIG_GUARD` is a bypass on a safety check, so it is documented
|
||||
`MSD_SKIP_LIVE_CONFIG_GUARD` is a bypass on a safety check, so it is documented
|
||||
here rather than left to be discovered in the source: an undocumented bypass is
|
||||
one people eventually set without knowing what they turned off. If you need it
|
||||
routinely, that is a bug report, not a workflow.
|
||||
@@ -484,7 +484,7 @@ job by #2952, once sharding meant no single `test` runner saw the whole picture)
|
||||
stays single-lane (Ubuntu / Node 24 only) because multiplying coverage across
|
||||
OS/runtime lanes adds cost without improving the threshold signal. Note the gate's
|
||||
deliberate blind spot: it measures
|
||||
`gsd-core/bin/lib/*.cjs` only — `scripts/`, `hooks/`, and `bin/` are
|
||||
`msd-core/bin/lib/*.cjs` only — `scripts/`, `hooks/`, and `bin/` are
|
||||
unenforced, and `stryker.config.mjs` additionally excludes ~48% of lib lines
|
||||
from mutation testing (see the UNMUTATED list there). Widening either gate is
|
||||
tracked work, not an accident to "fix" silently by raising thresholds.
|
||||
@@ -492,7 +492,7 @@ tracked work, not an accident to "fix" silently by raising thresholds.
|
||||
To inspect the scope locally:
|
||||
|
||||
```bash
|
||||
npm run ci:test-scope -- --files "commands/gsd/plan-phase.md"
|
||||
npm run ci:test-scope -- --files "commands/msd/plan-phase.md"
|
||||
node scripts/ci-test-scope.cjs --base origin/next --head HEAD
|
||||
```
|
||||
|
||||
@@ -580,12 +580,12 @@ the accumulated history, not something either mechanism decides on its own.
|
||||
|
||||
Regenerate when the suite's cost profile has visibly drifted — after adding or
|
||||
removing expensive tests, not on a schedule. The input is a `node:test` reporter
|
||||
event stream from a `gsd-test` run:
|
||||
event stream from a `msd-test` run:
|
||||
|
||||
```bash
|
||||
node scripts/gen-test-timings.cjs \
|
||||
~/.local/state/gsd-test/runs/<run-id>/test-events-linux-node24.jsonl \
|
||||
~/.local/state/gsd-test/runs/<run-id>/test-events-macos-node24.jsonl
|
||||
~/.local/state/msd-test/runs/<run-id>/test-events-linux-node24.jsonl \
|
||||
~/.local/state/msd-test/runs/<run-id>/test-events-macos-node24.jsonl
|
||||
```
|
||||
|
||||
Pass every lane you have. A file's recorded time is the **max** across the
|
||||
@@ -613,7 +613,7 @@ Keys are sorted so a regeneration diff shows only the files whose cost moved.
|
||||
| Layer | File | What it covers |
|
||||
|---|---|---|
|
||||
| **Unit** | `feat-443-effort-fast-mode.test.cjs` | Pure logic: cascade rules, clamping, escalation math, malformed config handling, schema key validation. No CLI subprocess. |
|
||||
| **Integration** | `feat-443-effort-fast-mode.integration.test.cjs` | Architecture-level invariants: cross-provider validity, totality across the 33-agent registry, CLI JSON contract, config round-trip, fast-mode honesty. Real subprocesses via `runGsdTools`. |
|
||||
| **Integration** | `feat-443-effort-fast-mode.integration.test.cjs` | Architecture-level invariants: cross-provider validity, totality across the 33-agent registry, CLI JSON contract, config round-trip, fast-mode honesty. Real subprocesses via `runMsdTools`. |
|
||||
| **E2E** *(pending)* | *(not yet wired)* | Propagation layer: effort frontmatter / `CLAUDE_CODE_EFFORT_LEVEL` env actually reaching a spawned Claude Code subagent. See "Gaps" below. |
|
||||
|
||||
### Architectural invariants
|
||||
@@ -648,7 +648,7 @@ here would silently drop effort from subagent invocations.
|
||||
|
||||
#### (c) Resolve-execution JSON contract
|
||||
|
||||
**What:** The `gsd-tools resolve-execution <agent>` command emits a JSON object
|
||||
**What:** The `msd-tools resolve-execution <agent>` command emits a JSON object
|
||||
with all eight keys present and typed correctly: `model` (string), `profile`
|
||||
(string), `effort` (VALID_EFFORTS member), `effort_rendered` (string),
|
||||
`effort_param` (string|null), `effort_propagation` (string|null), `fast_mode`
|
||||
@@ -702,7 +702,7 @@ over-escalation or under-escalation.
|
||||
|
||||
#### (h) Config-tooling round-trip
|
||||
|
||||
**What:** `gsd-tools config-set` accepts all new key namespaces
|
||||
**What:** `msd-tools config-set` accepts all new key namespaces
|
||||
(`effort.default`, `effort.routing_tier_defaults.<tier>`,
|
||||
`effort.agent_overrides.<agent>`, `fast_mode.enabled`,
|
||||
`fast_mode.routing_tier_defaults.<tier>`, `fast_mode.agent_overrides.<agent>`)
|
||||
@@ -723,7 +723,7 @@ a silent write failure and appear as a bug only at runtime.
|
||||
### Gaps / not yet covered
|
||||
|
||||
**E2E orchestrator-spawn-propagation layer (pending follow-up wiring):**
|
||||
The integration tests verify that GSD resolves and renders effort values
|
||||
The integration tests verify that MSD resolves and renders effort values
|
||||
correctly. They do NOT verify that the rendered values actually reach a spawned
|
||||
Claude Code or Codex subagent at runtime. Specifically uncovered:
|
||||
|
||||
|
||||
Reference in New Issue
Block a user