golem15/msd-core
4
0
Fork 0
Code Issues 1 Pull Requests Actions 3 Packages Projects Releases Wiki Activity

refactor: hard-fork GSD -> MSD (Make Software Done)

Browse Source 
Mechanical rename produced by scripts/msd-rename.cjs: gsd/Gsd/GSD -> msd/Msd/MSD
across contents and paths, upstream package/repo coordinates -> @golem15/msd-core
and golem15com/msd-core. Deep links into upstream history, sibling upstream
packages, the GSD-2 import feature, CHANGELOG.md and .changeset/ are kept as-is.

Hand edits on top: MSD block-letter banner and logos, LICENSE copyright line,
package/plugin identity, regenerated lockfile, install-tree fixtures, derived
registries and benchmark baseline; migration checksum baseline re-locked
(MSD keeps its own install state, so no install had applied the old sums);
sort-order and regex-escaped expectations in tests adjusted.
This commit is contained in:
Jakub Zych
2026-10-06 01:47:40 +02:00
parent fe069b2a56
commit a9a7a328e6
2763 changed files with 78465 additions and 78434 deletions
Download Patch File Download Diff File Expand all files Collapse all files

48
tests/orphaned-hooks.test.cjs
View File

@@ -1,9 +1,9 @@
/**
* Regression test for #1750: orphaned hook files from removed features
* (e.g., gsd-intel-*.js) should NOT be flagged as stale by gsd-check-update.js.
* (e.g., msd-intel-*.js) should NOT be flagged as stale by msd-check-update.js.
*
* The stale hooks scanner should only check hooks that are part of the current
* distribution, not every gsd-*.js file in the hooks directory.
* distribution, not every msd-*.js file in the hooks directory.
*
* Migration note (#455): previously used fs.readFileSync + regex on the worker
* and build-hooks source to extract arrays. Now imports typed exports directly:
@@ -16,8 +16,8 @@ const assert = require('node:assert/strict');
const fs = require('fs');
const path = require('path');
const CHECK_UPDATE_PATH = path.join(__dirname, '..', 'hooks', 'gsd-check-update.js');
const WORKER_PATH = path.join(__dirname, '..', 'hooks', 'gsd-check-update-worker.js');
const CHECK_UPDATE_PATH = path.join(__dirname, '..', 'hooks', 'msd-check-update.js');
const WORKER_PATH = path.join(__dirname, '..', 'hooks', 'msd-check-update-worker.js');
const HOOKS_DIR = path.join(__dirname, '..', 'hooks');
// Typed imports — no source-grep needed (#455)
@@ -25,46 +25,46 @@ const { MANAGED_HOOKS } = require(path.join(HOOKS_DIR, 'managed-hooks-registry.c
const { HOOKS_TO_COPY, HOOKS_SUBDIRS_TO_COPY } = require(path.join(__dirname, '..', 'scripts', 'build-hooks.js'));
describe('orphaned hooks stale detection (#1750)', () => {
test('MANAGED_HOOKS is an array and does not use a broad gsd-* wildcard', () => {
test('MANAGED_HOOKS is an array and does not use a broad msd-* wildcard', () => {
// The scanner must reference a known set of managed hook filenames,
// not a broad startsWith('gsd-') filter that catches orphaned files.
// not a broad startsWith('msd-') filter that catches orphaned files.
assert.ok(Array.isArray(MANAGED_HOOKS), 'MANAGED_HOOKS must be an array');
// Each entry is a concrete filename string — no glob/wildcard patterns
for (const entry of MANAGED_HOOKS) {
assert.ok(typeof entry === 'string', `MANAGED_HOOKS entry must be a string, got ${typeof entry}`);
assert.ok(!entry.includes('*'), `MANAGED_HOOKS entry '${entry}' must not contain wildcards`);
assert.ok(entry.startsWith('gsd-'), `MANAGED_HOOKS entry '${entry}' must start with gsd-`);
assert.ok(entry.startsWith('msd-'), `MANAGED_HOOKS entry '${entry}' must start with msd-`);
}
});
test('gsd-check-update-worker.js imports managed-hooks-registry.cjs (not inline array)', () => {
test('msd-check-update-worker.js imports managed-hooks-registry.cjs (not inline array)', () => {
// allow-test-rule: structural-regression-guard (#3545) — presence of a
// require() wire-up and absence of a reintroduced inline array are source
// structure facts, not runtime behavior; see file header.
const content = fs.readFileSync(WORKER_PATH, 'utf8');
assert.ok(
content.includes('managed-hooks-registry.cjs'),
'gsd-check-update-worker.js must require managed-hooks-registry.cjs'
'msd-check-update-worker.js must require managed-hooks-registry.cjs'
);
// The inline MANAGED_HOOKS array must no longer be in the worker
assert.ok(
!content.includes('const MANAGED_HOOKS = ['),
'gsd-check-update-worker.js must not define MANAGED_HOOKS inline — it should import from managed-hooks-registry.cjs'
'msd-check-update-worker.js must not define MANAGED_HOOKS inline — it should import from managed-hooks-registry.cjs'
);
});
test('gsd-check-update.js spawns the worker by file path (not inline -e code)', () => {
test('msd-check-update.js spawns the worker by file path (not inline -e code)', () => {
// allow-test-rule: structural-regression-guard (#3545) — spawn-target
// wiring and absence of inline `-e` code are source structure facts, not
// runtime behavior; see file header.
const content = fs.readFileSync(CHECK_UPDATE_PATH, 'utf8');
assert.ok(
content.includes('gsd-check-update-worker.js'),
'gsd-check-update.js must reference gsd-check-update-worker.js as the spawn target'
content.includes('msd-check-update-worker.js'),
'msd-check-update.js must reference msd-check-update-worker.js as the spawn target'
);
assert.ok(
!content.includes("'-e'"),
'gsd-check-update.js must not use node -e inline code (logic moved to worker file)'
'msd-check-update.js must not use node -e inline code (logic moved to worker file)'
);
});
@@ -81,17 +81,17 @@ describe('orphaned hooks stale detection (#1750)', () => {
}
});
test('MANAGED_HOOKS is a superset of all gsd-* hooks in HOOKS_TO_COPY (all extensions)', () => {
// Every hook-named file in HOOKS_TO_COPY (matching the gsd-* naming pattern
test('MANAGED_HOOKS is a superset of all msd-* hooks in HOOKS_TO_COPY (all extensions)', () => {
// Every hook-named file in HOOKS_TO_COPY (matching the msd-* naming pattern
// that the registry governs, regardless of extension) must appear in MANAGED_HOOKS.
// Non-hook support files like managed-hooks-registry.cjs are intentionally
// excluded from this check because they are not themselves hooks.
// This catches missing .sh entries as well as .js entries.
assert.ok(Array.isArray(HOOKS_TO_COPY), 'HOOKS_TO_COPY must be an array');
const gsdHooks = HOOKS_TO_COPY.filter(h => h.startsWith('gsd-'));
assert.ok(gsdHooks.length >= 5, `expected at least 5 gsd-* hooks in HOOKS_TO_COPY, got ${gsdHooks.length}`);
const msdHooks = HOOKS_TO_COPY.filter(h => h.startsWith('msd-'));
assert.ok(msdHooks.length >= 5, `expected at least 5 msd-* hooks in HOOKS_TO_COPY, got ${msdHooks.length}`);
for (const hook of gsdHooks) {
for (const hook of msdHooks) {
assert.ok(
MANAGED_HOOKS.includes(hook),
`MANAGED_HOOKS should include '${hook}' (from HOOKS_TO_COPY) — add it to hooks/managed-hooks-registry.cjs`
@@ -101,9 +101,9 @@ describe('orphaned hooks stale detection (#1750)', () => {
test('orphaned hook filenames are NOT in MANAGED_HOOKS', () => {
const orphanedHooks = [
'gsd-intel-index.js',
'gsd-intel-prune.js',
'gsd-intel-session.js',
'msd-intel-index.js',
'msd-intel-prune.js',
'msd-intel-session.js',
];
for (const orphan of orphanedHooks) {
@@ -115,7 +115,7 @@ describe('orphaned hooks stale detection (#1750)', () => {
});
test('every same-dir require() target of a shipped hook is itself shipped (#606)', () => {
// Regression guard for #606: gsd-check-update-worker.js does
// Regression guard for #606: msd-check-update-worker.js does
// require('./managed-hooks-registry.cjs'), but that sibling was missing from
// HOOKS_TO_COPY, so the installer never placed it next to the worker and the
// background worker crashed at runtime with "Cannot find module". The fix added
@@ -124,7 +124,7 @@ describe('orphaned hooks stale detection (#1750)', () => {
//
// Scope: only *same-directory* relative requires — require('./x') and
// require('./subdir/x'). A require('../...') target reaches out of the hooks/
// dir into sibling package dirs (e.g. gsd-core/) whose shipping is governed
// dir into sibling package dirs (e.g. msd-core/) whose shipping is governed
// by package.json "files", not by this allowlist, so it is out of scope here.
assert.ok(Array.isArray(HOOKS_SUBDIRS_TO_COPY), 'HOOKS_SUBDIRS_TO_COPY must be exported as an array');