From aa4532b82090656ca2d2b6e0505eaa04652e6a6d Mon Sep 17 00:00:00 2001 From: Tom Boucher Date: Sat, 11 Apr 2026 09:02:18 -0400 Subject: [PATCH] fix(workflow): quote path variables in workspace next-step examples (#2096) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Display examples showing 'cd $TARGET_PATH' and 'cd $WORKSPACE_PATH/repo1' were unquoted, causing path splitting when project paths contain spaces (e.g. Windows paths like C:\Users\First Last\...). Quote all path variable references in user-facing guidance blocks so the examples shown to users are safe to copy-paste directly. The actual bash execution blocks (git worktree add, rm -rf, etc.) were already correctly quoted — this fixes only the display examples. Fixes #2088 Co-authored-by: Claude Sonnet 4.6 --- get-shit-done/workflows/new-workspace.md | 6 +++--- get-shit-done/workflows/remove-workspace.md | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/get-shit-done/workflows/new-workspace.md b/get-shit-done/workflows/new-workspace.md index edbc2f9c5..d732ecef1 100644 --- a/get-shit-done/workflows/new-workspace.md +++ b/get-shit-done/workflows/new-workspace.md @@ -202,7 +202,7 @@ Workspace created: $TARGET_PATH Branch: $BRANCH_NAME Next steps: - cd $TARGET_PATH + cd "$TARGET_PATH" /gsd-new-project # Initialize GSD in the workspace ``` @@ -215,7 +215,7 @@ Workspace created with $SUCCESS_COUNT of $TOTAL_COUNT repos: $TARGET_PATH Failed: repo3 (branch already exists), repo4 (not a git repo) Next steps: - cd $TARGET_PATH + cd "$TARGET_PATH" /gsd-new-project # Initialize GSD in the workspace ``` @@ -225,7 +225,7 @@ Use AskUserQuestion: - header: "Initialize GSD" - question: "Would you like to initialize a GSD project in the new workspace?" - options: - - "Yes — run /gsd-new-project" → tell user to `cd $TARGET_PATH` first, then run `/gsd-new-project` + - "Yes — run /gsd-new-project" → tell user to `cd "$TARGET_PATH"` first, then run `/gsd-new-project` - "No — I'll set it up later" → done diff --git a/get-shit-done/workflows/remove-workspace.md b/get-shit-done/workflows/remove-workspace.md index 267ba18a3..63d6cc57b 100644 --- a/get-shit-done/workflows/remove-workspace.md +++ b/get-shit-done/workflows/remove-workspace.md @@ -43,7 +43,7 @@ Cannot remove workspace "$WORKSPACE_NAME" — the following repos have uncommitt - repo2 Commit or stash changes in these repos before removing the workspace: - cd $WORKSPACE_PATH/repo1 + cd "$WORKSPACE_PATH/repo1" git stash # or git commit ```