test(#4521): migrate capability subsystem batch to named timeout constants (#4627)

Batch 10 of the ad hoc timeout literal migration (epic #4445). Replaces
every bare numeric timeout/timeoutMs object-literal property in
tests/adr857-core-without-capabilities.test.cjs, tests/capability-cli.test.cjs,
tests/capability-probe-fallback.test.cjs, tests/capability-state.test.cjs,
tests/capability-trust.test.cjs,
tests/capability-validator-task-content-resolver.test.cjs, and
tests/capability-writer.test.cjs with a named constant, per
eslint-rules/no-adhoc-timeout-literal.cjs. Removes these 7 files from the
rule's allowlist.

Reuses the existing PROBE_TIMEOUT_MS constant at 8 sites across 3 files.
Adds 7 new file-local constants (no promotion to the shared helper needed
this batch -- every new class is confined to exactly one file, below the
two-file promotion bar): GSD_TOOLS_CLI_TIMEOUT_MS,
FRAGMENT_PROBE_SNIPPET_TIMEOUT_MS, INSTALLED_RUNTIME_CLI_TIMEOUT_MS,
FIXTURE_MCP_SERVER_TIMEOUT_VALUE, TASK_RESOLVER_FIXTURE_TIMEOUT_MS,
TASK_RESOLVER_TIMEOUT_CEILING_MS, and TASK_RESOLVER_TIMEOUT_CEILING_PLUS_ONE_MS
(the last two forming a boundary-coverage limit/limit+1 pair). No src/bin
file touched, no numeric value changed anywhere.

Co-authored-by: sim <sim@local>
Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
Tom Boucher
2026-09-11 09:55:55 -04:00
committed by GitHub
parent 7249bdddac
commit aad96e0b5f
8 changed files with 97 additions and 25 deletions

View File

@@ -105,6 +105,15 @@ function buildTddOnlyConfig() {
// ── Helpers ───────────────────────────────────────────────────────────────────
/**
* A single gsd-tools.cjs CLI subcommand invocation via execFileSync, no
* fan-out. Same class as tests/helpers/timeouts.cjs's
* LOOP_HOOK_POINT_CLI_TIMEOUT_MS, but at half that constant's pre-existing
* bound -- not equalized without bench data. Kept file-local: this batch's
* only site at this exact class+value.
*/
const GSD_TOOLS_CLI_TIMEOUT_MS = 30000;
/**
* Run gsd-tools subprocess and return { exitCode, output }.
* Does NOT throw on non-zero exit — let the test assert.
@@ -114,7 +123,7 @@ function runCli(args, cwd) {
const stdout = execFileSync(process.execPath, [GSD_TOOLS, ...args], {
cwd,
encoding: 'utf-8',
timeout: 30000,
timeout: GSD_TOOLS_CLI_TIMEOUT_MS,
});
return { exitCode: 0, output: stdout.trim() };
} catch (err) {