golem15/msd-core
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

test(#4521): migrate capability subsystem batch to named timeout constants (#4627)

Browse Source 
Batch 10 of the ad hoc timeout literal migration (epic #4445). Replaces
every bare numeric timeout/timeoutMs object-literal property in
tests/adr857-core-without-capabilities.test.cjs, tests/capability-cli.test.cjs,
tests/capability-probe-fallback.test.cjs, tests/capability-state.test.cjs,
tests/capability-trust.test.cjs,
tests/capability-validator-task-content-resolver.test.cjs, and
tests/capability-writer.test.cjs with a named constant, per
eslint-rules/no-adhoc-timeout-literal.cjs. Removes these 7 files from the
rule's allowlist.

Reuses the existing PROBE_TIMEOUT_MS constant at 8 sites across 3 files.
Adds 7 new file-local constants (no promotion to the shared helper needed
this batch -- every new class is confined to exactly one file, below the
two-file promotion bar): GSD_TOOLS_CLI_TIMEOUT_MS,
FRAGMENT_PROBE_SNIPPET_TIMEOUT_MS, INSTALLED_RUNTIME_CLI_TIMEOUT_MS,
FIXTURE_MCP_SERVER_TIMEOUT_VALUE, TASK_RESOLVER_FIXTURE_TIMEOUT_MS,
TASK_RESOLVER_TIMEOUT_CEILING_MS, and TASK_RESOLVER_TIMEOUT_CEILING_PLUS_ONE_MS
(the last two forming a boundary-coverage limit/limit+1 pair). No src/bin
file touched, no numeric value changed anywhere.

Co-authored-by: sim <sim@local>
Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
Tom Boucher
2026-09-11 09:55:55 -04:00
committed by GitHub
parent 7249bdddac
commit aad96e0b5f
8 changed files with 97 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

39
tests/capability-validator-task-content-resolver.test.cjs
View File

@@ -22,6 +22,39 @@ const {
validateCrossCapability,
} = require('../gsd-core/bin/lib/capability-validator.cjs');
/**
* NOT a subprocess spawn timeout. Fixture DATA -- the default valid
* `invoke.timeoutMs` value used across most tests in this file's
* `validResolver()` base fixture, validated by validateTaskContentResolver()
* as pure manifest data. Coincides numerically with
* tests/helpers/timeouts.cjs's QUICK_SPAWN_TIMEOUT_MS but is not a real
* timeout in this file's own execution -- kept local.
*/
const TASK_RESOLVER_FIXTURE_TIMEOUT_MS = 10000;
/**
* NOT a subprocess spawn timeout. Fixture DATA -- the exact ceiling value a
* dedicated describe block ("invoke.timeoutMs upper ceiling") asserts is
* still ACCEPTED by validateTaskContentResolver(). Mirrors a business-logic
* ceiling constant in gsd-core/bin/lib/capability-validator.cjs (production
* code, untouched by this migration). Coincides numerically with
* tests/helpers/timeouts.cjs's INSTALL_TIMEOUT_MS but is not a real timeout
* in this file's own execution -- kept local. Forms a CLAUDE.md
* limit/limit+1 boundary pair with TASK_RESOLVER_TIMEOUT_CEILING_PLUS_ONE_MS
* below -- do not change either value independently.
*/
const TASK_RESOLVER_TIMEOUT_CEILING_MS = 120000;
/**
* NOT a subprocess spawn timeout. Fixture DATA -- the boundary-violating
* companion to TASK_RESOLVER_TIMEOUT_CEILING_MS above, asserting exactly
* one ms past the ceiling is REJECTED. A CLAUDE.md "Boundary Coverage"
* limit+1 value -- must always equal TASK_RESOLVER_TIMEOUT_CEILING_MS + 1.
* Declared as its own literal (not computed via +1 arithmetic) to match
* this migration's convention of plain-literal constants throughout.
*/
const TASK_RESOLVER_TIMEOUT_CEILING_PLUS_ONE_MS = 120001;
// ─── Fixture builders ──────────────────────────────────────────────────────
// House convention (tests/capability-manifest-version.test.cjs): builder
// functions return a VALID fixture, which each test then mutates. Every call
@@ -34,7 +67,7 @@ function validResolver() {
invoke: {
binary: 'bd',
args: ['show', '{{id}}', '--json'],
timeoutMs: 10000,
timeoutMs: TASK_RESOLVER_FIXTURE_TIMEOUT_MS,
},
};
}
@@ -233,7 +266,7 @@ describe('row 23 — invoke.timeoutMs must be a positive integer', () => {
describe('invoke.timeoutMs upper ceiling (120000ms)', () => {
test('timeoutMs 120000 (exactly at the ceiling) is accepted', () => {
const resolver = validResolver();
resolver.invoke = { ...resolver.invoke, timeoutMs: 120000 };
resolver.invoke = { ...resolver.invoke, timeoutMs: TASK_RESOLVER_TIMEOUT_CEILING_MS };
const cap = featureCap({ taskContentResolver: resolver });
const errs = validateTaskContentResolver(cap);
assert.ok(
@@ -244,7 +277,7 @@ describe('invoke.timeoutMs upper ceiling (120000ms)', () => {
test('timeoutMs 120001 (one past the ceiling) is rejected', () => {
const resolver = validResolver();
resolver.invoke = { ...resolver.invoke, timeoutMs: 120001 };
resolver.invoke = { ...resolver.invoke, timeoutMs: TASK_RESOLVER_TIMEOUT_CEILING_PLUS_ONE_MS };
const cap = featureCap({ taskContentResolver: resolver });
const errs = validateTaskContentResolver(cap);
assert.ok(