test(#4514): migrate git-adjacent workflow checks to named timeout constants

Batch 3 of the ad hoc timeout literal migration (epic #4445). Replaces
every bare numeric timeout/timeoutMs object-literal property in
tests/ci-rebase-check.test.cjs, tests/gsd-validate-commit-crash-policy.test.cjs,
tests/pr-branch-planning-filter.test.cjs, tests/reapply-verify-hunks.test.cjs,
tests/ship-notes-wedged-pr.test.cjs, tests/slug-derivation-drift-guard.test.cjs,
and tests/worktree-safety.test.cjs with a named constant, per
eslint-rules/no-adhoc-timeout-literal.cjs. Removes the 7 files from the
rule's allowlist.

Mints a new shared class norm, QUICK_SPAWN_TIMEOUT_MS (10000ms), in
tests/helpers/timeouts.cjs: 5 sites across 4 of this batch's files had
independently arrived at the same value for the same shape (a cheap,
trivial subprocess/hook invocation with no real git/network/fan-out
work). No src/bin file touched, no numeric value changed anywhere.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
sim
2026-09-09 07:05:48 -04:00
parent fd37b6a171
commit ab0405ad22
9 changed files with 82 additions and 24 deletions

View File

@@ -4980,6 +4980,7 @@ const path = require('node:path');
const { cleanup } = require('./helpers.cjs');
const { runHook: seamRunHook } = require('./helpers/process-seam.cjs');
const { gitOrThrow } = require('./helpers/git-fixture.cjs');
const { QUICK_SPAWN_TIMEOUT_MS } = require('./helpers/timeouts.cjs');
const HOOK_PATH = path.join(__dirname, '..', 'hooks', 'gsd-worktree-path-guard.js');
const INSTALL_SRC = path.join(__dirname, '..', 'bin', 'install.js');
@@ -5036,15 +5037,17 @@ function makeWorktree(mainRepo, branchName) {
* Run the hook with a given payload, returning the spawnSync result.
*/
function runHook(cwd, payload) {
// 10000ms: previously UNBOUNDED (no `timeout` option passed to spawnSync).
// gsd-worktree-path-guard.js is a synchronous, in-process path-guard hook
// (fs/path checks against a JSON stdin payload) — no subprocess or network
// work of its own. 10s leaves generous headroom over its sub-second
// worst case even on a heavily contended CI runner.
// QUICK_SPAWN_TIMEOUT_MS (10000ms): previously UNBOUNDED (no `timeout`
// option passed to spawnSync). gsd-worktree-path-guard.js is a
// synchronous, in-process path-guard hook (fs/path checks against a JSON
// stdin payload) — no subprocess or network work of its own. 10s leaves
// generous headroom over its sub-second worst case even on a heavily
// contended CI runner. See tests/helpers/timeouts.cjs for the shared
// norm this value was promoted to (#4514).
const r = seamRunHook(HOOK_PATH, [], {
cwd,
input: JSON.stringify(payload),
timeoutMs: 10_000,
timeoutMs: QUICK_SPAWN_TIMEOUT_MS,
});
return { status: r.exitCode, stdout: r.stdout, stderr: r.stderr };
}