* fix(#2868): resume a phase stranded between its last plan and verification discover_and_group_plans exited unconditionally once every plan was filtered out, conflating "no plan work left" with "phase fully done". Those differ once a run can be interrupted between the final wave's SUMMARY and the verify step -- most often by a checkpoint plan that is retired but still writes a SUMMARY. The result was a phase that looked healthy from every index yet had no VERIFICATION.md, and whose recommended recovery command provably no-opped, because the only step that produces the artifact sits ten steps past that exit. The exit is now conditional. When the verification report is genuinely missing and no filter is active, the run reports the situation by name and continues at the tail gates instead of stopping. Two guards keep the normal paths untouched: - A filtered run (--gaps-only, or an explicit wave) finding nothing left in its own slice says nothing about whether the phase as a whole is done, so it exits exactly as before. Without this, --wave 1 on a finished first wave would jump to verification with later waves still outstanding. - A phase that already has its report exits as before too. The recovered path deliberately keeps the code-review and regression gates. The manual workaround this replaces skipped both, and that gap is the reason a real route exists rather than telling users to spawn the verifier by hand. Also acknowledges the emitted growth of the workflow file. As with #2830 it is appended to the fragment that already owns that path, since the linter hard-fails when two acknowledgment sources name the same one. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(#2868): never treat a blocked-and-incomplete phase as finished Three findings from adversarial review, all fixed. BLOCKER -- the trigger conflated two different zero-runnable states. This step now has two skip rules: has_summary (the #2868 target) and, from #2830, a skip for plans whose blocked_by is non-empty. "All filtered" was therefore reachable with plans that never ran: plan A halts and is summarized, plan B is blocked by A and has no summary. The resume path fired, announced "All N plans are summarized" -- false -- skipped the wave steps so B was never dispatched, and jumped to the gates. B was silently abandoned, which is the same class of disappearance #2830 exists to prevent, reintroduced one layer up. The decision is now an explicit ordered three-way: a filtered run exits unchanged; any blocked-plan skip reports the phase as stuck on a halt and exits, routing to resolving the halt rather than to verification; only an all-summarized, unfiltered phase with a missing report resumes. MAJOR -- RESUME_TAIL_ONLY was set and never read anywhere in the workflow or its step fragments. Dead state implying enforcement that did not exist. Removed; the imperative at the decision point is what actually carries the control flow, so it now says so plainly. MAJOR -- the resume path skipped aggregate_results, which is the only step that runs the secure-phase threats-open gate. A phase with open threats would have advanced with no warning where a normal run always shows one. The path now enters at aggregate_results, verified to read only on-disk phase artifacts and independent queries, so it tolerates having executed no plans this run. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * chore(#2868): backfill changeset pr number Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
@@ -1050,3 +1050,76 @@ describe('#2617: the phase-complete error path projects too', () => {
|
||||
});
|
||||
}
|
||||
});
|
||||
|
||||
// ─── #2868: stranded-phase detection via `verification status` ────────────────
|
||||
//
|
||||
// execute-phase's `discover_and_group_plans` step resumes at the phase gates
|
||||
// when every plan is summarized but no *-VERIFICATION.md exists yet. That
|
||||
// resume decision is driven by `gsd_run query verification status <phaseDir>
|
||||
// --pick status` reading `missing`. These tests pin the CLI query's behavior
|
||||
// on the exact fixture shapes the workflow branches on, via the real CLI
|
||||
// (runGsdTools), not the in-process readVerificationStatus() helper used above.
|
||||
describe('#2868: verification status CLI drives the execute-phase stranded-phase resume', () => {
|
||||
const { runGsdTools, createTempGitProject } = require('./helpers.cjs');
|
||||
|
||||
test('D1: all plans summarized, no *-VERIFICATION.md → status is missing', () => {
|
||||
const projectDir = createTempGitProject();
|
||||
try {
|
||||
const phaseDir = path.join(projectDir, '.planning', 'phases', '01-example');
|
||||
fs.mkdirSync(phaseDir, { recursive: true });
|
||||
fs.writeFileSync(path.join(phaseDir, '01-01-PLAN.md'), '# Plan\n');
|
||||
fs.writeFileSync(path.join(phaseDir, '01-01-SUMMARY.md'), '# Summary\n');
|
||||
|
||||
const res = runGsdTools(['verification', 'status', phaseDir, '--pick', 'status'], projectDir);
|
||||
assert.equal(res.success, true, `verification status should succeed: ${res.error}`);
|
||||
assert.equal(res.output, 'missing', 'no VERIFICATION.md at all → status must be missing');
|
||||
} finally {
|
||||
cleanup(projectDir);
|
||||
}
|
||||
});
|
||||
|
||||
test('D2: same fixture plus a passed *-VERIFICATION.md → status is not missing', () => {
|
||||
const projectDir = createTempGitProject();
|
||||
try {
|
||||
const phaseDir = path.join(projectDir, '.planning', 'phases', '01-example');
|
||||
fs.mkdirSync(phaseDir, { recursive: true });
|
||||
fs.writeFileSync(path.join(phaseDir, '01-01-PLAN.md'), '# Plan\n');
|
||||
fs.writeFileSync(path.join(phaseDir, '01-01-SUMMARY.md'), '# Summary\n');
|
||||
fs.writeFileSync(
|
||||
path.join(phaseDir, '01-VERIFICATION.md'),
|
||||
'---\nstatus: passed\n---\n\n# Verification\n',
|
||||
);
|
||||
|
||||
const res = runGsdTools(['verification', 'status', phaseDir, '--pick', 'status'], projectDir);
|
||||
assert.equal(res.success, true, `verification status should succeed: ${res.error}`);
|
||||
assert.notEqual(res.output, 'missing', 'a passed VERIFICATION.md must not read as missing');
|
||||
assert.equal(res.output, 'passed');
|
||||
} finally {
|
||||
cleanup(projectDir);
|
||||
}
|
||||
});
|
||||
|
||||
test('D3: one plan lacking a SUMMARY and no verification → still missing (not conflated with "stranded")', () => {
|
||||
const projectDir = createTempGitProject();
|
||||
try {
|
||||
const phaseDir = path.join(projectDir, '.planning', 'phases', '01-example');
|
||||
fs.mkdirSync(phaseDir, { recursive: true });
|
||||
fs.writeFileSync(path.join(phaseDir, '01-01-PLAN.md'), '# Plan 1\n');
|
||||
fs.writeFileSync(path.join(phaseDir, '01-01-SUMMARY.md'), '# Summary 1\n');
|
||||
// 01-02 has a PLAN but no SUMMARY — plan work is still outstanding, which is
|
||||
// a different condition from the phase being "stranded" (all plans done,
|
||||
// verification never ran). The query must not conflate the two.
|
||||
fs.writeFileSync(path.join(phaseDir, '01-02-PLAN.md'), '# Plan 2\n');
|
||||
|
||||
const res = runGsdTools(['verification', 'status', phaseDir, '--pick', 'status'], projectDir);
|
||||
assert.equal(res.success, true, `verification status should succeed: ${res.error}`);
|
||||
assert.equal(
|
||||
res.output,
|
||||
'missing',
|
||||
'outstanding plan work must not change verification status away from missing',
|
||||
);
|
||||
} finally {
|
||||
cleanup(projectDir);
|
||||
}
|
||||
});
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user