fix(#2760): defensive Codex install — strip legacy agents blocks, default hooks to AoT, validate post-write schema (#2785)
* fix(#2760): defensive Codex install — strip legacy agents blocks, default hooks to AoT, validate post-write schema Three defects, three defensive fixes shipped together. Issue reporter never returned with the requested diagnostic backup, but four additional users have since confirmed the same Codex breakage and ZakAnun confirmed manual cleanup is the only working workaround — defensive triple ships without the original backup grep, justified by the corroborating reports. Fix 1 (defect 3 — confirmed real). The Codex hooks emit path always appended a top-level `[[hooks]]` AoT block, which collides with users who already use the namespaced AoT form `[[hooks.SessionStart]]`. New helper `hasUserNamespacedAotHooks()` detects the user's preferred shape on parse and the install emits the GSD-managed hook in that same shape when present. Default for fresh configs stays at top-level `[[hooks]]` so status-quo behavior is preserved. Fix 2 (defects 1+2 — defensive). `stripLeakedGsdCodexSections()` (the install-time stripper) now always purges bare `[agents]` single-bracket tables and `[[agents]]` sequence tables regardless of GSD marker presence — both forms are invalid in current Codex schema and produce "invalid type: ..., expected struct AgentsToml". Previously gated on GSD-name lookup which missed marker-stripped configs and third-party authored entries. The uninstall-time stripper (`stripCodexGsdAgentSections`) keeps its old conservative behavior so user-authored entries survive uninstall. Fix 3 (defensive). Post-write schema validation parses the bytes about to be committed and asserts no bare `[agents]`, no `[[agents]]`, and no bare `[hooks.<Event>]` tables remain. On failure the install restores the pre-install backup of config.toml and aborts loudly so the user is never left with a Codex CLI that refuses to load. Pre-install snapshot is captured before installCodexConfig runs (not after) so restore returns the file to its true pre-GSD state. Tests added (10 new, 1 updated): - bug-2760-codex-install-defensive.test.cjs (10 new tests across 4 describes: hooks AoT preservation, strip robustness for both [agents] and [[agents]] without marker, schema validator behavior, abort+restore via test seam) - codex-config.test.cjs "case 2 ..." updated to reflect new defensive bare-[agents] purge Full suite: 5747 pass / 0 fail. Closes #2760 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(#2760): normalize Codex hooks emit field name across migration and managed paths The migrateCodexHooksMapFormat path emitted `type = "<TYPE>"` for legacy [hooks.TYPE] sections, while the GSD-managed Codex install emitted `event = "SessionStart"` — same target [[hooks]] schema, two different field names. Codex currently tolerates both via permissive parsing, but the moment one path tightens this becomes a silent #2760-class regression. Normalize both call sites on `event` (the existing GSD-managed convention). Update migration emit, docstring, and existing migration assertions to match. Add a parity regression test that drives both code paths and asserts the [[hooks]] field key is identical. * test(#2153): fix test isolation by building hooks/dist on demand The "Codex install copies hook file (#2153)" regression depends on hooks/dist/ being populated, but that directory is gitignored and only built by `npm run build:hooks`. The npm pretest chain runs `build:sdk` but not `build:hooks`, so when this file is run in isolation (`node --test tests/codex-config.test.cjs`) the hook copy step skips silently and the regression test fails on a stale-environment artifact rather than a real bug. Add a top-level before() hook that runs scripts/build-hooks.js when hooks/dist/ is missing or empty. Matches the pattern already used by bug-1834-sh-hooks-installed and other install integration tests, so the suite passes regardless of runner ordering or which tests are targeted. * fix(#2760): structural TOML validation, atomic writes, and behavioral test rewrites Addresses CodeRabbit review on PR #2785 plus source-grep violations the maintainer flagged in the regression test. Fix 1 (CR 3149606220) — validateCodexConfigSchema now parses the TOML into a structured object first via the new parseTomlToObject helper, then runs schema-shape checks against both the parsed structure and the table section headers. Malformed TOML with valid-looking headers no longer slips past validation. Fix 2 (CR 3149606224) — Replaced the four source-grep assertions in tests/bug-2760-codex-install-defensive.test.cjs (lines 109, 125, 169, 201) with structural assertions against the parsed TOML object via the exported parseTomlToObject helper. Tests now verify behavior (the file parses and contains the expected structure) instead of literal byte patterns. Robust to formatting changes — exactly what the regex-loosening suggestion was reaching for, done correctly. Confirmed clean by `npm run lint:tests` (0 violations). Fix 3 (CR 3149606234) — The describe block that mutates installModule.__codexSchemaValidator now runs with concurrency: false so the test seam mutation cannot leak into sibling suites that also call runCodexInstall. Fix 4 (CR outside-diff) — Approach (b): atomic temp-file + renameSync. Added atomicWriteFileSync helper used by mergeCodexConfig and the final hooks-write. A mid-write failure leaves the .tmp-<pid>-<n> sibling behind (cleaned up immediately) and never truncates the original config.toml. Paired with try/catch wrapping around the entire post-snapshot mutation sequence so any unexpected throw also triggers restoreCodexSnapshot. Two layers of defense: atomic write prevents the corruption window, snapshot restore handles non-atomic write paths. Added behavioral test for fix 4: stubs fs.renameSync to throw on the configPath rename, asserts the on-disk bytes match the pre-install snapshot byte-for-byte, asserts the parsed structure is still the user's [model] section (no half-written GSD agents block), and asserts no stray .tmp-* files remain. Marked concurrency: false because it monkey-patches a global. Test results: 5749/5749 pass, 0 fail. lint:tests clean. * test(#2760): TOML-parse based assertions for bare-agents purge and hook-field parity (CodeRabbit follow-up) * fix(#2760): treat write failures as fatal, strip legacy hooks before guard, tighten TOML parser (CR4) CR4 finding 1 (MAJOR) — Write failures silently succeeded. The inner catch around atomicWriteFileSync restored the snapshot then re-threw, but the outer catch only matched 'post-write Codex schema validation failed' and downgraded everything else to a warn-and-continue. Install finished with "Done!" while Codex had no GSD agents configured. Fix: wrap writeErr with a `post-write Codex install failed:` prefix and broaden the outer guard to `.startsWith( 'post-write')` so both schema-validation and write failures abort install. CR4 finding 2 (MAJOR) — Legacy flat [[hooks]] block prevented namespaced AoT upgrade. The `!configContent.includes('gsd-check-update')` guard short- circuited the new namespaced emit when an existing install had the legacy flat [[hooks]] block, leaving users stuck in the mixed layout this fix is designed to eliminate. Fix: strip ALL existing managed gsd-check-update hook blocks (top-level [[hooks]] AND namespaced [[hooks.SessionStart]]) BEFORE evaluating the includes guard, so every install converges on the right shape regardless of prior state. CR4 finding 3 (MAJOR) — Homegrown TOML parser silently accepted malformed input. parseTomlValue happily consumed the `0` prefix of `timeout = 0.5` and parseTomlToObject did not verify the full RHS was consumed, so `key = "x" junk` and date/time literals slipped through. Per CONTRIBUTING ("No external dependencies in core"), option (b) was chosen over adding @iarna/toml: (a) parseTomlValue rejects any integer immediately followed by `.`, `e`, `E`, `:`, `-`, `T`, or `Z` (floats / dates / times); (b) parseTomlToObject scans from parsed.end to the next newline and throws `trailing bytes after value` if anything other than whitespace + optional `# comment` is present. * test(#2760): add CR4 regression tests + scope GSD_TEST_MODE + rename rename-fault test CR4 finding 5 (NIT) — GSD_TEST_MODE leak. Saved previous value, set '1' for the require, then restored (delete if undefined). No more test-only env var leaking to siblings in the same node process. CR4 finding 4 (NIT) — Renamed the existing fix-4 test from 'fs.writeFileSync' to 'fs.renameSync' (the only call actually faulted) and added a sibling test that stubs fs.writeFileSync to throw on the .tmp- target — exercising the pre-rename branch of atomicWriteFileSync that was previously untested. Both serialize via concurrency: false on the existing describe block. CR4 finding 1 (MAJOR test) — New behavioral test asserts install throws with a `post-write Codex install failed` message AND never prints "Done!" when the hook-block atomic rename fails. Captures stdout via console.log stub, asserts byte equality of restored snapshot. Faults only the rename whose temp source contains gsd-check-update so earlier mergeCodexConfig writes are not collateral damage. CR4 finding 2 (MAJOR test) — New TOML-parsed behavioral test for the legacy-hook upgrade path: pre-install has [[hooks.SessionStart]] (user) + legacy flat [[hooks]] managed gsd-check-update entry; post-install must have hooks.SessionStart as Array-of-tables with both user hook and GSD entry, and no top-level [[hooks]] AoT remaining. Also asserts exactly one gsd-check-update entry (no duplicates). CR4 finding 3 (MAJOR test) — parseTomlToObject regression suite: rejects floats (timeout = 0.5), dates (created = 1979-05-27), trailing garbage (key = "x" junk), and accepts trailing whitespace + # comment. * fix(#2760): CR5 — pre-write fatal, TOML duplicate-key/header rejection, namespaced AoT migration Address all five CodeRabbit round-5 findings on PR #2785: Finding 1 (MAJOR) — Pre-write failures in the Codex hook configuration catch (around bin/install.js:7002) used to fall through to console.warn even though restoreCodexSnapshot() had already run. This produced "Done!" output with no Codex hooks configured. Now wraps the original error with a "(pre-write)" prefix and rethrows so install aborts loudly. Same defect class as CR4 finding 1, different layer. Finding 2 (MAJOR) — parseTomlToObject silently reused existing tables and overwrote duplicate keys. Real TOML 1.0 rejects: - duplicate scalar key in same table ([a]\nx=1\nx=2) - re-declared [a] header (two [a] sections) - [[arr]] then [arr] for same path (shape mismatch) Tracks pathShape, declaredHeaders, and per-table-instance key sets; throws "duplicate or shape-mismatched table header at <path>" or "duplicate key <name> in <path>". Finding 3 (MAJOR) — migrateCodexHooksMapFormat used to emit flat [[hooks]]\nevent="<TYPE>", which produced mixed flat+namespaced layouts when the user already had [[hooks.<OTHER>]] entries. Now emits [[hooks.<TYPE>]] directly (the namespace IS the event); managed-emit detector hasUserNamespacedAotHooks fires correctly so the install converges on a single namespaced layout regardless of pre-existing state. Finding 4 (NIT) — tests/bug-2760-codex-install-defensive.test.cjs rename-failure test tightened from "throw OR warn acceptable" to assert.equal(threw, true), locking the contract Finding 1 establishes. Finding 5 (NIT) — bug-2760 test suite snapshots and restores fs.renameSync defensively in beforeEach/afterEach (symmetric with fs.writeFileSync), removing the fragile per-test try/finally. Second test in the same suite cleaned up to drop its try/finally. Updates tests/codex-config.test.cjs to assert the new namespaced AoT migration shape via parseTomlToObject (no source-grep). Existing field- parity test reframed as shape-parity since both paths now emit namespaced. Tests: 5764 pass (+8 new). lint:tests: 0 violations. * docs(#2760): add CHANGELOG entry for Codex install defensive triple Adds the [Unreleased] Fixed entry for the Codex install fix landed in this PR — defensive strip of legacy [agents]/[[agents]] blocks, namespaced AoT hook detection across all events, atomic write + rollback, strict TOML validation rejecting duplicate keys/repeated headers/trailing bytes. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Tom Boucher
@@ -8,11 +8,30 @@
|
||||
// Enable test exports from install.js (skips main CLI logic)
|
||||
process.env.GSD_TEST_MODE = '1';
|
||||
|
||||
const { test, describe, beforeEach, afterEach } = require('node:test');
|
||||
const { test, describe, before, beforeEach, afterEach } = require('node:test');
|
||||
const assert = require('node:assert/strict');
|
||||
const fs = require('fs');
|
||||
const path = require('path');
|
||||
const os = require('os');
|
||||
const { execFileSync } = require('child_process');
|
||||
|
||||
// #2153 follow-up: ensure hooks/dist/ exists before any install integration
|
||||
// test runs. The Codex install path copies hook files from hooks/dist/, which
|
||||
// is gitignored and only populated by `npm run build:hooks`. When this file is
|
||||
// run in isolation (`node --test tests/codex-config.test.cjs`) the build step
|
||||
// from the npm-test pretest chain does not run, and the "Codex install copies
|
||||
// hook file" regression silently fails because hooks/dist/ is empty.
|
||||
// Build on demand so the test passes regardless of runner ordering.
|
||||
const HOOKS_DIST = path.join(__dirname, '..', 'hooks', 'dist');
|
||||
const BUILD_HOOKS_SCRIPT = path.join(__dirname, '..', 'scripts', 'build-hooks.js');
|
||||
before(() => {
|
||||
if (!fs.existsSync(HOOKS_DIST) || fs.readdirSync(HOOKS_DIST).length === 0) {
|
||||
execFileSync(process.execPath, [BUILD_HOOKS_SCRIPT], {
|
||||
encoding: 'utf-8',
|
||||
stdio: 'pipe',
|
||||
});
|
||||
}
|
||||
});
|
||||
|
||||
const {
|
||||
getCodexSkillAdapterHeader,
|
||||
@@ -26,6 +45,7 @@ const {
|
||||
install,
|
||||
GSD_CODEX_MARKER,
|
||||
CODEX_AGENT_SANDBOX,
|
||||
parseTomlToObject,
|
||||
} = require('../bin/install.js');
|
||||
|
||||
function runCodexInstall(codexHome, cwd = path.join(__dirname, '..')) {
|
||||
@@ -575,7 +595,7 @@ describe('migrateCodexHooksMapFormat', () => {
|
||||
assert.strictEqual(migrateCodexHooksMapFormat(''), '');
|
||||
});
|
||||
|
||||
test('converts [hooks.shell] with command key to [[hooks]] with type = "shell"', () => {
|
||||
test('converts [hooks.shell] to namespaced AoT [[hooks.shell]] (#2760 CR5 finding 3)', () => {
|
||||
const content = [
|
||||
'[features]',
|
||||
'codex_hooks = true',
|
||||
@@ -587,34 +607,38 @@ describe('migrateCodexHooksMapFormat', () => {
|
||||
'',
|
||||
].join('\n');
|
||||
const result = migrateCodexHooksMapFormat(content);
|
||||
// Old format removed
|
||||
assert.ok(!result.includes('[hooks.shell]'), 'removes [hooks.shell] map header');
|
||||
assert.ok(!result.match(/^\[hooks\]$/m), 'removes bare [hooks] container');
|
||||
// New format present
|
||||
assert.ok(result.includes('[[hooks]]'), 'adds [[hooks]] array header');
|
||||
assert.ok(result.includes('type = "shell"'), 'adds type = "shell" key');
|
||||
assert.ok(result.includes('command = "node /home/.codex/hooks/gsd-check-update.js"'), 'preserves command value');
|
||||
// User content preserved
|
||||
assert.ok(result.includes('[features]'), 'preserves [features] section');
|
||||
assert.ok(result.includes('codex_hooks = true'), 'preserves codex_hooks key');
|
||||
// Parse structurally — no source-grep on raw bytes.
|
||||
const parsed = parseTomlToObject(result);
|
||||
assert.ok(parsed.hooks && Array.isArray(parsed.hooks.shell),
|
||||
'hooks.shell must be an array of tables, got: ' + (parsed.hooks ? typeof parsed.hooks.shell : 'no hooks table'));
|
||||
assert.strictEqual(parsed.hooks.shell.length, 1);
|
||||
assert.strictEqual(parsed.hooks.shell[0].command, 'node /home/.codex/hooks/gsd-check-update.js');
|
||||
// No flat top-level [[hooks]] AoT and no synthetic event field.
|
||||
assert.ok(!Array.isArray(parsed.hooks),
|
||||
'no top-level [[hooks]] AoT — namespace IS the event in CR5 form');
|
||||
assert.equal(parsed.hooks.shell[0].event, undefined,
|
||||
'no synthetic event field — namespace [[hooks.shell]] encodes the event');
|
||||
// User content preserved.
|
||||
assert.equal(parsed.features && parsed.features.codex_hooks, true);
|
||||
});
|
||||
|
||||
test('converts [hooks.exec] to [[hooks]] with type = "exec"', () => {
|
||||
test('converts [hooks.exec] to namespaced AoT [[hooks.exec]] (#2760 CR5 finding 3)', () => {
|
||||
const content = [
|
||||
'[hooks.exec]',
|
||||
'command = "echo hello"',
|
||||
'event = "SessionStart"',
|
||||
'extra_key = "preserved"',
|
||||
'',
|
||||
].join('\n');
|
||||
const result = migrateCodexHooksMapFormat(content);
|
||||
assert.ok(!result.includes('[hooks.exec]'), 'removes [hooks.exec] map header');
|
||||
assert.ok(result.includes('[[hooks]]'), 'adds [[hooks]] array header');
|
||||
assert.ok(result.includes('type = "exec"'), 'adds type = "exec" key');
|
||||
assert.ok(result.includes('command = "echo hello"'), 'preserves command');
|
||||
assert.ok(result.includes('event = "SessionStart"'), 'preserves event');
|
||||
const parsed = parseTomlToObject(result);
|
||||
assert.ok(parsed.hooks && Array.isArray(parsed.hooks.exec));
|
||||
assert.strictEqual(parsed.hooks.exec.length, 1);
|
||||
assert.strictEqual(parsed.hooks.exec[0].command, 'echo hello');
|
||||
assert.strictEqual(parsed.hooks.exec[0].extra_key, 'preserved');
|
||||
assert.equal(parsed.hooks.exec[0].event, undefined);
|
||||
});
|
||||
|
||||
test('converts multiple [hooks.TYPE] sections to separate [[hooks]] blocks', () => {
|
||||
test('converts multiple [hooks.TYPE] sections to separate namespaced AoT blocks (#2760 CR5 finding 3)', () => {
|
||||
const content = [
|
||||
'[hooks.shell]',
|
||||
'command = "node /home/.codex/hooks/gsd-check-update.js"',
|
||||
@@ -624,12 +648,13 @@ describe('migrateCodexHooksMapFormat', () => {
|
||||
'',
|
||||
].join('\n');
|
||||
const result = migrateCodexHooksMapFormat(content);
|
||||
assert.ok(!result.includes('[hooks.shell]'), 'removes [hooks.shell]');
|
||||
assert.ok(!result.includes('[hooks.exec]'), 'removes [hooks.exec]');
|
||||
const hookHeaders = (result.match(/\[\[hooks\]\]/g) || []).length;
|
||||
assert.strictEqual(hookHeaders, 2, 'produces two [[hooks]] array entries');
|
||||
assert.ok(result.includes('type = "shell"'), 'first entry has type = "shell"');
|
||||
assert.ok(result.includes('type = "exec"'), 'second entry has type = "exec"');
|
||||
const parsed = parseTomlToObject(result);
|
||||
assert.ok(parsed.hooks && Array.isArray(parsed.hooks.shell));
|
||||
assert.ok(parsed.hooks && Array.isArray(parsed.hooks.exec));
|
||||
assert.strictEqual(parsed.hooks.shell.length, 1);
|
||||
assert.strictEqual(parsed.hooks.exec.length, 1);
|
||||
assert.strictEqual(parsed.hooks.shell[0].command, 'node /home/.codex/hooks/gsd-check-update.js');
|
||||
assert.strictEqual(parsed.hooks.exec[0].command, 'echo done');
|
||||
});
|
||||
|
||||
test('leaves user-authored [[hooks]] array entries untouched when no legacy [hooks] map present', () => {
|
||||
@@ -642,7 +667,7 @@ describe('migrateCodexHooksMapFormat', () => {
|
||||
assert.strictEqual(migrateCodexHooksMapFormat(content), content);
|
||||
});
|
||||
|
||||
test('end-to-end: install on config with old [hooks] map format produces [[hooks]] array format (#2637)', () => {
|
||||
test('end-to-end: install on config with old [hooks] map format produces namespaced AoT (#2637, #2760 CR5)', () => {
|
||||
// Simulates the exact old GSD config.toml format that broke on Codex 0.124.0
|
||||
const oldContent = [
|
||||
'[features]',
|
||||
@@ -655,18 +680,15 @@ describe('migrateCodexHooksMapFormat', () => {
|
||||
'',
|
||||
].join('\n');
|
||||
const result = migrateCodexHooksMapFormat(oldContent);
|
||||
// Must not contain any [hooks] or [hooks.*] map-style headers
|
||||
assert.ok(!result.match(/^\s*\[hooks\]\s*$/m), 'no bare [hooks] map header');
|
||||
assert.ok(!result.match(/^\s*\[hooks\./m), 'no [hooks.TYPE] map headers');
|
||||
// Must contain [[hooks]] array format
|
||||
assert.ok(result.includes('[[hooks]]'), 'has [[hooks]] array-of-tables header');
|
||||
// type key must be present
|
||||
assert.ok(result.includes('type = "shell"'), 'has type = "shell" in [[hooks]] entry');
|
||||
// command is preserved
|
||||
assert.ok(result.includes('command = "node /home/.codex/hooks/gsd-check-update.js"'), 'command preserved');
|
||||
// [features] user content preserved
|
||||
assert.ok(result.includes('[features]'), 'preserves [features]');
|
||||
assert.ok(result.includes('codex_hooks = true'), 'preserves codex_hooks');
|
||||
const parsed = parseTomlToObject(result);
|
||||
// Codex 0.124.0+: must produce array-of-tables form. CR5 finding 3:
|
||||
// namespaced AoT [[hooks.shell]] (no flat [[hooks]] with synthetic event).
|
||||
assert.ok(parsed.hooks && Array.isArray(parsed.hooks.shell),
|
||||
'hooks.shell must be array-of-tables in namespaced form');
|
||||
assert.strictEqual(parsed.hooks.shell.length, 1);
|
||||
assert.strictEqual(parsed.hooks.shell[0].command,
|
||||
'node /home/.codex/hooks/gsd-check-update.js');
|
||||
assert.equal(parsed.features && parsed.features.codex_hooks, true);
|
||||
});
|
||||
|
||||
test('bare [hooks] section without sub-tables is dropped (no [[hooks]] block added)', () => {
|
||||
@@ -688,7 +710,7 @@ describe('migrateCodexHooksMapFormat', () => {
|
||||
assert.ok(result.includes('[model]'), 'preserves [model]');
|
||||
});
|
||||
|
||||
test('CRLF line endings are preserved through migration', () => {
|
||||
test('CRLF line endings are preserved through migration (#2760 CR5: namespaced AoT)', () => {
|
||||
const content = [
|
||||
'[features]',
|
||||
'codex_hooks = true',
|
||||
@@ -698,9 +720,58 @@ describe('migrateCodexHooksMapFormat', () => {
|
||||
'',
|
||||
].join('\r\n');
|
||||
const result = migrateCodexHooksMapFormat(content);
|
||||
assert.ok(result.includes('[[hooks]]\r\n'), 'uses CRLF in [[hooks]] header');
|
||||
assert.ok(result.includes('type = "shell"\r\n'), 'uses CRLF in type line');
|
||||
assert.ok(!result.includes('[hooks.shell]'), 'removes legacy [hooks.shell]');
|
||||
assert.ok(result.includes('[[hooks.shell]]\r\n'),
|
||||
'uses CRLF in namespaced [[hooks.shell]] header');
|
||||
// Round-trip parse confirms the structural shape independent of EOL.
|
||||
const parsed = parseTomlToObject(result);
|
||||
assert.ok(parsed.hooks && Array.isArray(parsed.hooks.shell));
|
||||
assert.strictEqual(parsed.hooks.shell[0].command,
|
||||
'node /home/.codex/hooks/gsd-check-update.js');
|
||||
});
|
||||
});
|
||||
|
||||
// ─── shape parity between migration and managed emit (#2760 CR5 finding 3) ──
|
||||
|
||||
describe('Codex hooks emit: migration produces namespaced AoT so managed-emit converges', () => {
|
||||
// After #2760 CR5 finding 3, the legacy migration path
|
||||
// (migrateCodexHooksMapFormat) emits `[[hooks.<TYPE>]]` directly — the
|
||||
// namespace IS the event, no synthetic `event = ...` field. The managed
|
||||
// install path (writes "# GSD Hooks") detects existing namespaced AoT via
|
||||
// hasUserNamespacedAotHooks and emits its block in the same shape. The two
|
||||
// paths must therefore both produce a namespaced layout when a legacy
|
||||
// [hooks.SessionStart] is migrated, eliminating the mixed flat+namespaced
|
||||
// bug class entirely.
|
||||
|
||||
let tmpDir;
|
||||
beforeEach(() => {
|
||||
tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'gsd-codex-fieldparity-'));
|
||||
});
|
||||
afterEach(() => {
|
||||
fs.rmSync(tmpDir, { recursive: true, force: true });
|
||||
});
|
||||
|
||||
test('migration of legacy [hooks.SessionStart] produces namespaced AoT', () => {
|
||||
const legacyContent = [
|
||||
'[features]',
|
||||
'codex_hooks = true',
|
||||
'',
|
||||
'[hooks.SessionStart]',
|
||||
'command = "node /home/.codex/hooks/gsd-check-update.js"',
|
||||
'',
|
||||
].join('\n');
|
||||
const migrated = migrateCodexHooksMapFormat(legacyContent);
|
||||
const parsed = parseTomlToObject(migrated);
|
||||
assert.ok(
|
||||
parsed.hooks && Array.isArray(parsed.hooks.SessionStart),
|
||||
'migration must emit [[hooks.SessionStart]] namespaced AoT'
|
||||
);
|
||||
assert.equal(parsed.hooks.SessionStart[0].event, undefined,
|
||||
'migration must NOT emit a synthetic event field — namespace IS the event');
|
||||
assert.equal(
|
||||
Array.isArray(parsed.hooks),
|
||||
false,
|
||||
'migration must NOT emit a flat top-level [[hooks]] AoT'
|
||||
);
|
||||
});
|
||||
});
|
||||
|
||||
@@ -929,7 +1000,7 @@ describe('mergeCodexConfig', () => {
|
||||
assertUsesOnlyEol(content, '\r\n');
|
||||
});
|
||||
|
||||
test('case 2 preserves user-authored [agents] tables while stripping leaked GSD sections in CRLF files', () => {
|
||||
test('case 2 strips bare [agents] tables (invalid in current Codex schema, #2760) and removes leaked GSD sections in CRLF files', () => {
|
||||
const configPath = path.join(tmpDir, 'config.toml');
|
||||
const brokenContent = [
|
||||
'[features]',
|
||||
@@ -958,8 +1029,24 @@ describe('mergeCodexConfig', () => {
|
||||
const markerIndex = content.indexOf(GSD_CODEX_MARKER);
|
||||
const beforeMarker = content.slice(0, markerIndex);
|
||||
|
||||
assert.ok(beforeMarker.includes('[agents]\r\ndefault = "custom-agent"\r\n'), 'preserves user-authored [agents] table');
|
||||
assert.strictEqual(countMatches(beforeMarker, /^\[agents\.gsd-executor\]\s*$/gm), 0, 'removes leaked GSD agent section above marker');
|
||||
// Bare [agents] is invalid under Codex's current schema (rejected with
|
||||
// "expected struct AgentsToml") so install-time stripping always purges
|
||||
// it (#2760). User feature keys above the marker are preserved.
|
||||
// Structural assertion: TOML-parse the pre-marker region and verify the
|
||||
// bare [agents] block is fully gone — header AND body keys (e.g.,
|
||||
// `default = "custom-agent"`). A header-only check would miss a
|
||||
// partial-strip regression that leaves orphan body keys reparented to a
|
||||
// sibling section.
|
||||
const parsedBefore = parseTomlToObject(beforeMarker);
|
||||
assert.equal(
|
||||
parsedBefore.agents,
|
||||
undefined,
|
||||
'bare [agents] block fully purged including body keys (#2760)',
|
||||
);
|
||||
assert.ok(
|
||||
parsedBefore.features && parsedBefore.features.child_agents_md === false,
|
||||
'preserves user feature keys above marker',
|
||||
);
|
||||
// New struct format: exactly one [agents.gsd-executor] in the GSD block (after marker)
|
||||
assert.strictEqual(countMatches(content, /^\[agents\.gsd-executor\]\s*$/gm), 1, 'exactly one struct agent header in GSD block');
|
||||
assert.strictEqual(countMatches(content, /name = "gsd-executor"/g), 0, 'no name = field in struct format');
|
||||
|
||||
Reference in New Issue
Block a user