golem15/msd-core
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(#1943): extensionEvents vocabulary — separate from hookEvents (extension-system surface) (#1946)

Browse Source 
* feat(#1943): extensionEvents vocabulary — separate from hookEvents (extension-system surface)

* fix(#1943): re-export VALID_EXTENSION_EVENTS from gen-capability-registry (test import path)

* fix(#1943): regenerate capability-registry.cjs + add changeset fragment

* fix(#1943): import VALID_EXTENSION_EVENTS from validator, not gen-capability-registry (golden parity)
This commit is contained in:
Tom Boucher
2026-07-02 21:45:35 -04:00
committed by GitHub
parent d3d689a5e9
commit b51cbf96cf
11 changed files with 157 additions and 47 deletions
Download Patch File Download Diff File Expand all files Collapse all files

52
tests/host-integration.test.cjs
View File

@@ -23,34 +23,60 @@ const {
negotiateHostCapabilities,
hookEventSurfaceFor,
HOOK_EVENT_SURFACES,
extensionEventSurfaceFor,
EXTENSION_EVENT_SURFACES,
} = hi;
describe('hookEventSurfaceFor (hookEvents dialect consumer — #1682)', () => {
test('returns the full Claude surface for "claude"', () => {
describe('hookEventSurfaceFor (MANAGED-hook dialect consumer — claude/gemini only)', () => {
test('returns the full Claude managed-hook surface for "claude"', () => {
const s = hookEventSurfaceFor('claude');
assert.ok(s && s.includes('PreToolUse') && s.includes('PostToolUse') && s.includes('Stop'));
});
test('returns the Gemini BeforeTool/AfterTool surface for "gemini"', () => {
test('returns the Gemini BeforeTool/AfterTool managed-hook surface for "gemini"', () => {
const s = hookEventSurfaceFor('gemini');
assert.ok(s && s.includes('BeforeTool') && s.includes('AfterTool'));
});
test('CONSUMES "opencode-subset": OpenCode session/tool/file subset with NO workflow-phase events', () => {
const s = hookEventSurfaceFor('opencode-subset');
assert.ok(s, 'opencode-subset must resolve (non-null) — it is consumed, not reserved');
assert.ok(s.includes('experimental.session.compacting'));
assert.ok(s.includes('session.idle'));
assert.ok(s.includes('tool.execute.before') && s.includes('tool.execute.after'));
assert.ok(!s.some((e) => /plan:|verify:|ship:|execute:/.test(e)),
'opencode-subset fires no workflow-phase events (engine owns phase sequencing)');
test('hookEvents is the MANAGED-hook dialect only — opencode-subset is NOT here (#1943)', () => {
assert.equal(hookEventSurfaceFor('opencode-subset'), null,
'opencode-subset is not a hookEvents value — it moved to the extensionEvents vocabulary');
});
test('returns null for unknown / missing / non-string dialect (fail-closed)', () => {
assert.equal(hookEventSurfaceFor('nope'), null);
assert.equal(hookEventSurfaceFor(undefined), null);
assert.equal(hookEventSurfaceFor(123), null);
});
test('HOOK_EVENT_SURFACES is frozen + covers exactly the 3 dialects', () => {
test('HOOK_EVENT_SURFACES is frozen + covers exactly the 2 managed-hook dialects', () => {
assert.equal(Object.isFrozen(HOOK_EVENT_SURFACES), true);
assert.deepEqual(Object.keys(HOOK_EVENT_SURFACES).sort(), ['claude', 'gemini', 'opencode-subset']);
assert.deepEqual(Object.keys(HOOK_EVENT_SURFACES).sort(), ['claude', 'gemini']);
});
});
describe('extensionEventSurfaceFor (extension-system event dialect — #1943)', () => {
test('opencode = OpenCode plugin event subset with NO workflow-phase events', () => {
const s = extensionEventSurfaceFor('opencode');
assert.ok(s, 'opencode must resolve (non-null) — it is a consumed extensionEvents value');
assert.ok(s.includes('experimental.session.compacting'));
assert.ok(s.includes('session.idle'));
assert.ok(s.includes('tool.execute.before') && s.includes('tool.execute.after'));
assert.ok(!s.some((e) => /plan:|verify:|ship:/.test(e)),
'opencode extension events include no workflow-phase events (engine owns phase sequencing)');
});
test('pi resolves (extension-system dialect)', () => {
const s = extensionEventSurfaceFor('pi');
assert.ok(Array.isArray(s), 'pi is a consumed extensionEvents value');
});
test('none = empty surface (host exposes no extension events; engine owns the bus)', () => {
assert.deepEqual(extensionEventSurfaceFor('none'), []);
});
test('returns null for unknown / missing / non-string dialect (fail-closed)', () => {
assert.equal(extensionEventSurfaceFor('opencode-subset'), null,
'the old opencode-subset name is gone — use extensionEventSurfaceFor("opencode")');
assert.equal(extensionEventSurfaceFor('nope'), null);
assert.equal(extensionEventSurfaceFor(undefined), null);
});
test('EXTENSION_EVENT_SURFACES is frozen + covers opencode/pi/none', () => {
assert.equal(Object.isFrozen(EXTENSION_EVENT_SURFACES), true);
assert.deepEqual(Object.keys(EXTENSION_EVENT_SURFACES).sort(), ['none', 'opencode', 'pi']);
});
});