* fix(#4709): retire the Gemini CLI reviewer lane
Google stopped serving Gemini CLI for the free/Pro/Ultra tiers on 2026-06-18 —
the same sunset that removed the gemini RUNTIME in #1928 (shipped 1.8.0). GSD
targets solo developers, so those tiers ARE the user path: the lane spawned
`gemini {{model}} -p -`, a binary that no longer answers for the majority of
users, and five locales documented it as a supported choice.
The lane was re-created after #1928 by the reviewer-lane-as-manifest-data work
(6a9babda69, #2798/#2837, ADR-2782). Per the maintainer that re-creation was an
error in that buildout rather than a considered decision, so this corrects a
mistake and needs no ADR-2782 amendment.
Reviewer roster: 12 lanes / 13 flags -> 11 lanes / 12 flags.
TWO sources of truth had to be removed, not one. Deleting
capabilities/gemini/capability.json left the capability registry at 11 lanes
while src/review-lane-descriptor.cts's hand-maintained REVIEWER_LANES array
still carried its own complete gemini entry at 12 — precisely the disagreement
checkReviewerLaneParity exists to catch. Both are gone; both parity checkers
now run clean against the real tree (lane parity ok/0 violations, docs parity
0 violations).
Surfaces stripped of the dead flag:
- capabilities/gemini/ deleted; registry and capability-matrix regenerated
- src/review-lane-descriptor.cts: REVIEWER_LANES entry, docblock count, and the
three doc comments that used --gemini as a live example
- commands/gsd/{review,plan-review-convergence,autonomous,progress}.md and the
four matching skills/*/SKILL.md: argument-hint frontmatter and flag bullets
- gsd-core/workflows/help/modes/{full,full.compact}.md: /gsd-help signatures,
the detected-CLI list, and the reviewer-title list
- gsd-core/workflows/settings-integrations.md: the integrations wizard no longer
offers "Gemini" as a model option, and the settable-keys list drops it
- gsd-core/workflows/review.md: the `command -v gemini` probe, the --gemini
flag, the roster frontmatter, the install pointer to the sunset repo, and the
jq-less / precedence / self-skip lane lists
- gsd-core/workflows/sync-skills.md: "two runtimes (grok, gemini) resolve to
ANOTHER runtime's skills root" is now one runtime; gemini never aliased
anything, it fell through canonicalizeRuntimeName to a fail-closed default
- docs/{CONFIGURATION,COMMANDS,CLI-TOOLS}.md, docs/reference/capability-matrix.md,
docs/how-to/set-up-cross-ai-review.md — including its `npm install -g
@google/gemini-cli` instruction and the two rows recommending --gemini
- docs/features/{cross-ai-peer-review,opt-in-parallel-reviewer-lanes}.md as the
generator inputs behind docs/FEATURES.md, plus the three locale FEATURES.md
signature lines the docs-parity gate covers (the #2781 class: a flag change
that never reaches the mirrors)
Counts reconciled against measurement rather than arithmetic: 8 timeout keys of
11 lanes, 11 budget keys, 9 model keys, and four hardcoded literals in
tests/reviewer-lane-declarations.test.cjs (NEW_LANE_ONLY_IDS 5->4, LITERAL_ROSTER
12->11, two roster counts 12->11).
BEHAVIOR CHANGE, accepted deliberately: `gsd config-set review.models.gemini`
now errors with "Unknown config key". An existing key already in
.planning/config.json still parses and is simply never read, so no project fails
to load. This is the repo's own documented policy for exactly this case
(docs/CONFIGURATION.md:327 — "a key left over from a removed reviewer validated
silently and was never read. Such a key is now rejected by config-set"), so no
installer migration ships. Note my first measurement of this was WRONG: I tested
config-get, which reads undeclared keys fine, and generalised. Read and write are
different surfaces and gave different answers.
Antigravity is untouched throughout — its --antigravity/--agy flags,
review.models.agy, ~/.gemini/antigravity configHome, ~/.gemini/config global
skills root (#3738), hookEvents "gemini", GEMINI.md instruction file, and every
gemini-* model id it actually runs on.
Refs #4709
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
* chore(#4709): changeset for the reviewer-lane retirement
Type Removed: the --gemini flag and its three config keys are user-visible
surface that no longer exists.
Refs #4709
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
* fix(#4709): close the 24 test failures and the locale-doc gap the gates found
An adversarial review and a full matrix run between them found substantially
more fallout than inspection had. All of it is this PR's own, and all of it is
fixed rather than waved off.
THE MATRIX RUN FOUND 24 FAILURES ACROSS 6 FILES. Inspection had predicted two.
The dominant class was a test helper that looks up a lane by slug and throws
`no declared lane 'gemini'`:
- tests/feat-2483-review-claude-mds-guard.test.cjs (6) — used gemini as the
"other declared first-party lane" to contrast against claude's env
suppression. Now qwen, verified from source as a lane that declares no `env`
(only claude does), so the contrast still holds.
- tests/review-lane-descriptor.test.cjs (6) — the duplicate-flag and
duplicate-section fixtures deliberately COLLIDED with a real declared lane to
prove the parity checker reports a duplicate. `--gemini`/`Gemini` no longer
collide with anything, so the checker reported
`descriptor_lane_not_in_registry:acme` instead and the tests proved nothing.
Now collide with `--codex`/`Codex`, reproduced against the real checker.
- tests/review-reviewer-selection.test.cjs (3) — these distinguish KNOWN-but-
undetected from UNKNOWN. gemini flipped categories, inverting what they
proved. The known case now uses qwen; `__nope__` stays the unknown fixture.
- tests/review-default-reviewers-resolution.test.cjs (2), and
tests/settings-integrations.test.cjs (3) — the wizard now offers three
reviewer CLIs, not four, so the test and its name say three.
- Two count assertions the earlier sweep missed outright:
reviewer-lane-declarations.test.cjs:359 (`length, 12`) and
reviewer-docs-parity.test.cjs:681 (`>= 12`).
THE LOCALE-DOC GAP, and why the parity gate stayed green over it. All four
locale mirrors still documented `--gemini` as a live reviewer flag. The
docs-parity checker asserts the PRESENCE of every current flag and never the
ABSENCE of a retired one, so "0 violations" was never evidence those files were
clean — my earlier reading of it as such was wrong. This is the #2781
locale-drift class in the opposite direction. Fixed across 12 locale files:
COMMANDS.md flag lists and table rows, CONFIGURATION.md `review.models.gemini`
rows and reviewer prose, CLI-TOOLS.md config examples, and
set-up-cross-ai-review.md including its install block and its
which-reviewer-to-choose row, which now recommends Antigravity.
ALSO FOUND, and instructive about my own method: docs/CONFIGURATION.md:297 still
carried a `review.models.gemini` row. My sweep had missed it because my grep
excluded lines matching `gemini-[0-9]` to spare Google's model ids — and that
row's example value is `"gemini-2.5-pro"` on the same line. The exclusion built
to avoid false positives created a false negative.
Remaining comment/example sites: src/review-reviewer-selection.cts:309 and
src/config.cts:598 named the dead flag and key as examples;
gsd-core/references/planning-config.md:269 likewise; and
review-reviewer-selection.cts:22 claimed in the PRESENT tense that gemini is a
lane-only reviewer capability. Line 38 of that same docblock says "Before this
phase the five non-runtime reviewers (gemini, ...)" and is left exactly as is —
that is past-tense history, and rewriting it would falsify the record.
Deliberately still deferred to Phase 4, because it is the RUNTIME axis rather
than the reviewer lane: the locale install-on-your-runtime.md `--gemini --global`
instructions, the USER-GUIDE colon-form notes, and the ARCHITECTURE
runtime-detection flag lists.
Both parity checkers green against the real tree; lint:ci exit 0.
Refs #4709
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
* chore(#4709): backfill the changeset PR number
pr: 0 -> 4716, now that the PR exists. Never guessed ahead of the number.
Refs #4709
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
---------
Co-authored-by: sim <sim@local>
Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
Tom Boucher
@@ -595,7 +595,7 @@ function _setNestedValue(
|
||||
|
||||
/**
|
||||
* Deletes a value from the config object, allowing nested values via dot
|
||||
* notation (e.g., "review.models.gemini"). Mirrors `_setNestedValue`'s
|
||||
* notation (e.g., "review.models.codex"). Mirrors `_setNestedValue`'s
|
||||
* prototype-pollution guard on every path segment (including intermediates).
|
||||
*
|
||||
* Unlike `_setNestedValue`, this NEVER creates missing intermediate objects —
|
||||
|
||||
@@ -105,7 +105,7 @@ export type LaneProbe =
|
||||
* `args` is an argv TEMPLATE, not a prefix. The injected pieces — model, effort, output file,
|
||||
* argv-borne prompt — do not all go in the same place, and no positional rule expresses that:
|
||||
* `codex` injects the model in the MIDDLE (after the `exec --ephemeral` subcommand) and the output
|
||||
* file later still, while `gemini` injects the model first and five lanes end with a bare `-` that
|
||||
* file later still, while `kimi-code` injects the model first and five lanes end with a bare `-` that
|
||||
* must stay last. Splicing by position silently produced
|
||||
* `codex --model M -o F exec --ephemeral …`, which is not a valid codex invocation.
|
||||
*
|
||||
@@ -278,36 +278,16 @@ const SPAWN_STDIN_STDOUT = {
|
||||
} as const;
|
||||
|
||||
/**
|
||||
* The twelve declared lanes, in `write_reviews` order.
|
||||
* The eleven declared lanes, in `write_reviews` order.
|
||||
*
|
||||
* The `gemini` lane was retired by #4709: Google sunset Gemini CLI on 2026-06-18 (the same
|
||||
* sunset that removed the gemini RUNTIME in #1928/1.8.0), so the lane spawned a binary that no
|
||||
* longer serves the free/Pro/Ultra tiers that are GSD's audience.
|
||||
*
|
||||
* `kimi-code` joined in Phase 5b (#2799, closes #2718) — ADR-2782's phase table lands it here
|
||||
* rather than in 5a precisely so it arrives together with the iteration that can invoke it.
|
||||
*/
|
||||
export const REVIEWER_LANES: ReadonlyArray<ReviewerLane> = Object.freeze([
|
||||
{
|
||||
slug: 'gemini',
|
||||
flags: ['--gemini'],
|
||||
transport: 'spawn',
|
||||
probe: { kind: 'command-exists', binary: 'gemini' },
|
||||
invoke: {
|
||||
binary: 'gemini',
|
||||
args: ['{{model}}', '-p', '-'],
|
||||
...SPAWN_STDIN_STDOUT,
|
||||
modelArg: '-m',
|
||||
effortChannel: 'none',
|
||||
},
|
||||
timeoutFloorMs: 900_000,
|
||||
timeoutConfigKey: 'review.timeouts.gemini',
|
||||
emptyOutput: 'stub-with-stderr',
|
||||
reviewsSection: 'Gemini',
|
||||
evidenceClass: 'source-grounded',
|
||||
requiresBinaries: [],
|
||||
promptBudgetKey: 'review.max_prompt_tokens_per_reviewer.gemini',
|
||||
modelConfigKey: 'review.models.gemini',
|
||||
effortConfigKey: null,
|
||||
defaultEffort: null,
|
||||
handler: null,
|
||||
},
|
||||
{
|
||||
// 1_200_000 rather than the 900_000 floor: headless Claude measured ~525 s
|
||||
// on a large plan set (review.md:304).
|
||||
@@ -323,8 +303,8 @@ export const REVIEWER_LANES: ReadonlyArray<ReviewerLane> = Object.freeze([
|
||||
effortChannel: 'argv',
|
||||
// #2483: without these the claude leg is the only reviewer that additionally inherits the
|
||||
// invoking user's global CLAUDE.md, the project CLAUDE.md, and Claude Code auto-memory —
|
||||
// a context asymmetry against the independent-review premise (gemini sees only the
|
||||
// assembled prompt; codex runs --ephemeral). Both flags, not just the first: CLAUDE.md
|
||||
// a context asymmetry against the independent-review premise (codex sees only the
|
||||
// assembled prompt and runs --ephemeral). Both flags, not just the first: CLAUDE.md
|
||||
// loading and auto-memory are independently-toggled mechanisms, and an environment
|
||||
// exporting CLAUDE_CODE_DISABLE_AUTO_MEMORY=0 forces auto-memory back ON — the explicit
|
||||
// pair is robust against that. Applies when /gsd:review runs from a non-Claude-Code host;
|
||||
@@ -1060,7 +1040,7 @@ const NON_LANE_SIGNATURE_FLAGS: ReadonlySet<string> = new Set(['--all']);
|
||||
/**
|
||||
* Is `flag` documented in `text` under one of the two structural shapes docs actually use?
|
||||
*
|
||||
* Backticked is the `COMMANDS.md` table-cell shape; bracketed (`[--gemini]`) is the
|
||||
* Backticked is the `COMMANDS.md` table-cell shape; bracketed (`[--codex]`) is the
|
||||
* `FEATURES.md` signature shape. Requiring one of those two delimiters — rather than a bare
|
||||
* substring — is what keeps prose and fenced examples from satisfying the gate, and it bounds the
|
||||
* token for free: a backticked `--claude` demands its closing backtick, so a backticked
|
||||
@@ -1155,7 +1135,7 @@ const BRACKETED_FLAG_RE = /\[(--[a-z0-9][a-z0-9-]*)\]/g;
|
||||
* cell 3. A file-scoped check is therefore satisfied by the forwarding row alone, so deleting a
|
||||
* lane's actual table row — the exact #2781 regression — passes. Keying on cell 1 separates the
|
||||
* two: `| `--agy` / `--antigravity` | … |` is one lane row declaring two flags, while
|
||||
* `| Reviewer flags | No | … `--gemini`, `--claude` … |` is not a lane row at all.
|
||||
* `| Reviewer flags | No | … `--codex`, `--claude` … |` is not a lane row at all.
|
||||
*/
|
||||
function flagsInFirstTableCell(lines: string[], declared: ReadonlySet<string>): Set<string> {
|
||||
const found = new Set<string>();
|
||||
|
||||
@@ -19,7 +19,7 @@
|
||||
* `reviewer` bodies in the capability registry, not a hand-maintained tail.
|
||||
* A capability of EITHER `role: "runtime"` (the six dual-purpose hosts —
|
||||
* antigravity/claude/codex/cursor/opencode/qwen) or the lane-only
|
||||
* `role: "reviewer"` (gemini/coderabbit/ollama/lm_studio/llama_cpp) may carry
|
||||
* `role: "reviewer"` (coderabbit/ollama/lm_studio/llama_cpp) may carry
|
||||
* a `reviewer` body, and it is the body's `reviewer.slug` — NOT the capability
|
||||
* id — that becomes the roster entry: the two differ for `lm-studio` (id) /
|
||||
* `lm_studio` (slug) and `llama-cpp` (id) / `llama_cpp` (slug), ADR-2782's
|
||||
@@ -306,7 +306,7 @@ export function resolveReviewerSelection(
|
||||
// ADR-2782 D4: absent-safe governs DISCOVERY, never explicit selection.
|
||||
// Not finding a lane nobody asked for is normal; failing to run a lane
|
||||
// somebody asked for is an error. Every miss used to be an `info`, so a
|
||||
// PARTIAL miss (`--gemini --qwen` with qwen absent) ran the review with a
|
||||
// PARTIAL miss (`--codex --qwen` with qwen absent) ran the review with a
|
||||
// thinner reviewer set while present_results reported success — "a cross-AI
|
||||
// review that silently drops a lane is blind in one eye" (review.md).
|
||||
// A total miss already errored, but only as a side effect of the selected
|
||||
|
||||
Reference in New Issue
Block a user