From b694d31239017b3b4632eae8aca0811d8c840b76 Mon Sep 17 00:00:00 2001 From: Tom Boucher Date: Tue, 5 May 2026 18:53:35 -0400 Subject: [PATCH] chore(3155): address CodeRabbit changeset ref and test diagnostics --- ...fix-3150-stats-json-decimal-gap-regression.md | 2 +- ...g-3150-stats-json-decimal-phase-gaps.test.cjs | 16 +++++++++++++++- 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/.changeset/fix-3150-stats-json-decimal-gap-regression.md b/.changeset/fix-3150-stats-json-decimal-gap-regression.md index 4dfead42d..8fd458586 100644 --- a/.changeset/fix-3150-stats-json-decimal-gap-regression.md +++ b/.changeset/fix-3150-stats-json-decimal-gap-regression.md @@ -1,5 +1,5 @@ --- type: Fixed -pr: 3150 +pr: 3155 --- **`stats.json` decimal phase ordering now has explicit regression coverage** — added a fixture ensuring `06.7/06.8/06.9` remain present when `06.10` exists, preventing dropped-phase regressions in mixed decimal phase ranges. \ No newline at end of file diff --git a/tests/bug-3150-stats-json-decimal-phase-gaps.test.cjs b/tests/bug-3150-stats-json-decimal-phase-gaps.test.cjs index 35251c7f0..56851750c 100644 --- a/tests/bug-3150-stats-json-decimal-phase-gaps.test.cjs +++ b/tests/bug-3150-stats-json-decimal-phase-gaps.test.cjs @@ -26,7 +26,21 @@ describe('bug #3150: stats.json includes contiguous decimal phases when .10 exis const result = runGsdTools('stats json', tmpDir); assert.ok(result.success, `Command failed: ${result.error}`); - const output = JSON.parse(result.output); + let output; + assert.doesNotThrow( + () => { + output = JSON.parse(result.output); + }, + `Command output must be valid JSON. Raw output prefix: ${result.output.slice(0, 200)}` + ); + assert.ok( + output && typeof output === 'object' && !Array.isArray(output), + `Expected object output, got: ${typeof output}` + ); + assert.ok( + Array.isArray(output.phases), + `Expected output.phases array. Raw output prefix: ${result.output.slice(0, 200)}` + ); const phaseNumbers = output.phases.map((p) => p.number); assert.deepStrictEqual(