refactor(query): deepen command/dispatch seams and resolve coderabbit findings

* refactor(query): deepen command definition seam and fold fallback mapping cleanup

* refactor(query): add shared dispatch formatting module seam

* fix(query): restore QueryResult type import in dispatch deps

* test/query: align raw-output policy and definition normalization contracts

* refactor(query): deepen diagnosis, invariant report, and error taxonomy seams

* refactor(query): deepen dispatch plan, fallback bridge, policy snapshot, and hints seams

* refactor(query): deepen validation, fallback policy, capability, and result builder seams

* refactor(query): deepen resolution strategy, output classifier, observability, and policy-capability seams

* refactor(query): finalize deep strategy/classifier/observability/capability seams

* test/query: address coderabbit inline and out-of-diff dispatch nits

* fix(query): address remaining coderabbit input-validation and bridge stderr threads

* fix(query): address remaining coderabbit dispatch and strategy/output nits
This commit is contained in:
Tom Boucher
2026-05-03 15:29:34 -04:00
committed by GitHub
parent c3f896f311
commit b6c401dc90
49 changed files with 1159 additions and 484 deletions

View File

@@ -11,6 +11,7 @@ import {
assertMutationCommandsRegistered,
assertNoDuplicateRegisteredCommands,
assertRawOutputPolicyCommandsRegistered,
collectRegistryAssemblyInvariantReport,
type RegistryAssemblyAliasGroup,
type RegistryAssemblyStaticGroup,
} from './registry-assembly-invariants.js';
@@ -106,4 +107,26 @@ describe('registry assembly invariants', () => {
expect(() => assertMutationCommandsRegistered(registry, new Set(['one']))).not.toThrow();
expect(() => assertRawOutputPolicyCommandsRegistered(registry, ['canon'])).not.toThrow();
});
it('collects invariant report for all failure classes', () => {
const registry = new QueryRegistry();
const report = collectRegistryAssemblyInvariantReport({
staticGroups: [
{ name: 'S1', entries: [['dup', noop]] },
{ name: 'S2', entries: [['dup', noop]] },
],
aliasGroups: [
{ family: 'f', aliases: [{ canonical: 'missing', aliases: ['dup'] }], handlers: {} },
],
mutationCommands: new Set(['missing.mutation']),
rawOutputPolicyCommands: ['missing.raw'],
}, registry);
expect(report).toEqual({
duplicateCommandKeys: ['dup'],
aliasCanonicalsMissingHandlers: ['f:missing'],
missingMutationCommands: ['missing.mutation'],
missingRawOutputPolicyCommands: ['missing.raw'],
});
});
});