fix(#2402): honor response_language across orchestrator output + UAT checkpoint renderer (#2457)

* fix(#2402): honor response_language across orchestrator output + UAT checkpoint renderer

Replays the in-flight bot branch fix/2402-response-language-orchestrator-coverage
(seven commits, never pushed) onto current origin/next as a single squashed commit.
The original work was substantial and correct; this commit preserves its full scope,
trimmed where rebase conflicts + workflow size budgets required it.

Three independent layers where response_language was being dropped are closed:

Layer 1 — orchestrator-facing directives across workflows. Adds the strong
"All user-facing output in this workflow MUST be presented in {response_language};
technical terms, code, paths, and subagent prompts stay in English" directive
to ~40 workflows that previously either lacked it entirely (verify-work,
new-project, new-milestone, quick, manager, and ~35 more) or carried only
the weak subagent-prompt-only form (plan-phase, execute-phase). The directive
covers narration between tool calls and banner output, not just the
AskUserQuestion prompts.

Layer 2 — UAT checkpoint renderer (src/uat.cts). buildCheckpoint now accepts
an optional responseLanguage parameter and renders the frame strings
("CHECKPOINT: Verification Required", "Type `pass` or describe what's wrong.")
in any of 9 languages (English/Spanish/French/German/Portuguese/Japanese/
Chinese/Korean/Italian) with an alias table covering ~30 input variants
(en, es, español, ja, 日本語, etc.). cmdRenderCheckpoint reads
config.response_language via loadConfig(cwd) and passes it through, so the
byte-for-byte block verify-work.md reprints verbatim is already localized
when written — preserving the anti-injection hygiene rule at verify-work.md
(the model is forbidden to translate after the fact). CJK display width is
computed by East Asian Width property ranges (W/F) so the right ║ border of
the banner stays aligned for full-width characters. English fallback is
byte-identical to the pre-fix behavior when response_language is unset or
unrecognized.

Layer 3 — literal English report templates in execute-phase. The top-of-
workflow directive covers all template sites (templates are a structural
source, not literal output). Inline render-language notes that previously
sat at each template site were removed during the squash because they
pushed execute-phase.md over its frozen pre-phase-6 byte ceiling
(93600 — ADR-857 Phase 6 capstone). The single top directive covers the
same surface with fewer bytes.

Also extends src/docs.cts and src/init.cts to propagate response_language
into the init JSON bundle of the additional workflows so the directive can
read it.

Tests added:
- tests/uat.test.cjs: buildCheckpoint with unset/unrecognized language falls
  back to English default; recognized language swaps only the two frame
  strings while structural lines stay untouched; CJK display-width regression
  (independent recomputation of East Asian Width W/F ranges).
- tests/workspace.test.cjs, tests/docs-update.test.cjs: response_language
  wiring through docs.cts/init.cts.

References: #2402; reporter's three-layer triage + Layer-4 follow-up; the
byte-for-byte anti-injection hygiene rule at verify-work.md (the reason
Layer 2 must be renderer-side, not model-translated).

This is a squash of the in-flight bot branch — seven commits representing
the original implementation plus its subsequent fix/CJK-padding/test/
changeset/regen cycles, none of which were ever pushed or PR'd. The squash
captures the final coherent state.

* chore(#2402): backfill pr:2457 in .changeset/2402-response-language-orchestrator-coverage.md

* chore(#2402): regen golden + size baseline after rebase against #2315 (PR #2451)

Rebase conflicts were entirely in generated artifacts (golden-install-parity
fixtures + workflow-size-baseline.json). After taking theirs during rebase,
regenerated cleanly against the merged source tree.
This commit is contained in:
Tom Boucher
2026-07-20 14:22:27 -04:00
committed by GitHub
parent 352876ff0c
commit b6e6a22fce
90 changed files with 1435 additions and 846 deletions

View File

@@ -160,6 +160,7 @@
"gsd-core/references/execute-phase-between-wave-reset.md": "3ad96ca0f7fee37e",
"gsd-core/references/execute-phase-context-guard.md": "a5a1058d35806a8e",
"gsd-core/references/execute-phase-requirement-revert.md": "48ade76866c57ce2",
"gsd-core/references/execute-phase-response-language.md": "c240dc476dd15df5",
"gsd-core/references/execute-phase-wave-guard.md": "de9ac22cead4cfd8",
"gsd-core/references/executor-examples.md": "ba59243ed45c8ab1",
"gsd-core/references/few-shot-examples/plan-checker.md": "2574808188ac9de4",
@@ -279,23 +280,23 @@
"gsd-core/workflows/_runtime-launcher.snippet.sh": "bf2dd5d1debd5335",
"gsd-core/workflows/add-backlog.md": "08289088a88d410f",
"gsd-core/workflows/add-phase.md": "739e34f6122e1e61",
"gsd-core/workflows/add-tests.md": "b4deb88c74d491c7",
"gsd-core/workflows/add-todo.md": "36b6d7fec9631ec7",
"gsd-core/workflows/ai-integration-phase.md": "f8288f0434d17c84",
"gsd-core/workflows/add-tests.md": "582b03df9cb71fe0",
"gsd-core/workflows/add-todo.md": "2ccd1c97a3636c36",
"gsd-core/workflows/ai-integration-phase.md": "be951047fcdf6f67",
"gsd-core/workflows/analyze-dependencies.md": "77aff48f97fa6f1c",
"gsd-core/workflows/audit-fix.md": "3aaafee8857dcfab",
"gsd-core/workflows/audit-milestone.md": "8bd0b730de08d1a8",
"gsd-core/workflows/audit-uat.md": "c800099fab1e1c1b",
"gsd-core/workflows/autonomous.md": "6cb0c014f5f56965",
"gsd-core/workflows/check-todos.md": "6526b64ee88c7d2e",
"gsd-core/workflows/cleanup.md": "94d771d26f62dc86",
"gsd-core/workflows/check-todos.md": "795eb611182bf038",
"gsd-core/workflows/cleanup.md": "9d510a45aec81ba1",
"gsd-core/workflows/code-review-fix.md": "adb9388bb157610c",
"gsd-core/workflows/code-review.md": "016d1c9cbabf04f2",
"gsd-core/workflows/complete-milestone.md": "614299b2c08e66c3",
"gsd-core/workflows/debug.md": "63ea176f51f2eeb7",
"gsd-core/workflows/complete-milestone.md": "9482dadd0f8902d2",
"gsd-core/workflows/debug.md": "0055f60eb85d8d8f",
"gsd-core/workflows/diagnose-issues.md": "1d1aa1d919bc4d03",
"gsd-core/workflows/discovery-phase.md": "724408336596c50c",
"gsd-core/workflows/discuss-phase-assumptions.md": "92e43cd12200c610",
"gsd-core/workflows/discovery-phase.md": "0ef23f38adfb0e6e",
"gsd-core/workflows/discuss-phase-assumptions.md": "f582dc980face737",
"gsd-core/workflows/discuss-phase-power.md": "5c0d1ca6abda0383",
"gsd-core/workflows/discuss-phase.md": "3a62a8d4c374c69f",
"gsd-core/workflows/discuss-phase/modes/advisor.md": "83ca3ea4fac785af",
@@ -310,88 +311,88 @@
"gsd-core/workflows/discuss-phase/templates/checkpoint.json": "e3bc3dca49db59eb",
"gsd-core/workflows/discuss-phase/templates/context.md": "9804674fccada405",
"gsd-core/workflows/discuss-phase/templates/discussion-log.md": "04e4feee14772275",
"gsd-core/workflows/do.md": "85c4c8cb7aa8af87",
"gsd-core/workflows/docs-update.md": "850366c2ef8fb780",
"gsd-core/workflows/do.md": "532afe82bbf9f775",
"gsd-core/workflows/docs-update.md": "4c7ea896438d9d45",
"gsd-core/workflows/edit-phase.md": "1876c855fb0a0a39",
"gsd-core/workflows/eval-review.md": "5394694d29ad7543",
"gsd-core/workflows/execute-phase.md": "83e7df675b781f8f",
"gsd-core/workflows/eval-review.md": "1973f08d0eb34159",
"gsd-core/workflows/execute-phase.md": "6148ab536d9210cc",
"gsd-core/workflows/execute-phase/steps/codebase-drift-gate.md": "1804215577f1ad35",
"gsd-core/workflows/execute-phase/steps/per-plan-worktree-gate.md": "7ebb7d1af6082028",
"gsd-core/workflows/execute-phase/steps/post-merge-gate.md": "c4cba01539f0368a",
"gsd-core/workflows/execute-phase/steps/regression-gate.md": "21f4d9b3abc334ce",
"gsd-core/workflows/execute-phase/steps/worktree-recovery-policy.md": "be84efbd71e1513e",
"gsd-core/workflows/execute-plan.md": "ac4a07ff7e42190d",
"gsd-core/workflows/execute-plan.md": "cf668f02001b9778",
"gsd-core/workflows/explore.md": "7f5f9231cfd3089b",
"gsd-core/workflows/extract-learnings.md": "92b3c0979604b7d0",
"gsd-core/workflows/fast.md": "12187b242e6af970",
"gsd-core/workflows/forensics.md": "9354cb830152fd28",
"gsd-core/workflows/graduation.md": "13080b5c24eec27d",
"gsd-core/workflows/health.md": "a91e0a8e5d20b2e9",
"gsd-core/workflows/graduation.md": "589b9b303cff8643",
"gsd-core/workflows/health.md": "05447688e0b332c5",
"gsd-core/workflows/help.md": "5d040504b9ab35e3",
"gsd-core/workflows/help/modes/brief.md": "fa2675516b40e2e3",
"gsd-core/workflows/help/modes/default.md": "be05e56b2c5ee2c0",
"gsd-core/workflows/help/modes/full.md": "7e68200aeb086535",
"gsd-core/workflows/help/modes/topic.md": "0bf9ab39d7044d69",
"gsd-core/workflows/import.md": "03527dcd27f9f7e7",
"gsd-core/workflows/inbox.md": "a073396097c89c01",
"gsd-core/workflows/ingest-docs.md": "9066e37d34b2691e",
"gsd-core/workflows/import.md": "15d09b825badf7ed",
"gsd-core/workflows/inbox.md": "7e46f5d6b0694074",
"gsd-core/workflows/ingest-docs.md": "d6e090893e6083d9",
"gsd-core/workflows/insert-phase.md": "858224afbf977c14",
"gsd-core/workflows/list-phase-assumptions.md": "e7b5e35c9452e3b3",
"gsd-core/workflows/list-seeds.md": "9b05425fa7d24827",
"gsd-core/workflows/list-workspaces.md": "dc6d30036c6dc426",
"gsd-core/workflows/manager.md": "b652b27ca9c6451a",
"gsd-core/workflows/manager.md": "eda80c0d3d32dbf6",
"gsd-core/workflows/map-codebase.md": "ab67f493aac12fa3",
"gsd-core/workflows/milestone-summary.md": "321ea8a6a206f38f",
"gsd-core/workflows/mvp-phase.md": "b4d688baa4c60dfc",
"gsd-core/workflows/new-milestone.md": "11c0d446a3320ef5",
"gsd-core/workflows/new-project.md": "4a4a4f0010b3e1a0",
"gsd-core/workflows/new-workspace.md": "3d82392388ee24c7",
"gsd-core/workflows/mvp-phase.md": "94360741a1d8d7ce",
"gsd-core/workflows/new-milestone.md": "70cc7e68313ce1fd",
"gsd-core/workflows/new-project.md": "e3691650a7483f10",
"gsd-core/workflows/new-workspace.md": "53f8abf8baca9345",
"gsd-core/workflows/next.md": "6719a37b8ce2ac4f",
"gsd-core/workflows/node-repair.md": "07a1628e5a1ff96b",
"gsd-core/workflows/note.md": "0d1374f2a2257858",
"gsd-core/workflows/onboard.md": "102556e1715c01b9",
"gsd-core/workflows/onboard.md": "ca3a59a2e36b829a",
"gsd-core/workflows/pause-work.md": "70c72beca55c080a",
"gsd-core/workflows/plan-milestone-gaps.md": "0a9dacd422cd9533",
"gsd-core/workflows/plan-phase.md": "b133e7c08a39aad0",
"gsd-core/workflows/plan-phase.md": "9dc1b4d1e7c0878f",
"gsd-core/workflows/plan-phase/steps/closed-phase-gate.md": "4099ef6d0868de60",
"gsd-core/workflows/plan-phase/steps/prd-express-path.md": "3a09141de7f3dedb",
"gsd-core/workflows/plan-phase/steps/windows-troubleshooting.md": "e9de7a96bbfff261",
"gsd-core/workflows/plan-review-convergence.md": "f91c297dce1253a2",
"gsd-core/workflows/plant-seed.md": "b8dad652e31c2318",
"gsd-core/workflows/plant-seed.md": "ac8bbe2d9d52f2c1",
"gsd-core/workflows/pr-branch.md": "929b7cb0c99c7b9e",
"gsd-core/workflows/profile-user.md": "248d59a31948e0ed",
"gsd-core/workflows/profile-user.md": "9275d5895237b801",
"gsd-core/workflows/progress.md": "c3d7149133d571a9",
"gsd-core/workflows/quick.md": "f2641bad95c6614e",
"gsd-core/workflows/quick.md": "2b83359cc9a39d17",
"gsd-core/workflows/reapply-patches.md": "a0e9b53f90abceb2",
"gsd-core/workflows/remove-phase.md": "dea4661e8f89596f",
"gsd-core/workflows/remove-workspace.md": "446847e71aa52504",
"gsd-core/workflows/remove-workspace.md": "21a8581add5f31ae",
"gsd-core/workflows/resume-project.md": "ad9f06a10bab8cc0",
"gsd-core/workflows/review.md": "fbe68c9f86385274",
"gsd-core/workflows/scan.md": "63cf8d9067610704",
"gsd-core/workflows/secure-phase.md": "71e6e689e80288ec",
"gsd-core/workflows/secure-phase.md": "7ad9fd285facdef8",
"gsd-core/workflows/session-report.md": "2e5b1205324ddefa",
"gsd-core/workflows/settings-advanced.md": "252b0d3edc315339",
"gsd-core/workflows/settings-integrations.md": "d1711a95f44fdbde",
"gsd-core/workflows/settings.md": "2e42ee34c791378a",
"gsd-core/workflows/ship.md": "9e773a94f4abf0e6",
"gsd-core/workflows/settings-integrations.md": "1c3997dc6953e7eb",
"gsd-core/workflows/settings.md": "a244850ce2f7b8dd",
"gsd-core/workflows/ship.md": "b3dedb0506ba3ab6",
"gsd-core/workflows/sketch-wrap-up.md": "681800323681c5c6",
"gsd-core/workflows/sketch.md": "fcb7af914159ef7b",
"gsd-core/workflows/smart-entry.md": "2a253fe437496eea",
"gsd-core/workflows/sketch.md": "da82c9be7074545c",
"gsd-core/workflows/smart-entry.md": "c4c780d3aa2124f8",
"gsd-core/workflows/spec-phase.md": "5c4a3001095ca722",
"gsd-core/workflows/spike-wrap-up.md": "30a73aa19a1db271",
"gsd-core/workflows/spike.md": "f8b07d411473560a",
"gsd-core/workflows/spike.md": "7462ab0428468932",
"gsd-core/workflows/stats.md": "846cd2808461ccdc",
"gsd-core/workflows/sync-skills.md": "7e2c138cdbef4282",
"gsd-core/workflows/thread.md": "82652edb1883af59",
"gsd-core/workflows/transition.md": "372b6fc7c0c68a89",
"gsd-core/workflows/ui-phase.md": "4d11cc725ebfe597",
"gsd-core/workflows/ui-review.md": "149f39373eee5c92",
"gsd-core/workflows/ui-phase.md": "bef76916ad5844df",
"gsd-core/workflows/ui-review.md": "5be4a2ea3dc52222",
"gsd-core/workflows/ultraplan-phase.md": "f4bad8de3fdb49fa",
"gsd-core/workflows/undo.md": "0bba5e7f6196c894",
"gsd-core/workflows/update.md": "71b6cd852f38b4bc",
"gsd-core/workflows/validate-phase.md": "434d9927c65f2bba",
"gsd-core/workflows/undo.md": "bbb91a18ee896975",
"gsd-core/workflows/update.md": "7af09036dc7b5f98",
"gsd-core/workflows/validate-phase.md": "4c3ed60b16a5e91f",
"gsd-core/workflows/verify-phase.md": "73025aa5d8bf7bd5",
"gsd-core/workflows/verify-work.md": "528fa7529501ee10",
"gsd-core/workflows/verify-work.md": "c9b631068931ad15",
"hooks/gsd-check-update-worker.js": "385fb7c67810baf6",
"hooks/gsd-check-update.js": "4549451414ffa7d7",
"hooks/gsd-config-reload.js": "96546e0e8bb47904",