From b6ead219716f35a22c5d477932a467ebef60b6cf Mon Sep 17 00:00:00 2001 From: Tom Boucher Date: Fri, 22 May 2026 10:42:22 -0400 Subject: [PATCH] fix(rulesets): correct status-check context order (os, node) The GitHub Actions matrix in test.yml is ordered {os, node-version}, so matrix-derived check contexts are 'test (, )'. The ruleset specs had the inverse, so the required_status_checks rule silently watches for names that never appear in any check run. In evaluate mode this is a no-op; flipping to 'active' without this fix would deadlock every PR. Closes #111 Refs #107 --- .github/rulesets/main-protection.json | 12 ++++++------ .github/rulesets/release-branches.json | 12 ++++++------ 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/.github/rulesets/main-protection.json b/.github/rulesets/main-protection.json index 8a91a3c84..d18310f90 100644 --- a/.github/rulesets/main-protection.json +++ b/.github/rulesets/main-protection.json @@ -35,12 +35,12 @@ "strict_required_status_checks_policy": true, "required_status_checks": [ { "context": "lint-tests" }, - { "context": "test (22, ubuntu-latest)" }, - { "context": "test (22, macos-latest)" }, - { "context": "test (22, windows-latest)" }, - { "context": "test (24, ubuntu-latest)" }, - { "context": "test (24, macos-latest)" }, - { "context": "test (24, windows-latest)" }, + { "context": "test (ubuntu-latest, 22)" }, + { "context": "test (macos-latest, 22)" }, + { "context": "test (windows-latest, 22)" }, + { "context": "test (ubuntu-latest, 24)" }, + { "context": "test (macos-latest, 24)" }, + { "context": "test (windows-latest, 24)" }, { "context": "Changeset Required" }, { "context": "require-issue-link" }, { "context": "pr-template-format" } diff --git a/.github/rulesets/release-branches.json b/.github/rulesets/release-branches.json index 457eaf607..36caa35a6 100644 --- a/.github/rulesets/release-branches.json +++ b/.github/rulesets/release-branches.json @@ -32,12 +32,12 @@ "strict_required_status_checks_policy": true, "required_status_checks": [ { "context": "lint-tests" }, - { "context": "test (22, ubuntu-latest)" }, - { "context": "test (22, macos-latest)" }, - { "context": "test (22, windows-latest)" }, - { "context": "test (24, ubuntu-latest)" }, - { "context": "test (24, macos-latest)" }, - { "context": "test (24, windows-latest)" }, + { "context": "test (ubuntu-latest, 22)" }, + { "context": "test (macos-latest, 22)" }, + { "context": "test (windows-latest, 22)" }, + { "context": "test (ubuntu-latest, 24)" }, + { "context": "test (macos-latest, 24)" }, + { "context": "test (windows-latest, 24)" }, { "context": "Changeset Required" }, { "context": "require-issue-link" }, { "context": "pr-template-format" }