* refactor(#455): implement typed surfaces to retire grep tests Production surfaces added: - hooks/managed-hooks-registry.cjs: new CJS module exporting MANAGED_HOOKS as a typed array; gsd-check-update-worker.js now requires it instead of declaring an inline array - bin/install.js: elevate inline gsdHooks to module-level GSD_UNINSTALL_HOOKS, export it alongside runtimeMap/allRuntimes (already exported) - scripts/build-hooks.js: export HOOKS_TO_COPY; guard build() behind require.main===module so tests can require the file without triggering a build - get-shit-done/bin/lib/init.cjs: add --json mode to agent-skills command, emitting typed IR { agent_type, block, skills_count } for test assertions - get-shit-done/bin/gsd-tools.cjs: wire --json flag for agent-skills dispatch Category-B source-grep migrations: - tests/managed-hooks.test.cjs: require MANAGED_HOOKS from registry, drop fs.readFileSync+regex - tests/orphaned-hooks.test.cjs: require MANAGED_HOOKS+HOOKS_TO_COPY as typed exports - tests/hooks-opt-in.test.cjs: replace gsdHooks regex-parse with GSD_UNINSTALL_HOOKS import - tests/install-minimal-hooks.test.cjs: replace gsdHooks regex-parse with GSD_UNINSTALL_HOOKS - tests/copilot-install.test.cjs: replace src.includes() checks with typed assertions on runtimeMap, allRuntimes, parseRuntimeInput, buildRuntimePromptText - tests/agent-skills.test.cjs: migrate to --json typed IR assertions pending-migration-to-typed-ir token cleared (87 of 87 files): - 78 files already had source-text-is-the-product; removed duplicate token - 5 files already used typed assertions; reclassified or annotated - 4 files required individual reclassification to source-text-is-the-product or architectural-invariant Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(#455): update workflow-guard test to typed GSD_UNINSTALL_HOOKS import; isolate HOME in runtime-launcher (D) test Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(#455): guard install.js main() behind require.main===module so the typed export is require-safe Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * docs(#455): document --json typed surfaces for agent-skills, progress, validate context Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * docs(#455): add changeset fragment for new --json surfaces Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(#455): complete grep migration for files flagged by lint-tests The branch commit 4e630d99 stripped `allow-test-rule: pending-migration-to-typed-ir` from ~80 test files without replacing their assertions or adding the correct exemption annotation. The files were NOT source-grep tests — they read .md workflow/agent/command/reference files (source-text-is-the-product) or hook source files for structural invariants (structural-regression-guard). No assertion logic was changed; only the correct allow-test-rule annotation was added to each file per CONTRIBUTING.md exception matrix. 73 files: `source-text-is-the-product` — workflow/agent/command/reference .md 7 files: `structural-regression-guard` — hook .js / bin/install.js structural checks Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: CI Rebase Check <ci@gsd-redux> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -1,13 +1,18 @@
|
||||
/**
|
||||
* Regression tests for bug #2136
|
||||
*
|
||||
* gsd-check-update.js contains a MANAGED_HOOKS array used to detect stale
|
||||
* hooks after a GSD update. It must list every hook file that GSD ships so
|
||||
* that all deployed hooks are checked for staleness — not just the .js ones.
|
||||
* gsd-check-update-worker.js uses a MANAGED_HOOKS array (now in the shared
|
||||
* managed-hooks-registry.cjs module) to detect stale hooks after a GSD update.
|
||||
* It must list every hook file that GSD ships so that all deployed hooks are
|
||||
* checked for staleness — not just the .js ones.
|
||||
*
|
||||
* The original bug: the 3 bash hooks (gsd-phase-boundary.sh,
|
||||
* gsd-session-state.sh, gsd-validate-commit.sh) were missing from
|
||||
* MANAGED_HOOKS, so they would never be detected as stale after an update.
|
||||
*
|
||||
* Migration note (#455): previously used fs.readFileSync + regex on the worker
|
||||
* source to extract the array. Now requires the typed export directly from
|
||||
* hooks/managed-hooks-registry.cjs.
|
||||
*/
|
||||
|
||||
'use strict';
|
||||
@@ -18,38 +23,25 @@ const fs = require('fs');
|
||||
const path = require('path');
|
||||
|
||||
const HOOKS_DIR = path.join(__dirname, '..', 'hooks');
|
||||
// MANAGED_HOOKS now lives in the worker script (extracted from inline -e code
|
||||
// to avoid template-literal regex-escaping concerns). The test reads the worker.
|
||||
const MANAGED_HOOKS_FILE = path.join(HOOKS_DIR, 'gsd-check-update-worker.js');
|
||||
// Typed import — no source-grep needed (#455)
|
||||
const { MANAGED_HOOKS } = require(path.join(HOOKS_DIR, 'managed-hooks-registry.cjs'));
|
||||
|
||||
describe('bug #2136: MANAGED_HOOKS must include all shipped hook files', () => {
|
||||
let src;
|
||||
let managedHooks;
|
||||
let shippedHooks;
|
||||
|
||||
// Read once — all tests share the same source snapshot
|
||||
src = fs.readFileSync(MANAGED_HOOKS_FILE, 'utf-8');
|
||||
|
||||
// Extract the MANAGED_HOOKS array entries from the source
|
||||
// The array is defined as a multi-line array literal of quoted strings
|
||||
const match = src.match(/const MANAGED_HOOKS\s*=\s*\[([\s\S]*?)\]/);
|
||||
assert.ok(match, 'MANAGED_HOOKS array not found in gsd-check-update-worker.js');
|
||||
|
||||
managedHooks = match[1]
|
||||
.split('\n')
|
||||
.map(line => line.trim().replace(/^['"]|['"],?$/g, ''))
|
||||
.filter(s => s.length > 0 && !s.startsWith('//'));
|
||||
|
||||
// List all GSD-managed hook files in hooks/ (names starting with "gsd-")
|
||||
shippedHooks = fs.readdirSync(HOOKS_DIR)
|
||||
const shippedHooks = fs.readdirSync(HOOKS_DIR)
|
||||
.filter(f => f.startsWith('gsd-') && (f.endsWith('.js') || f.endsWith('.sh')));
|
||||
|
||||
test('MANAGED_HOOKS is a non-empty array', () => {
|
||||
assert.ok(Array.isArray(MANAGED_HOOKS), 'MANAGED_HOOKS must be an array');
|
||||
assert.ok(MANAGED_HOOKS.length > 0, 'MANAGED_HOOKS must not be empty');
|
||||
});
|
||||
|
||||
test('every shipped gsd-*.js hook is in MANAGED_HOOKS', () => {
|
||||
const jsHooks = shippedHooks.filter(f => f.endsWith('.js'));
|
||||
for (const hookFile of jsHooks) {
|
||||
assert.ok(
|
||||
managedHooks.includes(hookFile),
|
||||
`${hookFile} is shipped in hooks/ but missing from MANAGED_HOOKS in gsd-check-update-worker.js`
|
||||
MANAGED_HOOKS.includes(hookFile),
|
||||
`${hookFile} is shipped in hooks/ but missing from MANAGED_HOOKS in managed-hooks-registry.cjs`
|
||||
);
|
||||
}
|
||||
});
|
||||
@@ -58,14 +50,14 @@ describe('bug #2136: MANAGED_HOOKS must include all shipped hook files', () => {
|
||||
const shHooks = shippedHooks.filter(f => f.endsWith('.sh'));
|
||||
for (const hookFile of shHooks) {
|
||||
assert.ok(
|
||||
managedHooks.includes(hookFile),
|
||||
`${hookFile} is shipped in hooks/ but missing from MANAGED_HOOKS in gsd-check-update-worker.js`
|
||||
MANAGED_HOOKS.includes(hookFile),
|
||||
`${hookFile} is shipped in hooks/ but missing from MANAGED_HOOKS in managed-hooks-registry.cjs`
|
||||
);
|
||||
}
|
||||
});
|
||||
|
||||
test('MANAGED_HOOKS contains no entries for hooks that do not exist', () => {
|
||||
for (const entry of managedHooks) {
|
||||
for (const entry of MANAGED_HOOKS) {
|
||||
const exists = fs.existsSync(path.join(HOOKS_DIR, entry));
|
||||
assert.ok(
|
||||
exists,
|
||||
|
||||
Reference in New Issue
Block a user