golem15/msd-core
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(#3498): escapeRegex falls back below Node 24 (no RegExp.escape) (#3499)

Browse Source 
RegExp.escape is ES2026 (first shipped in Node 24); pattern.cts called it
unconditionally, and the build consumes the module
(scripts/gen-loop-host-contract.cjs), so npm run build failed on Node 22 and
the gsd-test linux-node22 lane could not reach run_tests.

Fix: prefer the built-in when present, else an in-file metachar escape —
still the sole owner of escaping (#3212 invariant; lint scope unchanged).
Builtin captured at module load so runtime mutation cannot flip the path.

Regression: tests/pattern.test.cjs section 4 — child-process probes neuter
RegExp.escape before/after require and assert match-behavior equivalence.

Co-authored-by: sim <sim@local>
This commit is contained in:
Tom Boucher
2026-08-14 13:51:33 -04:00
committed by GitHub
parent 1218d76d62
commit b946051a46
3 changed files with 73 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
src/pattern.cts
View File

@@ -6,10 +6,10 @@
* (gitignored), per the repo's ADR-457 build-at-publish convention.
*
* Sole owner of building a `RegExp` from a runtime value. `escapeRegex`
* delegates to the built-in `RegExp.escape` (ES2026 / Node 24+) rather than
* hand-rolling yet another copy of the metacharacter-escape helper this
* module replaces — see ADR §1 ("No module outside the seam escapes a value
* for regex use").
* delegates to the built-in `RegExp.escape` (ES2026 / Node 24+) when present,
* falling back to an in-file metacharacter escape below Node 24 (#3498) —
* still the one owner: no module outside this seam escapes a value for regex
* use (ADR §1).
*
* Counts, corrected during implementation (design doc "Ground truth" #1;
* .gsd/phase/chore-3412-pattern-seam/40-design.md): the ADR's census counted
@@ -41,8 +41,24 @@
* migration-equivalence property sweep in tests/pattern.test.cjs (rows 15-17).
*/
// #3498: RegExp.escape is ES2026 (first shipped in Node 24). The gsd-test
// matrix still runs a linux-node22 lane, and the build itself consumes this
// module (scripts/gen-loop-host-contract.cjs), so a hard dependency breaks
// `npm run build` on Node 22. Prefer the built-in when present; otherwise use
// the local metachar escape — still inside this file, so the #3212 sole-owner
// invariant (and lint-no-adhoc-regex-escape's scope) is preserved. Captured at
// module load so a runtime mutation of RegExp.escape cannot flip the path
// mid-process.
const escapeBuiltin: ((value: string) => string) | undefined =
typeof RegExp.escape === 'function'
? RegExp.escape.bind(RegExp)
: undefined;
const escapeMetachars = (value: string): string =>
value.replace(/[.*+?^${}()|[\]\\]/g, '\\$&');
export function escapeRegex(value: string): string {
return RegExp.escape(value);
return (escapeBuiltin ?? escapeMetachars)(value);
}
export function literalPattern(value: string, flags?: string): RegExp {