golem15/msd-core
4
0
Fork 0
Code Issues 1 Pull Requests Actions 3 Packages Projects Releases Wiki Activity

chore: clean up clear-cut ESLint warnings (#732) (#734)

Browse Source 
Pay down pre-existing error→warn lint debt. Removes dead imports/vars, unused functions, redundant regex/string escapes, and stale eslint-disable directives; converts unused `catch (_e)` to optional catch binding (src/*.cts).

No behavior change. Lint 345→125 warnings (0 errors); deferred categories (n/no-process-exit, test-sleeps, control-regex) tracked in #732 for follow-up. Full test suite green (0 failures); code-review verified all removals unused and all escape fixes semantics-preserving.

Closes #732

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
Tom Boucher
2026-06-06 11:24:48 -04:00
committed by GitHub
parent 42b74100f1
commit ba231ecbfc
117 changed files with 132 additions and 350 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
tests/workflow-shell-pinning.test.cjs
View File

@@ -118,14 +118,14 @@ function findViolations(filePath) {
let inDefaultsBlock = false; // currently inside a `defaults:` mapping
let inDefaultsRunBlock = false; // currently inside `defaults: run:`
let defaultsBlockOwner = null; // 'workflow' or 'job'
let defaultsBlockCol = null; // column of the `defaults:` key
let _defaultsBlockCol = null; // column of the `defaults:` key
// Strategy/matrix tracking
let inStrategyBlock = false;
let inMatrixBlock = false;
let inMatrixOsBlock = false;
let strategyCol = null;
let matrixCol = null;
let _inStrategyBlock = false;
let _inMatrixBlock = false;
let _inMatrixOsBlock = false;
let _strategyCol = null;
let _matrixCol = null;
// Step tracking
let stepIndent = null; // indent level of the `- name:/run:/uses:` items
@@ -178,7 +178,7 @@ function findViolations(filePath) {
inDefaultsBlock = true;
inDefaultsRunBlock = false;
defaultsBlockOwner = 'workflow';
defaultsBlockCol = 0;
_defaultsBlockCol = 0;
continue;
}
@@ -216,9 +216,9 @@ function findViolations(filePath) {
// Reset sub-section tracking
inDefaultsBlock = false;
inDefaultsRunBlock = false;
inStrategyBlock = false;
inMatrixBlock = false;
inMatrixOsBlock = false;
_inStrategyBlock = false;
_inMatrixBlock = false;
_inMatrixOsBlock = false;
continue;
}
@@ -229,7 +229,7 @@ function findViolations(filePath) {
inDefaultsBlock = true;
inDefaultsRunBlock = false;
defaultsBlockOwner = 'job';
defaultsBlockCol = 4;
_defaultsBlockCol = 4;
continue;
}
@@ -248,7 +248,7 @@ function findViolations(filePath) {
// ── Step list detection ───────────────────────────────────────────────
const stepStartMatch = line.match(
/^(\s+)-\s+(name|run|uses|shell|if|id|env|with|continue-on-error|timeout-minutes|working-directory)\s*[:\|]/,
/^(\s+)-\s+(name|run|uses|shell|if|id|env|with|continue-on-error|timeout-minutes|working-directory)\s*[:|]/,
);
if (stepStartMatch) {
const thisIndent = stepStartMatch[1].length;