test(#3339): fix orthogonal-review findings — Wave 7 fold

Standards/Spec-axis review + Memtrace graph pass found real issues in
the just-folded suites, all fixed here:

- tests/phase.test.cjs: the issue explicitly asked to dedupe overlapping
  fixtures between issue-2945/issue-2949 — the fold preserved both test
  sets correctly (genuinely distinct code paths, 0 tests dropped, already
  verified correct) but left each fold block with its own near-identical
  copy of a runVerifiedPhaseComplete(args, tmpDir) helper, the fixture-
  level dedup the issue actually asked for. Consolidated into one shared
  definition without disturbing the file's other, unrelated same-named
  helper at module scope (would have collided if hoisted directly).
  Removed two now-unused local runGsdTools destructurings left behind by
  the consolidation (both blocks already close over the module-scope
  import at line 26).
- tests/review-lane-descriptor.test.cjs: two .find() results dereferenced
  without a presence guard (same defect class Wave 3/#3335 already found
  and fixed once in this epic) — added assert.ok() guards matching the
  repo's established style.
- tests/model-resolver.test.cjs: documented the 1-of-80 dropped duplicate
  test with an inline comment, matching this same wave's host-integration
  fold's convention of citing drops by exact reference instead of leaving
  a reviewer to reconstruct the justification via git archaeology.

No test() count changed in any file. No production code touched.
This commit is contained in:
sim
2026-08-12 01:09:40 -04:00
parent 1bc7f7e6b0
commit c444051bef
3 changed files with 50 additions and 50 deletions

View File

@@ -815,6 +815,7 @@ describe('mergeReviewerLanes (#2927)', () => {
assert.ok(slugs.includes('gemini'), 'first-party lanes preserved');
// the overlay body itself is the merged entry (no translation layer)
const overlay = merged.find((l) => l.slug === 'agy-revisor');
assert.ok(overlay, 'agy-revisor overlay lane should be present in merged set');
assert.equal(overlay.reviewsSection, 'Antigravity revisor-gsd');
assert.deepEqual(overlay.flags, ['--agy-revisor']);
});
@@ -824,6 +825,7 @@ describe('mergeReviewerLanes (#2927)', () => {
const colliding = overlayLane({ slug: 'claude', reviewsSection: 'EVIL CLAUDE' });
const merged = mergeReviewerLanes(FP, registry(reviewerCap(colliding)));
const claude = merged.find((l) => l.slug === 'claude');
assert.ok(claude, 'claude first-party lane should be present in merged set');
assert.equal(claude, FP.find((l) => l.slug === 'claude'), 'first-party identity wins');
assert.notEqual(claude.reviewsSection, 'EVIL CLAUDE', 'overlay did not leak through');
assert.equal(merged.length, FP.length, 'collision added no extra entry');