feat(sdk): golden parity harness and query handler CJS alignment (#2302 Track A) (#2341)

* feat(sdk): golden parity harness and query handler CJS alignment (#2302 Track A)

Golden/read-only parity tests and registry alignment, query handler fixes
(check-completion, state-mutation, commit, validate, summary, etc.), and
WAITING.json dual-write for .gsd/.planning readers.

Refs gsd-build/get-shit-done#2341

* fix(sdk): getMilestoneInfo matches GSD ROADMAP (🟡, last bold, STATE fallback)

- Recognize in-flight 🟡 milestone bullets like 🚧.
- Derive from last **vX.Y Title** before ## Phases when emoji absent.
- Fall back to STATE.md milestone when ROADMAP is missing; use last bare vX.Y
  in cleaned text instead of first (avoids v1.0 from shipped list).
- Fixes init.execute-phase milestone_version and buildStateFrontmatter after
  state.begin-phase (syncStateFrontmatter).

* feat(sdk): phase list, plan task structure, requirements extract handlers

- Register phase.list-plans, phase.list-artifacts, plan.task-structure,
  requirements.extract-from-plans (SDK-only; golden-policy exceptions).
- Add unit tests; document in QUERY-HANDLERS.md.
- writeProfile: honor --output, render dimensions, return profile_path and dimensions_scored.

* feat(sdk): centralize getGsdAgentsDir in query helpers

Extract agent directory resolution to helpers (GSD_AGENTS_DIR, primary
~/.claude/agents, legacy path). Use from init and docs-init init bundles.

docs(15): add 15-CONTEXT for autonomous phase-15 run.

* feat(sdk): query CLI CJS fallback and session correlation

- createRegistry(eventStream, sessionId) threads correlation into mutation events
- gsd-sdk query falls back to gsd-tools.cjs when no native handler matches
  (disable with GSD_QUERY_FALLBACK=off); stderr bridge warnings
- Export createRegistry from @gsd-build/sdk; add sdk/README.md
- Update QUERY-HANDLERS.md and registry module docs for fallback + sessionId
- Agents: prefer node dist/cli.js query over cat/grep for STATE and plans

* fix(sdk): init phase_found parity, docs-init agents path, state field extract

- Normalize findPhase not-found to null before roadmap fallback (matches findPhaseInternal)

- docs-init: use detectRuntime + resolveAgentsDir for checkAgentsInstalled

- state.cjs stateExtractField: horizontal whitespace only after colon (YAML progress guard)

- Tests: commit_docs default true; config-get golden uses temp config; golden integration green

Refs: #2302

* refactor(sdk): share SessionJsonlRecord in profile-extract-messages

CodeRabbit nit: dedupe JSONL record shape for isGenuineUserMessage and streamExtractMessages.

* fix(sdk): address CodeRabbit major threads (paths, gates, audit, verify)

- Resolve @file: and CLI JSON indirection relative to projectDir; guard empty normalized query command

- plan.task-structure + intel extract/patch-meta: resolvePathUnderProject containment

- check.config-gates: safe string booleans; plan_checker alias precedence over plan_check default

- state.validate/sync: phaseTokenMatches + comparePhaseNum ordering

- verify.schema-drift: token match phase dirs; files_modified from parsed frontmatter

- audit-open: has_scan_errors, unreadable rows, human report when scans fail

- requirements PLANNED key PLAN for root PLAN.md; gsd-tools timeout note

- ingest-docs: repo-root path containment; classifier output slug-hash

Golden parity test strips has_scan_errors until CJS adds field.

* fix: Resolve CodeRabbit security and quality findings
- Secure intel.ts and cli.ts against path traversal
- Catch and validate git add status in commit.ts
- Expand roadmap milestone marker extraction
- Fix parsing array-of-objects in frontmatter YAML
- Fix unhandled config evaluations
- Improve coverage test parity mapping

* test: raise planner character extraction limit to 48K

* fix(sdk): resolve TS build error in docs-init passing config
This commit is contained in:
Rezolv
2026-04-20 18:09:02 -04:00
committed by GitHub
parent c8807e38d7
commit c5b1445529
109 changed files with 11588 additions and 1030 deletions

View File

@@ -7,7 +7,8 @@ import { mkdtemp, writeFile, mkdir, rm, readFile } from 'node:fs/promises';
import { join } from 'node:path';
import { tmpdir } from 'node:os';
import { writeProfile, learningsCopy } from './profile.js';
import { writeProfile } from './profile-output.js';
import { learningsCopy } from './profile.js';
describe('writeProfile', () => {
let tmpDir: string;
@@ -21,14 +22,32 @@ describe('writeProfile', () => {
await rm(tmpDir, { recursive: true, force: true });
});
it('writes USER-PROFILE.md from --input JSON', async () => {
it('writes USER-PROFILE.md from --input JSON (CJS template + dimensions shape)', async () => {
const analysisPath = join(tmpDir, 'analysis.json');
await writeFile(analysisPath, JSON.stringify({ communication_style: 'terse' }), 'utf-8');
const result = await writeProfile(['--input', analysisPath], tmpDir);
const outPath = join(tmpDir, '.planning', 'USER-PROFILE.md');
await writeFile(
analysisPath,
JSON.stringify({
profile_version: '1.0',
data_source: 'test',
dimensions: {
communication_style: {
rating: 'terse-direct',
confidence: 'HIGH',
claude_instruction: 'Keep it short.',
summary: 'Test summary.',
evidence: [],
},
},
}),
'utf-8',
);
const result = await writeProfile(['--input', analysisPath, '--output', outPath], tmpDir);
const data = result.data as Record<string, unknown>;
expect(data.written).toBe(true);
const md = await readFile(join(tmpDir, '.planning', 'USER-PROFILE.md'), 'utf-8');
expect(md).toContain('User Developer Profile');
expect(data.profile_path).toBe(outPath);
expect(data.dimensions_scored).toBe(1);
const md = await readFile(outPath, 'utf-8');
expect(md).toContain('Developer Profile');
expect(md).toMatch(/Communication Style/i);
});
});
@@ -45,10 +64,11 @@ describe('learningsCopy', () => {
await rm(tmpDir, { recursive: true, force: true });
});
it('returns copied:false when LEARNINGS.md is missing', async () => {
it('returns zero counts when LEARNINGS.md is missing (matches learnings.cjs)', async () => {
const result = await learningsCopy([], tmpDir);
const data = result.data as Record<string, unknown>;
expect(data.copied).toBe(false);
expect(data.reason).toContain('LEARNINGS');
expect(data.total).toBe(0);
expect(data.created).toBe(0);
expect(data.skipped).toBe(0);
});
});