* feat(sdk): golden parity harness and query handler CJS alignment (#2302 Track A) Golden/read-only parity tests and registry alignment, query handler fixes (check-completion, state-mutation, commit, validate, summary, etc.), and WAITING.json dual-write for .gsd/.planning readers. Refs gsd-build/get-shit-done#2341 * fix(sdk): getMilestoneInfo matches GSD ROADMAP (🟡, last bold, STATE fallback) - Recognize in-flight 🟡 milestone bullets like 🚧. - Derive from last **vX.Y Title** before ## Phases when emoji absent. - Fall back to STATE.md milestone when ROADMAP is missing; use last bare vX.Y in cleaned text instead of first (avoids v1.0 from shipped list). - Fixes init.execute-phase milestone_version and buildStateFrontmatter after state.begin-phase (syncStateFrontmatter). * feat(sdk): phase list, plan task structure, requirements extract handlers - Register phase.list-plans, phase.list-artifacts, plan.task-structure, requirements.extract-from-plans (SDK-only; golden-policy exceptions). - Add unit tests; document in QUERY-HANDLERS.md. - writeProfile: honor --output, render dimensions, return profile_path and dimensions_scored. * feat(sdk): centralize getGsdAgentsDir in query helpers Extract agent directory resolution to helpers (GSD_AGENTS_DIR, primary ~/.claude/agents, legacy path). Use from init and docs-init init bundles. docs(15): add 15-CONTEXT for autonomous phase-15 run. * feat(sdk): query CLI CJS fallback and session correlation - createRegistry(eventStream, sessionId) threads correlation into mutation events - gsd-sdk query falls back to gsd-tools.cjs when no native handler matches (disable with GSD_QUERY_FALLBACK=off); stderr bridge warnings - Export createRegistry from @gsd-build/sdk; add sdk/README.md - Update QUERY-HANDLERS.md and registry module docs for fallback + sessionId - Agents: prefer node dist/cli.js query over cat/grep for STATE and plans * fix(sdk): init phase_found parity, docs-init agents path, state field extract - Normalize findPhase not-found to null before roadmap fallback (matches findPhaseInternal) - docs-init: use detectRuntime + resolveAgentsDir for checkAgentsInstalled - state.cjs stateExtractField: horizontal whitespace only after colon (YAML progress guard) - Tests: commit_docs default true; config-get golden uses temp config; golden integration green Refs: #2302 * refactor(sdk): share SessionJsonlRecord in profile-extract-messages CodeRabbit nit: dedupe JSONL record shape for isGenuineUserMessage and streamExtractMessages. * fix(sdk): address CodeRabbit major threads (paths, gates, audit, verify) - Resolve @file: and CLI JSON indirection relative to projectDir; guard empty normalized query command - plan.task-structure + intel extract/patch-meta: resolvePathUnderProject containment - check.config-gates: safe string booleans; plan_checker alias precedence over plan_check default - state.validate/sync: phaseTokenMatches + comparePhaseNum ordering - verify.schema-drift: token match phase dirs; files_modified from parsed frontmatter - audit-open: has_scan_errors, unreadable rows, human report when scans fail - requirements PLANNED key PLAN for root PLAN.md; gsd-tools timeout note - ingest-docs: repo-root path containment; classifier output slug-hash Golden parity test strips has_scan_errors until CJS adds field. * fix: Resolve CodeRabbit security and quality findings - Secure intel.ts and cli.ts against path traversal - Catch and validate git add status in commit.ts - Expand roadmap milestone marker extraction - Fix parsing array-of-objects in frontmatter YAML - Fix unhandled config evaluations - Improve coverage test parity mapping * test: raise planner character extraction limit to 48K * fix(sdk): resolve TS build error in docs-init passing config
This commit is contained in:
Rezolv
@@ -16,8 +16,11 @@
|
||||
|
||||
import { readFile, readdir, writeFile } from 'node:fs/promises';
|
||||
import { existsSync } from 'node:fs';
|
||||
import { join, resolve } from 'node:path';
|
||||
import { dirname, join, resolve } from 'node:path';
|
||||
import { fileURLToPath } from 'node:url';
|
||||
import { homedir } from 'node:os';
|
||||
|
||||
import { MODEL_PROFILES } from './config-query.js';
|
||||
import { GSDError, ErrorClassification } from '../errors.js';
|
||||
import { extractFrontmatter, parseMustHavesBlock } from './frontmatter.js';
|
||||
import { escapeRegex, normalizePhaseName, planningPaths, resolvePathUnderProject } from './helpers.js';
|
||||
@@ -109,34 +112,42 @@ export const verifyKeyLinks: QueryHandler = async (args, projectDir) => {
|
||||
};
|
||||
|
||||
let sourceContent: string | null = null;
|
||||
try {
|
||||
const fromPath = await resolvePathUnderProject(projectDir, check.from);
|
||||
sourceContent = await readFile(fromPath, 'utf-8');
|
||||
} catch {
|
||||
// Source file not found or path invalid
|
||||
if (check.from) {
|
||||
try {
|
||||
const sourcePath = await resolvePathUnderProject(projectDir, check.from);
|
||||
sourceContent = await readFile(sourcePath, 'utf-8');
|
||||
} catch {
|
||||
// Source file not found or path escapes project
|
||||
}
|
||||
}
|
||||
|
||||
if (!sourceContent) {
|
||||
check.detail = 'Source file not found';
|
||||
} else if (linkObj.pattern) {
|
||||
const regex = regexForKeyLinkPattern(linkObj.pattern as string);
|
||||
if (regex.test(sourceContent)) {
|
||||
check.verified = true;
|
||||
check.detail = 'Pattern found in source';
|
||||
} else {
|
||||
let targetContent: string | null = null;
|
||||
try {
|
||||
const toPath = await resolvePathUnderProject(projectDir, check.to);
|
||||
targetContent = await readFile(toPath, 'utf-8');
|
||||
} catch {
|
||||
// Target file not found
|
||||
}
|
||||
if (targetContent && regex.test(targetContent)) {
|
||||
try {
|
||||
const regex = new RegExp(linkObj.pattern as string);
|
||||
if (regex.test(sourceContent)) {
|
||||
check.verified = true;
|
||||
check.detail = 'Pattern found in target';
|
||||
check.detail = 'Pattern found in source';
|
||||
} else {
|
||||
check.detail = `Pattern "${linkObj.pattern}" not found in source or target`;
|
||||
let targetContent: string | null = null;
|
||||
if (check.to) {
|
||||
try {
|
||||
const targetPath = await resolvePathUnderProject(projectDir, check.to);
|
||||
targetContent = await readFile(targetPath, 'utf-8');
|
||||
} catch {
|
||||
// Target file not found or path escapes project
|
||||
}
|
||||
}
|
||||
if (targetContent && regex.test(targetContent)) {
|
||||
check.verified = true;
|
||||
check.detail = 'Pattern found in target';
|
||||
} else {
|
||||
check.detail = `Pattern "${linkObj.pattern}" not found in source or target`;
|
||||
}
|
||||
}
|
||||
} catch {
|
||||
check.detail = `Invalid regex pattern: ${linkObj.pattern}`;
|
||||
}
|
||||
} else {
|
||||
// No pattern: check if target path is referenced in source content
|
||||
@@ -736,3 +747,61 @@ export const validateHealth: QueryHandler = async (args, projectDir) => {
|
||||
},
|
||||
};
|
||||
};
|
||||
|
||||
// ─── validateAgents ────────────────────────────────────────────────────────
|
||||
|
||||
/**
|
||||
* Default agents directory — mirrors `getAgentsDir` in `get-shit-done/bin/lib/core.cjs`:
|
||||
* `GSD_AGENTS_DIR`, else `../../../agents` relative to this module (`sdk/dist/query` → monorepo
|
||||
* root), matching `core.cjs` (`get-shit-done/bin/lib` → same repo `agents/`).
|
||||
*/
|
||||
function getAgentsDirForValidateAgents(): string {
|
||||
if (process.env.GSD_AGENTS_DIR) return process.env.GSD_AGENTS_DIR;
|
||||
const here = dirname(fileURLToPath(import.meta.url));
|
||||
return resolve(here, '..', '..', '..', 'agents');
|
||||
}
|
||||
|
||||
/**
|
||||
* Validate GSD agent file installation under the managed agents directory.
|
||||
*
|
||||
* Port of `cmdValidateAgents` from `verify.cjs` lines 997–1009 (uses `checkAgentsInstalled` from core).
|
||||
*/
|
||||
export const validateAgents: QueryHandler = async (_args, _projectDir) => {
|
||||
const agentsDir = getAgentsDirForValidateAgents();
|
||||
const expected = Object.keys(MODEL_PROFILES);
|
||||
const installed: string[] = [];
|
||||
const missing: string[] = [];
|
||||
|
||||
if (!existsSync(agentsDir)) {
|
||||
return {
|
||||
data: {
|
||||
agents_dir: agentsDir,
|
||||
agents_found: false,
|
||||
installed: [] as string[],
|
||||
missing: expected,
|
||||
expected,
|
||||
},
|
||||
};
|
||||
}
|
||||
|
||||
for (const agent of expected) {
|
||||
const agentFile = join(agentsDir, `${agent}.md`);
|
||||
const agentFileCopilot = join(agentsDir, `${agent}.agent.md`);
|
||||
if (existsSync(agentFile) || existsSync(agentFileCopilot)) {
|
||||
installed.push(agent);
|
||||
} else {
|
||||
missing.push(agent);
|
||||
}
|
||||
}
|
||||
|
||||
const agentsInstalled = installed.length > 0 && missing.length === 0;
|
||||
return {
|
||||
data: {
|
||||
agents_dir: agentsDir,
|
||||
agents_found: agentsInstalled,
|
||||
installed,
|
||||
missing,
|
||||
expected,
|
||||
},
|
||||
};
|
||||
};
|
||||
|
||||
Reference in New Issue
Block a user