* feat(sdk): golden parity harness and query handler CJS alignment (#2302 Track A) Golden/read-only parity tests and registry alignment, query handler fixes (check-completion, state-mutation, commit, validate, summary, etc.), and WAITING.json dual-write for .gsd/.planning readers. Refs gsd-build/get-shit-done#2341 * fix(sdk): getMilestoneInfo matches GSD ROADMAP (🟡, last bold, STATE fallback) - Recognize in-flight 🟡 milestone bullets like 🚧. - Derive from last **vX.Y Title** before ## Phases when emoji absent. - Fall back to STATE.md milestone when ROADMAP is missing; use last bare vX.Y in cleaned text instead of first (avoids v1.0 from shipped list). - Fixes init.execute-phase milestone_version and buildStateFrontmatter after state.begin-phase (syncStateFrontmatter). * feat(sdk): phase list, plan task structure, requirements extract handlers - Register phase.list-plans, phase.list-artifacts, plan.task-structure, requirements.extract-from-plans (SDK-only; golden-policy exceptions). - Add unit tests; document in QUERY-HANDLERS.md. - writeProfile: honor --output, render dimensions, return profile_path and dimensions_scored. * feat(sdk): centralize getGsdAgentsDir in query helpers Extract agent directory resolution to helpers (GSD_AGENTS_DIR, primary ~/.claude/agents, legacy path). Use from init and docs-init init bundles. docs(15): add 15-CONTEXT for autonomous phase-15 run. * feat(sdk): query CLI CJS fallback and session correlation - createRegistry(eventStream, sessionId) threads correlation into mutation events - gsd-sdk query falls back to gsd-tools.cjs when no native handler matches (disable with GSD_QUERY_FALLBACK=off); stderr bridge warnings - Export createRegistry from @gsd-build/sdk; add sdk/README.md - Update QUERY-HANDLERS.md and registry module docs for fallback + sessionId - Agents: prefer node dist/cli.js query over cat/grep for STATE and plans * fix(sdk): init phase_found parity, docs-init agents path, state field extract - Normalize findPhase not-found to null before roadmap fallback (matches findPhaseInternal) - docs-init: use detectRuntime + resolveAgentsDir for checkAgentsInstalled - state.cjs stateExtractField: horizontal whitespace only after colon (YAML progress guard) - Tests: commit_docs default true; config-get golden uses temp config; golden integration green Refs: #2302 * refactor(sdk): share SessionJsonlRecord in profile-extract-messages CodeRabbit nit: dedupe JSONL record shape for isGenuineUserMessage and streamExtractMessages. * fix(sdk): address CodeRabbit major threads (paths, gates, audit, verify) - Resolve @file: and CLI JSON indirection relative to projectDir; guard empty normalized query command - plan.task-structure + intel extract/patch-meta: resolvePathUnderProject containment - check.config-gates: safe string booleans; plan_checker alias precedence over plan_check default - state.validate/sync: phaseTokenMatches + comparePhaseNum ordering - verify.schema-drift: token match phase dirs; files_modified from parsed frontmatter - audit-open: has_scan_errors, unreadable rows, human report when scans fail - requirements PLANNED key PLAN for root PLAN.md; gsd-tools timeout note - ingest-docs: repo-root path containment; classifier output slug-hash Golden parity test strips has_scan_errors until CJS adds field. * fix: Resolve CodeRabbit security and quality findings - Secure intel.ts and cli.ts against path traversal - Catch and validate git add status in commit.ts - Expand roadmap milestone marker extraction - Fix parsing array-of-objects in frontmatter YAML - Fix unhandled config evaluations - Improve coverage test parity mapping * test: raise planner character extraction limit to 48K * fix(sdk): resolve TS build error in docs-init passing config
This commit is contained in:
Rezolv
@@ -19,7 +19,12 @@ import { existsSync, readdirSync, readFileSync, statSync } from 'node:fs';
|
||||
import { join, isAbsolute } from 'node:path';
|
||||
import { GSDError, ErrorClassification } from '../errors.js';
|
||||
import { extractFrontmatter, parseMustHavesBlock } from './frontmatter.js';
|
||||
import { normalizePhaseName, phaseTokenMatches, planningPaths } from './helpers.js';
|
||||
import {
|
||||
comparePhaseNum,
|
||||
normalizePhaseName,
|
||||
phaseTokenMatches,
|
||||
planningPaths,
|
||||
} from './helpers.js';
|
||||
import type { QueryHandler } from './utils.js';
|
||||
|
||||
// ─── verifyPlanStructure ───────────────────────────────────────────────────
|
||||
@@ -405,6 +410,7 @@ export const verifyReferences: QueryHandler = async (args, projectDir) => {
|
||||
valid: missing.length === 0,
|
||||
found: found.length,
|
||||
missing,
|
||||
total: found.length + missing.length,
|
||||
},
|
||||
};
|
||||
};
|
||||
@@ -545,44 +551,95 @@ export const verifyPathExists: QueryHandler = async (args, projectDir) => {
|
||||
|
||||
// ─── verifySchemaDrift ────────────────────────────────────────────────────
|
||||
|
||||
/**
|
||||
* Detect schema drift for a phase — port of `cmdVerifySchemaDrift` from verify.cjs lines 1013–1086.
|
||||
*/
|
||||
export const verifySchemaDrift: QueryHandler = async (args, projectDir) => {
|
||||
const phaseArg = args[0];
|
||||
const paths = planningPaths(projectDir);
|
||||
const skipFlag = args.includes('--skip');
|
||||
|
||||
const issues: string[] = [];
|
||||
const REQUIRED_FRONTMATTER = ['phase', 'plan', 'type', 'must_haves'];
|
||||
|
||||
try {
|
||||
const phasesDir = paths.phases;
|
||||
if (!existsSync(phasesDir)) {
|
||||
return { data: { valid: true, issues: [], checked: 0 } };
|
||||
}
|
||||
|
||||
const entries = readdirSync(phasesDir, { withFileTypes: true });
|
||||
let checked = 0;
|
||||
|
||||
for (const entry of entries) {
|
||||
if (!entry.isDirectory()) continue;
|
||||
if (phaseArg && !entry.name.startsWith(normalizePhaseName(phaseArg))) continue;
|
||||
|
||||
const phaseDir = join(phasesDir, entry.name);
|
||||
const files = readdirSync(phaseDir).filter(f => f.endsWith('-PLAN.md') || f === 'PLAN.md');
|
||||
|
||||
for (const planFile of files) {
|
||||
checked++;
|
||||
try {
|
||||
const content = await readFile(join(phaseDir, planFile), 'utf-8');
|
||||
for (const field of REQUIRED_FRONTMATTER) {
|
||||
if (!new RegExp(`^${field}:`, 'm').test(content)) {
|
||||
issues.push(`${planFile}: missing '${field}' in frontmatter`);
|
||||
}
|
||||
}
|
||||
} catch { /* skip */ }
|
||||
}
|
||||
}
|
||||
|
||||
return { data: { valid: issues.length === 0, issues, checked } };
|
||||
} catch {
|
||||
return { data: { valid: true, issues: [], checked: 0 } };
|
||||
if (!phaseArg) {
|
||||
throw new GSDError('Usage: verify schema-drift <phase> [--skip]', ErrorClassification.Validation);
|
||||
}
|
||||
|
||||
const { checkSchemaDrift } = await import('./schema-detect.js');
|
||||
const { execGit } = await import('./commit.js');
|
||||
|
||||
const phasesDir = planningPaths(projectDir).phases;
|
||||
if (!existsSync(phasesDir)) {
|
||||
return {
|
||||
data: {
|
||||
drift_detected: false,
|
||||
blocking: false,
|
||||
message: 'No phases directory',
|
||||
},
|
||||
};
|
||||
}
|
||||
|
||||
const normalized = normalizePhaseName(phaseArg);
|
||||
const dirNames = readdirSync(phasesDir, { withFileTypes: true })
|
||||
.filter(e => e.isDirectory())
|
||||
.map(e => e.name)
|
||||
.sort((a, b) => comparePhaseNum(a, b));
|
||||
|
||||
let phaseDirName = dirNames.find(d => phaseTokenMatches(d, normalized)) ?? null;
|
||||
if (!phaseDirName && /^[\d.]+/.test(phaseArg)) {
|
||||
const exact = join(phasesDir, phaseArg);
|
||||
if (existsSync(exact)) phaseDirName = phaseArg;
|
||||
}
|
||||
|
||||
if (!phaseDirName) {
|
||||
return {
|
||||
data: {
|
||||
drift_detected: false,
|
||||
blocking: false,
|
||||
message: `Phase directory not found: ${phaseArg}`,
|
||||
},
|
||||
};
|
||||
}
|
||||
|
||||
const phaseDir = join(phasesDir, phaseDirName);
|
||||
|
||||
function filesModifiedFromFrontmatter(fm: Record<string, unknown>): string[] {
|
||||
const v = fm.files_modified;
|
||||
if (Array.isArray(v)) return v.map(x => String(x).trim()).filter(Boolean);
|
||||
if (typeof v === 'string') {
|
||||
const t = v.trim();
|
||||
return t ? [t] : [];
|
||||
}
|
||||
return [];
|
||||
}
|
||||
|
||||
const allFiles: string[] = [];
|
||||
const planFiles = readdirSync(phaseDir).filter(f => f.endsWith('-PLAN.md') || f === 'PLAN.md');
|
||||
for (const pf of planFiles) {
|
||||
const content = readFileSync(join(phaseDir, pf), 'utf-8');
|
||||
const fm = extractFrontmatter(content) as Record<string, unknown>;
|
||||
allFiles.push(...filesModifiedFromFrontmatter(fm));
|
||||
}
|
||||
|
||||
let executionLog = '';
|
||||
const summaryFiles = readdirSync(phaseDir).filter(f => f.endsWith('-SUMMARY.md'));
|
||||
for (const sf of summaryFiles) {
|
||||
executionLog += readFileSync(join(phaseDir, sf), 'utf-8') + '\n';
|
||||
}
|
||||
|
||||
const gitLog = execGit(projectDir, ['log', '--oneline', '--all', '-50']);
|
||||
if (gitLog.exitCode === 0) {
|
||||
executionLog += '\n' + gitLog.stdout;
|
||||
}
|
||||
|
||||
const result = checkSchemaDrift(allFiles, executionLog, { skipCheck: !!skipFlag });
|
||||
|
||||
return {
|
||||
data: {
|
||||
drift_detected: result.driftDetected,
|
||||
blocking: result.blocking,
|
||||
schema_files: result.schemaFiles,
|
||||
orms: result.orms,
|
||||
unpushed_orms: result.unpushedOrms,
|
||||
message: result.message,
|
||||
skipped: result.skipped || false,
|
||||
},
|
||||
};
|
||||
};
|
||||
|
||||
Reference in New Issue
Block a user